2008-06-24 03:24:28 +02:00
|
|
|
#!/bin/sh
|
|
|
|
|
#
|
|
|
|
|
# Copyright (c) 2008 Nicolas Pitre
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
test_description='resilience to pack corruptions with redundant objects'
|
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
|
|
# Note: the test objects are created with knowledge of their pack encoding
|
|
|
|
|
# to ensure good code path coverage, and to facilitate direct alteration
|
|
|
|
|
# later on. The assumed characteristics are:
|
|
|
|
|
#
|
|
|
|
|
# 1) blob_2 is a delta with blob_1 for base and blob_3 is a delta with blob2
|
|
|
|
|
# for base, such that blob_3 delta depth is 2;
|
|
|
|
|
#
|
|
|
|
|
# 2) the bulk of object data is uncompressible so the text part remains
|
|
|
|
|
# visible;
|
|
|
|
|
#
|
|
|
|
|
# 3) object header is always 2 bytes.
|
|
|
|
|
|
|
|
|
|
create_test_files() {
|
|
|
|
|
test-genrandom "foo" 2000 > file_1 &&
|
|
|
|
|
test-genrandom "foo" 1800 > file_2 &&
|
|
|
|
|
test-genrandom "foo" 1800 > file_3 &&
|
|
|
|
|
echo " base " >> file_1 &&
|
|
|
|
|
echo " delta1 " >> file_2 &&
|
|
|
|
|
echo " delta delta2 " >> file_3 &&
|
|
|
|
|
test-genrandom "bar" 150 >> file_2 &&
|
|
|
|
|
test-genrandom "baz" 100 >> file_3
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
create_new_pack() {
|
|
|
|
|
rm -rf .git &&
|
|
|
|
|
git init &&
|
|
|
|
|
blob_1=`git hash-object -t blob -w file_1` &&
|
|
|
|
|
blob_2=`git hash-object -t blob -w file_2` &&
|
|
|
|
|
blob_3=`git hash-object -t blob -w file_3` &&
|
|
|
|
|
pack=`printf "$blob_1\n$blob_2\n$blob_3\n" |
|
|
|
|
|
git pack-objects $@ .git/objects/pack/pack` &&
|
|
|
|
|
pack=".git/objects/pack/pack-${pack}" &&
|
|
|
|
|
git verify-pack -v ${pack}.pack
|
|
|
|
|
}
|
|
|
|
|
|
2008-10-30 00:02:51 +01:00
|
|
|
do_repack() {
|
|
|
|
|
pack=`printf "$blob_1\n$blob_2\n$blob_3\n" |
|
|
|
|
|
git pack-objects $@ .git/objects/pack/pack` &&
|
|
|
|
|
pack=".git/objects/pack/pack-${pack}"
|
|
|
|
|
}
|
|
|
|
|
|
2008-06-24 03:24:28 +02:00
|
|
|
do_corrupt_object() {
|
|
|
|
|
ofs=`git show-index < ${pack}.idx | grep $1 | cut -f1 -d" "` &&
|
|
|
|
|
ofs=$(($ofs + $2)) &&
|
|
|
|
|
chmod +w ${pack}.pack &&
|
2013-06-14 23:51:01 +02:00
|
|
|
dd of=${pack}.pack bs=1 conv=notrunc seek=$ofs &&
|
2008-06-24 03:24:28 +02:00
|
|
|
test_must_fail git verify-pack ${pack}.pack
|
|
|
|
|
}
|
|
|
|
|
|
2008-11-17 09:21:30 +01:00
|
|
|
printf '\0' > zero
|
|
|
|
|
|
2008-06-24 03:24:28 +02:00
|
|
|
test_expect_success \
|
|
|
|
|
'initial setup validation' \
|
|
|
|
|
'create_test_files &&
|
|
|
|
|
create_new_pack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'create corruption in header of first object' \
|
2008-11-17 09:21:30 +01:00
|
|
|
'do_corrupt_object $blob_1 0 < zero &&
|
2008-06-24 03:24:28 +02:00
|
|
|
test_must_fail git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... but having a loose copy allows for full recovery' \
|
|
|
|
|
'mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_1 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... and loose copy of first delta allows for partial recovery' \
|
|
|
|
|
'git prune-packed &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'create corruption in data of first object' \
|
|
|
|
|
'create_new_pack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
chmod +w ${pack}.pack &&
|
2012-06-12 18:49:59 +02:00
|
|
|
"$PERL_PATH" -i.bak -pe "s/ base /abcdef/" ${pack}.pack &&
|
2008-06-24 03:24:28 +02:00
|
|
|
test_must_fail git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... but having a loose copy allows for full recovery' \
|
|
|
|
|
'mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_1 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... and loose copy of second object allows for partial recovery' \
|
|
|
|
|
'git prune-packed &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'create corruption in header of first delta' \
|
|
|
|
|
'create_new_pack &&
|
|
|
|
|
git prune-packed &&
|
2008-11-17 09:21:30 +01:00
|
|
|
do_corrupt_object $blob_2 0 < zero &&
|
2008-06-24 03:24:28 +02:00
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... but having a loose copy allows for full recovery' \
|
|
|
|
|
'mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
2008-10-30 00:02:51 +01:00
|
|
|
test_expect_success \
|
|
|
|
|
'... and then a repack "clears" the corruption' \
|
|
|
|
|
'do_repack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
git verify-pack ${pack}.pack &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
2008-06-24 03:24:28 +02:00
|
|
|
test_expect_success \
|
|
|
|
|
'create corruption in data of first delta' \
|
|
|
|
|
'create_new_pack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
chmod +w ${pack}.pack &&
|
2012-06-12 18:49:59 +02:00
|
|
|
"$PERL_PATH" -i.bak -pe "s/ delta1 /abcdefgh/" ${pack}.pack &&
|
2008-06-24 03:24:28 +02:00
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... but having a loose copy allows for full recovery' \
|
|
|
|
|
'mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
2008-10-30 00:02:51 +01:00
|
|
|
test_expect_success \
|
|
|
|
|
'... and then a repack "clears" the corruption' \
|
|
|
|
|
'do_repack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
git verify-pack ${pack}.pack &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
2008-06-24 03:24:28 +02:00
|
|
|
test_expect_success \
|
|
|
|
|
'corruption in delta base reference of first delta (OBJ_REF_DELTA)' \
|
|
|
|
|
'create_new_pack &&
|
|
|
|
|
git prune-packed &&
|
2008-11-17 09:21:30 +01:00
|
|
|
do_corrupt_object $blob_2 2 < zero &&
|
2008-06-24 03:24:28 +02:00
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... but having a loose copy allows for full recovery' \
|
|
|
|
|
'mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
2008-10-30 00:02:51 +01:00
|
|
|
'... and then a repack "clears" the corruption' \
|
|
|
|
|
'do_repack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
git verify-pack ${pack}.pack &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'corruption #0 in delta base reference of first delta (OBJ_OFS_DELTA)' \
|
2008-06-24 03:24:28 +02:00
|
|
|
'create_new_pack --delta-base-offset &&
|
|
|
|
|
git prune-packed &&
|
2008-11-17 09:21:30 +01:00
|
|
|
do_corrupt_object $blob_2 2 < zero &&
|
2008-06-24 03:24:28 +02:00
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
2008-10-30 00:02:51 +01:00
|
|
|
'... but having a loose copy allows for full recovery' \
|
2008-06-24 03:24:28 +02:00
|
|
|
'mv ${pack}.idx tmp &&
|
2008-10-30 00:02:51 +01:00
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... and then a repack "clears" the corruption' \
|
|
|
|
|
'do_repack --delta-base-offset &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
git verify-pack ${pack}.pack &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'corruption #1 in delta base reference of first delta (OBJ_OFS_DELTA)' \
|
|
|
|
|
'create_new_pack --delta-base-offset &&
|
|
|
|
|
git prune-packed &&
|
2008-11-09 22:11:06 +01:00
|
|
|
printf "\001" | do_corrupt_object $blob_2 2 &&
|
2008-10-30 00:02:51 +01:00
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... but having a loose copy allows for full recovery' \
|
|
|
|
|
'mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... and then a repack "clears" the corruption' \
|
|
|
|
|
'do_repack --delta-base-offset &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
git verify-pack ${pack}.pack &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... and a redundant pack allows for full recovery too' \
|
2008-11-17 09:21:30 +01:00
|
|
|
'do_corrupt_object $blob_2 2 < zero &&
|
2008-10-30 00:02:51 +01:00
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null &&
|
|
|
|
|
mv ${pack}.idx tmp &&
|
2008-06-24 03:24:28 +02:00
|
|
|
git hash-object -t blob -w file_1 &&
|
|
|
|
|
git hash-object -t blob -w file_2 &&
|
|
|
|
|
printf "$blob_1\n$blob_2\n" | git pack-objects .git/objects/pack/pack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
unpack_entry: do not die when we fail to apply a delta
When we try to load an object from disk and fail, our
general strategy is to see if we can get it from somewhere
else (e.g., a loose object). That lets users fix corruption
problems by copying known-good versions of objects into the
object database.
We already handle the case where we were not able to read
the delta from disk. However, when we find that the delta we
read does not apply, we simply die. This case is harder to
trigger, as corruption in the delta data itself would
trigger a crc error from zlib. However, a corruption that
pointed us at the wrong delta base might cause it.
We can do the same "fail and try to find the object
elsewhere" trick instead of dying. This not only gives us a
chance to recover, but also puts us on code paths that will
alert the user to the problem (with the current message,
they do not even know which sha1 caused the problem).
Note that unlike some other pack corruptions, we do not
recover automatically from this case when doing a repack.
There is nothing apparently wrong with the delta, as it
points to a valid, accessible object, and we realize the
error only when the resulting size does not match up. And in
theory, one could even have a case where the corrupted size
is the same, and the problem would only be noticed by
recomputing the sha1.
We can get around this by recomputing the deltas with
--no-reuse-delta, which our test does (and this is probably
good advice for anyone recovering from pack corruption).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-06-14 23:53:34 +02:00
|
|
|
test_expect_success \
|
|
|
|
|
'corruption of delta base reference pointing to wrong object' \
|
|
|
|
|
'create_new_pack --delta-base-offset &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
printf "\220\033" | do_corrupt_object $blob_3 2 &&
|
|
|
|
|
git cat-file blob $blob_1 >/dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 >/dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 >/dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... but having a loose copy allows for full recovery' \
|
|
|
|
|
'mv ${pack}.idx tmp &&
|
|
|
|
|
git hash-object -t blob -w file_3 &&
|
|
|
|
|
mv tmp ${pack}.idx &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
|
|
|
|
test_expect_success \
|
|
|
|
|
'... and then a repack "clears" the corruption' \
|
|
|
|
|
'do_repack --delta-base-offset --no-reuse-delta &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
git verify-pack ${pack}.pack &&
|
|
|
|
|
git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
2009-10-14 16:23:51 +02:00
|
|
|
test_expect_success \
|
|
|
|
|
'corrupting header to have too small output buffer fails unpack' \
|
|
|
|
|
'create_new_pack &&
|
|
|
|
|
git prune-packed &&
|
|
|
|
|
printf "\262\001" | do_corrupt_object $blob_1 0 &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_1 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_2 > /dev/null &&
|
|
|
|
|
test_must_fail git cat-file blob $blob_3 > /dev/null'
|
|
|
|
|
|
2008-06-24 03:24:28 +02:00
|
|
|
test_done
|