2012-09-20 20:04:08 +02:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
test_description='test refspec written by clone-command'
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
# Make two branches, "master" and "side"
|
|
|
|
echo one >file &&
|
|
|
|
git add file &&
|
|
|
|
git commit -m one &&
|
|
|
|
echo two >file &&
|
|
|
|
git commit -a -m two &&
|
|
|
|
git tag two &&
|
|
|
|
echo three >file &&
|
|
|
|
git commit -a -m three &&
|
|
|
|
git checkout -b side &&
|
|
|
|
echo four >file &&
|
|
|
|
git commit -a -m four &&
|
|
|
|
git checkout master &&
|
2017-04-27 01:12:33 +02:00
|
|
|
git tag five &&
|
2012-09-20 20:04:08 +02:00
|
|
|
|
|
|
|
# default clone
|
|
|
|
git clone . dir_all &&
|
|
|
|
|
2017-04-27 01:12:33 +02:00
|
|
|
# default clone --no-tags
|
|
|
|
git clone --no-tags . dir_all_no_tags &&
|
|
|
|
|
2012-09-20 20:04:08 +02:00
|
|
|
# default --single that follows HEAD=master
|
|
|
|
git clone --single-branch . dir_master &&
|
|
|
|
|
2017-04-27 01:12:33 +02:00
|
|
|
# default --single that follows HEAD=master with no tags
|
|
|
|
git clone --single-branch --no-tags . dir_master_no_tags &&
|
|
|
|
|
2012-09-20 20:04:08 +02:00
|
|
|
# default --single that follows HEAD=side
|
|
|
|
git checkout side &&
|
|
|
|
git clone --single-branch . dir_side &&
|
|
|
|
|
|
|
|
# explicit --single that follows side
|
|
|
|
git checkout master &&
|
|
|
|
git clone --single-branch --branch side . dir_side2 &&
|
|
|
|
|
|
|
|
# default --single with --mirror
|
|
|
|
git clone --single-branch --mirror . dir_mirror &&
|
|
|
|
|
|
|
|
# default --single with --branch and --mirror
|
|
|
|
git clone --single-branch --mirror --branch side . dir_mirror_side &&
|
|
|
|
|
|
|
|
# --single that does not know what branch to follow
|
|
|
|
git checkout two^ &&
|
|
|
|
git clone --single-branch . dir_detached &&
|
|
|
|
|
|
|
|
# explicit --single with tag
|
|
|
|
git clone --single-branch --branch two . dir_tag &&
|
|
|
|
|
2017-04-27 01:12:33 +02:00
|
|
|
# explicit --single with tag and --no-tags
|
|
|
|
git clone --single-branch --no-tags --branch two . dir_tag_no_tags &&
|
|
|
|
|
2012-09-20 20:04:08 +02:00
|
|
|
# advance both "master" and "side" branches
|
|
|
|
git checkout side &&
|
|
|
|
echo five >file &&
|
|
|
|
git commit -a -m five &&
|
|
|
|
git checkout master &&
|
|
|
|
echo six >file &&
|
|
|
|
git commit -a -m six &&
|
|
|
|
|
|
|
|
# update tag
|
|
|
|
git tag -d two && git tag two
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'by default all branches will be kept updated' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_all &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs/remotes/origin |
|
|
|
|
sed -e "/HEAD$/d" \
|
|
|
|
-e "s|/remotes/origin/|/heads/|" >../actual
|
|
|
|
) &&
|
|
|
|
# follow both master and side
|
|
|
|
git for-each-ref refs/heads >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'by default no tags will be kept updated' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_all &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs/tags >../actual
|
|
|
|
) &&
|
|
|
|
git for-each-ref refs/tags >expect &&
|
2017-04-27 01:12:33 +02:00
|
|
|
test_must_fail test_cmp expect actual &&
|
|
|
|
test_line_count = 2 actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'clone with --no-tags' '
|
|
|
|
(
|
|
|
|
cd dir_all_no_tags &&
|
|
|
|
git fetch &&
|
|
|
|
git for-each-ref refs/tags >../actual
|
|
|
|
) &&
|
2018-07-27 19:48:11 +02:00
|
|
|
test_must_be_empty actual
|
2012-09-20 20:04:08 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success '--single-branch while HEAD pointing at master' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_master &&
|
fetch: stop clobbering existing tags without --force
Change "fetch" to treat "+" in refspecs (aka --force) to mean we
should clobber a local tag of the same name.
This changes the long-standing behavior of "fetch" added in
853a3697dc ("[PATCH] Multi-head fetch.", 2005-08-20). Before this
change, all tag fetches effectively had --force enabled. See the
git-fetch-script code in fast_forward_local() with the comment:
> Tags need not be pointing at commits so there is no way to
> guarantee "fast-forward" anyway.
That commit and the rest of the history of "fetch" shows that the
"+" (--force) part of refpecs was only conceived for branch updates,
while tags have accepted any changes from upstream unconditionally and
clobbered the local tag object. Changing this behavior has been
discussed as early as 2011[1].
The current behavior doesn't make sense to me, it easily results in
local tags accidentally being clobbered. We could namespace our tags
per-remote and not locally populate refs/tags/*, but as with my
97716d217c ("fetch: add a --prune-tags option and fetch.pruneTags
config", 2018-02-09) it's easier to work around the current
implementation than to fix the root cause.
So this change implements suggestion #1 from Jeff's 2011 E-Mail[1],
"fetch" now only clobbers the tag if either "+" is provided as part of
the refspec, or if "--force" is provided on the command-line.
This also makes it nicely symmetrical with how "tag" itself works when
creating tags. I.e. we refuse to clobber any existing tags unless
"--force" is supplied. Now we can refuse all such clobbering, whether
it would happen by clobbering a local tag with "tag", or by fetching
it from the remote with "fetch".
Ref updates outside refs/{tags,heads/* are still still not symmetrical
with how "git push" works, as discussed in the recently changed
pull-fetch-param.txt documentation. This change brings the two
divergent behaviors more into line with one another. I don't think
there's any reason "fetch" couldn't fully converge with the behavior
used by "push", but that's a topic for another change.
One of the tests added in 31b808a032 ("clone --single: limit the fetch
refspec to fetched branch", 2012-09-20) is being changed to use
--force where a clone would clobber a tag. This changes nothing about
the existing behavior of the test.
1. https://public-inbox.org/git/20111123221658.GA22313@sigill.intra.peff.net/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-08-31 22:10:04 +02:00
|
|
|
git fetch --force &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs/remotes/origin |
|
|
|
|
sed -e "/HEAD$/d" \
|
|
|
|
-e "s|/remotes/origin/|/heads/|" >../actual
|
|
|
|
) &&
|
|
|
|
# only follow master
|
|
|
|
git for-each-ref refs/heads/master >expect &&
|
2017-04-27 01:12:33 +02:00
|
|
|
# get & check latest tags
|
|
|
|
test_cmp expect actual &&
|
|
|
|
(
|
|
|
|
cd dir_master &&
|
fetch: stop clobbering existing tags without --force
Change "fetch" to treat "+" in refspecs (aka --force) to mean we
should clobber a local tag of the same name.
This changes the long-standing behavior of "fetch" added in
853a3697dc ("[PATCH] Multi-head fetch.", 2005-08-20). Before this
change, all tag fetches effectively had --force enabled. See the
git-fetch-script code in fast_forward_local() with the comment:
> Tags need not be pointing at commits so there is no way to
> guarantee "fast-forward" anyway.
That commit and the rest of the history of "fetch" shows that the
"+" (--force) part of refpecs was only conceived for branch updates,
while tags have accepted any changes from upstream unconditionally and
clobbered the local tag object. Changing this behavior has been
discussed as early as 2011[1].
The current behavior doesn't make sense to me, it easily results in
local tags accidentally being clobbered. We could namespace our tags
per-remote and not locally populate refs/tags/*, but as with my
97716d217c ("fetch: add a --prune-tags option and fetch.pruneTags
config", 2018-02-09) it's easier to work around the current
implementation than to fix the root cause.
So this change implements suggestion #1 from Jeff's 2011 E-Mail[1],
"fetch" now only clobbers the tag if either "+" is provided as part of
the refspec, or if "--force" is provided on the command-line.
This also makes it nicely symmetrical with how "tag" itself works when
creating tags. I.e. we refuse to clobber any existing tags unless
"--force" is supplied. Now we can refuse all such clobbering, whether
it would happen by clobbering a local tag with "tag", or by fetching
it from the remote with "fetch".
Ref updates outside refs/{tags,heads/* are still still not symmetrical
with how "git push" works, as discussed in the recently changed
pull-fetch-param.txt documentation. This change brings the two
divergent behaviors more into line with one another. I don't think
there's any reason "fetch" couldn't fully converge with the behavior
used by "push", but that's a topic for another change.
One of the tests added in 31b808a032 ("clone --single: limit the fetch
refspec to fetched branch", 2012-09-20) is being changed to use
--force where a clone would clobber a tag. This changes nothing about
the existing behavior of the test.
1. https://public-inbox.org/git/20111123221658.GA22313@sigill.intra.peff.net/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-08-31 22:10:04 +02:00
|
|
|
git fetch --tags --force &&
|
2017-04-27 01:12:33 +02:00
|
|
|
git for-each-ref refs/tags >../actual
|
|
|
|
) &&
|
|
|
|
git for-each-ref refs/tags >expect &&
|
|
|
|
test_cmp expect actual &&
|
|
|
|
test_line_count = 2 actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success '--single-branch while HEAD pointing at master and --no-tags' '
|
|
|
|
(
|
|
|
|
cd dir_master_no_tags &&
|
|
|
|
git fetch &&
|
|
|
|
git for-each-ref refs/remotes/origin |
|
|
|
|
sed -e "/HEAD$/d" \
|
|
|
|
-e "s|/remotes/origin/|/heads/|" >../actual
|
|
|
|
) &&
|
|
|
|
# only follow master
|
|
|
|
git for-each-ref refs/heads/master >expect &&
|
|
|
|
test_cmp expect actual &&
|
|
|
|
# get tags (noop)
|
|
|
|
(
|
|
|
|
cd dir_master_no_tags &&
|
|
|
|
git fetch &&
|
|
|
|
git for-each-ref refs/tags >../actual
|
|
|
|
) &&
|
2018-07-27 19:48:11 +02:00
|
|
|
test_must_be_empty actual &&
|
2017-04-27 01:12:33 +02:00
|
|
|
test_line_count = 0 actual &&
|
|
|
|
# get tags with --tags overrides tagOpt
|
|
|
|
(
|
|
|
|
cd dir_master_no_tags &&
|
|
|
|
git fetch --tags &&
|
|
|
|
git for-each-ref refs/tags >../actual
|
|
|
|
) &&
|
|
|
|
git for-each-ref refs/tags >expect &&
|
|
|
|
test_cmp expect actual &&
|
|
|
|
test_line_count = 2 actual
|
2012-09-20 20:04:08 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success '--single-branch while HEAD pointing at side' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_side &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs/remotes/origin |
|
|
|
|
sed -e "/HEAD$/d" \
|
|
|
|
-e "s|/remotes/origin/|/heads/|" >../actual
|
|
|
|
) &&
|
|
|
|
# only follow side
|
|
|
|
git for-each-ref refs/heads/side >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success '--single-branch with explicit --branch side' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_side2 &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs/remotes/origin |
|
|
|
|
sed -e "/HEAD$/d" \
|
|
|
|
-e "s|/remotes/origin/|/heads/|" >../actual
|
|
|
|
) &&
|
|
|
|
# only follow side
|
|
|
|
git for-each-ref refs/heads/side >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success '--single-branch with explicit --branch with tag fetches updated tag' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_tag &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs/tags >../actual
|
|
|
|
) &&
|
|
|
|
git for-each-ref refs/tags >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
2017-04-27 01:12:33 +02:00
|
|
|
test_expect_success '--single-branch with explicit --branch with tag fetches updated tag despite --no-tags' '
|
|
|
|
(
|
|
|
|
cd dir_tag_no_tags &&
|
|
|
|
git fetch &&
|
|
|
|
git for-each-ref refs/tags >../actual
|
|
|
|
) &&
|
|
|
|
git for-each-ref refs/tags/two >expect &&
|
|
|
|
test_cmp expect actual &&
|
|
|
|
test_line_count = 1 actual
|
|
|
|
'
|
|
|
|
|
2012-09-20 20:04:08 +02:00
|
|
|
test_expect_success '--single-branch with --mirror' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_mirror &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs > ../actual
|
|
|
|
) &&
|
|
|
|
git for-each-ref refs >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success '--single-branch with explicit --branch and --mirror' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_mirror_side &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs > ../actual
|
|
|
|
) &&
|
|
|
|
git for-each-ref refs >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success '--single-branch with detached' '
|
|
|
|
(
|
2017-04-27 01:12:32 +02:00
|
|
|
cd dir_detached &&
|
|
|
|
git fetch &&
|
2012-09-20 20:04:08 +02:00
|
|
|
git for-each-ref refs/remotes/origin |
|
|
|
|
sed -e "/HEAD$/d" \
|
|
|
|
-e "s|/remotes/origin/|/heads/|" >../actual
|
2015-03-20 11:06:44 +01:00
|
|
|
) &&
|
2012-09-20 20:04:08 +02:00
|
|
|
# nothing
|
2018-07-27 19:48:11 +02:00
|
|
|
test_must_be_empty actual
|
2012-09-20 20:04:08 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_done
|