2011-04-03 09:06:54 +02:00
|
|
|
#include "builtin.h"
|
2006-11-01 23:06:21 +01:00
|
|
|
#include "pack.h"
|
2005-07-03 05:23:36 +02:00
|
|
|
#include "refs.h"
|
2005-06-30 05:50:15 +02:00
|
|
|
#include "pkt-line.h"
|
2010-02-05 21:57:41 +01:00
|
|
|
#include "sideband.h"
|
2005-07-31 21:17:43 +02:00
|
|
|
#include "run-command.h"
|
2006-11-01 23:06:25 +01:00
|
|
|
#include "exec_cmd.h"
|
2006-09-21 01:07:54 +02:00
|
|
|
#include "commit.h"
|
|
|
|
#include "object.h"
|
push: receiver end advertises refs from alternate repositories
Earlier, when pushing into a repository that borrows from alternate object
stores, we followed the longstanding design decision not to trust refs in
the alternate repository that houses the object store we are borrowing
from. If your public repository is borrowing from Linus's public
repository, you pushed into it long time ago, and now when you try to push
your updated history that is in sync with more recent history from Linus,
you will end up sending not just your own development, but also the
changes you acquired through Linus's tree, even though the objects needed
for the latter already exists at the receiving end. This is because the
receiving end does not advertise that the objects only reachable from the
borrowed repository (i.e. Linus's) are already available there.
This solves the issue by making the receiving end advertise refs from
borrowed repositories. They are not sent with their true names but with a
phoney name ".have" to make sure that the old senders will safely ignore
them (otherwise, the old senders will misbehave, trying to push matching
refs, and mirror push that deletes refs that only exist at the receiving
end).
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-09-09 10:27:10 +02:00
|
|
|
#include "remote.h"
|
|
|
|
#include "transport.h"
|
2010-04-20 00:19:18 +02:00
|
|
|
#include "string-list.h"
|
receive-pack: eliminate duplicate .have refs
When receiving a push, we advertise ref tips from any
alternate repositories, in case that helps the client send a
smaller pack. Since these refs don't actually exist in the
destination repository, we don't transmit the real ref
names, but instead use the pseudo-ref ".have".
If your alternate has a large number of duplicate refs (for
example, because it is aggregating objects from many related
repositories, some of which will have the same tags and
branch tips), then we will send each ".have $sha1" line
multiple times. This is a pointless waste of bandwidth, as
we are simply repeating the same fact to the client over and
over.
This patch eliminates duplicate .have refs early on. It does
so efficiently by sorting the complete list and skipping
duplicates. This has the side effect of re-ordering the
.have lines by ascending sha1; this isn't a problem, though,
as the original order was meaningless.
There is a similar .have system in fetch-pack, but it
does not suffer from the same problem. For each alternate
ref we consider in fetch-pack, we actually open the object
and mark it with the SEEN flag, so duplicates are
automatically culled.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-05-19 23:34:46 +02:00
|
|
|
#include "sha1-array.h"
|
2011-09-03 01:52:08 +02:00
|
|
|
#include "connected.h"
|
2012-08-03 18:19:16 +02:00
|
|
|
#include "version.h"
|
2005-06-30 02:52:11 +02:00
|
|
|
|
2009-01-04 19:39:27 +01:00
|
|
|
static const char receive_pack_usage[] = "git receive-pack <git-dir>";
|
2005-06-30 02:52:11 +02:00
|
|
|
|
2008-11-09 02:49:27 +01:00
|
|
|
enum deny_action {
|
2009-02-01 02:34:05 +01:00
|
|
|
DENY_UNCONFIGURED,
|
2008-11-09 02:49:27 +01:00
|
|
|
DENY_IGNORE,
|
|
|
|
DENY_WARN,
|
2010-05-14 11:31:35 +02:00
|
|
|
DENY_REFUSE
|
2008-11-09 02:49:27 +01:00
|
|
|
};
|
|
|
|
|
2009-02-09 07:19:43 +01:00
|
|
|
static int deny_deletes;
|
|
|
|
static int deny_non_fast_forwards;
|
2009-02-01 02:34:05 +01:00
|
|
|
static enum deny_action deny_current_branch = DENY_UNCONFIGURED;
|
2009-02-09 07:31:21 +01:00
|
|
|
static enum deny_action deny_delete_current = DENY_UNCONFIGURED;
|
2011-09-04 21:37:45 +02:00
|
|
|
static int receive_fsck_objects = -1;
|
|
|
|
static int transfer_fsck_objects = -1;
|
2007-01-25 02:02:15 +01:00
|
|
|
static int receive_unpack_limit = -1;
|
|
|
|
static int transfer_unpack_limit = -1;
|
2006-12-07 05:01:00 +01:00
|
|
|
static int unpack_limit = 100;
|
2006-08-15 19:23:48 +02:00
|
|
|
static int report_status;
|
2010-02-05 21:57:41 +01:00
|
|
|
static int use_sideband;
|
2012-01-08 22:06:20 +01:00
|
|
|
static int quiet;
|
2009-05-01 22:56:47 +02:00
|
|
|
static int prefer_ofs_delta = 1;
|
2009-10-20 23:56:40 +02:00
|
|
|
static int auto_update_server_info;
|
|
|
|
static int auto_gc = 1;
|
2009-02-09 07:31:21 +01:00
|
|
|
static const char *head_name;
|
2011-12-13 15:17:48 +01:00
|
|
|
static void *head_name_to_free;
|
2010-02-05 21:57:40 +01:00
|
|
|
static int sent_capabilities;
|
2005-12-26 08:18:37 +01:00
|
|
|
|
2008-11-09 02:49:27 +01:00
|
|
|
static enum deny_action parse_deny_action(const char *var, const char *value)
|
|
|
|
{
|
|
|
|
if (value) {
|
|
|
|
if (!strcasecmp(value, "ignore"))
|
|
|
|
return DENY_IGNORE;
|
|
|
|
if (!strcasecmp(value, "warn"))
|
|
|
|
return DENY_WARN;
|
|
|
|
if (!strcasecmp(value, "refuse"))
|
|
|
|
return DENY_REFUSE;
|
|
|
|
}
|
|
|
|
if (git_config_bool(var, value))
|
|
|
|
return DENY_REFUSE;
|
|
|
|
return DENY_IGNORE;
|
|
|
|
}
|
|
|
|
|
2008-05-14 19:46:53 +02:00
|
|
|
static int receive_pack_config(const char *var, const char *value, void *cb)
|
2006-10-30 23:35:18 +01:00
|
|
|
{
|
2008-11-01 15:42:16 +01:00
|
|
|
if (strcmp(var, "receive.denydeletes") == 0) {
|
|
|
|
deny_deletes = git_config_bool(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-01-25 02:02:15 +01:00
|
|
|
if (strcmp(var, "receive.denynonfastforwards") == 0) {
|
2006-10-30 23:35:18 +01:00
|
|
|
deny_non_fast_forwards = git_config_bool(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-01-25 02:02:15 +01:00
|
|
|
if (strcmp(var, "receive.unpacklimit") == 0) {
|
|
|
|
receive_unpack_limit = git_config_int(var, value);
|
2006-11-01 23:06:21 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-01-25 02:02:15 +01:00
|
|
|
if (strcmp(var, "transfer.unpacklimit") == 0) {
|
|
|
|
transfer_unpack_limit = git_config_int(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-02-25 22:46:13 +01:00
|
|
|
if (strcmp(var, "receive.fsckobjects") == 0) {
|
|
|
|
receive_fsck_objects = git_config_bool(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-09-04 21:37:45 +02:00
|
|
|
if (strcmp(var, "transfer.fsckobjects") == 0) {
|
|
|
|
transfer_fsck_objects = git_config_bool(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-11-09 02:49:27 +01:00
|
|
|
if (!strcmp(var, "receive.denycurrentbranch")) {
|
|
|
|
deny_current_branch = parse_deny_action(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-02-09 07:31:21 +01:00
|
|
|
if (strcmp(var, "receive.denydeletecurrent") == 0) {
|
|
|
|
deny_delete_current = parse_deny_action(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-05-01 22:56:47 +02:00
|
|
|
if (strcmp(var, "repack.usedeltabaseoffset") == 0) {
|
|
|
|
prefer_ofs_delta = git_config_bool(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-10-20 23:56:40 +02:00
|
|
|
if (strcmp(var, "receive.updateserverinfo") == 0) {
|
|
|
|
auto_update_server_info = git_config_bool(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (strcmp(var, "receive.autogc") == 0) {
|
|
|
|
auto_gc = git_config_bool(var, value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-05-14 19:46:53 +02:00
|
|
|
return git_default_config(var, value, cb);
|
2006-10-30 23:35:18 +01:00
|
|
|
}
|
|
|
|
|
2012-01-06 15:12:32 +01:00
|
|
|
static void show_ref(const char *path, const unsigned char *sha1)
|
2005-06-30 02:52:11 +02:00
|
|
|
{
|
2010-02-05 21:57:40 +01:00
|
|
|
if (sent_capabilities)
|
2005-12-26 08:18:37 +01:00
|
|
|
packet_write(1, "%s %s\n", sha1_to_hex(sha1), path);
|
|
|
|
else
|
2012-08-03 18:19:16 +02:00
|
|
|
packet_write(1, "%s %s%c%s%s agent=%s\n",
|
2010-02-05 21:57:40 +01:00
|
|
|
sha1_to_hex(sha1), path, 0,
|
2012-01-08 22:06:20 +01:00
|
|
|
" report-status delete-refs side-band-64k quiet",
|
2012-08-03 18:19:16 +02:00
|
|
|
prefer_ofs_delta ? " ofs-delta" : "",
|
|
|
|
git_user_agent_sanitized());
|
2010-02-05 21:57:40 +01:00
|
|
|
sent_capabilities = 1;
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
|
|
|
|
2012-01-06 15:12:32 +01:00
|
|
|
static int show_ref_cb(const char *path, const unsigned char *sha1, int flag, void *unused)
|
2011-07-09 01:13:32 +02:00
|
|
|
{
|
|
|
|
path = strip_namespace(path);
|
|
|
|
/*
|
|
|
|
* Advertise refs outside our current namespace as ".have"
|
|
|
|
* refs, so that the client can use them to minimize data
|
|
|
|
* transfer but will otherwise ignore them. This happens to
|
|
|
|
* cover ".have" that are thrown in by add_one_alternate_ref()
|
|
|
|
* to mark histories that are complete in our alternates as
|
|
|
|
* well.
|
|
|
|
*/
|
|
|
|
if (!path)
|
|
|
|
path = ".have";
|
2012-01-06 15:12:32 +01:00
|
|
|
show_ref(path, sha1);
|
|
|
|
return 0;
|
2011-07-09 01:13:32 +02:00
|
|
|
}
|
|
|
|
|
2012-01-06 15:12:33 +01:00
|
|
|
static void show_one_alternate_sha1(const unsigned char sha1[20], void *unused)
|
2012-01-06 15:12:31 +01:00
|
|
|
{
|
2012-01-06 15:12:33 +01:00
|
|
|
show_ref(".have", sha1);
|
2012-01-06 15:12:31 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static void collect_one_alternate_ref(const struct ref *ref, void *data)
|
|
|
|
{
|
|
|
|
struct sha1_array *sa = data;
|
|
|
|
sha1_array_append(sa, ref->old_sha1);
|
2011-07-09 01:13:32 +02:00
|
|
|
}
|
|
|
|
|
2005-07-03 05:23:36 +02:00
|
|
|
static void write_head_info(void)
|
2005-06-30 02:52:11 +02:00
|
|
|
{
|
2012-01-06 15:12:31 +01:00
|
|
|
struct sha1_array sa = SHA1_ARRAY_INIT;
|
|
|
|
for_each_alternate_ref(collect_one_alternate_ref, &sa);
|
2012-01-06 15:12:33 +01:00
|
|
|
sha1_array_for_each_unique(&sa, show_one_alternate_sha1, NULL);
|
2012-01-06 15:12:31 +01:00
|
|
|
sha1_array_clear(&sa);
|
2011-07-09 01:13:32 +02:00
|
|
|
for_each_ref(show_ref_cb, NULL);
|
2010-02-05 21:57:40 +01:00
|
|
|
if (!sent_capabilities)
|
2012-01-06 15:12:32 +01:00
|
|
|
show_ref("capabilities^{}", null_sha1);
|
2005-12-26 08:18:37 +01:00
|
|
|
|
2012-01-06 15:12:31 +01:00
|
|
|
/* EOF */
|
|
|
|
packet_flush(1);
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
|
|
|
|
2005-06-30 08:01:14 +02:00
|
|
|
struct command {
|
|
|
|
struct command *next;
|
2005-12-26 08:18:37 +01:00
|
|
|
const char *error_string;
|
2011-09-28 17:39:35 +02:00
|
|
|
unsigned int skip_update:1,
|
|
|
|
did_not_exist:1;
|
2005-06-30 08:01:14 +02:00
|
|
|
unsigned char old_sha1[20];
|
|
|
|
unsigned char new_sha1[20];
|
2006-01-07 10:33:54 +01:00
|
|
|
char ref_name[FLEX_ARRAY]; /* more */
|
2005-06-30 02:52:11 +02:00
|
|
|
};
|
|
|
|
|
2007-03-07 22:52:05 +01:00
|
|
|
static const char pre_receive_hook[] = "hooks/pre-receive";
|
|
|
|
static const char post_receive_hook[] = "hooks/post-receive";
|
2005-07-31 21:17:43 +02:00
|
|
|
|
2010-02-10 18:34:12 +01:00
|
|
|
static void rp_error(const char *err, ...) __attribute__((format (printf, 1, 2)));
|
|
|
|
static void rp_warning(const char *err, ...) __attribute__((format (printf, 1, 2)));
|
|
|
|
|
|
|
|
static void report_message(const char *prefix, const char *err, va_list params)
|
|
|
|
{
|
|
|
|
int sz = strlen(prefix);
|
|
|
|
char msg[4096];
|
|
|
|
|
|
|
|
strncpy(msg, prefix, sz);
|
|
|
|
sz += vsnprintf(msg + sz, sizeof(msg) - sz, err, params);
|
|
|
|
if (sz > (sizeof(msg) - 1))
|
|
|
|
sz = sizeof(msg) - 1;
|
|
|
|
msg[sz++] = '\n';
|
|
|
|
|
|
|
|
if (use_sideband)
|
|
|
|
send_sideband(1, 2, msg, sz, use_sideband);
|
|
|
|
else
|
|
|
|
xwrite(2, msg, sz);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void rp_warning(const char *err, ...)
|
|
|
|
{
|
|
|
|
va_list params;
|
|
|
|
va_start(params, err);
|
|
|
|
report_message("warning: ", err, params);
|
|
|
|
va_end(params);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void rp_error(const char *err, ...)
|
|
|
|
{
|
|
|
|
va_list params;
|
|
|
|
va_start(params, err);
|
|
|
|
report_message("error: ", err, params);
|
|
|
|
va_end(params);
|
|
|
|
}
|
|
|
|
|
2010-02-05 21:57:42 +01:00
|
|
|
static int copy_to_sideband(int in, int out, void *arg)
|
|
|
|
{
|
|
|
|
char data[128];
|
|
|
|
while (1) {
|
|
|
|
ssize_t sz = xread(in, data, sizeof(data));
|
|
|
|
if (sz <= 0)
|
|
|
|
break;
|
|
|
|
send_sideband(1, 2, data, sz, use_sideband);
|
|
|
|
}
|
|
|
|
close(in);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-09-08 21:17:09 +02:00
|
|
|
typedef int (*feed_fn)(void *, const char **, size_t *);
|
|
|
|
static int run_and_feed_hook(const char *hook_name, feed_fn feed, void *feed_state)
|
2005-07-31 21:17:43 +02:00
|
|
|
{
|
2007-03-10 09:28:16 +01:00
|
|
|
struct child_process proc;
|
2010-02-05 21:57:42 +01:00
|
|
|
struct async muxer;
|
2007-03-10 09:28:16 +01:00
|
|
|
const char *argv[2];
|
2011-09-08 21:17:09 +02:00
|
|
|
int code;
|
2005-07-31 21:17:43 +02:00
|
|
|
|
2011-09-08 21:17:09 +02:00
|
|
|
if (access(hook_name, X_OK) < 0)
|
2005-07-31 21:17:43 +02:00
|
|
|
return 0;
|
2007-03-07 22:51:09 +01:00
|
|
|
|
|
|
|
argv[0] = hook_name;
|
2007-03-10 09:28:16 +01:00
|
|
|
argv[1] = NULL;
|
|
|
|
|
|
|
|
memset(&proc, 0, sizeof(proc));
|
|
|
|
proc.argv = argv;
|
|
|
|
proc.in = -1;
|
|
|
|
proc.stdout_to_stderr = 1;
|
|
|
|
|
2010-02-05 21:57:42 +01:00
|
|
|
if (use_sideband) {
|
|
|
|
memset(&muxer, 0, sizeof(muxer));
|
|
|
|
muxer.proc = copy_to_sideband;
|
|
|
|
muxer.in = -1;
|
|
|
|
code = start_async(&muxer);
|
|
|
|
if (code)
|
|
|
|
return code;
|
|
|
|
proc.err = muxer.in;
|
|
|
|
}
|
|
|
|
|
2007-03-10 09:28:16 +01:00
|
|
|
code = start_command(&proc);
|
2010-02-05 21:57:42 +01:00
|
|
|
if (code) {
|
|
|
|
if (use_sideband)
|
|
|
|
finish_async(&muxer);
|
2009-07-04 21:26:43 +02:00
|
|
|
return code;
|
2010-02-05 21:57:42 +01:00
|
|
|
}
|
|
|
|
|
2011-09-08 21:17:09 +02:00
|
|
|
while (1) {
|
|
|
|
const char *buf;
|
|
|
|
size_t n;
|
|
|
|
if (feed(feed_state, &buf, &n))
|
|
|
|
break;
|
|
|
|
if (write_in_full(proc.in, buf, n) != n)
|
|
|
|
break;
|
2007-03-07 22:51:09 +01:00
|
|
|
}
|
2008-02-16 18:36:38 +01:00
|
|
|
close(proc.in);
|
2010-02-05 21:57:42 +01:00
|
|
|
if (use_sideband)
|
|
|
|
finish_async(&muxer);
|
2009-07-04 21:26:43 +02:00
|
|
|
return finish_command(&proc);
|
2005-07-31 21:17:43 +02:00
|
|
|
}
|
|
|
|
|
2011-09-08 21:17:09 +02:00
|
|
|
struct receive_hook_feed_state {
|
|
|
|
struct command *cmd;
|
2011-10-18 06:37:10 +02:00
|
|
|
int skip_broken;
|
2011-09-08 21:17:09 +02:00
|
|
|
struct strbuf buf;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int feed_receive_hook(void *state_, const char **bufp, size_t *sizep)
|
|
|
|
{
|
|
|
|
struct receive_hook_feed_state *state = state_;
|
|
|
|
struct command *cmd = state->cmd;
|
|
|
|
|
2011-10-18 06:37:10 +02:00
|
|
|
while (cmd &&
|
|
|
|
state->skip_broken && (cmd->error_string || cmd->did_not_exist))
|
2011-09-08 21:17:09 +02:00
|
|
|
cmd = cmd->next;
|
|
|
|
if (!cmd)
|
|
|
|
return -1; /* EOF */
|
|
|
|
strbuf_reset(&state->buf);
|
|
|
|
strbuf_addf(&state->buf, "%s %s %s\n",
|
|
|
|
sha1_to_hex(cmd->old_sha1), sha1_to_hex(cmd->new_sha1),
|
|
|
|
cmd->ref_name);
|
|
|
|
state->cmd = cmd->next;
|
|
|
|
if (bufp) {
|
|
|
|
*bufp = state->buf.buf;
|
|
|
|
*sizep = state->buf.len;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-10-18 06:37:10 +02:00
|
|
|
static int run_receive_hook(struct command *commands, const char *hook_name,
|
|
|
|
int skip_broken)
|
2011-09-08 21:17:09 +02:00
|
|
|
{
|
|
|
|
struct receive_hook_feed_state state;
|
|
|
|
int status;
|
|
|
|
|
|
|
|
strbuf_init(&state.buf, 0);
|
|
|
|
state.cmd = commands;
|
2011-10-18 06:37:10 +02:00
|
|
|
state.skip_broken = skip_broken;
|
2011-09-08 21:17:09 +02:00
|
|
|
if (feed_receive_hook(&state, NULL, NULL))
|
|
|
|
return 0;
|
|
|
|
state.cmd = commands;
|
|
|
|
status = run_and_feed_hook(hook_name, feed_receive_hook, &state);
|
|
|
|
strbuf_release(&state.buf);
|
|
|
|
return status;
|
|
|
|
}
|
|
|
|
|
2007-03-10 09:28:13 +01:00
|
|
|
static int run_update_hook(struct command *cmd)
|
|
|
|
{
|
|
|
|
static const char update_hook[] = "hooks/update";
|
|
|
|
const char *argv[5];
|
2010-02-05 21:57:42 +01:00
|
|
|
struct child_process proc;
|
|
|
|
int code;
|
2007-03-10 09:28:13 +01:00
|
|
|
|
|
|
|
if (access(update_hook, X_OK) < 0)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
argv[0] = update_hook;
|
|
|
|
argv[1] = cmd->ref_name;
|
|
|
|
argv[2] = sha1_to_hex(cmd->old_sha1);
|
|
|
|
argv[3] = sha1_to_hex(cmd->new_sha1);
|
|
|
|
argv[4] = NULL;
|
|
|
|
|
2010-02-05 21:57:42 +01:00
|
|
|
memset(&proc, 0, sizeof(proc));
|
|
|
|
proc.no_stdin = 1;
|
|
|
|
proc.stdout_to_stderr = 1;
|
|
|
|
proc.err = use_sideband ? -1 : 0;
|
|
|
|
proc.argv = argv;
|
|
|
|
|
|
|
|
code = start_command(&proc);
|
|
|
|
if (code)
|
|
|
|
return code;
|
|
|
|
if (use_sideband)
|
|
|
|
copy_to_sideband(proc.err, -1, NULL);
|
|
|
|
return finish_command(&proc);
|
2007-03-10 09:28:13 +01:00
|
|
|
}
|
|
|
|
|
2008-11-09 02:49:27 +01:00
|
|
|
static int is_ref_checked_out(const char *ref)
|
|
|
|
{
|
|
|
|
if (is_bare_repository())
|
|
|
|
return 0;
|
|
|
|
|
2009-02-09 07:31:21 +01:00
|
|
|
if (!head_name)
|
2008-11-09 02:49:27 +01:00
|
|
|
return 0;
|
2009-02-09 07:31:21 +01:00
|
|
|
return !strcmp(head_name, ref);
|
2008-11-09 02:49:27 +01:00
|
|
|
}
|
|
|
|
|
2009-02-11 11:28:03 +01:00
|
|
|
static char *refuse_unconfigured_deny_msg[] = {
|
|
|
|
"By default, updating the current branch in a non-bare repository",
|
|
|
|
"is denied, because it will make the index and work tree inconsistent",
|
|
|
|
"with what you pushed, and will require 'git reset --hard' to match",
|
|
|
|
"the work tree to HEAD.",
|
2009-02-01 02:34:05 +01:00
|
|
|
"",
|
|
|
|
"You can set 'receive.denyCurrentBranch' configuration variable to",
|
2009-02-11 11:28:03 +01:00
|
|
|
"'ignore' or 'warn' in the remote repository to allow pushing into",
|
|
|
|
"its current branch; however, this is not recommended unless you",
|
|
|
|
"arranged to update its work tree to match what you pushed in some",
|
|
|
|
"other way.",
|
2009-02-01 02:34:05 +01:00
|
|
|
"",
|
2009-02-11 11:28:03 +01:00
|
|
|
"To squelch this message and still keep the default behaviour, set",
|
|
|
|
"'receive.denyCurrentBranch' configuration variable to 'refuse'."
|
2009-02-01 02:34:05 +01:00
|
|
|
};
|
|
|
|
|
2009-02-11 11:28:03 +01:00
|
|
|
static void refuse_unconfigured_deny(void)
|
2009-02-01 02:34:05 +01:00
|
|
|
{
|
|
|
|
int i;
|
2009-02-11 11:28:03 +01:00
|
|
|
for (i = 0; i < ARRAY_SIZE(refuse_unconfigured_deny_msg); i++)
|
2010-03-03 07:54:50 +01:00
|
|
|
rp_error("%s", refuse_unconfigured_deny_msg[i]);
|
2009-02-01 02:34:05 +01:00
|
|
|
}
|
|
|
|
|
2009-02-09 09:19:46 +01:00
|
|
|
static char *refuse_unconfigured_deny_delete_current_msg[] = {
|
|
|
|
"By default, deleting the current branch is denied, because the next",
|
|
|
|
"'git clone' won't result in any file checked out, causing confusion.",
|
2009-02-09 07:31:21 +01:00
|
|
|
"",
|
|
|
|
"You can set 'receive.denyDeleteCurrent' configuration variable to",
|
2009-02-09 09:19:46 +01:00
|
|
|
"'warn' or 'ignore' in the remote repository to allow deleting the",
|
|
|
|
"current branch, with or without a warning message.",
|
2009-02-09 07:31:21 +01:00
|
|
|
"",
|
2009-02-09 09:19:46 +01:00
|
|
|
"To squelch this message, you can set it to 'refuse'."
|
2009-02-09 07:31:21 +01:00
|
|
|
};
|
|
|
|
|
2009-02-09 09:19:46 +01:00
|
|
|
static void refuse_unconfigured_deny_delete_current(void)
|
2009-02-09 07:31:21 +01:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
for (i = 0;
|
2009-02-09 09:19:46 +01:00
|
|
|
i < ARRAY_SIZE(refuse_unconfigured_deny_delete_current_msg);
|
2009-02-09 07:31:21 +01:00
|
|
|
i++)
|
2010-03-03 07:54:50 +01:00
|
|
|
rp_error("%s", refuse_unconfigured_deny_delete_current_msg[i]);
|
2009-02-09 07:31:21 +01:00
|
|
|
}
|
|
|
|
|
2007-03-07 22:51:59 +01:00
|
|
|
static const char *update(struct command *cmd)
|
2005-06-30 19:15:22 +02:00
|
|
|
{
|
2005-12-26 08:18:37 +01:00
|
|
|
const char *name = cmd->ref_name;
|
2011-07-09 01:13:32 +02:00
|
|
|
struct strbuf namespaced_name_buf = STRBUF_INIT;
|
|
|
|
const char *namespaced_name;
|
2005-12-26 08:18:37 +01:00
|
|
|
unsigned char *old_sha1 = cmd->old_sha1;
|
|
|
|
unsigned char *new_sha1 = cmd->new_sha1;
|
2006-09-27 11:40:06 +02:00
|
|
|
struct ref_lock *lock;
|
2005-06-30 19:15:22 +02:00
|
|
|
|
2008-01-04 20:37:17 +01:00
|
|
|
/* only refs/... are allowed */
|
2011-09-15 23:10:25 +02:00
|
|
|
if (prefixcmp(name, "refs/") || check_refname_format(name + 5, 0)) {
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("refusing to create funny ref '%s' remotely", name);
|
2007-03-07 22:51:59 +01:00
|
|
|
return "funny refname";
|
2005-12-26 08:18:37 +01:00
|
|
|
}
|
2005-10-14 03:57:39 +02:00
|
|
|
|
2011-07-09 01:13:32 +02:00
|
|
|
strbuf_addf(&namespaced_name_buf, "%s%s", get_git_namespace(), name);
|
|
|
|
namespaced_name = strbuf_detach(&namespaced_name_buf, NULL);
|
|
|
|
|
|
|
|
if (is_ref_checked_out(namespaced_name)) {
|
2009-02-01 02:34:05 +01:00
|
|
|
switch (deny_current_branch) {
|
|
|
|
case DENY_IGNORE:
|
2008-11-09 02:49:27 +01:00
|
|
|
break;
|
2009-02-01 02:34:05 +01:00
|
|
|
case DENY_WARN:
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_warning("updating the current branch");
|
2008-11-09 02:49:27 +01:00
|
|
|
break;
|
2009-02-01 02:34:05 +01:00
|
|
|
case DENY_REFUSE:
|
2009-02-11 11:28:03 +01:00
|
|
|
case DENY_UNCONFIGURED:
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("refusing to update checked out branch: %s", name);
|
2009-02-11 11:28:03 +01:00
|
|
|
if (deny_current_branch == DENY_UNCONFIGURED)
|
|
|
|
refuse_unconfigured_deny();
|
2009-02-01 02:34:05 +01:00
|
|
|
return "branch is currently checked out";
|
|
|
|
}
|
2008-11-09 02:49:27 +01:00
|
|
|
}
|
|
|
|
|
2006-11-24 09:26:49 +01:00
|
|
|
if (!is_null_sha1(new_sha1) && !has_sha1_file(new_sha1)) {
|
2007-03-07 22:51:59 +01:00
|
|
|
error("unpack should have generated %s, "
|
|
|
|
"but I can't find it!", sha1_to_hex(new_sha1));
|
|
|
|
return "bad pack";
|
2005-12-26 08:18:37 +01:00
|
|
|
}
|
2009-02-09 07:31:21 +01:00
|
|
|
|
|
|
|
if (!is_null_sha1(old_sha1) && is_null_sha1(new_sha1)) {
|
|
|
|
if (deny_deletes && !prefixcmp(name, "refs/heads/")) {
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("denying ref deletion for %s", name);
|
2009-02-09 07:31:21 +01:00
|
|
|
return "deletion prohibited";
|
|
|
|
}
|
|
|
|
|
2011-07-09 01:13:32 +02:00
|
|
|
if (!strcmp(namespaced_name, head_name)) {
|
2009-02-09 07:31:21 +01:00
|
|
|
switch (deny_delete_current) {
|
|
|
|
case DENY_IGNORE:
|
|
|
|
break;
|
|
|
|
case DENY_WARN:
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_warning("deleting the current branch");
|
2009-02-09 07:31:21 +01:00
|
|
|
break;
|
|
|
|
case DENY_REFUSE:
|
2009-02-09 09:19:46 +01:00
|
|
|
case DENY_UNCONFIGURED:
|
|
|
|
if (deny_delete_current == DENY_UNCONFIGURED)
|
|
|
|
refuse_unconfigured_deny_delete_current();
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("refusing to delete the current branch: %s", name);
|
2009-02-09 07:31:21 +01:00
|
|
|
return "deletion of the current branch prohibited";
|
|
|
|
}
|
|
|
|
}
|
2008-11-01 15:42:16 +01:00
|
|
|
}
|
2009-02-09 07:31:21 +01:00
|
|
|
|
2006-11-24 09:26:49 +01:00
|
|
|
if (deny_non_fast_forwards && !is_null_sha1(new_sha1) &&
|
2006-12-05 01:30:00 +01:00
|
|
|
!is_null_sha1(old_sha1) &&
|
Mechanical conversion to use prefixcmp()
This mechanically converts strncmp() to use prefixcmp(), but only when
the parameters match specific patterns, so that they can be verified
easily. Leftover from this will be fixed in a separate step, including
idiotic conversions like
if (!strncmp("foo", arg, 3))
=>
if (!(-prefixcmp(arg, "foo")))
This was done by using this script in px.perl
#!/usr/bin/perl -i.bak -p
if (/strncmp\(([^,]+), "([^\\"]*)", (\d+)\)/ && (length($2) == $3)) {
s|strncmp\(([^,]+), "([^\\"]*)", (\d+)\)|prefixcmp($1, "$2")|;
}
if (/strncmp\("([^\\"]*)", ([^,]+), (\d+)\)/ && (length($1) == $3)) {
s|strncmp\("([^\\"]*)", ([^,]+), (\d+)\)|(-prefixcmp($2, "$1"))|;
}
and running:
$ git grep -l strncmp -- '*.c' | xargs perl px.perl
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-02-20 10:53:29 +01:00
|
|
|
!prefixcmp(name, "refs/heads/")) {
|
2008-01-02 08:39:21 +01:00
|
|
|
struct object *old_object, *new_object;
|
2006-09-21 01:07:54 +02:00
|
|
|
struct commit *old_commit, *new_commit;
|
|
|
|
|
2008-01-02 08:39:21 +01:00
|
|
|
old_object = parse_object(old_sha1);
|
|
|
|
new_object = parse_object(new_sha1);
|
|
|
|
|
|
|
|
if (!old_object || !new_object ||
|
|
|
|
old_object->type != OBJ_COMMIT ||
|
|
|
|
new_object->type != OBJ_COMMIT) {
|
|
|
|
error("bad sha1 objects for %s", name);
|
|
|
|
return "bad ref";
|
|
|
|
}
|
|
|
|
old_commit = (struct commit *)old_object;
|
|
|
|
new_commit = (struct commit *)new_object;
|
2012-08-28 00:16:38 +02:00
|
|
|
if (!in_merge_bases(old_commit, new_commit)) {
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("denying non-fast-forward %s"
|
|
|
|
" (you should pull first)", name);
|
2009-10-24 10:31:32 +02:00
|
|
|
return "non-fast-forward";
|
2007-03-07 22:51:59 +01:00
|
|
|
}
|
2006-09-21 01:07:54 +02:00
|
|
|
}
|
2007-03-10 09:28:13 +01:00
|
|
|
if (run_update_hook(cmd)) {
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("hook declined to update %s", name);
|
2007-03-07 22:51:59 +01:00
|
|
|
return "hook declined";
|
2005-07-31 21:17:43 +02:00
|
|
|
}
|
2006-09-27 11:40:06 +02:00
|
|
|
|
2006-11-24 09:26:49 +01:00
|
|
|
if (is_null_sha1(new_sha1)) {
|
2007-11-29 02:02:53 +01:00
|
|
|
if (!parse_object(old_sha1)) {
|
|
|
|
old_sha1 = NULL;
|
2011-09-28 17:39:35 +02:00
|
|
|
if (ref_exists(name)) {
|
|
|
|
rp_warning("Allowing deletion of corrupt ref.");
|
|
|
|
} else {
|
|
|
|
rp_warning("Deleting a non-existent ref.");
|
|
|
|
cmd->did_not_exist = 1;
|
|
|
|
}
|
2007-11-29 02:02:53 +01:00
|
|
|
}
|
2011-07-09 01:13:32 +02:00
|
|
|
if (delete_ref(namespaced_name, old_sha1, 0)) {
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("failed to delete %s", name);
|
2007-03-07 22:51:59 +01:00
|
|
|
return "failed to delete";
|
2006-11-24 09:26:49 +01:00
|
|
|
}
|
2007-03-07 22:51:59 +01:00
|
|
|
return NULL; /* good */
|
2006-11-24 09:26:49 +01:00
|
|
|
}
|
|
|
|
else {
|
2011-07-09 01:13:32 +02:00
|
|
|
lock = lock_any_ref_for_update(namespaced_name, old_sha1, 0);
|
2006-11-24 09:26:49 +01:00
|
|
|
if (!lock) {
|
2010-02-10 18:34:12 +01:00
|
|
|
rp_error("failed to lock %s", name);
|
2007-03-07 22:51:59 +01:00
|
|
|
return "failed to lock";
|
2006-11-24 09:26:49 +01:00
|
|
|
}
|
2007-03-07 18:04:24 +01:00
|
|
|
if (write_ref_sha1(lock, new_sha1, "push")) {
|
2007-03-07 22:51:59 +01:00
|
|
|
return "failed to write"; /* error() already called */
|
2007-03-07 18:04:24 +01:00
|
|
|
}
|
2007-03-07 22:51:59 +01:00
|
|
|
return NULL; /* good */
|
2005-08-02 23:24:22 +02:00
|
|
|
}
|
2005-06-30 19:15:22 +02:00
|
|
|
}
|
|
|
|
|
2005-08-02 23:24:22 +02:00
|
|
|
static char update_post_hook[] = "hooks/post-update";
|
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
static void run_update_post_hook(struct command *commands)
|
2005-08-02 23:24:22 +02:00
|
|
|
{
|
2010-04-20 00:08:30 +02:00
|
|
|
struct command *cmd;
|
2010-02-05 21:57:42 +01:00
|
|
|
int argc;
|
2006-03-05 11:47:29 +01:00
|
|
|
const char **argv;
|
2010-02-05 21:57:42 +01:00
|
|
|
struct child_process proc;
|
2005-08-02 23:24:22 +02:00
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
for (argc = 0, cmd = commands; cmd; cmd = cmd->next) {
|
2011-09-28 17:39:35 +02:00
|
|
|
if (cmd->error_string || cmd->did_not_exist)
|
2005-08-02 23:24:22 +02:00
|
|
|
continue;
|
|
|
|
argc++;
|
|
|
|
}
|
2007-03-07 22:50:43 +01:00
|
|
|
if (!argc || access(update_post_hook, X_OK) < 0)
|
|
|
|
return;
|
|
|
|
argv = xmalloc(sizeof(*argv) * (2 + argc));
|
2005-08-02 23:24:22 +02:00
|
|
|
argv[0] = update_post_hook;
|
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
for (argc = 1, cmd = commands; cmd; cmd = cmd->next) {
|
2006-03-05 11:47:29 +01:00
|
|
|
char *p;
|
2011-09-28 17:39:35 +02:00
|
|
|
if (cmd->error_string || cmd->did_not_exist)
|
2005-08-02 23:24:22 +02:00
|
|
|
continue;
|
2010-04-20 00:08:30 +02:00
|
|
|
p = xmalloc(strlen(cmd->ref_name) + 1);
|
|
|
|
strcpy(p, cmd->ref_name);
|
2006-03-05 11:47:29 +01:00
|
|
|
argv[argc] = p;
|
2005-08-02 23:24:22 +02:00
|
|
|
argc++;
|
|
|
|
}
|
|
|
|
argv[argc] = NULL;
|
2010-02-05 21:57:42 +01:00
|
|
|
|
|
|
|
memset(&proc, 0, sizeof(proc));
|
|
|
|
proc.no_stdin = 1;
|
|
|
|
proc.stdout_to_stderr = 1;
|
|
|
|
proc.err = use_sideband ? -1 : 0;
|
|
|
|
proc.argv = argv;
|
|
|
|
|
|
|
|
if (!start_command(&proc)) {
|
|
|
|
if (use_sideband)
|
|
|
|
copy_to_sideband(proc.err, -1, NULL);
|
|
|
|
finish_command(&proc);
|
|
|
|
}
|
2005-08-02 23:24:22 +02:00
|
|
|
}
|
2005-06-30 19:15:22 +02:00
|
|
|
|
2010-04-20 00:19:18 +02:00
|
|
|
static void check_aliased_update(struct command *cmd, struct string_list *list)
|
|
|
|
{
|
2011-07-09 01:13:32 +02:00
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
const char *dst_name;
|
2010-04-20 00:19:18 +02:00
|
|
|
struct string_list_item *item;
|
|
|
|
struct command *dst_cmd;
|
|
|
|
unsigned char sha1[20];
|
|
|
|
char cmd_oldh[41], cmd_newh[41], dst_oldh[41], dst_newh[41];
|
|
|
|
int flag;
|
|
|
|
|
2011-07-09 01:13:32 +02:00
|
|
|
strbuf_addf(&buf, "%s%s", get_git_namespace(), cmd->ref_name);
|
2011-12-12 12:20:32 +01:00
|
|
|
dst_name = resolve_ref_unsafe(buf.buf, sha1, 0, &flag);
|
2011-07-09 01:13:32 +02:00
|
|
|
strbuf_release(&buf);
|
2010-04-20 00:19:18 +02:00
|
|
|
|
|
|
|
if (!(flag & REF_ISSYMREF))
|
|
|
|
return;
|
|
|
|
|
2011-07-09 01:13:32 +02:00
|
|
|
dst_name = strip_namespace(dst_name);
|
|
|
|
if (!dst_name) {
|
|
|
|
rp_error("refusing update to broken symref '%s'", cmd->ref_name);
|
|
|
|
cmd->skip_update = 1;
|
|
|
|
cmd->error_string = "broken symref";
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-06-26 01:41:37 +02:00
|
|
|
if ((item = string_list_lookup(list, dst_name)) == NULL)
|
2010-04-20 00:19:18 +02:00
|
|
|
return;
|
|
|
|
|
|
|
|
cmd->skip_update = 1;
|
|
|
|
|
|
|
|
dst_cmd = (struct command *) item->util;
|
|
|
|
|
|
|
|
if (!hashcmp(cmd->old_sha1, dst_cmd->old_sha1) &&
|
|
|
|
!hashcmp(cmd->new_sha1, dst_cmd->new_sha1))
|
|
|
|
return;
|
|
|
|
|
|
|
|
dst_cmd->skip_update = 1;
|
|
|
|
|
|
|
|
strcpy(cmd_oldh, find_unique_abbrev(cmd->old_sha1, DEFAULT_ABBREV));
|
2010-06-10 20:43:51 +02:00
|
|
|
strcpy(cmd_newh, find_unique_abbrev(cmd->new_sha1, DEFAULT_ABBREV));
|
2010-04-20 00:19:18 +02:00
|
|
|
strcpy(dst_oldh, find_unique_abbrev(dst_cmd->old_sha1, DEFAULT_ABBREV));
|
2010-06-10 20:43:51 +02:00
|
|
|
strcpy(dst_newh, find_unique_abbrev(dst_cmd->new_sha1, DEFAULT_ABBREV));
|
2010-04-20 00:19:18 +02:00
|
|
|
rp_error("refusing inconsistent update between symref '%s' (%s..%s) and"
|
|
|
|
" its target '%s' (%s..%s)",
|
|
|
|
cmd->ref_name, cmd_oldh, cmd_newh,
|
|
|
|
dst_cmd->ref_name, dst_oldh, dst_newh);
|
|
|
|
|
|
|
|
cmd->error_string = dst_cmd->error_string =
|
|
|
|
"inconsistent aliased update";
|
|
|
|
}
|
|
|
|
|
|
|
|
static void check_aliased_updates(struct command *commands)
|
|
|
|
{
|
|
|
|
struct command *cmd;
|
2010-07-04 21:46:19 +02:00
|
|
|
struct string_list ref_list = STRING_LIST_INIT_NODUP;
|
2010-04-20 00:19:18 +02:00
|
|
|
|
|
|
|
for (cmd = commands; cmd; cmd = cmd->next) {
|
|
|
|
struct string_list_item *item =
|
2010-06-26 01:41:38 +02:00
|
|
|
string_list_append(&ref_list, cmd->ref_name);
|
2010-04-20 00:19:18 +02:00
|
|
|
item->util = (void *)cmd;
|
|
|
|
}
|
|
|
|
sort_string_list(&ref_list);
|
|
|
|
|
2012-02-13 21:17:12 +01:00
|
|
|
for (cmd = commands; cmd; cmd = cmd->next) {
|
|
|
|
if (!cmd->error_string)
|
|
|
|
check_aliased_update(cmd, &ref_list);
|
|
|
|
}
|
2010-04-20 00:19:18 +02:00
|
|
|
|
|
|
|
string_list_clear(&ref_list, 0);
|
|
|
|
}
|
|
|
|
|
2011-09-03 01:52:08 +02:00
|
|
|
static int command_singleton_iterator(void *cb_data, unsigned char sha1[20])
|
|
|
|
{
|
|
|
|
struct command **cmd_list = cb_data;
|
|
|
|
struct command *cmd = *cmd_list;
|
|
|
|
|
2011-11-03 20:15:08 +01:00
|
|
|
if (!cmd || is_null_sha1(cmd->new_sha1))
|
2011-09-03 01:52:08 +02:00
|
|
|
return -1; /* end of list */
|
|
|
|
*cmd_list = NULL; /* this returns only one */
|
|
|
|
hashcpy(sha1, cmd->new_sha1);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void set_connectivity_errors(struct command *commands)
|
|
|
|
{
|
|
|
|
struct command *cmd;
|
|
|
|
|
|
|
|
for (cmd = commands; cmd; cmd = cmd->next) {
|
|
|
|
struct command *singleton = cmd;
|
|
|
|
if (!check_everything_connected(command_singleton_iterator,
|
|
|
|
0, &singleton))
|
|
|
|
continue;
|
|
|
|
cmd->error_string = "missing necessary objects";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int iterate_receive_command_list(void *cb_data, unsigned char sha1[20])
|
|
|
|
{
|
|
|
|
struct command **cmd_list = cb_data;
|
|
|
|
struct command *cmd = *cmd_list;
|
|
|
|
|
2011-11-03 20:15:08 +01:00
|
|
|
while (cmd) {
|
|
|
|
if (!is_null_sha1(cmd->new_sha1)) {
|
|
|
|
hashcpy(sha1, cmd->new_sha1);
|
|
|
|
*cmd_list = cmd->next;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
cmd = cmd->next;
|
|
|
|
}
|
|
|
|
*cmd_list = NULL;
|
|
|
|
return -1; /* end of list */
|
2011-09-03 01:52:08 +02:00
|
|
|
}
|
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
static void execute_commands(struct command *commands, const char *unpacker_error)
|
2005-06-30 02:52:11 +02:00
|
|
|
{
|
2010-04-20 00:08:30 +02:00
|
|
|
struct command *cmd;
|
2009-02-09 07:31:21 +01:00
|
|
|
unsigned char sha1[20];
|
2007-03-07 22:51:59 +01:00
|
|
|
|
|
|
|
if (unpacker_error) {
|
2010-04-20 00:08:30 +02:00
|
|
|
for (cmd = commands; cmd; cmd = cmd->next)
|
2012-09-21 07:38:46 +02:00
|
|
|
cmd->error_string = "unpacker error";
|
2007-03-07 22:51:59 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2011-09-03 01:52:08 +02:00
|
|
|
cmd = commands;
|
|
|
|
if (check_everything_connected(iterate_receive_command_list,
|
|
|
|
0, &cmd))
|
|
|
|
set_connectivity_errors(commands);
|
|
|
|
|
2011-10-18 06:37:10 +02:00
|
|
|
if (run_receive_hook(commands, pre_receive_hook, 0)) {
|
2012-02-13 21:17:12 +01:00
|
|
|
for (cmd = commands; cmd; cmd = cmd->next) {
|
|
|
|
if (!cmd->error_string)
|
|
|
|
cmd->error_string = "pre-receive hook declined";
|
|
|
|
}
|
2007-03-07 22:52:05 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-04-20 00:19:18 +02:00
|
|
|
check_aliased_updates(commands);
|
|
|
|
|
2011-12-13 15:17:48 +01:00
|
|
|
free(head_name_to_free);
|
|
|
|
head_name = head_name_to_free = resolve_refdup("HEAD", sha1, 0, NULL);
|
2009-02-09 07:31:21 +01:00
|
|
|
|
2012-02-13 21:17:12 +01:00
|
|
|
for (cmd = commands; cmd; cmd = cmd->next) {
|
|
|
|
if (cmd->error_string)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (cmd->skip_update)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
cmd->error_string = update(cmd);
|
|
|
|
}
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
static struct command *read_head_info(void)
|
2005-06-30 02:52:11 +02:00
|
|
|
{
|
2010-04-20 00:08:30 +02:00
|
|
|
struct command *commands = NULL;
|
2005-06-30 08:01:14 +02:00
|
|
|
struct command **p = &commands;
|
2005-06-30 02:52:11 +02:00
|
|
|
for (;;) {
|
|
|
|
static char line[1000];
|
2005-06-30 08:01:14 +02:00
|
|
|
unsigned char old_sha1[20], new_sha1[20];
|
|
|
|
struct command *cmd;
|
2005-12-26 08:18:37 +01:00
|
|
|
char *refname;
|
|
|
|
int len, reflen;
|
2005-06-30 08:01:14 +02:00
|
|
|
|
|
|
|
len = packet_read_line(0, line, sizeof(line));
|
2005-06-30 02:52:11 +02:00
|
|
|
if (!len)
|
|
|
|
break;
|
2005-06-30 08:01:14 +02:00
|
|
|
if (line[len-1] == '\n')
|
|
|
|
line[--len] = 0;
|
|
|
|
if (len < 83 ||
|
|
|
|
line[40] != ' ' ||
|
|
|
|
line[81] != ' ' ||
|
|
|
|
get_sha1_hex(line, old_sha1) ||
|
|
|
|
get_sha1_hex(line + 41, new_sha1))
|
2005-12-26 08:18:37 +01:00
|
|
|
die("protocol error: expected old/new/ref, got '%s'",
|
|
|
|
line);
|
|
|
|
|
|
|
|
refname = line + 82;
|
|
|
|
reflen = strlen(refname);
|
|
|
|
if (reflen + 82 < len) {
|
2012-01-08 22:06:19 +01:00
|
|
|
const char *feature_list = refname + reflen + 1;
|
|
|
|
if (parse_feature_request(feature_list, "report-status"))
|
2005-12-26 08:18:37 +01:00
|
|
|
report_status = 1;
|
2012-01-08 22:06:19 +01:00
|
|
|
if (parse_feature_request(feature_list, "side-band-64k"))
|
2010-02-05 21:57:41 +01:00
|
|
|
use_sideband = LARGE_PACKET_MAX;
|
2012-01-08 22:06:20 +01:00
|
|
|
if (parse_feature_request(feature_list, "quiet"))
|
|
|
|
quiet = 1;
|
2005-12-26 08:18:37 +01:00
|
|
|
}
|
2010-04-20 00:19:18 +02:00
|
|
|
cmd = xcalloc(1, sizeof(struct command) + len - 80);
|
2006-08-23 08:49:00 +02:00
|
|
|
hashcpy(cmd->old_sha1, old_sha1);
|
|
|
|
hashcpy(cmd->new_sha1, new_sha1);
|
2005-06-30 08:01:14 +02:00
|
|
|
memcpy(cmd->ref_name, line + 82, len - 81);
|
|
|
|
*p = cmd;
|
|
|
|
p = &cmd->next;
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
2010-04-20 00:08:30 +02:00
|
|
|
return commands;
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
|
|
|
|
2006-11-01 23:06:21 +01:00
|
|
|
static const char *parse_pack_header(struct pack_header *hdr)
|
|
|
|
{
|
2007-01-23 06:55:18 +01:00
|
|
|
switch (read_pack_header(0, hdr)) {
|
|
|
|
case PH_ERROR_EOF:
|
|
|
|
return "eof before pack header was fully read";
|
|
|
|
|
|
|
|
case PH_ERROR_PACK_SIGNATURE:
|
2006-11-01 23:06:21 +01:00
|
|
|
return "protocol error (pack signature mismatch detected)";
|
2007-01-23 06:55:18 +01:00
|
|
|
|
|
|
|
case PH_ERROR_PROTOCOL:
|
2006-11-01 23:06:21 +01:00
|
|
|
return "protocol error (pack version unsupported)";
|
2007-01-23 06:55:18 +01:00
|
|
|
|
|
|
|
default:
|
|
|
|
return "unknown error in parse_pack_header";
|
|
|
|
|
|
|
|
case 0:
|
|
|
|
return NULL;
|
|
|
|
}
|
2006-11-01 23:06:21 +01:00
|
|
|
}
|
|
|
|
|
2006-11-01 23:06:25 +01:00
|
|
|
static const char *pack_lockfile;
|
|
|
|
|
receive-pack: send pack-processing stderr over sideband
Receive-pack invokes either unpack-objects or index-pack to
handle the incoming pack. However, we do not redirect the
stderr of the sub-processes at all, so it is never seen by
the client. From the initial thread adding sideband support,
which is here:
http://thread.gmane.org/gmane.comp.version-control.git/139471
it is clear that some messages are specifically kept off the
sideband (with the assumption that they are of interest only
to an administrator, not the client). The stderr of the
subprocesses is mentioned in the thread, but it's unclear if
they are included in that group, or were simply forgotten.
However, there are a few good reasons to show them to the
client:
1. In many cases, they are directly about the incoming
packfile (e.g., fsck warnings with --strict, corruption
in the packfile, etc). Without these messages, the
client just gets "unpacker error" with no extra useful
diagnosis.
2. No matter what the cause, we are probably better off
showing the errors to the client. If the client and the
server admin are not the same entity, it is probably
much easier for the client to cut-and-paste the errors
they see than for the admin to try to dig them out of a
log and correlate them with a particular session.
3. Users of the ssh transport typically already see these
stderr messages, as the remote's stderr is copied
literally by ssh. This brings other transports (http,
and push-over-git if you are crazy enough to enable it)
more in line with ssh. As a bonus for ssh users,
because the messages are now fed through the sideband
and printed by the local git, they will have "remote:"
prepended and be properly interleaved with any local
output to stderr.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-09-21 07:34:55 +02:00
|
|
|
static const char *unpack(int err_fd)
|
2005-06-30 02:52:11 +02:00
|
|
|
{
|
2006-11-01 23:06:21 +01:00
|
|
|
struct pack_header hdr;
|
|
|
|
const char *hdr_err;
|
|
|
|
char hdr_arg[38];
|
2011-09-04 21:37:45 +02:00
|
|
|
int fsck_objects = (receive_fsck_objects >= 0
|
|
|
|
? receive_fsck_objects
|
|
|
|
: transfer_fsck_objects >= 0
|
|
|
|
? transfer_fsck_objects
|
|
|
|
: 0);
|
2006-11-01 23:06:21 +01:00
|
|
|
|
|
|
|
hdr_err = parse_pack_header(&hdr);
|
|
|
|
if (hdr_err)
|
|
|
|
return hdr_err;
|
2008-07-03 17:52:09 +02:00
|
|
|
snprintf(hdr_arg, sizeof(hdr_arg),
|
|
|
|
"--pack_header=%"PRIu32",%"PRIu32,
|
2006-11-01 23:06:21 +01:00
|
|
|
ntohl(hdr.hdr_version), ntohl(hdr.hdr_entries));
|
|
|
|
|
|
|
|
if (ntohl(hdr.hdr_entries) < unpack_limit) {
|
2008-02-25 22:46:13 +01:00
|
|
|
int code, i = 0;
|
2012-09-21 07:32:52 +02:00
|
|
|
struct child_process child;
|
2012-01-08 22:06:20 +01:00
|
|
|
const char *unpacker[5];
|
2008-02-25 22:46:13 +01:00
|
|
|
unpacker[i++] = "unpack-objects";
|
2012-01-08 22:06:20 +01:00
|
|
|
if (quiet)
|
|
|
|
unpacker[i++] = "-q";
|
2011-09-04 21:37:45 +02:00
|
|
|
if (fsck_objects)
|
2008-02-25 22:46:13 +01:00
|
|
|
unpacker[i++] = "--strict";
|
|
|
|
unpacker[i++] = hdr_arg;
|
|
|
|
unpacker[i++] = NULL;
|
2012-09-21 07:32:52 +02:00
|
|
|
memset(&child, 0, sizeof(child));
|
|
|
|
child.argv = unpacker;
|
|
|
|
child.no_stdout = 1;
|
receive-pack: send pack-processing stderr over sideband
Receive-pack invokes either unpack-objects or index-pack to
handle the incoming pack. However, we do not redirect the
stderr of the sub-processes at all, so it is never seen by
the client. From the initial thread adding sideband support,
which is here:
http://thread.gmane.org/gmane.comp.version-control.git/139471
it is clear that some messages are specifically kept off the
sideband (with the assumption that they are of interest only
to an administrator, not the client). The stderr of the
subprocesses is mentioned in the thread, but it's unclear if
they are included in that group, or were simply forgotten.
However, there are a few good reasons to show them to the
client:
1. In many cases, they are directly about the incoming
packfile (e.g., fsck warnings with --strict, corruption
in the packfile, etc). Without these messages, the
client just gets "unpacker error" with no extra useful
diagnosis.
2. No matter what the cause, we are probably better off
showing the errors to the client. If the client and the
server admin are not the same entity, it is probably
much easier for the client to cut-and-paste the errors
they see than for the admin to try to dig them out of a
log and correlate them with a particular session.
3. Users of the ssh transport typically already see these
stderr messages, as the remote's stderr is copied
literally by ssh. This brings other transports (http,
and push-over-git if you are crazy enough to enable it)
more in line with ssh. As a bonus for ssh users,
because the messages are now fed through the sideband
and printed by the local git, they will have "remote:"
prepended and be properly interleaved with any local
output to stderr.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-09-21 07:34:55 +02:00
|
|
|
child.err = err_fd;
|
2012-09-21 07:32:52 +02:00
|
|
|
child.git_cmd = 1;
|
|
|
|
code = run_command(&child);
|
2009-06-21 23:16:09 +02:00
|
|
|
if (!code)
|
2006-11-01 23:06:21 +01:00
|
|
|
return NULL;
|
2009-06-21 23:16:09 +02:00
|
|
|
return "unpack-objects abnormal exit";
|
2006-11-01 23:06:25 +01:00
|
|
|
} else {
|
2008-02-25 22:46:13 +01:00
|
|
|
const char *keeper[7];
|
|
|
|
int s, status, i = 0;
|
2006-11-01 23:06:25 +01:00
|
|
|
char keep_arg[256];
|
2007-03-13 00:00:26 +01:00
|
|
|
struct child_process ip;
|
2006-11-01 23:06:25 +01:00
|
|
|
|
2008-08-31 14:09:39 +02:00
|
|
|
s = sprintf(keep_arg, "--keep=receive-pack %"PRIuMAX" on ", (uintmax_t) getpid());
|
2006-11-01 23:06:25 +01:00
|
|
|
if (gethostname(keep_arg + s, sizeof(keep_arg) - s))
|
|
|
|
strcpy(keep_arg + s, "localhost");
|
|
|
|
|
2008-02-25 22:46:13 +01:00
|
|
|
keeper[i++] = "index-pack";
|
|
|
|
keeper[i++] = "--stdin";
|
2011-09-04 21:37:45 +02:00
|
|
|
if (fsck_objects)
|
2008-02-25 22:46:13 +01:00
|
|
|
keeper[i++] = "--strict";
|
|
|
|
keeper[i++] = "--fix-thin";
|
|
|
|
keeper[i++] = hdr_arg;
|
|
|
|
keeper[i++] = keep_arg;
|
|
|
|
keeper[i++] = NULL;
|
2007-03-13 00:00:26 +01:00
|
|
|
memset(&ip, 0, sizeof(ip));
|
|
|
|
ip.argv = keeper;
|
|
|
|
ip.out = -1;
|
receive-pack: send pack-processing stderr over sideband
Receive-pack invokes either unpack-objects or index-pack to
handle the incoming pack. However, we do not redirect the
stderr of the sub-processes at all, so it is never seen by
the client. From the initial thread adding sideband support,
which is here:
http://thread.gmane.org/gmane.comp.version-control.git/139471
it is clear that some messages are specifically kept off the
sideband (with the assumption that they are of interest only
to an administrator, not the client). The stderr of the
subprocesses is mentioned in the thread, but it's unclear if
they are included in that group, or were simply forgotten.
However, there are a few good reasons to show them to the
client:
1. In many cases, they are directly about the incoming
packfile (e.g., fsck warnings with --strict, corruption
in the packfile, etc). Without these messages, the
client just gets "unpacker error" with no extra useful
diagnosis.
2. No matter what the cause, we are probably better off
showing the errors to the client. If the client and the
server admin are not the same entity, it is probably
much easier for the client to cut-and-paste the errors
they see than for the admin to try to dig them out of a
log and correlate them with a particular session.
3. Users of the ssh transport typically already see these
stderr messages, as the remote's stderr is copied
literally by ssh. This brings other transports (http,
and push-over-git if you are crazy enough to enable it)
more in line with ssh. As a bonus for ssh users,
because the messages are now fed through the sideband
and printed by the local git, they will have "remote:"
prepended and be properly interleaved with any local
output to stderr.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-09-21 07:34:55 +02:00
|
|
|
ip.err = err_fd;
|
2007-03-13 00:00:26 +01:00
|
|
|
ip.git_cmd = 1;
|
2009-06-21 23:16:09 +02:00
|
|
|
status = start_command(&ip);
|
|
|
|
if (status) {
|
2006-11-01 23:06:25 +01:00
|
|
|
return "index-pack fork failed";
|
2009-06-21 23:16:09 +02:00
|
|
|
}
|
2007-09-14 09:31:16 +02:00
|
|
|
pack_lockfile = index_pack_lockfile(ip.out);
|
2008-02-16 18:36:38 +01:00
|
|
|
close(ip.out);
|
2007-03-13 00:00:26 +01:00
|
|
|
status = finish_command(&ip);
|
|
|
|
if (!status) {
|
2006-11-01 23:06:25 +01:00
|
|
|
reprepare_packed_git();
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
return "index-pack abnormal exit";
|
2005-12-26 08:18:37 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
receive-pack: send pack-processing stderr over sideband
Receive-pack invokes either unpack-objects or index-pack to
handle the incoming pack. However, we do not redirect the
stderr of the sub-processes at all, so it is never seen by
the client. From the initial thread adding sideband support,
which is here:
http://thread.gmane.org/gmane.comp.version-control.git/139471
it is clear that some messages are specifically kept off the
sideband (with the assumption that they are of interest only
to an administrator, not the client). The stderr of the
subprocesses is mentioned in the thread, but it's unclear if
they are included in that group, or were simply forgotten.
However, there are a few good reasons to show them to the
client:
1. In many cases, they are directly about the incoming
packfile (e.g., fsck warnings with --strict, corruption
in the packfile, etc). Without these messages, the
client just gets "unpacker error" with no extra useful
diagnosis.
2. No matter what the cause, we are probably better off
showing the errors to the client. If the client and the
server admin are not the same entity, it is probably
much easier for the client to cut-and-paste the errors
they see than for the admin to try to dig them out of a
log and correlate them with a particular session.
3. Users of the ssh transport typically already see these
stderr messages, as the remote's stderr is copied
literally by ssh. This brings other transports (http,
and push-over-git if you are crazy enough to enable it)
more in line with ssh. As a bonus for ssh users,
because the messages are now fed through the sideband
and printed by the local git, they will have "remote:"
prepended and be properly interleaved with any local
output to stderr.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-09-21 07:34:55 +02:00
|
|
|
static const char *unpack_with_sideband(void)
|
|
|
|
{
|
|
|
|
struct async muxer;
|
|
|
|
const char *ret;
|
|
|
|
|
|
|
|
if (!use_sideband)
|
|
|
|
return unpack(0);
|
|
|
|
|
|
|
|
memset(&muxer, 0, sizeof(muxer));
|
|
|
|
muxer.proc = copy_to_sideband;
|
|
|
|
muxer.in = -1;
|
|
|
|
if (start_async(&muxer))
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
ret = unpack(muxer.in);
|
|
|
|
|
|
|
|
finish_async(&muxer);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
static void report(struct command *commands, const char *unpack_status)
|
2005-12-26 08:18:37 +01:00
|
|
|
{
|
|
|
|
struct command *cmd;
|
2010-02-05 21:57:41 +01:00
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
|
|
packet_buf_write(&buf, "unpack %s\n",
|
|
|
|
unpack_status ? unpack_status : "ok");
|
2005-12-26 08:18:37 +01:00
|
|
|
for (cmd = commands; cmd; cmd = cmd->next) {
|
|
|
|
if (!cmd->error_string)
|
2010-02-05 21:57:41 +01:00
|
|
|
packet_buf_write(&buf, "ok %s\n",
|
|
|
|
cmd->ref_name);
|
2005-12-26 08:18:37 +01:00
|
|
|
else
|
2010-02-05 21:57:41 +01:00
|
|
|
packet_buf_write(&buf, "ng %s %s\n",
|
|
|
|
cmd->ref_name, cmd->error_string);
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
2010-02-05 21:57:41 +01:00
|
|
|
packet_buf_flush(&buf);
|
|
|
|
|
|
|
|
if (use_sideband)
|
|
|
|
send_sideband(1, 1, buf.buf, buf.len, use_sideband);
|
|
|
|
else
|
|
|
|
safe_write(1, buf.buf, buf.len);
|
|
|
|
strbuf_release(&buf);
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
static int delete_only(struct command *commands)
|
2006-11-24 09:26:49 +01:00
|
|
|
{
|
2010-04-20 00:08:30 +02:00
|
|
|
struct command *cmd;
|
|
|
|
for (cmd = commands; cmd; cmd = cmd->next) {
|
2006-11-24 09:26:49 +01:00
|
|
|
if (!is_null_sha1(cmd->new_sha1))
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2008-09-09 10:27:08 +02:00
|
|
|
int cmd_receive_pack(int argc, const char **argv, const char *prefix)
|
2005-06-30 02:52:11 +02:00
|
|
|
{
|
2009-10-31 01:47:33 +01:00
|
|
|
int advertise_refs = 0;
|
|
|
|
int stateless_rpc = 0;
|
2005-06-30 21:28:24 +02:00
|
|
|
int i;
|
2005-11-17 20:37:14 +01:00
|
|
|
char *dir = NULL;
|
2010-04-20 00:08:30 +02:00
|
|
|
struct command *commands;
|
2005-06-30 02:52:11 +02:00
|
|
|
|
2011-02-24 15:30:19 +01:00
|
|
|
packet_trace_identity("receive-pack");
|
|
|
|
|
2005-06-30 02:52:11 +02:00
|
|
|
argv++;
|
|
|
|
for (i = 1; i < argc; i++) {
|
2008-09-09 10:27:08 +02:00
|
|
|
const char *arg = *argv++;
|
2005-06-30 02:52:11 +02:00
|
|
|
|
|
|
|
if (*arg == '-') {
|
2012-01-08 22:06:20 +01:00
|
|
|
if (!strcmp(arg, "--quiet")) {
|
|
|
|
quiet = 1;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2009-10-31 01:47:33 +01:00
|
|
|
if (!strcmp(arg, "--advertise-refs")) {
|
|
|
|
advertise_refs = 1;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (!strcmp(arg, "--stateless-rpc")) {
|
|
|
|
stateless_rpc = 1;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2005-06-30 02:52:11 +02:00
|
|
|
usage(receive_pack_usage);
|
|
|
|
}
|
2005-06-30 21:28:24 +02:00
|
|
|
if (dir)
|
|
|
|
usage(receive_pack_usage);
|
2008-09-09 10:27:08 +02:00
|
|
|
dir = xstrdup(arg);
|
2005-06-30 02:52:11 +02:00
|
|
|
}
|
|
|
|
if (!dir)
|
|
|
|
usage(receive_pack_usage);
|
|
|
|
|
2008-07-21 21:19:52 +02:00
|
|
|
setup_path();
|
2008-03-03 05:08:43 +01:00
|
|
|
|
2006-09-27 11:40:06 +02:00
|
|
|
if (!enter_repo(dir, 0))
|
2009-03-04 09:32:29 +01:00
|
|
|
die("'%s' does not appear to be a git repository", dir);
|
2005-06-30 02:52:11 +02:00
|
|
|
|
2007-01-22 07:23:58 +01:00
|
|
|
if (is_repository_shallow())
|
|
|
|
die("attempt to push into a shallow repository");
|
|
|
|
|
2008-05-14 19:46:53 +02:00
|
|
|
git_config(receive_pack_config, NULL);
|
2006-10-30 23:35:18 +01:00
|
|
|
|
2007-01-25 02:02:15 +01:00
|
|
|
if (0 <= transfer_unpack_limit)
|
|
|
|
unpack_limit = transfer_unpack_limit;
|
|
|
|
else if (0 <= receive_unpack_limit)
|
|
|
|
unpack_limit = receive_unpack_limit;
|
|
|
|
|
2009-10-31 01:47:33 +01:00
|
|
|
if (advertise_refs || !stateless_rpc) {
|
|
|
|
write_head_info();
|
|
|
|
}
|
|
|
|
if (advertise_refs)
|
|
|
|
return 0;
|
2005-06-30 02:52:11 +02:00
|
|
|
|
2010-04-20 00:08:30 +02:00
|
|
|
if ((commands = read_head_info()) != NULL) {
|
2006-11-24 09:26:49 +01:00
|
|
|
const char *unpack_status = NULL;
|
|
|
|
|
|
|
|
if (!delete_only(commands))
|
receive-pack: send pack-processing stderr over sideband
Receive-pack invokes either unpack-objects or index-pack to
handle the incoming pack. However, we do not redirect the
stderr of the sub-processes at all, so it is never seen by
the client. From the initial thread adding sideband support,
which is here:
http://thread.gmane.org/gmane.comp.version-control.git/139471
it is clear that some messages are specifically kept off the
sideband (with the assumption that they are of interest only
to an administrator, not the client). The stderr of the
subprocesses is mentioned in the thread, but it's unclear if
they are included in that group, or were simply forgotten.
However, there are a few good reasons to show them to the
client:
1. In many cases, they are directly about the incoming
packfile (e.g., fsck warnings with --strict, corruption
in the packfile, etc). Without these messages, the
client just gets "unpacker error" with no extra useful
diagnosis.
2. No matter what the cause, we are probably better off
showing the errors to the client. If the client and the
server admin are not the same entity, it is probably
much easier for the client to cut-and-paste the errors
they see than for the admin to try to dig them out of a
log and correlate them with a particular session.
3. Users of the ssh transport typically already see these
stderr messages, as the remote's stderr is copied
literally by ssh. This brings other transports (http,
and push-over-git if you are crazy enough to enable it)
more in line with ssh. As a bonus for ssh users,
because the messages are now fed through the sideband
and printed by the local git, they will have "remote:"
prepended and be properly interleaved with any local
output to stderr.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-09-21 07:34:55 +02:00
|
|
|
unpack_status = unpack_with_sideband();
|
2010-04-20 00:08:30 +02:00
|
|
|
execute_commands(commands, unpack_status);
|
2006-11-01 23:06:25 +01:00
|
|
|
if (pack_lockfile)
|
2009-04-29 23:22:56 +02:00
|
|
|
unlink_or_warn(pack_lockfile);
|
2005-12-26 08:18:37 +01:00
|
|
|
if (report_status)
|
2010-04-20 00:08:30 +02:00
|
|
|
report(commands, unpack_status);
|
2011-10-18 06:37:10 +02:00
|
|
|
run_receive_hook(commands, post_receive_hook, 1);
|
2007-03-07 22:50:24 +01:00
|
|
|
run_update_post_hook(commands);
|
2009-10-20 23:56:40 +02:00
|
|
|
if (auto_gc) {
|
|
|
|
const char *argv_gc_auto[] = {
|
|
|
|
"gc", "--auto", "--quiet", NULL,
|
|
|
|
};
|
2012-08-07 07:31:10 +02:00
|
|
|
int opt = RUN_GIT_CMD | RUN_COMMAND_STDOUT_TO_STDERR;
|
|
|
|
run_command_v_opt(argv_gc_auto, opt);
|
2009-10-20 23:56:40 +02:00
|
|
|
}
|
|
|
|
if (auto_update_server_info)
|
|
|
|
update_server_info(0);
|
2005-06-30 07:50:48 +02:00
|
|
|
}
|
2010-02-05 21:57:41 +01:00
|
|
|
if (use_sideband)
|
|
|
|
packet_flush(1);
|
2005-06-30 02:52:11 +02:00
|
|
|
return 0;
|
|
|
|
}
|