2015-05-11 17:25:03 +02:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
2016-06-07 10:13:04 +02:00
|
|
|
test_description='Test git update-ref error handling'
|
2015-05-11 17:25:03 +02:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
2016-06-10 08:55:40 +02:00
|
|
|
# Create some references, perhaps run pack-refs --all, then try to
|
|
|
|
|
# create some more references. Ensure that the second creation fails
|
|
|
|
|
# with the correct error message.
|
|
|
|
|
# Usage: test_update_rejected <before> <pack> <create> <error>
|
|
|
|
|
# <before> is a ws-separated list of refs to create before the test
|
|
|
|
|
# <pack> (true or false) tells whether to pack the refs before the test
|
|
|
|
|
# <create> is a list of variables to attempt creating
|
|
|
|
|
# <error> is a string to look for in the stderr of update-ref.
|
|
|
|
|
# All references are created in the namespace specified by the current
|
|
|
|
|
# value of $prefix.
|
2015-05-11 17:25:03 +02:00
|
|
|
test_update_rejected () {
|
2016-06-10 08:50:53 +02:00
|
|
|
before="$1" &&
|
|
|
|
|
pack="$2" &&
|
|
|
|
|
create="$3" &&
|
|
|
|
|
error="$4" &&
|
2015-05-11 17:25:03 +02:00
|
|
|
printf "create $prefix/%s $C\n" $before |
|
|
|
|
|
git update-ref --stdin &&
|
|
|
|
|
git for-each-ref $prefix >unchanged &&
|
|
|
|
|
if $pack
|
|
|
|
|
then
|
|
|
|
|
git pack-refs --all
|
|
|
|
|
fi &&
|
|
|
|
|
printf "create $prefix/%s $C\n" $create >input &&
|
|
|
|
|
test_must_fail git update-ref --stdin <input 2>output.err &&
|
|
|
|
|
grep -F "$error" output.err &&
|
|
|
|
|
git for-each-ref $prefix >actual &&
|
|
|
|
|
test_cmp unchanged actual
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Q="'"
|
|
|
|
|
|
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
|
|
|
|
|
|
git commit --allow-empty -m Initial &&
|
2016-05-05 13:22:23 +02:00
|
|
|
C=$(git rev-parse HEAD) &&
|
|
|
|
|
git commit --allow-empty -m Second &&
|
2016-06-07 12:29:02 +02:00
|
|
|
D=$(git rev-parse HEAD) &&
|
|
|
|
|
git commit --allow-empty -m Third &&
|
|
|
|
|
E=$(git rev-parse HEAD)
|
2015-05-11 17:25:03 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'existing loose ref is a simple prefix of new' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/1l &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c e" false "b c/x d" \
|
2015-05-11 17:25:16 +02:00
|
|
|
"$Q$prefix/c$Q exists; cannot create $Q$prefix/c/x$Q"
|
2015-05-11 17:25:03 +02:00
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'existing packed ref is a simple prefix of new' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/1p &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c e" true "b c/x d" \
|
2015-05-11 17:25:03 +02:00
|
|
|
"$Q$prefix/c$Q exists; cannot create $Q$prefix/c/x$Q"
|
|
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'existing loose ref is a deeper prefix of new' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/2l &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c e" false "b c/x/y d" \
|
2015-05-11 17:25:16 +02:00
|
|
|
"$Q$prefix/c$Q exists; cannot create $Q$prefix/c/x/y$Q"
|
2015-05-11 17:25:03 +02:00
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'existing packed ref is a deeper prefix of new' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/2p &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c e" true "b c/x/y d" \
|
2015-05-11 17:25:03 +02:00
|
|
|
"$Q$prefix/c$Q exists; cannot create $Q$prefix/c/x/y$Q"
|
|
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'new ref is a simple prefix of existing loose' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/3l &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c/x e" false "b c d" \
|
2015-05-11 17:25:16 +02:00
|
|
|
"$Q$prefix/c/x$Q exists; cannot create $Q$prefix/c$Q"
|
2015-05-11 17:25:03 +02:00
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'new ref is a simple prefix of existing packed' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/3p &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c/x e" true "b c d" \
|
2015-05-11 17:25:03 +02:00
|
|
|
"$Q$prefix/c/x$Q exists; cannot create $Q$prefix/c$Q"
|
|
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'new ref is a deeper prefix of existing loose' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/4l &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c/x/y e" false "b c d" \
|
2015-05-11 17:25:16 +02:00
|
|
|
"$Q$prefix/c/x/y$Q exists; cannot create $Q$prefix/c$Q"
|
2015-05-11 17:25:03 +02:00
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'new ref is a deeper prefix of existing packed' '
|
|
|
|
|
|
|
|
|
|
prefix=refs/4p &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a c/x/y e" true "b c d" \
|
2015-05-11 17:25:03 +02:00
|
|
|
"$Q$prefix/c/x/y$Q exists; cannot create $Q$prefix/c$Q"
|
|
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
refs: check for D/F conflicts among refs created in a transaction
If two references that D/F conflict (e.g., "refs/foo" and
"refs/foo/bar") are created in a single transaction, the old code
discovered the problem only after the "commit" phase of
ref_transaction_commit() had already begun. This could leave some
references updated and others not, which violates the promise of
atomicity.
Instead, check for such conflicts during the "locking" phase:
* Teach is_refname_available() to take an "extras" parameter that can
contain extra reference names with which the specified refname must
not conflict.
* Change lock_ref_sha1_basic() to take an "extras" parameter, which it
passes through to is_refname_available().
* Change ref_transaction_commit() to pass "affected_refnames" to
lock_ref_sha1_basic() as its "extras" argument.
This change fixes a test case in t1404.
This code is a bit stricter than it needs to be. We could conceivably
allow reference "refs/foo/bar" to be created in the same transaction
as "refs/foo" is deleted (or vice versa). But that would be
complicated to implement, because it is not possible to lock
"refs/foo/bar" while "refs/foo" exists as a loose reference, but on
the other hand we don't want to delete some references before adding
others (because that could leave a gap during which required objects
are unreachable). There is also a complication that reflog files'
paths can conflict.
Any less-strict implementation would probably require tricks like the
packing of all references before the start of the real transaction, or
the use of temporary intermediate reference names.
So for now let's accept too-strict checks. Some reference update
transactions will be rejected unnecessarily, but they will be rejected
in their entirety rather than leaving the repository in an
intermediate state, as would happen now.
Please note that there is still one kind of D/F conflict that is *not*
handled correctly. If two processes are running at the same time, and
one tries to create "refs/foo" at the same time that the other tries
to create "refs/foo/bar", then they can race with each other. Both
processes can obtain their respective locks ("refs/foo.lock" and
"refs/foo/bar.lock"), proceed to the "commit" phase of
ref_transaction_commit(), and then the slower process will discover
that it cannot rename its lockfile into place (after possibly having
committed changes to other references). There appears to be no way to
fix this race without changing the locking policy, which in turn would
require a change to *all* Git clients.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
2015-05-11 17:25:12 +02:00
|
|
|
test_expect_success 'one new ref is a simple prefix of another' '
|
2015-05-11 17:25:03 +02:00
|
|
|
|
|
|
|
|
prefix=refs/5 &&
|
2016-06-10 08:50:53 +02:00
|
|
|
test_update_rejected "a e" false "b c c/x d" \
|
2015-05-11 17:25:03 +02:00
|
|
|
"cannot process $Q$prefix/c$Q and $Q$prefix/c/x$Q at the same time"
|
|
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
2016-05-05 14:09:41 +02:00
|
|
|
test_expect_success 'empty directory should not fool rev-parse' '
|
2016-05-05 13:22:23 +02:00
|
|
|
prefix=refs/e-rev-parse &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
git pack-refs --all &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
echo "$C" >expected &&
|
|
|
|
|
git rev-parse $prefix/foo >actual &&
|
|
|
|
|
test_cmp expected actual
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty directory should not fool for-each-ref' '
|
|
|
|
|
prefix=refs/e-for-each-ref &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
git for-each-ref $prefix >expected &&
|
|
|
|
|
git pack-refs --all &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
git for-each-ref $prefix >actual &&
|
|
|
|
|
test_cmp expected actual
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty directory should not fool create' '
|
|
|
|
|
prefix=refs/e-create &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
printf "create %s $C\n" $prefix/foo |
|
|
|
|
|
git update-ref --stdin
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty directory should not fool verify' '
|
|
|
|
|
prefix=refs/e-verify &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
git pack-refs --all &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
printf "verify %s $C\n" $prefix/foo |
|
|
|
|
|
git update-ref --stdin
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty directory should not fool 1-arg update' '
|
|
|
|
|
prefix=refs/e-update-1 &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
git pack-refs --all &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
printf "update %s $D\n" $prefix/foo |
|
|
|
|
|
git update-ref --stdin
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty directory should not fool 2-arg update' '
|
|
|
|
|
prefix=refs/e-update-2 &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
git pack-refs --all &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
printf "update %s $D $C\n" $prefix/foo |
|
|
|
|
|
git update-ref --stdin
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty directory should not fool 0-arg delete' '
|
|
|
|
|
prefix=refs/e-delete-0 &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
git pack-refs --all &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
printf "delete %s\n" $prefix/foo |
|
|
|
|
|
git update-ref --stdin
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'empty directory should not fool 1-arg delete' '
|
|
|
|
|
prefix=refs/e-delete-1 &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
git pack-refs --all &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar/baz &&
|
|
|
|
|
printf "delete %s $C\n" $prefix/foo |
|
|
|
|
|
git update-ref --stdin
|
|
|
|
|
'
|
|
|
|
|
|
2016-06-07 12:29:02 +02:00
|
|
|
# Test various errors when reading the old values of references...
|
|
|
|
|
|
|
|
|
|
test_expect_success 'missing old value blocks update' '
|
|
|
|
|
prefix=refs/missing-update &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: unable to resolve reference $Q$prefix/foo$Q
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/foo $E $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'incorrect old value blocks update' '
|
|
|
|
|
prefix=refs/incorrect-update &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: is at $C but expected $D
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/foo $E $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'existing old value blocks create' '
|
|
|
|
|
prefix=refs/existing-create &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: reference already exists
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "create $prefix/foo $E" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'incorrect old value blocks delete' '
|
|
|
|
|
prefix=refs/incorrect-delete &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: is at $C but expected $D
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "delete $prefix/foo $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'missing old value blocks indirect update' '
|
|
|
|
|
prefix=refs/missing-indirect-update &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
cat >expected <<-EOF &&
|
2016-06-07 09:29:23 +02:00
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: unable to resolve reference $Q$prefix/foo$Q
|
2016-06-07 12:29:02 +02:00
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/symref $E $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'incorrect old value blocks indirect update' '
|
|
|
|
|
prefix=refs/incorrect-indirect-update &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: is at $C but expected $D
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/symref $E $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'existing old value blocks indirect create' '
|
|
|
|
|
prefix=refs/existing-indirect-create &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: reference already exists
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "create $prefix/symref $E" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'incorrect old value blocks indirect delete' '
|
|
|
|
|
prefix=refs/incorrect-indirect-delete &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: is at $C but expected $D
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "delete $prefix/symref $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'missing old value blocks indirect no-deref update' '
|
|
|
|
|
prefix=refs/missing-noderef-update &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
cat >expected <<-EOF &&
|
2016-06-07 09:29:23 +02:00
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: reference is missing but expected $D
|
2016-06-07 12:29:02 +02:00
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "option no-deref" "update $prefix/symref $E $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'incorrect old value blocks indirect no-deref update' '
|
|
|
|
|
prefix=refs/incorrect-noderef-update &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: is at $C but expected $D
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "option no-deref" "update $prefix/symref $E $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
2016-06-07 09:29:23 +02:00
|
|
|
test_expect_success 'existing old value blocks indirect no-deref create' '
|
2016-06-07 12:29:02 +02:00
|
|
|
prefix=refs/existing-noderef-create &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: reference already exists
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "option no-deref" "create $prefix/symref $E" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'incorrect old value blocks indirect no-deref delete' '
|
|
|
|
|
prefix=refs/incorrect-noderef-delete &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
git update-ref $prefix/foo $C &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: is at $C but expected $D
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "option no-deref" "delete $prefix/symref $D" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'non-empty directory blocks create' '
|
|
|
|
|
prefix=refs/ne-create &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar &&
|
|
|
|
|
: >.git/$prefix/foo/bar/baz.lock &&
|
|
|
|
|
test_when_finished "rm -f .git/$prefix/foo/bar/baz.lock" &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: there is a non-empty directory $Q.git/$prefix/foo$Q blocking reference $Q$prefix/foo$Q
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/foo $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: unable to resolve reference $Q$prefix/foo$Q
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/foo $D $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'broken reference blocks create' '
|
|
|
|
|
prefix=refs/broken-create &&
|
|
|
|
|
mkdir -p .git/$prefix &&
|
|
|
|
|
echo "gobbledigook" >.git/$prefix/foo &&
|
|
|
|
|
test_when_finished "rm -f .git/$prefix/foo" &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: unable to resolve reference $Q$prefix/foo$Q: reference broken
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/foo $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err &&
|
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
|
fatal: cannot lock ref $Q$prefix/foo$Q: unable to resolve reference $Q$prefix/foo$Q: reference broken
|
|
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/foo $D $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'non-empty directory blocks indirect create' '
|
|
|
|
|
prefix=refs/ne-indirect-create &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
mkdir -p .git/$prefix/foo/bar &&
|
|
|
|
|
: >.git/$prefix/foo/bar/baz.lock &&
|
|
|
|
|
test_when_finished "rm -f .git/$prefix/foo/bar/baz.lock" &&
|
|
|
|
|
cat >expected <<-EOF &&
|
2016-06-07 09:29:23 +02:00
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: there is a non-empty directory $Q.git/$prefix/foo$Q blocking reference $Q$prefix/foo$Q
|
2016-06-07 12:29:02 +02:00
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/symref $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err &&
|
|
|
|
|
cat >expected <<-EOF &&
|
2016-06-07 09:29:23 +02:00
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: unable to resolve reference $Q$prefix/foo$Q
|
2016-06-07 12:29:02 +02:00
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/symref $D $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'broken reference blocks indirect create' '
|
|
|
|
|
prefix=refs/broken-indirect-create &&
|
|
|
|
|
git symbolic-ref $prefix/symref $prefix/foo &&
|
|
|
|
|
echo "gobbledigook" >.git/$prefix/foo &&
|
|
|
|
|
test_when_finished "rm -f .git/$prefix/foo" &&
|
|
|
|
|
cat >expected <<-EOF &&
|
2016-06-07 09:29:23 +02:00
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: unable to resolve reference $Q$prefix/foo$Q: reference broken
|
2016-06-07 12:29:02 +02:00
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/symref $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err &&
|
|
|
|
|
cat >expected <<-EOF &&
|
2016-06-07 09:29:23 +02:00
|
|
|
fatal: cannot lock ref $Q$prefix/symref$Q: unable to resolve reference $Q$prefix/foo$Q: reference broken
|
2016-06-07 12:29:02 +02:00
|
|
|
EOF
|
|
|
|
|
printf "%s\n" "update $prefix/symref $D $C" |
|
|
|
|
|
test_must_fail git update-ref --stdin 2>output.err &&
|
|
|
|
|
test_cmp expected output.err
|
|
|
|
|
'
|
|
|
|
|
|
2015-05-11 17:25:03 +02:00
|
|
|
test_done
|