2011-08-23 04:20:33 +02:00
|
|
|
#
|
2012-04-09 02:18:02 +02:00
|
|
|
# Library code for git p4 tests
|
2011-08-23 04:20:33 +02:00
|
|
|
#
|
|
|
|
|
2012-06-27 14:00:57 +02:00
|
|
|
# p4 tests never use the top-level repo; always build/clone into
|
|
|
|
# a subdirectory called "$git"
|
|
|
|
TEST_NO_CREATE_REPO=NoThanks
|
|
|
|
|
2015-11-19 09:58:08 +01:00
|
|
|
# Some operations require multiple attempts to be successful. Define
|
|
|
|
# here the maximal retry timeout in seconds.
|
|
|
|
RETRY_TIMEOUT=60
|
|
|
|
|
2015-11-19 09:58:09 +01:00
|
|
|
# Sometimes p4d seems to hang. Terminate the p4d process automatically after
|
|
|
|
# the defined timeout in seconds.
|
|
|
|
P4D_TIMEOUT=300
|
|
|
|
|
2011-08-23 04:20:33 +02:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
2013-01-27 04:11:11 +01:00
|
|
|
if ! test_have_prereq PYTHON
|
|
|
|
then
|
2012-04-09 02:18:02 +02:00
|
|
|
skip_all='skipping git p4 tests; python not available'
|
2011-08-23 04:20:33 +02:00
|
|
|
test_done
|
|
|
|
fi
|
|
|
|
( p4 -h && p4d -h ) >/dev/null 2>&1 || {
|
2012-04-09 02:18:02 +02:00
|
|
|
skip_all='skipping git p4 tests; no p4 or p4d'
|
2011-08-23 04:20:33 +02:00
|
|
|
test_done
|
|
|
|
}
|
|
|
|
|
2013-01-27 04:11:11 +01:00
|
|
|
# On cygwin, the NT version of Perforce can be used. When giving
|
|
|
|
# it paths, either on the command-line or in client specifications,
|
|
|
|
# be sure to use the native windows form.
|
|
|
|
#
|
|
|
|
# Older versions of perforce were available compiled natively for
|
|
|
|
# cygwin. Those do not accept native windows paths, so make sure
|
|
|
|
# not to convert for them.
|
2016-04-19 21:49:41 +02:00
|
|
|
native_path () {
|
2013-01-27 04:11:11 +01:00
|
|
|
path="$1" &&
|
|
|
|
if test_have_prereq CYGWIN && ! p4 -V | grep -q CYGWIN
|
|
|
|
then
|
|
|
|
path=$(cygpath --windows "$path")
|
|
|
|
else
|
2018-03-24 08:44:49 +01:00
|
|
|
path=$(test-tool path-utils real_path "$path")
|
2013-01-27 04:11:11 +01:00
|
|
|
fi &&
|
|
|
|
echo "$path"
|
|
|
|
}
|
|
|
|
|
2015-11-19 09:58:08 +01:00
|
|
|
# On Solaris the 'date +%s' function is not supported and therefore we
|
|
|
|
# need this replacement.
|
|
|
|
# Attention: This function is not safe again against time offset updates
|
|
|
|
# at runtime (e.g. via NTP). The 'clock_gettime(CLOCK_MONOTONIC)'
|
|
|
|
# function could fix that but it is not in Python until 3.3.
|
2016-04-19 21:49:41 +02:00
|
|
|
time_in_seconds () {
|
2016-04-26 09:51:01 +02:00
|
|
|
(cd / && "$PYTHON_PATH" -c 'import time; print(int(time.time()))')
|
2015-11-19 09:58:08 +01:00
|
|
|
}
|
|
|
|
|
test-lib-functions: introduce the 'test_set_port' helper function
Several test scripts run daemons like 'git-daemon' or Apache, and
communicate with them through TCP sockets. To have unique ports where
these daemons are accessible, the ports are usually the number of the
corresponding test scripts, unless the user overrides them via
environment variables, and thus all those tests and test libs contain
more or less the same bit of one-liner boilerplate code to find out
the port. The last patch in this series will make this a bit more
complicated.
Factor out finding the port for a daemon into the common helper
function 'test_set_port' to avoid repeating ourselves.
Take special care of test scripts with "low" numbers:
- Test numbers below 1024 would result in a port that's only usable
as root, so set their port to '10000 + test-nr' to make sure it
doesn't interfere with other tests in the test suite. This makes
the hardcoded port number in 't0410-partial-clone.sh' unnecessary,
remove it.
- The shell's arithmetic evaluation interprets numbers with leading
zeros as octal values, which means that test number below 1000 and
containing the digits 8 or 9 will trigger an error. Remove all
leading zeros from the test numbers to prevent this.
Note that the 'git p4' tests are unlike the other tests involving
daemons in that:
- 'lib-git-p4.sh' doesn't use the test's number for unique port as
is, but does a bit of additional arithmetic on top [1].
- The port is not overridable via an environment variable.
With this patch even 'git p4' tests will use the test's number as
default port, and it will be overridable via the P4DPORT environment
variable.
[1] Commit fc00233071 (git-p4 tests: refactor and cleanup, 2011-08-22)
introduced that "unusual" unique port computation without
explaining why it was necessary (as opposed to simply using the
test number as is). It seems to be just unnecessary complication,
and in any case that commit came way before the "test nr as unique
port" got "standardized" for other daemons in commits c44132fcf3
(tests: auto-set git-daemon port, 2014-02-10), 3bb486e439 (tests:
auto-set LIB_HTTPD_PORT from test name, 2014-02-10), and
bf9d7df950 (t/lib-git-svn.sh: improve svnserve tests with parallel
make test, 2017-12-01).
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-01-05 02:08:58 +01:00
|
|
|
test_set_port P4DPORT
|
2011-08-23 04:20:33 +02:00
|
|
|
|
2012-09-09 22:16:02 +02:00
|
|
|
P4PORT=localhost:$P4DPORT
|
|
|
|
P4CLIENT=client
|
2014-01-22 00:16:43 +01:00
|
|
|
P4USER=author
|
git p4 test: do not pollute /tmp
Generating the submit template for p4 uses tempfile.mkstemp(),
which by default puts files in /tmp. For a test that fails,
possibly on purpose, this is not cleaned up. Run with TMPDIR
pointing into the trash directory so the temp files go away
with the test results.
To do this required some other minor changes. First, the editor
is launched using system(editor + " " + template_file), using
shell expansion to build the command string. This doesn't work
if editor has a space in it. And is generally unwise as it's
easy to fool the shell into doing extra work. Exec the args
directly, without shell expansion.
Second, without shell expansion, the trick of "P4EDITOR=:" used
in the tests doesn't work. Use a real command, true, as the
non-interactive editor for testing.
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2014-01-22 00:16:44 +01:00
|
|
|
P4EDITOR=true
|
2013-08-10 22:15:12 +02:00
|
|
|
unset P4CHARSET
|
2014-01-22 00:16:43 +01:00
|
|
|
export P4PORT P4CLIENT P4USER P4EDITOR P4CHARSET
|
2011-08-23 04:20:33 +02:00
|
|
|
|
|
|
|
db="$TRASH_DIRECTORY/db"
|
2013-01-27 04:11:11 +01:00
|
|
|
cli="$TRASH_DIRECTORY/cli"
|
2011-08-23 04:20:33 +02:00
|
|
|
git="$TRASH_DIRECTORY/git"
|
|
|
|
pidfile="$TRASH_DIRECTORY/p4d.pid"
|
|
|
|
|
2015-11-19 09:58:10 +01:00
|
|
|
# Sometimes "prove" seems to hang on exit because p4d is still running
|
2016-04-19 21:49:41 +02:00
|
|
|
cleanup () {
|
2015-11-19 09:58:10 +01:00
|
|
|
if test -f "$pidfile"
|
|
|
|
then
|
|
|
|
kill -9 $(cat "$pidfile") 2>/dev/null && exit 255
|
|
|
|
fi
|
|
|
|
}
|
|
|
|
trap cleanup EXIT
|
|
|
|
|
git p4 test: do not pollute /tmp
Generating the submit template for p4 uses tempfile.mkstemp(),
which by default puts files in /tmp. For a test that fails,
possibly on purpose, this is not cleaned up. Run with TMPDIR
pointing into the trash directory so the temp files go away
with the test results.
To do this required some other minor changes. First, the editor
is launched using system(editor + " " + template_file), using
shell expansion to build the command string. This doesn't work
if editor has a space in it. And is generally unwise as it's
easy to fool the shell into doing extra work. Exec the args
directly, without shell expansion.
Second, without shell expansion, the trick of "P4EDITOR=:" used
in the tests doesn't work. Use a real command, true, as the
non-interactive editor for testing.
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2014-01-22 00:16:44 +01:00
|
|
|
# git p4 submit generates a temp file, which will
|
|
|
|
# not get cleaned up if the submission fails. Don't
|
|
|
|
# clutter up /tmp on the test machine.
|
|
|
|
TMPDIR="$TRASH_DIRECTORY"
|
|
|
|
export TMPDIR
|
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
start_p4d () {
|
2011-08-23 04:20:33 +02:00
|
|
|
mkdir -p "$db" "$cli" "$git" &&
|
2012-06-28 04:48:07 +02:00
|
|
|
rm -f "$pidfile" &&
|
2011-08-23 04:20:33 +02:00
|
|
|
(
|
2013-01-27 04:11:10 +01:00
|
|
|
cd "$db" &&
|
|
|
|
{
|
2015-04-28 11:08:01 +02:00
|
|
|
p4d -q -p $P4DPORT "$@" &
|
2013-01-27 04:11:10 +01:00
|
|
|
echo $! >"$pidfile"
|
|
|
|
}
|
2011-08-23 04:20:33 +02:00
|
|
|
) &&
|
2012-06-28 04:48:07 +02:00
|
|
|
|
|
|
|
# This gives p4d a long time to start up, as it can be
|
|
|
|
# quite slow depending on the machine. Set this environment
|
|
|
|
# variable to something smaller to fail faster in, say,
|
|
|
|
# an automated test setup. If the p4d process dies, that
|
|
|
|
# will be caught with the "kill -0" check below.
|
|
|
|
i=${P4D_START_PATIENCE:-300}
|
|
|
|
pid=$(cat "$pidfile")
|
2015-11-19 09:58:09 +01:00
|
|
|
|
|
|
|
timeout=$(($(time_in_seconds) + $P4D_TIMEOUT))
|
|
|
|
while true
|
|
|
|
do
|
|
|
|
if test $(time_in_seconds) -gt $timeout
|
|
|
|
then
|
|
|
|
kill -9 $pid
|
|
|
|
exit 1
|
|
|
|
fi
|
|
|
|
sleep 1
|
|
|
|
done &
|
|
|
|
watchdog_pid=$!
|
|
|
|
|
2012-06-28 04:48:07 +02:00
|
|
|
ready=
|
|
|
|
while test $i -gt 0
|
|
|
|
do
|
|
|
|
# succeed when p4 client commands start to work
|
|
|
|
if p4 info >/dev/null 2>&1
|
|
|
|
then
|
|
|
|
ready=true
|
|
|
|
break
|
|
|
|
fi
|
|
|
|
# fail if p4d died
|
|
|
|
kill -0 $pid 2>/dev/null || break
|
|
|
|
echo waiting for p4d to start
|
2011-08-23 04:20:33 +02:00
|
|
|
sleep 1
|
2012-06-28 04:48:07 +02:00
|
|
|
i=$(( $i - 1 ))
|
|
|
|
done
|
|
|
|
|
|
|
|
if test -z "$ready"
|
|
|
|
then
|
|
|
|
# p4d failed to start
|
|
|
|
return 1
|
|
|
|
fi
|
|
|
|
|
2014-01-22 00:16:43 +01:00
|
|
|
# build a p4 user so author@example.com has an entry
|
|
|
|
p4_add_user author
|
|
|
|
|
2012-06-28 04:48:07 +02:00
|
|
|
# build a client
|
2013-01-27 04:11:07 +01:00
|
|
|
client_view "//depot/... //client/..." &&
|
|
|
|
|
2012-06-28 04:48:07 +02:00
|
|
|
return 0
|
2011-08-23 04:20:33 +02:00
|
|
|
}
|
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
p4_add_user () {
|
2014-01-22 00:16:43 +01:00
|
|
|
name=$1 &&
|
|
|
|
p4 user -f -i <<-EOF
|
|
|
|
User: $name
|
|
|
|
Email: $name@example.com
|
|
|
|
FullName: Dr. $name
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
p4_add_job () {
|
|
|
|
p4 job -f -i <<-EOF
|
|
|
|
Job: $1
|
|
|
|
Status: open
|
|
|
|
User: dummy
|
|
|
|
Description:
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
retry_until_success () {
|
2015-11-19 09:58:08 +01:00
|
|
|
timeout=$(($(time_in_seconds) + $RETRY_TIMEOUT))
|
|
|
|
until "$@" 2>/dev/null || test $(time_in_seconds) -gt $timeout
|
|
|
|
do
|
|
|
|
sleep 1
|
|
|
|
done
|
|
|
|
}
|
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
retry_until_fail () {
|
2015-11-19 09:58:08 +01:00
|
|
|
timeout=$(($(time_in_seconds) + $RETRY_TIMEOUT))
|
|
|
|
until ! "$@" 2>/dev/null || test $(time_in_seconds) -gt $timeout
|
|
|
|
do
|
|
|
|
sleep 1
|
|
|
|
done
|
|
|
|
}
|
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
kill_p4d () {
|
2011-08-23 04:20:33 +02:00
|
|
|
pid=$(cat "$pidfile")
|
2015-11-19 09:58:08 +01:00
|
|
|
retry_until_fail kill $pid
|
|
|
|
retry_until_fail kill -9 $pid
|
2011-08-23 04:20:33 +02:00
|
|
|
# complain if it would not die
|
|
|
|
test_must_fail kill $pid >/dev/null 2>&1 &&
|
2015-11-19 09:58:09 +01:00
|
|
|
rm -rf "$db" "$cli" "$pidfile" &&
|
|
|
|
retry_until_fail kill -9 $watchdog_pid
|
2011-08-23 04:20:33 +02:00
|
|
|
}
|
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
cleanup_git () {
|
2015-11-19 09:58:08 +01:00
|
|
|
retry_until_success rm -r "$git"
|
|
|
|
test_must_fail test -d "$git" &&
|
|
|
|
retry_until_success mkdir "$git"
|
2011-08-23 04:20:33 +02:00
|
|
|
}
|
2012-07-04 15:34:19 +02:00
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
marshal_dump () {
|
2012-07-04 15:34:19 +02:00
|
|
|
what=$1 &&
|
|
|
|
line=${2:-1} &&
|
|
|
|
cat >"$TRASH_DIRECTORY/marshal-dump.py" <<-EOF &&
|
|
|
|
import marshal
|
|
|
|
import sys
|
2016-04-26 09:51:00 +02:00
|
|
|
instream = getattr(sys.stdin, 'buffer', sys.stdin)
|
2012-07-04 15:34:19 +02:00
|
|
|
for i in range($line):
|
2016-04-26 09:51:00 +02:00
|
|
|
d = marshal.load(instream)
|
|
|
|
print(d[b'$what'].decode('utf-8'))
|
2012-07-04 15:34:19 +02:00
|
|
|
EOF
|
|
|
|
"$PYTHON_PATH" "$TRASH_DIRECTORY/marshal-dump.py"
|
|
|
|
}
|
2012-08-11 18:55:00 +02:00
|
|
|
|
|
|
|
#
|
|
|
|
# Construct a client with this list of View lines
|
|
|
|
#
|
2016-04-19 21:49:41 +02:00
|
|
|
client_view () {
|
2012-08-11 18:55:00 +02:00
|
|
|
(
|
|
|
|
cat <<-EOF &&
|
2013-01-27 04:11:09 +01:00
|
|
|
Client: $P4CLIENT
|
|
|
|
Description: $P4CLIENT
|
2012-08-11 18:55:00 +02:00
|
|
|
Root: $cli
|
2013-01-27 04:11:11 +01:00
|
|
|
AltRoots: $(native_path "$cli")
|
2013-01-27 04:11:15 +01:00
|
|
|
LineEnd: unix
|
2012-08-11 18:55:00 +02:00
|
|
|
View:
|
|
|
|
EOF
|
2013-01-27 04:11:08 +01:00
|
|
|
printf "\t%s\n" "$@"
|
2012-08-11 18:55:00 +02:00
|
|
|
) | p4 client -i
|
|
|
|
}
|
git p4: cygwin p4 client does not mark read-only
There are some old versions of p4, compiled for cygwin, that
treat read-only files differently.
Normally, a file that is not open is read-only, meaning that
"test -w" on the file is false. This works on unix, and it works
on windows using the NT version of p4. The cygwin version
of p4, though, changes the permissions, but does not set the
windows read-only attribute, so "test -w" returns false.
Notice this oddity and make the tests work, even on cygiwn.
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-01-27 04:11:17 +01:00
|
|
|
|
2016-04-19 21:49:41 +02:00
|
|
|
is_cli_file_writeable () {
|
git p4: cygwin p4 client does not mark read-only
There are some old versions of p4, compiled for cygwin, that
treat read-only files differently.
Normally, a file that is not open is read-only, meaning that
"test -w" on the file is false. This works on unix, and it works
on windows using the NT version of p4. The cygwin version
of p4, though, changes the permissions, but does not set the
windows read-only attribute, so "test -w" returns false.
Notice this oddity and make the tests work, even on cygiwn.
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-01-27 04:11:17 +01:00
|
|
|
# cygwin version of p4 does not set read-only attr,
|
|
|
|
# will be marked 444 but -w is true
|
|
|
|
file="$1" &&
|
|
|
|
if test_have_prereq CYGWIN && p4 -V | grep -q CYGWIN
|
|
|
|
then
|
|
|
|
stat=$(stat --format=%a "$file") &&
|
|
|
|
test $stat = 644
|
|
|
|
else
|
|
|
|
test -w "$file"
|
|
|
|
fi
|
|
|
|
}
|