2013-12-19 01:08:10 +01:00
|
|
|
#!/bin/sh
|
|
|
|
|
diff: --{rotate,skip}-to=<path>
In the implementation of "git difftool", there is a case where the
user wants to start viewing the diffs at a specific path and
continue on to the rest, optionally wrapping around to the
beginning. Since it is somewhat cumbersome to implement such a
feature as a post-processing step of "git diff" output, let's
support it internally with two new options.
- "git diff --rotate-to=C", when the resulting patch would show
paths A B C D E without the option, would "rotate" the paths to
shows patch to C D E A B instead. It is an error when there is
no patch for C is shown.
- "git diff --skip-to=C" would instead "skip" the paths before C,
and shows patch to C D E. Again, it is an error when there is no
patch for C is shown.
- "git log [-p]" also accepts these two options, but it is not an
error if there is no change to the specified path. Instead, the
set of output paths are rotated or skipped to the specified path
or the first path that sorts after the specified path.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-02-11 20:57:50 +01:00
|
|
|
test_description='diff order & rotate'
|
2013-12-19 01:08:10 +01:00
|
|
|
|
2020-11-19 00:44:27 +01:00
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
tests: mark tests relying on the current default for `init.defaultBranch`
In addition to the manual adjustment to let the `linux-gcc` CI job run
the test suite with `master` and then with `main`, this patch makes sure
that GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME is set in all test scripts
that currently rely on the initial branch name being `master by default.
To determine which test scripts to mark up, the first step was to
force-set the default branch name to `master` in
- all test scripts that contain the keyword `master`,
- t4211, which expects `t/t4211/history.export` with a hard-coded ref to
initialize the default branch,
- t5560 because it sources `t/t556x_common` which uses `master`,
- t8002 and t8012 because both source `t/annotate-tests.sh` which also
uses `master`)
This trick was performed by this command:
$ sed -i '/^ *\. \.\/\(test-lib\|lib-\(bash\|cvs\|git-svn\)\|gitweb-lib\)\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' $(git grep -l master t/t[0-9]*.sh) \
t/t4211*.sh t/t5560*.sh t/t8002*.sh t/t8012*.sh
After that, careful, manual inspection revealed that some of the test
scripts containing the needle `master` do not actually rely on a
specific default branch name: either they mention `master` only in a
comment, or they initialize that branch specificially, or they do not
actually refer to the current default branch. Therefore, the
aforementioned modification was undone in those test scripts thusly:
$ git checkout HEAD -- \
t/t0027-auto-crlf.sh t/t0060-path-utils.sh \
t/t1011-read-tree-sparse-checkout.sh \
t/t1305-config-include.sh t/t1309-early-config.sh \
t/t1402-check-ref-format.sh t/t1450-fsck.sh \
t/t2024-checkout-dwim.sh \
t/t2106-update-index-assume-unchanged.sh \
t/t3040-subprojects-basic.sh t/t3301-notes.sh \
t/t3308-notes-merge.sh t/t3423-rebase-reword.sh \
t/t3436-rebase-more-options.sh \
t/t4015-diff-whitespace.sh t/t4257-am-interactive.sh \
t/t5323-pack-redundant.sh t/t5401-update-hooks.sh \
t/t5511-refspec.sh t/t5526-fetch-submodules.sh \
t/t5529-push-errors.sh t/t5530-upload-pack-error.sh \
t/t5548-push-porcelain.sh \
t/t5552-skipping-fetch-negotiator.sh \
t/t5572-pull-submodule.sh t/t5608-clone-2gb.sh \
t/t5614-clone-submodules-shallow.sh \
t/t7508-status.sh t/t7606-merge-custom.sh \
t/t9302-fast-import-unpack-limit.sh
We excluded one set of test scripts in these commands, though: the range
of `git p4` tests. The reason? `git p4` stores the (foreign) remote
branch in the branch called `p4/master`, which is obviously not the
default branch. Manual analysis revealed that only five of these tests
actually require a specific default branch name to pass; They were
modified thusly:
$ sed -i '/^ *\. \.\/lib-git-p4\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' t/t980[0167]*.sh t/t9811*.sh
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-11-19 00:44:19 +01:00
|
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
|
2013-12-19 01:08:10 +01:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
create_files () {
|
|
|
|
echo "$1" >a.h &&
|
|
|
|
echo "$1" >b.c &&
|
|
|
|
echo "$1" >c/Makefile &&
|
|
|
|
echo "$1" >d.txt &&
|
|
|
|
git add a.h b.c c/Makefile d.txt &&
|
|
|
|
git commit -m"$1"
|
|
|
|
}
|
|
|
|
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
mkdir c &&
|
|
|
|
create_files 1 &&
|
|
|
|
create_files 2 &&
|
|
|
|
|
|
|
|
cat >order_file_1 <<-\EOF &&
|
|
|
|
*Makefile
|
|
|
|
*.txt
|
|
|
|
*.h
|
|
|
|
EOF
|
|
|
|
|
|
|
|
cat >order_file_2 <<-\EOF &&
|
|
|
|
*Makefile
|
|
|
|
*.h
|
|
|
|
*.c
|
|
|
|
EOF
|
|
|
|
|
|
|
|
cat >expect_none <<-\EOF &&
|
|
|
|
a.h
|
|
|
|
b.c
|
|
|
|
c/Makefile
|
|
|
|
d.txt
|
|
|
|
EOF
|
|
|
|
|
|
|
|
cat >expect_1 <<-\EOF &&
|
|
|
|
c/Makefile
|
|
|
|
d.txt
|
|
|
|
a.h
|
|
|
|
b.c
|
|
|
|
EOF
|
|
|
|
|
|
|
|
cat >expect_2 <<-\EOF
|
|
|
|
c/Makefile
|
|
|
|
a.h
|
|
|
|
b.c
|
|
|
|
d.txt
|
|
|
|
EOF
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success "no order (=tree object order)" '
|
|
|
|
git diff --name-only HEAD^..HEAD >actual &&
|
|
|
|
test_cmp expect_none actual
|
|
|
|
'
|
|
|
|
|
diff: let "git diff -O" read orderfile from any file and fail properly
The -O flag really shouldn't silently fail to do anything when given
a path that it can't read from.
However, it should be able to read from un-mmappable files, such as:
* pipes/fifos
* /dev/null: It's a character device (at least on Linux)
* ANY empty file:
Quoting Linux mmap(2), "SUSv3 specifies that mmap() should fail if
length is 0. However, in kernels before 2.6.12, mmap() succeeded in
this case: no mapping was created and the call returned addr. Since
kernel 2.6.12, mmap() fails with the error EINVAL for this case."
We especially want "-O/dev/null" to work, since we will be documenting
it as the way to cancel "diff.orderfile" when we add that.
(Note: "-O/dev/null" did have the right effect, since the existing error
handling essentially worked out to "silently ignore the orderfile". But
this was probably more coincidence than anything else.)
So, lets toss all of that logic to get the file mmapped and just use
strbuf_read_file() instead, which gives us decent error handling
practically for free.
Signed-off-by: Samuel Bronson <naesten@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-12-19 01:08:11 +01:00
|
|
|
test_expect_success 'missing orderfile' '
|
|
|
|
rm -f bogus_file &&
|
|
|
|
test_must_fail git diff -Obogus_file --name-only HEAD^..HEAD
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success POSIXPERM,SANITY 'unreadable orderfile' '
|
|
|
|
>unreadable_file &&
|
|
|
|
chmod -r unreadable_file &&
|
|
|
|
test_must_fail git diff -Ounreadable_file --name-only HEAD^..HEAD
|
|
|
|
'
|
|
|
|
|
2016-01-21 12:48:44 +01:00
|
|
|
test_expect_success "orderfile using option from subdir with --output" '
|
|
|
|
mkdir subdir &&
|
|
|
|
git -C subdir diff -O../order_file_1 --output ../actual --name-only HEAD^..HEAD &&
|
|
|
|
test_cmp expect_1 actual
|
|
|
|
'
|
|
|
|
|
2013-12-19 01:08:10 +01:00
|
|
|
for i in 1 2
|
|
|
|
do
|
|
|
|
test_expect_success "orderfile using option ($i)" '
|
|
|
|
git diff -Oorder_file_$i --name-only HEAD^..HEAD >actual &&
|
|
|
|
test_cmp expect_$i actual
|
|
|
|
'
|
diff: let "git diff -O" read orderfile from any file and fail properly
The -O flag really shouldn't silently fail to do anything when given
a path that it can't read from.
However, it should be able to read from un-mmappable files, such as:
* pipes/fifos
* /dev/null: It's a character device (at least on Linux)
* ANY empty file:
Quoting Linux mmap(2), "SUSv3 specifies that mmap() should fail if
length is 0. However, in kernels before 2.6.12, mmap() succeeded in
this case: no mapping was created and the call returned addr. Since
kernel 2.6.12, mmap() fails with the error EINVAL for this case."
We especially want "-O/dev/null" to work, since we will be documenting
it as the way to cancel "diff.orderfile" when we add that.
(Note: "-O/dev/null" did have the right effect, since the existing error
handling essentially worked out to "silently ignore the orderfile". But
this was probably more coincidence than anything else.)
So, lets toss all of that logic to get the file mmapped and just use
strbuf_read_file() instead, which gives us decent error handling
practically for free.
Signed-off-by: Samuel Bronson <naesten@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-12-19 01:08:11 +01:00
|
|
|
|
|
|
|
test_expect_success PIPE "orderfile is fifo ($i)" '
|
|
|
|
rm -f order_fifo &&
|
|
|
|
mkfifo order_fifo &&
|
|
|
|
{
|
|
|
|
cat order_file_$i >order_fifo &
|
|
|
|
} &&
|
|
|
|
git diff -O order_fifo --name-only HEAD^..HEAD >actual &&
|
|
|
|
wait &&
|
|
|
|
test_cmp expect_$i actual
|
|
|
|
'
|
2013-12-19 01:08:12 +01:00
|
|
|
|
|
|
|
test_expect_success "orderfile using config ($i)" '
|
|
|
|
git -c diff.orderfile=order_file_$i diff --name-only HEAD^..HEAD >actual &&
|
|
|
|
test_cmp expect_$i actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success "cancelling configured orderfile ($i)" '
|
|
|
|
git -c diff.orderfile=order_file_$i diff -O/dev/null --name-only HEAD^..HEAD >actual &&
|
|
|
|
test_cmp expect_none actual
|
|
|
|
'
|
2013-12-19 01:08:10 +01:00
|
|
|
done
|
|
|
|
|
2014-01-20 17:20:39 +01:00
|
|
|
test_expect_success 'setup for testing combine-diff order' '
|
|
|
|
git checkout -b tmp HEAD~ &&
|
|
|
|
create_files 3 &&
|
2020-11-19 00:44:27 +01:00
|
|
|
git checkout main &&
|
2014-01-20 17:20:39 +01:00
|
|
|
git merge --no-commit -s ours tmp &&
|
|
|
|
create_files 5
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success "combine-diff: no order (=tree object order)" '
|
|
|
|
git diff --name-only HEAD HEAD^ HEAD^2 >actual &&
|
|
|
|
test_cmp expect_none actual
|
|
|
|
'
|
|
|
|
|
|
|
|
for i in 1 2
|
|
|
|
do
|
|
|
|
test_expect_success "combine-diff: orderfile using option ($i)" '
|
|
|
|
git diff -Oorder_file_$i --name-only HEAD HEAD^ HEAD^2 >actual &&
|
|
|
|
test_cmp expect_$i actual
|
|
|
|
'
|
|
|
|
done
|
|
|
|
|
diff: --{rotate,skip}-to=<path>
In the implementation of "git difftool", there is a case where the
user wants to start viewing the diffs at a specific path and
continue on to the rest, optionally wrapping around to the
beginning. Since it is somewhat cumbersome to implement such a
feature as a post-processing step of "git diff" output, let's
support it internally with two new options.
- "git diff --rotate-to=C", when the resulting patch would show
paths A B C D E without the option, would "rotate" the paths to
shows patch to C D E A B instead. It is an error when there is
no patch for C is shown.
- "git diff --skip-to=C" would instead "skip" the paths before C,
and shows patch to C D E. Again, it is an error when there is no
patch for C is shown.
- "git log [-p]" also accepts these two options, but it is not an
error if there is no change to the specified path. Instead, the
set of output paths are rotated or skipped to the specified path
or the first path that sorts after the specified path.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-02-11 20:57:50 +01:00
|
|
|
### rotate and skip
|
|
|
|
|
|
|
|
test_expect_success 'rotate and skip setup' '
|
|
|
|
>sample1.t &&
|
|
|
|
>sample2.t &&
|
|
|
|
>sample3.t &&
|
|
|
|
>sample4.t &&
|
|
|
|
git add sample[1234].t &&
|
|
|
|
git commit -m "added" sample[1234].t &&
|
|
|
|
echo modified >>sample1.t &&
|
|
|
|
echo modified >>sample2.t &&
|
|
|
|
echo modified >>sample4.t &&
|
|
|
|
git commit -m "updated" sample[1234].t
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'diff --rotate-to' '
|
|
|
|
git diff --rotate-to=sample2.t --name-only HEAD^ >actual &&
|
|
|
|
test_write_lines sample2.t sample4.t sample1.t >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'diff --skip-to' '
|
|
|
|
git diff --skip-to=sample2.t --name-only HEAD^ >actual &&
|
|
|
|
test_write_lines sample2.t sample4.t >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'diff --rotate/skip-to error condition' '
|
|
|
|
test_must_fail git diff --rotate-to=sample3.t HEAD^ &&
|
|
|
|
test_must_fail git diff --skip-to=sample3.t HEAD^
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'log --rotate-to' '
|
|
|
|
git log --rotate-to=sample3.t --raw HEAD~2.. >raw &&
|
|
|
|
# just distill the commit header and paths
|
|
|
|
sed -n -e "s/^commit.*/commit/p" \
|
|
|
|
-e "/^:/s/^.* //p" raw >actual &&
|
|
|
|
|
|
|
|
cat >expect <<-\EOF &&
|
|
|
|
commit
|
|
|
|
sample4.t
|
|
|
|
sample1.t
|
|
|
|
sample2.t
|
|
|
|
commit
|
|
|
|
sample3.t
|
|
|
|
sample4.t
|
|
|
|
sample1.t
|
|
|
|
sample2.t
|
|
|
|
EOF
|
|
|
|
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'log --skip-to' '
|
|
|
|
git log --skip-to=sample3.t --raw HEAD~2.. >raw &&
|
|
|
|
# just distill the commit header and paths
|
|
|
|
sed -n -e "s/^commit.*/commit/p" \
|
|
|
|
-e "/^:/s/^.* //p" raw >actual &&
|
|
|
|
|
|
|
|
cat >expect <<-\EOF &&
|
|
|
|
commit
|
|
|
|
sample4.t
|
|
|
|
commit
|
|
|
|
sample3.t
|
|
|
|
sample4.t
|
|
|
|
EOF
|
|
|
|
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
2013-12-19 01:08:10 +01:00
|
|
|
test_done
|