2017-11-21 21:58:50 +01:00
|
|
|
#include "cache.h"
|
|
|
|
#include "commit.h"
|
|
|
|
#include "config.h"
|
|
|
|
#include "revision.h"
|
|
|
|
#include "argv-array.h"
|
|
|
|
#include "list-objects.h"
|
|
|
|
#include "list-objects-filter.h"
|
|
|
|
#include "list-objects-filter-options.h"
|
2019-06-25 15:40:31 +02:00
|
|
|
#include "promisor-remote.h"
|
2019-06-28 00:54:12 +02:00
|
|
|
#include "trace.h"
|
2019-06-28 00:54:08 +02:00
|
|
|
#include "url.h"
|
|
|
|
|
|
|
|
static int parse_combine_filter(
|
|
|
|
struct list_objects_filter_options *filter_options,
|
|
|
|
const char *arg,
|
|
|
|
struct strbuf *errbuf);
|
2017-11-21 21:58:50 +01:00
|
|
|
|
|
|
|
/*
|
2017-12-05 17:50:12 +01:00
|
|
|
* Parse value of the argument to the "filter" keyword.
|
2017-11-21 21:58:50 +01:00
|
|
|
* On the command line this looks like:
|
|
|
|
* --filter=<arg>
|
|
|
|
* and in the pack protocol as:
|
|
|
|
* "filter" SP <arg>
|
|
|
|
*
|
|
|
|
* The filter keyword will be used by many commands.
|
|
|
|
* See Documentation/rev-list-options.txt for allowed values for <arg>.
|
|
|
|
*
|
|
|
|
* Capture the given arg as the "filter_spec". This can be forwarded to
|
2019-01-08 01:17:09 +01:00
|
|
|
* subordinate commands when necessary (although it's better to pass it through
|
|
|
|
* expand_list_objects_filter_spec() first). We also "intern" the arg for the
|
|
|
|
* convenience of the current command.
|
2017-11-21 21:58:50 +01:00
|
|
|
*/
|
2017-12-08 16:58:45 +01:00
|
|
|
static int gently_parse_list_objects_filter(
|
|
|
|
struct list_objects_filter_options *filter_options,
|
|
|
|
const char *arg,
|
|
|
|
struct strbuf *errbuf)
|
2017-11-21 21:58:50 +01:00
|
|
|
{
|
|
|
|
const char *v0;
|
|
|
|
|
2019-06-25 15:40:32 +02:00
|
|
|
if (!arg)
|
|
|
|
return 0;
|
|
|
|
|
2019-06-28 00:54:09 +02:00
|
|
|
if (filter_options->choice)
|
|
|
|
BUG("filter_options already populated");
|
2017-11-21 21:58:50 +01:00
|
|
|
|
|
|
|
if (!strcmp(arg, "blob:none")) {
|
|
|
|
filter_options->choice = LOFC_BLOB_NONE;
|
|
|
|
return 0;
|
|
|
|
|
2017-12-08 16:58:45 +01:00
|
|
|
} else if (skip_prefix(arg, "blob:limit=", &v0)) {
|
|
|
|
if (git_parse_ulong(v0, &filter_options->blob_limit_value)) {
|
|
|
|
filter_options->choice = LOFC_BLOB_LIMIT;
|
|
|
|
return 0;
|
|
|
|
}
|
2017-11-21 21:58:50 +01:00
|
|
|
|
2018-10-05 23:31:27 +02:00
|
|
|
} else if (skip_prefix(arg, "tree:", &v0)) {
|
2019-01-09 03:59:13 +01:00
|
|
|
if (!git_parse_ulong(v0, &filter_options->tree_exclude_depth)) {
|
2019-06-28 00:54:07 +02:00
|
|
|
strbuf_addstr(errbuf, _("expected 'tree:<depth>'"));
|
2018-10-05 23:31:27 +02:00
|
|
|
return 1;
|
|
|
|
}
|
2019-01-09 03:59:13 +01:00
|
|
|
filter_options->choice = LOFC_TREE_DEPTH;
|
2018-10-05 23:31:27 +02:00
|
|
|
return 0;
|
|
|
|
|
2017-12-08 16:58:45 +01:00
|
|
|
} else if (skip_prefix(arg, "sparse:oid=", &v0)) {
|
list-objects-filter: delay parsing of sparse oid
The list-objects-filter code has two steps to its initialization:
1. parse_list_objects_filter() makes sure the spec is a filter we know
about and is syntactically correct. This step is done by "rev-list"
or "upload-pack" that is going to apply a filter, but also by "git
clone" or "git fetch" before they send the spec across the wire.
2. list_objects_filter__init() runs the type-specific initialization
(using function pointers established in step 1). This happens at
the start of traverse_commit_list_filtered(), when we're about to
actually use the filter.
It's a good idea to parse as much as we can in step 1, in order to catch
problems early (e.g., a blob size limit that isn't a number). But one
thing we _shouldn't_ do is resolve any oids at that step (e.g., for
sparse-file contents specified by oid). In the case of a fetch, the oid
has to be resolved on the remote side.
The current code does resolve the oid during the parse phase, but
ignores any error (which we must do, because we might just be sending
the spec across the wire). This leads to two bugs:
- if we're not in a repository (e.g., because it's git-clone parsing
the spec), then we trigger a BUG() trying to resolve the name
- if we did hit the error case, we still have to notice that later and
bail. The code path in rev-list handles this, but the one in
upload-pack does not, leading to a segfault.
We can fix both by moving the oid resolution into the sparse-oid init
function. At that point we know we have a repository (because we're
about to traverse), and handling the error there fixes the segfault.
As a bonus, we can drop the NULL sparse_oid_value check in rev-list,
since this is now handled in the sparse-oid-filter init function.
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-09-15 18:12:44 +02:00
|
|
|
filter_options->sparse_oid_name = xstrdup(v0);
|
2017-11-21 21:58:50 +01:00
|
|
|
filter_options->choice = LOFC_SPARSE_OID;
|
|
|
|
return 0;
|
|
|
|
|
2017-12-08 16:58:45 +01:00
|
|
|
} else if (skip_prefix(arg, "sparse:path=", &v0)) {
|
2019-05-29 14:44:32 +02:00
|
|
|
if (errbuf) {
|
|
|
|
strbuf_addstr(
|
|
|
|
errbuf,
|
|
|
|
_("sparse:path filters support has been dropped"));
|
|
|
|
}
|
|
|
|
return 1;
|
2019-06-28 00:54:08 +02:00
|
|
|
|
|
|
|
} else if (skip_prefix(arg, "combine:", &v0)) {
|
|
|
|
return parse_combine_filter(filter_options, v0, errbuf);
|
|
|
|
|
2017-11-21 21:58:50 +01:00
|
|
|
}
|
2019-02-16 12:24:41 +01:00
|
|
|
/*
|
|
|
|
* Please update _git_fetch() in git-completion.bash when you
|
|
|
|
* add new filters
|
|
|
|
*/
|
2017-11-21 21:58:50 +01:00
|
|
|
|
2019-06-28 00:54:07 +02:00
|
|
|
strbuf_addf(errbuf, _("invalid filter-spec '%s'"), arg);
|
2018-10-05 23:31:26 +02:00
|
|
|
|
2017-12-08 16:58:45 +01:00
|
|
|
memset(filter_options, 0, sizeof(*filter_options));
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2019-06-28 00:54:08 +02:00
|
|
|
static const char *RESERVED_NON_WS = "~`!@#$^&*()[]{}\\;'\",<>?";
|
|
|
|
|
|
|
|
static int has_reserved_character(
|
|
|
|
struct strbuf *sub_spec, struct strbuf *errbuf)
|
2017-12-08 16:58:45 +01:00
|
|
|
{
|
2019-06-28 00:54:08 +02:00
|
|
|
const char *c = sub_spec->buf;
|
|
|
|
while (*c) {
|
|
|
|
if (*c <= ' ' || strchr(RESERVED_NON_WS, *c)) {
|
|
|
|
strbuf_addf(
|
|
|
|
errbuf,
|
|
|
|
_("must escape char in sub-filter-spec: '%c'"),
|
|
|
|
*c);
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
c++;
|
|
|
|
}
|
|
|
|
|
2017-11-21 21:58:50 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-06-28 00:54:08 +02:00
|
|
|
static int parse_combine_subfilter(
|
|
|
|
struct list_objects_filter_options *filter_options,
|
|
|
|
struct strbuf *subspec,
|
|
|
|
struct strbuf *errbuf)
|
|
|
|
{
|
2019-06-28 00:54:13 +02:00
|
|
|
size_t new_index = filter_options->sub_nr;
|
2019-06-28 00:54:08 +02:00
|
|
|
char *decoded;
|
|
|
|
int result;
|
|
|
|
|
2019-06-28 00:54:13 +02:00
|
|
|
ALLOC_GROW_BY(filter_options->sub, filter_options->sub_nr, 1,
|
|
|
|
filter_options->sub_alloc);
|
2019-06-28 00:54:08 +02:00
|
|
|
|
|
|
|
decoded = url_percent_decode(subspec->buf);
|
|
|
|
|
|
|
|
result = has_reserved_character(subspec, errbuf) ||
|
|
|
|
gently_parse_list_objects_filter(
|
|
|
|
&filter_options->sub[new_index], decoded, errbuf);
|
|
|
|
|
|
|
|
free(decoded);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_combine_filter(
|
|
|
|
struct list_objects_filter_options *filter_options,
|
|
|
|
const char *arg,
|
|
|
|
struct strbuf *errbuf)
|
|
|
|
{
|
|
|
|
struct strbuf **subspecs = strbuf_split_str(arg, '+', 0);
|
|
|
|
size_t sub;
|
|
|
|
int result = 0;
|
|
|
|
|
|
|
|
if (!subspecs[0]) {
|
|
|
|
strbuf_addstr(errbuf, _("expected something after combine:"));
|
|
|
|
result = 1;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (sub = 0; subspecs[sub] && !result; sub++) {
|
|
|
|
if (subspecs[sub + 1]) {
|
|
|
|
/*
|
|
|
|
* This is not the last subspec. Remove trailing "+" so
|
|
|
|
* we can parse it.
|
|
|
|
*/
|
|
|
|
size_t last = subspecs[sub]->len - 1;
|
|
|
|
assert(subspecs[sub]->buf[last] == '+');
|
|
|
|
strbuf_remove(subspecs[sub], last, 1);
|
|
|
|
}
|
|
|
|
result = parse_combine_subfilter(
|
|
|
|
filter_options, subspecs[sub], errbuf);
|
|
|
|
}
|
|
|
|
|
|
|
|
filter_options->choice = LOFC_COMBINE;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
strbuf_list_free(subspecs);
|
|
|
|
if (result) {
|
|
|
|
list_objects_filter_release(filter_options);
|
|
|
|
memset(filter_options, 0, sizeof(*filter_options));
|
|
|
|
}
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2019-06-28 00:54:12 +02:00
|
|
|
static int allow_unencoded(char ch)
|
|
|
|
{
|
|
|
|
if (ch <= ' ' || ch == '%' || ch == '+')
|
|
|
|
return 0;
|
|
|
|
return !strchr(RESERVED_NON_WS, ch);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void filter_spec_append_urlencode(
|
|
|
|
struct list_objects_filter_options *filter, const char *raw)
|
2017-12-08 16:58:45 +01:00
|
|
|
{
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
2019-06-28 00:54:12 +02:00
|
|
|
strbuf_addstr_urlencode(&buf, raw, allow_unencoded);
|
|
|
|
trace_printf("Add to combine filter-spec: %s\n", buf.buf);
|
|
|
|
string_list_append(&filter->filter_spec, strbuf_detach(&buf, NULL));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Changes filter_options into an equivalent LOFC_COMBINE filter options
|
|
|
|
* instance. Does not do anything if filter_options is already LOFC_COMBINE.
|
|
|
|
*/
|
|
|
|
static void transform_to_combine_type(
|
|
|
|
struct list_objects_filter_options *filter_options)
|
|
|
|
{
|
|
|
|
assert(filter_options->choice);
|
|
|
|
if (filter_options->choice == LOFC_COMBINE)
|
|
|
|
return;
|
|
|
|
{
|
|
|
|
const int initial_sub_alloc = 2;
|
|
|
|
struct list_objects_filter_options *sub_array =
|
|
|
|
xcalloc(initial_sub_alloc, sizeof(*sub_array));
|
|
|
|
sub_array[0] = *filter_options;
|
|
|
|
memset(filter_options, 0, sizeof(*filter_options));
|
|
|
|
filter_options->sub = sub_array;
|
|
|
|
filter_options->sub_alloc = initial_sub_alloc;
|
|
|
|
}
|
|
|
|
filter_options->sub_nr = 1;
|
|
|
|
filter_options->choice = LOFC_COMBINE;
|
|
|
|
string_list_append(&filter_options->filter_spec, xstrdup("combine:"));
|
|
|
|
filter_spec_append_urlencode(
|
|
|
|
filter_options,
|
|
|
|
list_objects_filter_spec(&filter_options->sub[0]));
|
|
|
|
/*
|
|
|
|
* We don't need the filter_spec strings for subfilter specs, only the
|
|
|
|
* top level.
|
|
|
|
*/
|
|
|
|
string_list_clear(&filter_options->sub[0].filter_spec, /*free_util=*/0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void list_objects_filter_die_if_populated(
|
|
|
|
struct list_objects_filter_options *filter_options)
|
|
|
|
{
|
2019-06-28 00:54:09 +02:00
|
|
|
if (filter_options->choice)
|
|
|
|
die(_("multiple filter-specs cannot be combined"));
|
2019-06-28 00:54:12 +02:00
|
|
|
}
|
|
|
|
|
2019-06-28 00:54:14 +02:00
|
|
|
void parse_list_objects_filter(
|
2019-06-28 00:54:12 +02:00
|
|
|
struct list_objects_filter_options *filter_options,
|
|
|
|
const char *arg)
|
|
|
|
{
|
|
|
|
struct strbuf errbuf = STRBUF_INIT;
|
|
|
|
int parse_error;
|
|
|
|
|
|
|
|
if (!filter_options->choice) {
|
|
|
|
string_list_append(&filter_options->filter_spec, xstrdup(arg));
|
|
|
|
|
|
|
|
parse_error = gently_parse_list_objects_filter(
|
|
|
|
filter_options, arg, &errbuf);
|
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* Make filter_options an LOFC_COMBINE spec so we can trivially
|
|
|
|
* add subspecs to it.
|
|
|
|
*/
|
|
|
|
transform_to_combine_type(filter_options);
|
|
|
|
|
|
|
|
string_list_append(&filter_options->filter_spec, xstrdup("+"));
|
|
|
|
filter_spec_append_urlencode(filter_options, arg);
|
2019-06-28 00:54:13 +02:00
|
|
|
ALLOC_GROW_BY(filter_options->sub, filter_options->sub_nr, 1,
|
|
|
|
filter_options->sub_alloc);
|
2019-06-28 00:54:12 +02:00
|
|
|
|
|
|
|
parse_error = gently_parse_list_objects_filter(
|
2019-06-28 00:54:13 +02:00
|
|
|
&filter_options->sub[filter_options->sub_nr - 1], arg,
|
|
|
|
&errbuf);
|
2019-06-28 00:54:12 +02:00
|
|
|
}
|
|
|
|
if (parse_error)
|
|
|
|
die("%s", errbuf.buf);
|
2017-11-21 21:58:50 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
int opt_parse_list_objects_filter(const struct option *opt,
|
|
|
|
const char *arg, int unset)
|
|
|
|
{
|
|
|
|
struct list_objects_filter_options *filter_options = opt->value;
|
|
|
|
|
2019-06-28 00:54:14 +02:00
|
|
|
if (unset || !arg)
|
2017-12-08 16:58:50 +01:00
|
|
|
list_objects_filter_set_no_filter(filter_options);
|
2019-06-28 00:54:14 +02:00
|
|
|
else
|
|
|
|
parse_list_objects_filter(filter_options, arg);
|
|
|
|
return 0;
|
2017-11-21 21:58:50 +01:00
|
|
|
}
|
2017-12-05 17:50:13 +01:00
|
|
|
|
2019-06-28 00:54:10 +02:00
|
|
|
const char *list_objects_filter_spec(struct list_objects_filter_options *filter)
|
2019-01-08 01:17:09 +01:00
|
|
|
{
|
2019-06-28 00:54:10 +02:00
|
|
|
if (!filter->filter_spec.nr)
|
|
|
|
BUG("no filter_spec available for this filter");
|
|
|
|
if (filter->filter_spec.nr != 1) {
|
|
|
|
struct strbuf concatted = STRBUF_INIT;
|
|
|
|
strbuf_add_separated_string_list(
|
|
|
|
&concatted, "", &filter->filter_spec);
|
|
|
|
string_list_clear(&filter->filter_spec, /*free_util=*/0);
|
|
|
|
string_list_append(
|
|
|
|
&filter->filter_spec, strbuf_detach(&concatted, NULL));
|
2017-12-05 17:50:13 +01:00
|
|
|
}
|
2017-11-21 21:58:50 +01:00
|
|
|
|
2019-06-28 00:54:10 +02:00
|
|
|
return filter->filter_spec.items[0].string;
|
2017-11-21 21:58:50 +01:00
|
|
|
}
|
2017-12-05 17:50:13 +01:00
|
|
|
|
2019-06-28 00:54:10 +02:00
|
|
|
const char *expand_list_objects_filter_spec(
|
|
|
|
struct list_objects_filter_options *filter)
|
2019-01-08 01:17:09 +01:00
|
|
|
{
|
2019-06-28 00:54:10 +02:00
|
|
|
if (filter->choice == LOFC_BLOB_LIMIT) {
|
|
|
|
struct strbuf expanded_spec = STRBUF_INIT;
|
|
|
|
strbuf_addf(&expanded_spec, "blob:limit=%lu",
|
2019-01-08 01:17:09 +01:00
|
|
|
filter->blob_limit_value);
|
2019-06-28 00:54:10 +02:00
|
|
|
string_list_clear(&filter->filter_spec, /*free_util=*/0);
|
|
|
|
string_list_append(
|
|
|
|
&filter->filter_spec,
|
|
|
|
strbuf_detach(&expanded_spec, NULL));
|
|
|
|
}
|
|
|
|
|
|
|
|
return list_objects_filter_spec(filter);
|
2019-01-08 01:17:09 +01:00
|
|
|
}
|
|
|
|
|
2017-12-05 17:50:13 +01:00
|
|
|
void list_objects_filter_release(
|
|
|
|
struct list_objects_filter_options *filter_options)
|
|
|
|
{
|
2019-06-28 00:54:08 +02:00
|
|
|
size_t sub;
|
|
|
|
|
|
|
|
if (!filter_options)
|
|
|
|
return;
|
2019-06-28 00:54:10 +02:00
|
|
|
string_list_clear(&filter_options->filter_spec, /*free_util=*/0);
|
list-objects-filter: delay parsing of sparse oid
The list-objects-filter code has two steps to its initialization:
1. parse_list_objects_filter() makes sure the spec is a filter we know
about and is syntactically correct. This step is done by "rev-list"
or "upload-pack" that is going to apply a filter, but also by "git
clone" or "git fetch" before they send the spec across the wire.
2. list_objects_filter__init() runs the type-specific initialization
(using function pointers established in step 1). This happens at
the start of traverse_commit_list_filtered(), when we're about to
actually use the filter.
It's a good idea to parse as much as we can in step 1, in order to catch
problems early (e.g., a blob size limit that isn't a number). But one
thing we _shouldn't_ do is resolve any oids at that step (e.g., for
sparse-file contents specified by oid). In the case of a fetch, the oid
has to be resolved on the remote side.
The current code does resolve the oid during the parse phase, but
ignores any error (which we must do, because we might just be sending
the spec across the wire). This leads to two bugs:
- if we're not in a repository (e.g., because it's git-clone parsing
the spec), then we trigger a BUG() trying to resolve the name
- if we did hit the error case, we still have to notice that later and
bail. The code path in rev-list handles this, but the one in
upload-pack does not, leading to a segfault.
We can fix both by moving the oid resolution into the sparse-oid init
function. At that point we know we have a repository (because we're
about to traverse), and handling the error there fixes the segfault.
As a bonus, we can drop the NULL sparse_oid_value check in rev-list,
since this is now handled in the sparse-oid-filter init function.
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-09-15 18:12:44 +02:00
|
|
|
free(filter_options->sparse_oid_name);
|
2019-06-28 00:54:08 +02:00
|
|
|
for (sub = 0; sub < filter_options->sub_nr; sub++)
|
|
|
|
list_objects_filter_release(&filter_options->sub[sub]);
|
|
|
|
free(filter_options->sub);
|
2017-12-05 17:50:13 +01:00
|
|
|
memset(filter_options, 0, sizeof(*filter_options));
|
|
|
|
}
|
2017-12-08 16:58:45 +01:00
|
|
|
|
|
|
|
void partial_clone_register(
|
|
|
|
const char *remote,
|
2019-06-28 00:54:10 +02:00
|
|
|
struct list_objects_filter_options *filter_options)
|
2017-12-08 16:58:45 +01:00
|
|
|
{
|
2019-06-25 15:40:31 +02:00
|
|
|
char *cfg_name;
|
2019-06-25 15:40:32 +02:00
|
|
|
char *filter_name;
|
2017-12-08 16:58:45 +01:00
|
|
|
|
2019-06-25 15:40:31 +02:00
|
|
|
/* Check if it is already registered */
|
|
|
|
if (!promisor_remote_find(remote)) {
|
|
|
|
git_config_set("core.repositoryformatversion", "1");
|
2017-12-08 16:58:45 +01:00
|
|
|
|
2019-06-25 15:40:31 +02:00
|
|
|
/* Add promisor config for the remote */
|
|
|
|
cfg_name = xstrfmt("remote.%s.promisor", remote);
|
|
|
|
git_config_set(cfg_name, "true");
|
|
|
|
free(cfg_name);
|
|
|
|
}
|
2017-12-08 16:58:45 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Record the initial filter-spec in the config as
|
|
|
|
* the default for subsequent fetches from this remote.
|
|
|
|
*/
|
2019-06-25 15:40:32 +02:00
|
|
|
filter_name = xstrfmt("remote.%s.partialclonefilter", remote);
|
2019-09-18 20:50:09 +02:00
|
|
|
/* NEEDSWORK: 'expand' result leaking??? */
|
|
|
|
git_config_set(filter_name,
|
|
|
|
expand_list_objects_filter_spec(filter_options));
|
2019-06-25 15:40:32 +02:00
|
|
|
free(filter_name);
|
2019-06-25 15:40:31 +02:00
|
|
|
|
|
|
|
/* Make sure the config info are reset */
|
|
|
|
promisor_remote_reinit();
|
2017-12-08 16:58:45 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void partial_clone_get_default_filter_spec(
|
2019-06-25 15:40:32 +02:00
|
|
|
struct list_objects_filter_options *filter_options,
|
|
|
|
const char *remote)
|
2017-12-08 16:58:45 +01:00
|
|
|
{
|
2019-06-25 15:40:32 +02:00
|
|
|
struct promisor_remote *promisor = promisor_remote_find(remote);
|
2019-06-28 00:54:07 +02:00
|
|
|
struct strbuf errbuf = STRBUF_INIT;
|
2019-06-25 15:40:32 +02:00
|
|
|
|
2017-12-08 16:58:45 +01:00
|
|
|
/*
|
|
|
|
* Parse default value, but silently ignore it if it is invalid.
|
|
|
|
*/
|
2019-09-18 20:50:09 +02:00
|
|
|
if (!promisor)
|
2018-06-11 23:51:26 +02:00
|
|
|
return;
|
2019-06-28 00:54:08 +02:00
|
|
|
|
2019-06-28 00:54:10 +02:00
|
|
|
string_list_append(&filter_options->filter_spec,
|
2019-09-18 20:50:09 +02:00
|
|
|
promisor->partial_clone_filter);
|
2017-12-08 16:58:45 +01:00
|
|
|
gently_parse_list_objects_filter(filter_options,
|
2019-09-18 20:50:09 +02:00
|
|
|
promisor->partial_clone_filter,
|
2019-06-28 00:54:07 +02:00
|
|
|
&errbuf);
|
|
|
|
strbuf_release(&errbuf);
|
2017-12-08 16:58:45 +01:00
|
|
|
}
|