2007-06-25 02:11:14 +02:00
|
|
|
#!/bin/sh
|
|
|
|
#
|
|
|
|
# Copyright (c) 2007 Johannes E. Schindelin
|
|
|
|
#
|
|
|
|
|
|
|
|
test_description='git rebase interactive
|
|
|
|
|
|
|
|
This test runs git rebase "interactively", by faking an edit, and verifies
|
|
|
|
that the result still makes sense.
|
2010-10-31 08:39:51 +01:00
|
|
|
|
|
|
|
Initial setup:
|
|
|
|
|
|
|
|
one - two - three - four (conflict-branch)
|
|
|
|
/
|
2020-11-24 11:15:49 +01:00
|
|
|
A - B - C - D - E (primary)
|
2010-10-31 08:39:51 +01:00
|
|
|
| \
|
|
|
|
| F - G - H (branch1)
|
|
|
|
| \
|
|
|
|
|\ I (branch2)
|
|
|
|
| \
|
|
|
|
| J - K - L - M (no-conflict-branch)
|
|
|
|
\
|
|
|
|
N - O - P (no-ff-branch)
|
|
|
|
|
|
|
|
where A, B, D and G all touch file1, and one, two, three, four all
|
|
|
|
touch file "conflict".
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
tests: mark tests relying on the current default for `init.defaultBranch`
In addition to the manual adjustment to let the `linux-gcc` CI job run
the test suite with `master` and then with `main`, this patch makes sure
that GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME is set in all test scripts
that currently rely on the initial branch name being `master by default.
To determine which test scripts to mark up, the first step was to
force-set the default branch name to `master` in
- all test scripts that contain the keyword `master`,
- t4211, which expects `t/t4211/history.export` with a hard-coded ref to
initialize the default branch,
- t5560 because it sources `t/t556x_common` which uses `master`,
- t8002 and t8012 because both source `t/annotate-tests.sh` which also
uses `master`)
This trick was performed by this command:
$ sed -i '/^ *\. \.\/\(test-lib\|lib-\(bash\|cvs\|git-svn\)\|gitweb-lib\)\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' $(git grep -l master t/t[0-9]*.sh) \
t/t4211*.sh t/t5560*.sh t/t8002*.sh t/t8012*.sh
After that, careful, manual inspection revealed that some of the test
scripts containing the needle `master` do not actually rely on a
specific default branch name: either they mention `master` only in a
comment, or they initialize that branch specificially, or they do not
actually refer to the current default branch. Therefore, the
aforementioned modification was undone in those test scripts thusly:
$ git checkout HEAD -- \
t/t0027-auto-crlf.sh t/t0060-path-utils.sh \
t/t1011-read-tree-sparse-checkout.sh \
t/t1305-config-include.sh t/t1309-early-config.sh \
t/t1402-check-ref-format.sh t/t1450-fsck.sh \
t/t2024-checkout-dwim.sh \
t/t2106-update-index-assume-unchanged.sh \
t/t3040-subprojects-basic.sh t/t3301-notes.sh \
t/t3308-notes-merge.sh t/t3423-rebase-reword.sh \
t/t3436-rebase-more-options.sh \
t/t4015-diff-whitespace.sh t/t4257-am-interactive.sh \
t/t5323-pack-redundant.sh t/t5401-update-hooks.sh \
t/t5511-refspec.sh t/t5526-fetch-submodules.sh \
t/t5529-push-errors.sh t/t5530-upload-pack-error.sh \
t/t5548-push-porcelain.sh \
t/t5552-skipping-fetch-negotiator.sh \
t/t5572-pull-submodule.sh t/t5608-clone-2gb.sh \
t/t5614-clone-submodules-shallow.sh \
t/t7508-status.sh t/t7606-merge-custom.sh \
t/t9302-fast-import-unpack-limit.sh
We excluded one set of test scripts in these commands, though: the range
of `git p4` tests. The reason? `git p4` stores the (foreign) remote
branch in the branch called `p4/master`, which is obviously not the
default branch. Manual analysis revealed that only five of these tests
actually require a specific default branch name to pass; They were
modified thusly:
$ sed -i '/^ *\. \.\/lib-git-p4\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' t/t980[0167]*.sh t/t9811*.sh
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-11-19 00:44:19 +01:00
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master
|
|
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
2009-08-09 10:37:52 +02:00
|
|
|
. "$TEST_DIRECTORY"/lib-rebase.sh
|
2009-01-27 23:34:29 +01:00
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_expect_success 'setup' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git switch -C primary &&
|
2009-12-07 05:22:58 +01:00
|
|
|
test_commit A file1 &&
|
|
|
|
test_commit B file1 &&
|
|
|
|
test_commit C file2 &&
|
|
|
|
test_commit D file1 &&
|
|
|
|
test_commit E file3 &&
|
2007-06-25 02:11:14 +02:00
|
|
|
git checkout -b branch1 A &&
|
2009-12-07 05:22:58 +01:00
|
|
|
test_commit F file4 &&
|
|
|
|
test_commit G file1 &&
|
|
|
|
test_commit H file5 &&
|
2007-06-25 02:11:14 +02:00
|
|
|
git checkout -b branch2 F &&
|
2010-10-31 08:30:58 +01:00
|
|
|
test_commit I file6 &&
|
2010-01-14 06:54:56 +01:00
|
|
|
git checkout -b conflict-branch A &&
|
2010-10-31 08:38:25 +01:00
|
|
|
test_commit one conflict &&
|
|
|
|
test_commit two conflict &&
|
|
|
|
test_commit three conflict &&
|
|
|
|
test_commit four conflict &&
|
2010-01-14 06:54:56 +01:00
|
|
|
git checkout -b no-conflict-branch A &&
|
2010-10-31 08:38:25 +01:00
|
|
|
test_commit J fileJ &&
|
|
|
|
test_commit K fileK &&
|
|
|
|
test_commit L fileL &&
|
|
|
|
test_commit M fileM &&
|
2010-03-24 21:34:04 +01:00
|
|
|
git checkout -b no-ff-branch A &&
|
2010-10-31 08:38:25 +01:00
|
|
|
test_commit N fileN &&
|
|
|
|
test_commit O fileO &&
|
|
|
|
test_commit P fileP
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
2016-06-29 16:31:03 +02:00
|
|
|
# "exec" commands are run with the user shell by default, but this may
|
2010-08-10 17:17:51 +02:00
|
|
|
# be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
|
2016-05-10 16:05:58 +02:00
|
|
|
# to create a file. Unsetting SHELL avoids such non-portable behavior
|
2010-12-27 09:03:43 +01:00
|
|
|
# in tests. It must be exported for it to take effect where needed.
|
2010-08-10 17:17:51 +02:00
|
|
|
SHELL=
|
2010-12-27 09:03:43 +01:00
|
|
|
export SHELL
|
2010-08-10 17:17:51 +02:00
|
|
|
|
2014-05-18 22:28:39 +02:00
|
|
|
test_expect_success 'rebase --keep-empty' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout -b emptybranch primary &&
|
2014-05-18 22:28:39 +02:00
|
|
|
git commit --allow-empty -m "empty" &&
|
|
|
|
git rebase --keep-empty -i HEAD~2 &&
|
|
|
|
git log --oneline >actual &&
|
|
|
|
test_line_count = 6 actual
|
|
|
|
'
|
|
|
|
|
2020-01-16 07:14:16 +01:00
|
|
|
test_expect_success 'rebase -i with empty todo list' '
|
2019-06-24 20:13:14 +02:00
|
|
|
cat >expect <<-\EOF &&
|
|
|
|
error: nothing to do
|
|
|
|
EOF
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
2020-01-16 07:14:16 +01:00
|
|
|
test_must_fail env FAKE_LINES="#" \
|
|
|
|
git rebase -i HEAD^ >output 2>&1
|
2019-10-15 12:25:28 +02:00
|
|
|
) &&
|
2020-01-16 07:14:16 +01:00
|
|
|
tail -n 1 output >actual && # Ignore output about changing todo list
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect actual
|
2018-08-10 18:51:37 +02:00
|
|
|
'
|
|
|
|
|
2010-08-10 17:17:51 +02:00
|
|
|
test_expect_success 'rebase -i with the exec command' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2010-08-10 17:17:51 +02:00
|
|
|
(
|
2013-08-24 02:10:40 +02:00
|
|
|
set_fake_editor &&
|
2010-08-10 17:17:51 +02:00
|
|
|
FAKE_LINES="1 exec_>touch-one
|
|
|
|
2 exec_>touch-two exec_false exec_>touch-three
|
|
|
|
3 4 exec_>\"touch-file__name_with_spaces\";_>touch-after-semicolon 5" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
test_must_fail git rebase -i A
|
|
|
|
) &&
|
2010-08-10 17:17:52 +02:00
|
|
|
test_path_is_file touch-one &&
|
|
|
|
test_path_is_file touch-two &&
|
2021-02-12 14:29:41 +01:00
|
|
|
# Missing because we should have stopped by now.
|
|
|
|
test_path_is_missing touch-three &&
|
2010-10-31 08:40:30 +01:00
|
|
|
test_cmp_rev C HEAD &&
|
2010-08-10 17:17:51 +02:00
|
|
|
git rebase --continue &&
|
2010-08-10 17:17:52 +02:00
|
|
|
test_path_is_file touch-three &&
|
|
|
|
test_path_is_file "touch-file name with spaces" &&
|
|
|
|
test_path_is_file touch-after-semicolon &&
|
2020-11-24 11:15:49 +01:00
|
|
|
test_cmp_rev primary HEAD &&
|
2010-08-10 17:17:51 +02:00
|
|
|
rm -f touch-*
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i with the exec command runs from tree root' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2010-09-06 20:41:06 +02:00
|
|
|
mkdir subdir && (cd subdir &&
|
2013-08-24 02:10:40 +02:00
|
|
|
set_fake_editor &&
|
2010-08-10 17:17:51 +02:00
|
|
|
FAKE_LINES="1 exec_>touch-subdir" \
|
2010-09-06 20:41:06 +02:00
|
|
|
git rebase -i HEAD^
|
|
|
|
) &&
|
2010-08-10 17:17:52 +02:00
|
|
|
test_path_is_file touch-subdir &&
|
2010-08-10 17:17:51 +02:00
|
|
|
rm -fr subdir
|
|
|
|
'
|
|
|
|
|
2017-11-01 00:07:33 +01:00
|
|
|
test_expect_success 'rebase -i with exec allows git commands in subdirs' '
|
|
|
|
test_when_finished "rm -rf subdir" &&
|
|
|
|
test_when_finished "git rebase --abort ||:" &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2017-11-01 00:07:33 +01:00
|
|
|
mkdir subdir && (cd subdir &&
|
|
|
|
set_fake_editor &&
|
2018-10-27 10:08:01 +02:00
|
|
|
FAKE_LINES="1 x_cd_subdir_&&_git_rev-parse_--is-inside-work-tree" \
|
2017-11-01 00:07:33 +01:00
|
|
|
git rebase -i HEAD^
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2018-07-14 20:38:59 +02:00
|
|
|
test_expect_success 'rebase -i sets work tree properly' '
|
|
|
|
test_when_finished "rm -rf subdir" &&
|
|
|
|
test_when_finished "test_might_fail git rebase --abort" &&
|
|
|
|
mkdir subdir &&
|
|
|
|
git rebase -x "(cd subdir && git rev-parse --show-toplevel)" HEAD^ \
|
|
|
|
>actual &&
|
|
|
|
! grep "/subdir$" actual
|
|
|
|
'
|
|
|
|
|
2010-08-10 17:17:51 +02:00
|
|
|
test_expect_success 'rebase -i with the exec command checks tree cleanness' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="exec_echo_foo_>file1 1" \
|
|
|
|
git rebase -i HEAD^
|
|
|
|
) &&
|
2020-11-24 11:15:49 +01:00
|
|
|
test_cmp_rev primary^ HEAD &&
|
2010-08-10 17:17:51 +02:00
|
|
|
git reset --hard &&
|
|
|
|
git rebase --continue
|
|
|
|
'
|
|
|
|
|
2019-01-29 19:43:27 +01:00
|
|
|
test_expect_success 'rebase -x with empty command fails' '
|
|
|
|
test_when_finished "git rebase --abort ||:" &&
|
rebase: remove the rebase.useBuiltin setting
Remove the rebase.useBuiltin setting, which was added as an escape
hatch to disable the builtin version of rebase first released with Git
2.20.
See [1] for the initial implementation of rebase.useBuiltin, and [2]
and [3] for the documentation and corresponding
GIT_TEST_REBASE_USE_BUILTIN option.
Carrying the legacy version is a maintenance burden as seen in
7e097e27d3 ("legacy-rebase: backport -C<n> and --whitespace=<option>
checks", 2018-11-20) and 9aea5e9286 ("rebase: fix regression in
rebase.useBuiltin=false test mode", 2019-02-13). Since the built-in
version has been shown to be stable enough let's remove the legacy
version.
As noted in [3] having use_builtin_rebase() shell out to get its
config doesn't make any sense anymore, that was done for the purposes
of spawning the legacy rebase without having modified any global
state. Let's instead handle this case in rebase_config().
There's still a bunch of references to git-legacy-rebase in po/*.po,
but those will be dealt with in time by the i18n effort.
Even though this configuration variable only existed two releases
let's not entirely delete the entry from the docs, but note its
absence. Individual versions of git tend to be around for a while due
to distro packaging timelines, so e.g. if we're "lucky" a given
version like 2.21 might be installed on say OSX for half a decade.
That'll mean some people probably setting this in config, and then
when they later wonder if it's needed they can Google search the
config option name or check it in git-config. It also allows us to
refer to the docs from the warning for details.
1. 55071ea248 ("rebase: start implementing it as a builtin",
2018-08-07)
2. d8d0a546f0 ("rebase doc: document rebase.useBuiltin", 2018-11-14)
3. 62c23938fa ("tests: add a special setup where rebase.useBuiltin is
off", 2018-11-14)
3. https://public-inbox.org/git/nycvar.QRO.7.76.6.1903141544110.41@tvgsbejvaqbjf.bet/
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-03-18 12:01:52 +01:00
|
|
|
test_must_fail env git rebase -x "" @ 2>actual &&
|
2019-01-29 19:43:27 +01:00
|
|
|
test_write_lines "error: empty exec command" >expected &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expected actual &&
|
rebase: remove the rebase.useBuiltin setting
Remove the rebase.useBuiltin setting, which was added as an escape
hatch to disable the builtin version of rebase first released with Git
2.20.
See [1] for the initial implementation of rebase.useBuiltin, and [2]
and [3] for the documentation and corresponding
GIT_TEST_REBASE_USE_BUILTIN option.
Carrying the legacy version is a maintenance burden as seen in
7e097e27d3 ("legacy-rebase: backport -C<n> and --whitespace=<option>
checks", 2018-11-20) and 9aea5e9286 ("rebase: fix regression in
rebase.useBuiltin=false test mode", 2019-02-13). Since the built-in
version has been shown to be stable enough let's remove the legacy
version.
As noted in [3] having use_builtin_rebase() shell out to get its
config doesn't make any sense anymore, that was done for the purposes
of spawning the legacy rebase without having modified any global
state. Let's instead handle this case in rebase_config().
There's still a bunch of references to git-legacy-rebase in po/*.po,
but those will be dealt with in time by the i18n effort.
Even though this configuration variable only existed two releases
let's not entirely delete the entry from the docs, but note its
absence. Individual versions of git tend to be around for a while due
to distro packaging timelines, so e.g. if we're "lucky" a given
version like 2.21 might be installed on say OSX for half a decade.
That'll mean some people probably setting this in config, and then
when they later wonder if it's needed they can Google search the
config option name or check it in git-config. It also allows us to
refer to the docs from the warning for details.
1. 55071ea248 ("rebase: start implementing it as a builtin",
2018-08-07)
2. d8d0a546f0 ("rebase doc: document rebase.useBuiltin", 2018-11-14)
3. 62c23938fa ("tests: add a special setup where rebase.useBuiltin is
off", 2018-11-14)
3. https://public-inbox.org/git/nycvar.QRO.7.76.6.1903141544110.41@tvgsbejvaqbjf.bet/
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-03-18 12:01:52 +01:00
|
|
|
test_must_fail env git rebase -x " " @ 2>actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expected actual
|
2019-01-29 19:43:27 +01:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -x with newline in command fails' '
|
|
|
|
test_when_finished "git rebase --abort ||:" &&
|
rebase: remove the rebase.useBuiltin setting
Remove the rebase.useBuiltin setting, which was added as an escape
hatch to disable the builtin version of rebase first released with Git
2.20.
See [1] for the initial implementation of rebase.useBuiltin, and [2]
and [3] for the documentation and corresponding
GIT_TEST_REBASE_USE_BUILTIN option.
Carrying the legacy version is a maintenance burden as seen in
7e097e27d3 ("legacy-rebase: backport -C<n> and --whitespace=<option>
checks", 2018-11-20) and 9aea5e9286 ("rebase: fix regression in
rebase.useBuiltin=false test mode", 2019-02-13). Since the built-in
version has been shown to be stable enough let's remove the legacy
version.
As noted in [3] having use_builtin_rebase() shell out to get its
config doesn't make any sense anymore, that was done for the purposes
of spawning the legacy rebase without having modified any global
state. Let's instead handle this case in rebase_config().
There's still a bunch of references to git-legacy-rebase in po/*.po,
but those will be dealt with in time by the i18n effort.
Even though this configuration variable only existed two releases
let's not entirely delete the entry from the docs, but note its
absence. Individual versions of git tend to be around for a while due
to distro packaging timelines, so e.g. if we're "lucky" a given
version like 2.21 might be installed on say OSX for half a decade.
That'll mean some people probably setting this in config, and then
when they later wonder if it's needed they can Google search the
config option name or check it in git-config. It also allows us to
refer to the docs from the warning for details.
1. 55071ea248 ("rebase: start implementing it as a builtin",
2018-08-07)
2. d8d0a546f0 ("rebase doc: document rebase.useBuiltin", 2018-11-14)
3. 62c23938fa ("tests: add a special setup where rebase.useBuiltin is
off", 2018-11-14)
3. https://public-inbox.org/git/nycvar.QRO.7.76.6.1903141544110.41@tvgsbejvaqbjf.bet/
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-03-18 12:01:52 +01:00
|
|
|
test_must_fail env git rebase -x "a${LF}b" @ 2>actual &&
|
2019-01-29 19:43:27 +01:00
|
|
|
test_write_lines "error: exec commands cannot contain newlines" \
|
|
|
|
>expected &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expected actual
|
2019-01-29 19:43:27 +01:00
|
|
|
'
|
|
|
|
|
2012-09-18 13:15:26 +02:00
|
|
|
test_expect_success 'rebase -i with exec of inexistent command' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2012-09-18 13:15:26 +02:00
|
|
|
test_when_finished "git rebase --abort" &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="exec_this-command-does-not-exist 1" \
|
|
|
|
git rebase -i HEAD^ >actual 2>&1
|
|
|
|
) &&
|
2012-09-18 13:15:26 +02:00
|
|
|
! grep "Maybe git-rebase is broken" actual
|
|
|
|
'
|
|
|
|
|
2019-01-28 11:27:56 +01:00
|
|
|
test_expect_success 'implicit interactive rebase does not invoke sequence editor' '
|
|
|
|
test_when_finished "git rebase --abort ||:" &&
|
|
|
|
GIT_SEQUENCE_EDITOR="echo bad >" git rebase -x"echo one" @^
|
|
|
|
'
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_expect_success 'no changes are a nop' '
|
2010-01-14 06:54:56 +01:00
|
|
|
git checkout branch2 &&
|
2007-06-25 02:11:14 +02:00
|
|
|
git rebase -i F &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test "$(git symbolic-ref -q HEAD)" = "refs/heads/branch2" &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev I HEAD
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
2007-08-02 00:31:03 +02:00
|
|
|
test_expect_success 'test the [branch] option' '
|
|
|
|
git checkout -b dead-end &&
|
|
|
|
git rm file6 &&
|
|
|
|
git commit -m "stop here" &&
|
|
|
|
git rebase -i F branch2 &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test "$(git symbolic-ref -q HEAD)" = "refs/heads/branch2" &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev I branch2 &&
|
|
|
|
test_cmp_rev I HEAD
|
2007-08-02 00:31:03 +02:00
|
|
|
'
|
|
|
|
|
2008-06-22 01:55:50 +02:00
|
|
|
test_expect_success 'test --onto <branch>' '
|
|
|
|
git checkout -b test-onto branch2 &&
|
|
|
|
git rebase -i --onto branch1 F &&
|
|
|
|
test "$(git symbolic-ref -q HEAD)" = "refs/heads/test-onto" &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev HEAD^ branch1 &&
|
|
|
|
test_cmp_rev I branch2
|
2008-06-22 01:55:50 +02:00
|
|
|
'
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_expect_success 'rebase on top of a non-conflicting commit' '
|
|
|
|
git checkout branch1 &&
|
|
|
|
git tag original-branch1 &&
|
|
|
|
git rebase -i branch2 &&
|
|
|
|
test file6 = $(git diff --name-only original-branch1) &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test "$(git symbolic-ref -q HEAD)" = "refs/heads/branch1" &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev I branch2 &&
|
|
|
|
test_cmp_rev I HEAD~2
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
2007-06-25 19:58:28 +02:00
|
|
|
test_expect_success 'reflog for the branch shows state before rebase' '
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev branch1@{1} original-branch1
|
2007-06-25 19:58:28 +02:00
|
|
|
'
|
|
|
|
|
2017-06-19 19:56:03 +02:00
|
|
|
test_expect_success 'reflog for the branch shows correct finish message' '
|
2020-02-15 22:36:36 +01:00
|
|
|
printf "rebase (finish): refs/heads/branch1 onto %s\n" \
|
2017-06-19 19:56:03 +02:00
|
|
|
"$(git rev-parse branch2)" >expected &&
|
|
|
|
git log -g --pretty=%gs -1 refs/heads/branch1 >actual &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_expect_success 'exchange two commits' '
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="2 1" git rebase -i HEAD~2
|
|
|
|
) &&
|
2008-03-12 22:34:34 +01:00
|
|
|
test H = $(git cat-file commit HEAD^ | sed -ne \$p) &&
|
2019-08-18 21:16:38 +02:00
|
|
|
test G = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
blob1=$(git rev-parse --short HEAD^:file1) &&
|
|
|
|
blob2=$(git rev-parse --short HEAD:file1) &&
|
|
|
|
commit=$(git rev-parse --short HEAD)
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'stop on conflicting pick' '
|
2019-08-18 21:16:38 +02:00
|
|
|
cat >expect <<-EOF &&
|
2019-06-24 20:13:14 +02:00
|
|
|
diff --git a/file1 b/file1
|
2019-08-18 21:16:38 +02:00
|
|
|
index $blob1..$blob2 100644
|
2019-06-24 20:13:14 +02:00
|
|
|
--- a/file1
|
|
|
|
+++ b/file1
|
|
|
|
@@ -1 +1 @@
|
|
|
|
-A
|
|
|
|
+G
|
|
|
|
EOF
|
2019-08-18 21:16:38 +02:00
|
|
|
cat >expect2 <<-EOF &&
|
2019-06-24 20:13:14 +02:00
|
|
|
<<<<<<< HEAD
|
|
|
|
D
|
|
|
|
=======
|
|
|
|
G
|
sequencer: avoid garbled merge machinery messages due to commit labels
sequencer's get_message() exists to provide good labels on conflict
hunks; see commits
d68565402a ("revert: clarify label on conflict hunks", 2010-03-20)
bf975d379d ("cherry-pick, revert: add a label for ancestor", 2010-03-20)
043a4492b3 ("sequencer: factor code out of revert builtin", 2012-01-11).
for background on this function. These labels are of the form
<commitID>... <commit summary>
or
parent of <commitID>... <commit summary>
These labels are then passed as branch names to the merge machinery.
However, these labels, as formatted, often also serve to confuse. For
example, if we have a rename involved in a content merge, then it
results in text such as the following:
<<<<<<<< HEAD:foo.c
int j;
========
int counter;
>>>>>>>> b01dface... Removed unnecessary stuff:bar.c
Or in various conflict messages, it can make it very difficult to read:
CONFLICT (rename/delete): foo.c deleted in b01dface... Removed
unnecessary stuff and renamed in HEAD. Version HEAD of foo.c left
in tree.
CONFLICT (file location): dir1/foo.c added in b01dface... Removed
unnecessary stuff inside a directory that was renamed in HEAD,
suggesting it should perhaps be moved to dir2/foo.c.
Make a minor change to remove the ellipses and add parentheses around
the commit summary; this makes all three examples much easier to read:
<<<<<<<< HEAD:foo.c
int j;
========
int counter;
>>>>>>>> b01dface (Removed unnecessary stuff):bar.c
CONFLICT (rename/delete): foo.c deleted in b01dface (Removed
unnecessary stuff) and renamed in HEAD. Version HEAD of foo.c left
in tree.
CONFLICT (file location): dir1/foo.c added in b01dface (Removed
unnecessary stuff) inside a directory that was renamed in HEAD,
suggesting it should perhaps be moved to dir2/foo.c.
Signed-off-by: Elijah Newren <newren@gmail.com>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-08-12 16:40:04 +02:00
|
|
|
>>>>>>> $commit (G)
|
2019-06-24 20:13:14 +02:00
|
|
|
EOF
|
2007-06-25 02:11:14 +02:00
|
|
|
git tag new-branch1 &&
|
2020-11-24 11:15:49 +01:00
|
|
|
test_must_fail git rebase -i primary &&
|
|
|
|
test "$(git rev-parse HEAD~3)" = "$(git rev-parse primary)" &&
|
2008-07-16 03:33:44 +02:00
|
|
|
test_cmp expect .git/rebase-merge/patch &&
|
2008-03-12 22:36:36 +01:00
|
|
|
test_cmp expect2 file1 &&
|
2008-09-03 10:59:27 +02:00
|
|
|
test "$(git diff --name-status |
|
2008-06-22 01:55:50 +02:00
|
|
|
sed -n -e "/^U/s/^U[^a-z]*//p")" = file1 &&
|
2008-07-16 03:33:44 +02:00
|
|
|
test 4 = $(grep -v "^#" < .git/rebase-merge/done | wc -l) &&
|
|
|
|
test 0 = $(grep -c "^[^#]" < .git/rebase-merge/git-rebase-todo)
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
2018-02-11 10:43:27 +01:00
|
|
|
test_expect_success 'show conflicted patch' '
|
|
|
|
GIT_TRACE=1 git rebase --show-current-patch >/dev/null 2>stderr &&
|
2018-02-11 10:43:28 +01:00
|
|
|
grep "show.*REBASE_HEAD" stderr &&
|
|
|
|
# the original stopped-sha1 is abbreviated
|
|
|
|
stopped_sha1="$(git rev-parse $(cat ".git/rebase-merge/stopped-sha"))" &&
|
|
|
|
test "$(git rev-parse REBASE_HEAD)" = "$stopped_sha1"
|
2018-02-11 10:43:27 +01:00
|
|
|
'
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_expect_success 'abort' '
|
|
|
|
git rebase --abort &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev new-branch1 HEAD &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test "$(git symbolic-ref -q HEAD)" = "refs/heads/branch1" &&
|
2010-08-10 17:17:52 +02:00
|
|
|
test_path_is_missing .git/rebase-merge
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
2010-06-08 10:16:11 +02:00
|
|
|
test_expect_success 'abort with error when new base cannot be checked out' '
|
|
|
|
git rm --cached file1 &&
|
|
|
|
git commit -m "remove file in base" &&
|
2020-11-24 11:15:49 +01:00
|
|
|
test_must_fail git rebase -i primary > output 2>&1 &&
|
2016-06-17 22:21:08 +02:00
|
|
|
test_i18ngrep "The following untracked working tree files would be overwritten by checkout:" \
|
2010-06-08 10:16:11 +02:00
|
|
|
output &&
|
2016-06-17 22:21:08 +02:00
|
|
|
test_i18ngrep "file1" output &&
|
2010-08-10 17:17:52 +02:00
|
|
|
test_path_is_missing .git/rebase-merge &&
|
2010-06-08 10:16:11 +02:00
|
|
|
git reset --hard HEAD^
|
|
|
|
'
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_expect_success 'retain authorship' '
|
|
|
|
echo A > file7 &&
|
|
|
|
git add file7 &&
|
2007-06-25 19:56:55 +02:00
|
|
|
test_tick &&
|
2007-06-25 02:11:14 +02:00
|
|
|
GIT_AUTHOR_NAME="Twerp Snog" git commit -m "different author" &&
|
|
|
|
git tag twerp &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git rebase -i --onto primary HEAD^ &&
|
2007-06-25 02:11:14 +02:00
|
|
|
git show HEAD | grep "^Author: Twerp Snog"
|
|
|
|
'
|
|
|
|
|
2017-01-02 16:35:25 +01:00
|
|
|
test_expect_success 'retain authorship w/ conflicts' '
|
2018-07-12 22:07:51 +02:00
|
|
|
oGIT_AUTHOR_NAME=$GIT_AUTHOR_NAME &&
|
|
|
|
test_when_finished "GIT_AUTHOR_NAME=\$oGIT_AUTHOR_NAME" &&
|
|
|
|
|
2017-01-02 16:35:25 +01:00
|
|
|
git reset --hard twerp &&
|
|
|
|
test_commit a conflict a conflict-a &&
|
|
|
|
git reset --hard twerp &&
|
2018-07-12 22:07:51 +02:00
|
|
|
|
|
|
|
GIT_AUTHOR_NAME=AttributeMe &&
|
|
|
|
export GIT_AUTHOR_NAME &&
|
2017-01-02 16:35:25 +01:00
|
|
|
test_commit b conflict b conflict-b &&
|
2018-07-12 22:07:51 +02:00
|
|
|
GIT_AUTHOR_NAME=$oGIT_AUTHOR_NAME &&
|
|
|
|
|
2017-01-02 16:35:25 +01:00
|
|
|
test_must_fail git rebase -i conflict-a &&
|
|
|
|
echo resolved >conflict &&
|
|
|
|
git add conflict &&
|
|
|
|
git rebase --continue &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev conflict-a^0 HEAD^ &&
|
2017-01-02 16:35:25 +01:00
|
|
|
git show >out &&
|
|
|
|
grep AttributeMe out
|
|
|
|
'
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_expect_success 'squash' '
|
|
|
|
git reset --hard twerp &&
|
|
|
|
echo B > file7 &&
|
2007-06-25 19:56:55 +02:00
|
|
|
test_tick &&
|
2007-06-25 02:11:14 +02:00
|
|
|
GIT_AUTHOR_NAME="Nitfol" git commit -m "nitfol" file7 &&
|
|
|
|
echo "******************************" &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 squash 2" EXPECT_HEADER_COUNT=2 \
|
2020-11-24 11:15:49 +01:00
|
|
|
git rebase -i --onto primary HEAD~2
|
2019-10-15 12:25:28 +02:00
|
|
|
) &&
|
2007-06-25 02:11:14 +02:00
|
|
|
test B = $(cat file7) &&
|
2020-11-24 11:15:49 +01:00
|
|
|
test_cmp_rev HEAD^ primary
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'retain authorship when squashing' '
|
2007-09-30 01:34:23 +02:00
|
|
|
git show HEAD | grep "^Author: Twerp Snog"
|
2007-06-25 02:11:14 +02:00
|
|
|
'
|
|
|
|
|
2018-10-31 21:02:02 +01:00
|
|
|
test_expect_success REBASE_P '-p handles "no changes" gracefully' '
|
2007-12-17 22:01:25 +01:00
|
|
|
HEAD=$(git rev-parse HEAD) &&
|
|
|
|
git rebase -i -p HEAD^ &&
|
2008-08-13 23:41:23 +02:00
|
|
|
git update-index --refresh &&
|
|
|
|
git diff-files --quiet &&
|
|
|
|
git diff-index --quiet --cached HEAD -- &&
|
2007-12-17 22:01:25 +01:00
|
|
|
test $HEAD = $(git rev-parse HEAD)
|
|
|
|
'
|
|
|
|
|
2018-10-31 21:02:02 +01:00
|
|
|
test_expect_failure REBASE_P 'exchange two commits with -p' '
|
2012-05-19 15:14:16 +02:00
|
|
|
git checkout H &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="2 1" git rebase -i -p HEAD~2
|
|
|
|
) &&
|
2010-06-01 03:43:35 +02:00
|
|
|
test H = $(git cat-file commit HEAD^ | sed -ne \$p) &&
|
|
|
|
test G = $(git cat-file commit HEAD | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
2018-10-31 21:02:02 +01:00
|
|
|
test_expect_success REBASE_P 'preserve merges with -p' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout -b to-be-preserved primary^ &&
|
2007-06-25 19:59:43 +02:00
|
|
|
: > unrelated-file &&
|
|
|
|
git add unrelated-file &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "unrelated" &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout -b another-branch primary &&
|
2007-06-25 19:59:43 +02:00
|
|
|
echo B > file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m J file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git merge to-be-preserved &&
|
|
|
|
echo C > file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m K file1 &&
|
2008-07-12 17:47:31 +02:00
|
|
|
echo D > file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m L1 file1 &&
|
|
|
|
git checkout HEAD^ &&
|
|
|
|
echo 1 > unrelated-file &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m L2 unrelated-file &&
|
|
|
|
test_tick &&
|
|
|
|
git merge another-branch &&
|
|
|
|
echo E > file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m M file1 &&
|
|
|
|
git checkout -b to-be-rebased &&
|
2007-07-08 04:01:29 +02:00
|
|
|
test_tick &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git rebase -i -p --onto branch1 primary &&
|
2008-08-13 23:41:23 +02:00
|
|
|
git update-index --refresh &&
|
|
|
|
git diff-files --quiet &&
|
|
|
|
git diff-index --quiet --cached HEAD -- &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev HEAD~6 branch1 &&
|
|
|
|
test_cmp_rev HEAD~4^2 to-be-preserved &&
|
|
|
|
test_cmp_rev HEAD^^2^ HEAD^^^ &&
|
2008-07-12 17:47:31 +02:00
|
|
|
test $(git show HEAD~5:file1) = B &&
|
|
|
|
test $(git show HEAD~3:file1) = C &&
|
|
|
|
test $(git show HEAD:file1) = E &&
|
|
|
|
test $(git show HEAD:unrelated-file) = 1
|
2007-06-25 19:59:43 +02:00
|
|
|
'
|
|
|
|
|
2018-10-31 21:02:02 +01:00
|
|
|
test_expect_success REBASE_P 'edit ancestor with -p' '
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 2 edit 3 4" git rebase -i -p HEAD~3
|
|
|
|
) &&
|
2008-08-13 23:41:24 +02:00
|
|
|
echo 2 > unrelated-file &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m L2-modified --amend unrelated-file &&
|
|
|
|
git rebase --continue &&
|
|
|
|
git update-index --refresh &&
|
|
|
|
git diff-files --quiet &&
|
|
|
|
git diff-index --quiet --cached HEAD -- &&
|
|
|
|
test $(git show HEAD:unrelated-file) = 2
|
|
|
|
'
|
|
|
|
|
2007-07-08 04:01:29 +02:00
|
|
|
test_expect_success '--continue tries to commit' '
|
t3404: decouple some test cases from outcomes of previous test cases
Originally, the `--preserve-merges` option of the `git rebase` command
piggy-backed on top of the `--interactive` feature. For that reason, the
early test cases were added to the very same test script that contains
the `git rebase -i` tests: `t3404-rebase-interactive.sh`.
However, since c42abfe7857 (rebase: introduce a dedicated backend for
--preserve-merges, 2018-05-28), the `--preserve-merges` feature got its
own backend, in preparation for converting the rest of the
`--interactive` code to built-in code, written in C rather than shell.
The reason why the `--preserve-merges` feature was not converted at the
same time is that we have something much better now: `--rebase-merges`.
That option intends to supersede `--preserve-merges`, and we will
probably deprecate the latter soon.
Once `--preserve-merges` has been deprecated for a good amount of time,
it will be time to remove it, and along with it, its tests.
In preparation for that, let's make the rest of the test cases in
`t3404-rebase-interactive.sh` independent of the test cases dedicated to
`--preserve-merges`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-10-31 21:01:59 +01:00
|
|
|
git reset --hard D &&
|
2007-07-08 04:01:29 +02:00
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail git rebase -i --onto new-branch1 HEAD^ &&
|
|
|
|
echo resolved > file1 &&
|
|
|
|
git add file1 &&
|
|
|
|
FAKE_COMMIT_MESSAGE="chouette!" git rebase --continue
|
|
|
|
) &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev HEAD^ new-branch1 &&
|
2007-07-08 04:01:29 +02:00
|
|
|
git show HEAD | grep chouette
|
|
|
|
'
|
|
|
|
|
2007-07-08 04:02:47 +02:00
|
|
|
test_expect_success 'verbose flag is heeded, even after --continue' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git reset --hard primary@{1} &&
|
2007-07-08 04:02:47 +02:00
|
|
|
test_tick &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test_must_fail git rebase -v -i --onto new-branch1 HEAD^ &&
|
2007-07-08 04:02:47 +02:00
|
|
|
echo resolved > file1 &&
|
|
|
|
git add file1 &&
|
|
|
|
git rebase --continue > output &&
|
2012-04-30 22:38:58 +02:00
|
|
|
grep "^ file1 | 2 +-$" output
|
2007-07-08 04:02:47 +02:00
|
|
|
'
|
|
|
|
|
2021-02-11 02:53:51 +01:00
|
|
|
test_expect_success 'multi-squash only fires up editor once' '
|
2007-07-21 19:09:41 +02:00
|
|
|
base=$(git rev-parse HEAD~4) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_COMMIT_AMEND="ONCE" \
|
|
|
|
FAKE_LINES="1 squash 2 squash 3 squash 4" \
|
|
|
|
EXPECT_HEADER_COUNT=4 \
|
|
|
|
git rebase -i $base
|
|
|
|
) &&
|
2007-07-21 19:09:41 +02:00
|
|
|
test $base = $(git rev-parse HEAD^) &&
|
|
|
|
test 1 = $(git show | grep ONCE | wc -l)
|
|
|
|
'
|
|
|
|
|
2021-02-11 02:53:51 +01:00
|
|
|
test_expect_success 'multi-fixup does not fire up editor' '
|
2009-12-07 10:20:59 +01:00
|
|
|
git checkout -b multi-fixup E &&
|
|
|
|
base=$(git rev-parse HEAD~4) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_COMMIT_AMEND="NEVER" \
|
|
|
|
FAKE_LINES="1 fixup 2 fixup 3 fixup 4" \
|
|
|
|
git rebase -i $base
|
|
|
|
) &&
|
2009-12-07 10:20:59 +01:00
|
|
|
test $base = $(git rev-parse HEAD^) &&
|
2010-01-14 06:54:55 +01:00
|
|
|
test 0 = $(git show | grep NEVER | wc -l) &&
|
t3404: decouple some test cases from outcomes of previous test cases
Originally, the `--preserve-merges` option of the `git rebase` command
piggy-backed on top of the `--interactive` feature. For that reason, the
early test cases were added to the very same test script that contains
the `git rebase -i` tests: `t3404-rebase-interactive.sh`.
However, since c42abfe7857 (rebase: introduce a dedicated backend for
--preserve-merges, 2018-05-28), the `--preserve-merges` feature got its
own backend, in preparation for converting the rest of the
`--interactive` code to built-in code, written in C rather than shell.
The reason why the `--preserve-merges` feature was not converted at the
same time is that we have something much better now: `--rebase-merges`.
That option intends to supersede `--preserve-merges`, and we will
probably deprecate the latter soon.
Once `--preserve-merges` has been deprecated for a good amount of time,
it will be time to remove it, and along with it, its tests.
In preparation for that, let's make the rest of the test cases in
`t3404-rebase-interactive.sh` independent of the test cases dedicated to
`--preserve-merges`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-10-31 21:01:59 +01:00
|
|
|
git checkout @{-1} &&
|
2009-12-07 10:20:59 +01:00
|
|
|
git branch -D multi-fixup
|
|
|
|
'
|
|
|
|
|
2010-01-14 06:54:57 +01:00
|
|
|
test_expect_success 'commit message used after conflict' '
|
|
|
|
git checkout -b conflict-fixup conflict-branch &&
|
|
|
|
base=$(git rev-parse HEAD~4) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 fixup 3 fixup 4" \
|
|
|
|
git rebase -i $base &&
|
|
|
|
echo three > conflict &&
|
|
|
|
git add conflict &&
|
|
|
|
FAKE_COMMIT_AMEND="ONCE" EXPECT_HEADER_COUNT=2 \
|
|
|
|
git rebase --continue
|
|
|
|
) &&
|
2010-01-14 06:54:57 +01:00
|
|
|
test $base = $(git rev-parse HEAD^) &&
|
|
|
|
test 1 = $(git show | grep ONCE | wc -l) &&
|
t3404: decouple some test cases from outcomes of previous test cases
Originally, the `--preserve-merges` option of the `git rebase` command
piggy-backed on top of the `--interactive` feature. For that reason, the
early test cases were added to the very same test script that contains
the `git rebase -i` tests: `t3404-rebase-interactive.sh`.
However, since c42abfe7857 (rebase: introduce a dedicated backend for
--preserve-merges, 2018-05-28), the `--preserve-merges` feature got its
own backend, in preparation for converting the rest of the
`--interactive` code to built-in code, written in C rather than shell.
The reason why the `--preserve-merges` feature was not converted at the
same time is that we have something much better now: `--rebase-merges`.
That option intends to supersede `--preserve-merges`, and we will
probably deprecate the latter soon.
Once `--preserve-merges` has been deprecated for a good amount of time,
it will be time to remove it, and along with it, its tests.
In preparation for that, let's make the rest of the test cases in
`t3404-rebase-interactive.sh` independent of the test cases dedicated to
`--preserve-merges`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-10-31 21:01:59 +01:00
|
|
|
git checkout @{-1} &&
|
2010-01-14 06:54:57 +01:00
|
|
|
git branch -D conflict-fixup
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'commit message retained after conflict' '
|
|
|
|
git checkout -b conflict-squash conflict-branch &&
|
|
|
|
base=$(git rev-parse HEAD~4) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 fixup 3 squash 4" \
|
|
|
|
git rebase -i $base &&
|
|
|
|
echo three > conflict &&
|
|
|
|
git add conflict &&
|
|
|
|
FAKE_COMMIT_AMEND="TWICE" EXPECT_HEADER_COUNT=2 \
|
|
|
|
git rebase --continue
|
|
|
|
) &&
|
2010-01-14 06:54:57 +01:00
|
|
|
test $base = $(git rev-parse HEAD^) &&
|
|
|
|
test 2 = $(git show | grep TWICE | wc -l) &&
|
t3404: decouple some test cases from outcomes of previous test cases
Originally, the `--preserve-merges` option of the `git rebase` command
piggy-backed on top of the `--interactive` feature. For that reason, the
early test cases were added to the very same test script that contains
the `git rebase -i` tests: `t3404-rebase-interactive.sh`.
However, since c42abfe7857 (rebase: introduce a dedicated backend for
--preserve-merges, 2018-05-28), the `--preserve-merges` feature got its
own backend, in preparation for converting the rest of the
`--interactive` code to built-in code, written in C rather than shell.
The reason why the `--preserve-merges` feature was not converted at the
same time is that we have something much better now: `--rebase-merges`.
That option intends to supersede `--preserve-merges`, and we will
probably deprecate the latter soon.
Once `--preserve-merges` has been deprecated for a good amount of time,
it will be time to remove it, and along with it, its tests.
In preparation for that, let's make the rest of the test cases in
`t3404-rebase-interactive.sh` independent of the test cases dedicated to
`--preserve-merges`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-10-31 21:01:59 +01:00
|
|
|
git checkout @{-1} &&
|
2010-01-14 06:54:57 +01:00
|
|
|
git branch -D conflict-squash
|
|
|
|
'
|
|
|
|
|
2021-02-11 02:53:51 +01:00
|
|
|
test_expect_success 'squash and fixup generate correct log messages' '
|
2019-06-24 20:13:14 +02:00
|
|
|
cat >expect-squash-fixup <<-\EOF &&
|
|
|
|
B
|
2009-12-07 10:20:59 +01:00
|
|
|
|
2019-06-24 20:13:14 +02:00
|
|
|
D
|
2009-12-07 10:20:59 +01:00
|
|
|
|
2019-06-24 20:13:14 +02:00
|
|
|
ONCE
|
|
|
|
EOF
|
2009-12-07 10:20:59 +01:00
|
|
|
git checkout -b squash-fixup E &&
|
|
|
|
base=$(git rev-parse HEAD~4) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_COMMIT_AMEND="ONCE" \
|
|
|
|
FAKE_LINES="1 fixup 2 squash 3 fixup 4" \
|
|
|
|
EXPECT_HEADER_COUNT=4 \
|
|
|
|
git rebase -i $base
|
|
|
|
) &&
|
2009-12-07 10:20:59 +01:00
|
|
|
git cat-file commit HEAD | sed -e 1,/^\$/d > actual-squash-fixup &&
|
|
|
|
test_cmp expect-squash-fixup actual-squash-fixup &&
|
2017-11-10 12:09:41 +01:00
|
|
|
git cat-file commit HEAD@{2} |
|
|
|
|
grep "^# This is a combination of 3 commits\." &&
|
|
|
|
git cat-file commit HEAD@{3} |
|
|
|
|
grep "^# This is a combination of 2 commits\." &&
|
t3404: decouple some test cases from outcomes of previous test cases
Originally, the `--preserve-merges` option of the `git rebase` command
piggy-backed on top of the `--interactive` feature. For that reason, the
early test cases were added to the very same test script that contains
the `git rebase -i` tests: `t3404-rebase-interactive.sh`.
However, since c42abfe7857 (rebase: introduce a dedicated backend for
--preserve-merges, 2018-05-28), the `--preserve-merges` feature got its
own backend, in preparation for converting the rest of the
`--interactive` code to built-in code, written in C rather than shell.
The reason why the `--preserve-merges` feature was not converted at the
same time is that we have something much better now: `--rebase-merges`.
That option intends to supersede `--preserve-merges`, and we will
probably deprecate the latter soon.
Once `--preserve-merges` has been deprecated for a good amount of time,
it will be time to remove it, and along with it, its tests.
In preparation for that, let's make the rest of the test cases in
`t3404-rebase-interactive.sh` independent of the test cases dedicated to
`--preserve-merges`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-10-31 21:01:59 +01:00
|
|
|
git checkout @{-1} &&
|
2009-12-07 10:20:59 +01:00
|
|
|
git branch -D squash-fixup
|
|
|
|
'
|
|
|
|
|
2021-02-11 02:53:51 +01:00
|
|
|
test_expect_success 'squash ignores comments' '
|
2010-01-12 16:38:36 +01:00
|
|
|
git checkout -b skip-comments E &&
|
|
|
|
base=$(git rev-parse HEAD~4) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_COMMIT_AMEND="ONCE" \
|
|
|
|
FAKE_LINES="# 1 # squash 2 # squash 3 # squash 4 #" \
|
|
|
|
EXPECT_HEADER_COUNT=4 \
|
|
|
|
git rebase -i $base
|
|
|
|
) &&
|
2010-01-12 16:38:36 +01:00
|
|
|
test $base = $(git rev-parse HEAD^) &&
|
|
|
|
test 1 = $(git show | grep ONCE | wc -l) &&
|
t3404: decouple some test cases from outcomes of previous test cases
Originally, the `--preserve-merges` option of the `git rebase` command
piggy-backed on top of the `--interactive` feature. For that reason, the
early test cases were added to the very same test script that contains
the `git rebase -i` tests: `t3404-rebase-interactive.sh`.
However, since c42abfe7857 (rebase: introduce a dedicated backend for
--preserve-merges, 2018-05-28), the `--preserve-merges` feature got its
own backend, in preparation for converting the rest of the
`--interactive` code to built-in code, written in C rather than shell.
The reason why the `--preserve-merges` feature was not converted at the
same time is that we have something much better now: `--rebase-merges`.
That option intends to supersede `--preserve-merges`, and we will
probably deprecate the latter soon.
Once `--preserve-merges` has been deprecated for a good amount of time,
it will be time to remove it, and along with it, its tests.
In preparation for that, let's make the rest of the test cases in
`t3404-rebase-interactive.sh` independent of the test cases dedicated to
`--preserve-merges`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-10-31 21:01:59 +01:00
|
|
|
git checkout @{-1} &&
|
2010-01-12 16:38:36 +01:00
|
|
|
git branch -D skip-comments
|
|
|
|
'
|
|
|
|
|
2021-02-11 02:53:51 +01:00
|
|
|
test_expect_success 'squash ignores blank lines' '
|
2010-01-12 16:38:36 +01:00
|
|
|
git checkout -b skip-blank-lines E &&
|
|
|
|
base=$(git rev-parse HEAD~4) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_COMMIT_AMEND="ONCE" \
|
|
|
|
FAKE_LINES="> 1 > squash 2 > squash 3 > squash 4 >" \
|
|
|
|
EXPECT_HEADER_COUNT=4 \
|
|
|
|
git rebase -i $base
|
|
|
|
) &&
|
2010-01-12 16:38:36 +01:00
|
|
|
test $base = $(git rev-parse HEAD^) &&
|
|
|
|
test 1 = $(git show | grep ONCE | wc -l) &&
|
t3404: decouple some test cases from outcomes of previous test cases
Originally, the `--preserve-merges` option of the `git rebase` command
piggy-backed on top of the `--interactive` feature. For that reason, the
early test cases were added to the very same test script that contains
the `git rebase -i` tests: `t3404-rebase-interactive.sh`.
However, since c42abfe7857 (rebase: introduce a dedicated backend for
--preserve-merges, 2018-05-28), the `--preserve-merges` feature got its
own backend, in preparation for converting the rest of the
`--interactive` code to built-in code, written in C rather than shell.
The reason why the `--preserve-merges` feature was not converted at the
same time is that we have something much better now: `--rebase-merges`.
That option intends to supersede `--preserve-merges`, and we will
probably deprecate the latter soon.
Once `--preserve-merges` has been deprecated for a good amount of time,
it will be time to remove it, and along with it, its tests.
In preparation for that, let's make the rest of the test cases in
`t3404-rebase-interactive.sh` independent of the test cases dedicated to
`--preserve-merges`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-10-31 21:01:59 +01:00
|
|
|
git checkout @{-1} &&
|
2010-01-12 16:38:36 +01:00
|
|
|
git branch -D skip-blank-lines
|
|
|
|
'
|
|
|
|
|
2007-07-24 22:43:09 +02:00
|
|
|
test_expect_success 'squash works as expected' '
|
2010-01-14 06:54:56 +01:00
|
|
|
git checkout -b squash-works no-conflict-branch &&
|
2007-07-24 22:43:09 +02:00
|
|
|
one=$(git rev-parse HEAD~3) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 s 3 2" EXPECT_HEADER_COUNT=2 git rebase -i HEAD~3
|
|
|
|
) &&
|
2007-07-24 22:43:09 +02:00
|
|
|
test $one = $(git rev-parse HEAD~2)
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'interrupted squash works as expected' '
|
2010-01-14 06:54:56 +01:00
|
|
|
git checkout -b interrupted-squash conflict-branch &&
|
2007-07-24 22:43:09 +02:00
|
|
|
one=$(git rev-parse HEAD~3) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 squash 3 2" \
|
|
|
|
git rebase -i HEAD~3
|
|
|
|
) &&
|
2018-07-02 02:23:42 +02:00
|
|
|
test_write_lines one two four > conflict &&
|
2007-07-24 22:43:09 +02:00
|
|
|
git add conflict &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test_must_fail git rebase --continue &&
|
2007-07-24 22:43:09 +02:00
|
|
|
echo resolved > conflict &&
|
|
|
|
git add conflict &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test $one = $(git rev-parse HEAD~2)
|
|
|
|
'
|
|
|
|
|
2007-08-23 10:55:41 +02:00
|
|
|
test_expect_success 'interrupted squash works as expected (case 2)' '
|
2010-01-14 06:54:56 +01:00
|
|
|
git checkout -b interrupted-squash2 conflict-branch &&
|
2007-08-23 10:55:41 +02:00
|
|
|
one=$(git rev-parse HEAD~3) &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="3 squash 1 2" \
|
|
|
|
git rebase -i HEAD~3
|
|
|
|
) &&
|
2018-07-02 02:23:42 +02:00
|
|
|
test_write_lines one four > conflict &&
|
2007-08-23 10:55:41 +02:00
|
|
|
git add conflict &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test_must_fail git rebase --continue &&
|
2018-07-02 02:23:42 +02:00
|
|
|
test_write_lines one two four > conflict &&
|
2007-08-23 10:55:41 +02:00
|
|
|
git add conflict &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test_must_fail git rebase --continue &&
|
2007-08-23 10:55:41 +02:00
|
|
|
echo resolved > conflict &&
|
|
|
|
git add conflict &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test $one = $(git rev-parse HEAD~2)
|
|
|
|
'
|
|
|
|
|
2013-06-07 08:11:41 +02:00
|
|
|
test_expect_success '--continue tries to commit, even for "edit"' '
|
2007-08-01 16:59:35 +02:00
|
|
|
echo unrelated > file7 &&
|
|
|
|
git add file7 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "unrelated change" &&
|
2007-09-25 17:42:36 +02:00
|
|
|
parent=$(git rev-parse HEAD^) &&
|
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1" git rebase -i HEAD^ &&
|
|
|
|
echo edited > file7 &&
|
|
|
|
git add file7 &&
|
|
|
|
FAKE_COMMIT_MESSAGE="chouette!" git rebase --continue
|
|
|
|
) &&
|
2007-09-25 17:42:36 +02:00
|
|
|
test edited = $(git show HEAD:file7) &&
|
|
|
|
git show HEAD | grep chouette &&
|
|
|
|
test $parent = $(git rev-parse HEAD^)
|
|
|
|
'
|
|
|
|
|
2009-01-15 13:56:15 +01:00
|
|
|
test_expect_success 'aborted --continue does not squash commits after "edit"' '
|
|
|
|
old=$(git rev-parse HEAD) &&
|
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1" git rebase -i HEAD^ &&
|
|
|
|
echo "edited again" > file7 &&
|
|
|
|
git add file7 &&
|
|
|
|
test_must_fail env FAKE_COMMIT_MESSAGE=" " git rebase --continue
|
|
|
|
) &&
|
sequencer: fix --allow-empty-message behavior, make it smarter
In commit b00bf1c9a8dd ("git-rebase: make --allow-empty-message the
default", 2018-06-27), several arguments were given for transplanting
empty commits without halting and asking the user for confirmation on
each commit. These arguments were incomplete because the logic clearly
assumed the only cases under consideration were transplanting of commits
with empty messages (see the comment about "There are two sources for
commits with empty messages). It didn't discuss or even consider
rewords, squashes, etc. where the user is explicitly asked for a new
commit message and provides an empty one. (My bad, I totally should
have thought about that at the time, but just didn't.)
Rewords and squashes are significantly different, though, as described
by SZEDER:
Let's suppose you start an interactive rebase, choose a commit to
squash, save the instruction sheet, rebase fires up your editor, and
then you notice that you mistakenly chose the wrong commit to
squash. What do you do, how do you abort?
Before [that commit] you could clear the commit message, exit the
editor, and then rebase would say "Aborting commit due to empty
commit message.", and you get to run 'git rebase --abort', and start
over.
But [since that commit, ...] saving the commit message as is would
let rebase continue and create a bunch of unnecessary objects, and
then you would have to use the reflog to return to the pre-rebase
state.
Also, he states:
The instructions in the commit message template, which is shown for
'reword' and 'squash', too, still say...
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
These are sound arguments that when editing commit messages during a
sequencer operation, that if the commit message is empty then the
operation should halt and ask the user to correct. The arguments in
commit b00bf1c9a8dd (referenced above) still apply when transplanting
previously created commits with empty commit messages, so the sequencer
should not halt for those.
Furthermore, all rationale so far applies equally for cherry-pick as for
rebase. Therefore, make the code default to --allow-empty-message when
transplanting an existing commit, and to default to halting when the
user is asked to edit a commit message and provides an empty one -- for
both rebase and cherry-pick.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-09-12 23:18:48 +02:00
|
|
|
test $old = $(git rev-parse HEAD) &&
|
|
|
|
git rebase --abort
|
2009-01-15 13:56:15 +01:00
|
|
|
'
|
|
|
|
|
2009-01-15 13:56:16 +01:00
|
|
|
test_expect_success 'auto-amend only edited commits after "edit"' '
|
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1" git rebase -i HEAD^ &&
|
|
|
|
echo "edited again" > file7 &&
|
|
|
|
git add file7 &&
|
|
|
|
FAKE_COMMIT_MESSAGE="edited file7 again" git commit &&
|
|
|
|
echo "and again" > file7 &&
|
|
|
|
git add file7 &&
|
|
|
|
test_tick &&
|
|
|
|
test_must_fail env FAKE_COMMIT_MESSAGE="and again" \
|
|
|
|
git rebase --continue
|
|
|
|
) &&
|
2009-01-15 13:56:16 +01:00
|
|
|
git rebase --abort
|
|
|
|
'
|
|
|
|
|
2011-08-24 16:01:48 +02:00
|
|
|
test_expect_success 'clean error after failed "exec"' '
|
|
|
|
test_tick &&
|
|
|
|
test_when_finished "git rebase --abort || :" &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 exec_false" git rebase -i HEAD^
|
|
|
|
) &&
|
2011-08-24 16:01:48 +02:00
|
|
|
echo "edited again" > file7 &&
|
|
|
|
git add file7 &&
|
|
|
|
test_must_fail git rebase --continue 2>error &&
|
2017-02-09 23:23:11 +01:00
|
|
|
test_i18ngrep "you have staged changes in your working tree" error
|
2011-08-24 16:01:48 +02:00
|
|
|
'
|
|
|
|
|
2007-09-25 17:43:15 +02:00
|
|
|
test_expect_success 'rebase a detached HEAD' '
|
|
|
|
grandparent=$(git rev-parse HEAD~2) &&
|
|
|
|
git checkout $(git rev-parse HEAD) &&
|
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="2 1" git rebase -i HEAD~2
|
|
|
|
) &&
|
2007-09-25 17:43:15 +02:00
|
|
|
test $grandparent = $(git rev-parse HEAD~2)
|
|
|
|
'
|
|
|
|
|
2008-01-28 17:33:28 +01:00
|
|
|
test_expect_success 'rebase a commit violating pre-commit' '
|
|
|
|
|
|
|
|
mkdir -p .git/hooks &&
|
2016-04-12 18:59:59 +02:00
|
|
|
write_script .git/hooks/pre-commit <<-\EOF &&
|
|
|
|
test -z "$(git diff --cached --check)"
|
|
|
|
EOF
|
2008-01-28 17:33:28 +01:00
|
|
|
echo "monde! " >> file1 &&
|
|
|
|
test_tick &&
|
2008-06-22 01:55:50 +02:00
|
|
|
test_must_fail git commit -m doesnt-verify file1 &&
|
2008-01-28 17:33:28 +01:00
|
|
|
git commit -m doesnt-verify --no-verify file1 &&
|
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES=2 git rebase -i HEAD~2
|
|
|
|
)
|
2008-01-28 17:33:28 +01:00
|
|
|
'
|
|
|
|
|
2008-02-13 22:13:21 +01:00
|
|
|
test_expect_success 'rebase with a file named HEAD in worktree' '
|
|
|
|
|
|
|
|
rm -fr .git/hooks &&
|
|
|
|
git reset --hard &&
|
|
|
|
git checkout -b branch3 A &&
|
|
|
|
|
|
|
|
(
|
|
|
|
GIT_AUTHOR_NAME="Squashed Away" &&
|
|
|
|
export GIT_AUTHOR_NAME &&
|
|
|
|
>HEAD &&
|
|
|
|
git add HEAD &&
|
|
|
|
git commit -m "Add head" &&
|
|
|
|
>BODY &&
|
|
|
|
git add BODY &&
|
|
|
|
git commit -m "Add body"
|
|
|
|
) &&
|
|
|
|
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 squash 2" git rebase -i @{-1}
|
|
|
|
) &&
|
2008-02-13 22:13:21 +01:00
|
|
|
test "$(git show -s --pretty=format:%an)" = "Squashed Away"
|
|
|
|
|
|
|
|
'
|
|
|
|
|
2008-10-10 13:42:12 +02:00
|
|
|
test_expect_success 'do "noop" when there is nothing to cherry-pick' '
|
|
|
|
|
|
|
|
git checkout -b branch4 HEAD &&
|
|
|
|
GIT_EDITOR=: git commit --amend \
|
2010-10-31 08:30:58 +01:00
|
|
|
--author="Somebody else <somebody@else.com>" &&
|
2008-10-10 13:42:12 +02:00
|
|
|
test $(git rev-parse branch3) != $(git rev-parse branch4) &&
|
|
|
|
git rebase -i branch3 &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev branch3 branch4
|
2008-10-10 13:42:12 +02:00
|
|
|
|
|
|
|
'
|
|
|
|
|
2009-01-27 10:07:31 +01:00
|
|
|
test_expect_success 'submodule rebase setup' '
|
|
|
|
git checkout A &&
|
|
|
|
mkdir sub &&
|
|
|
|
(
|
|
|
|
cd sub && git init && >elif &&
|
|
|
|
git add elif && git commit -m "submodule initial"
|
|
|
|
) &&
|
|
|
|
echo 1 >file1 &&
|
2010-10-31 08:30:58 +01:00
|
|
|
git add file1 sub &&
|
2009-01-27 10:07:31 +01:00
|
|
|
test_tick &&
|
|
|
|
git commit -m "One" &&
|
|
|
|
echo 2 >file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -a -m "Two" &&
|
|
|
|
(
|
|
|
|
cd sub && echo 3 >elif &&
|
|
|
|
git commit -a -m "submodule second"
|
|
|
|
) &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -a -m "Three changes submodule"
|
|
|
|
'
|
|
|
|
|
2009-01-27 12:42:31 +01:00
|
|
|
test_expect_success 'submodule rebase -i' '
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 squash 2 3" git rebase -i A
|
|
|
|
)
|
2009-01-27 10:07:31 +01:00
|
|
|
'
|
|
|
|
|
2012-04-07 12:20:53 +02:00
|
|
|
test_expect_success 'submodule conflict setup' '
|
|
|
|
git tag submodule-base &&
|
|
|
|
git checkout HEAD^ &&
|
|
|
|
(
|
|
|
|
cd sub && git checkout HEAD^ && echo 4 >elif &&
|
|
|
|
git add elif && git commit -m "submodule conflict"
|
|
|
|
) &&
|
|
|
|
git add sub &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "Conflict in submodule" &&
|
|
|
|
git tag submodule-topic
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i continue with only submodule staged' '
|
|
|
|
test_must_fail git rebase -i submodule-base &&
|
|
|
|
git add sub &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test $(git rev-parse submodule-base) != $(git rev-parse HEAD)
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i continue with unstaged submodule' '
|
|
|
|
git checkout submodule-topic &&
|
|
|
|
git reset --hard &&
|
|
|
|
test_must_fail git rebase -i submodule-base &&
|
|
|
|
git reset &&
|
|
|
|
git rebase --continue &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev submodule-base HEAD
|
2012-04-07 12:20:53 +02:00
|
|
|
'
|
|
|
|
|
2009-03-03 10:55:31 +01:00
|
|
|
test_expect_success 'avoid unnecessary reset' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2012-04-07 12:20:53 +02:00
|
|
|
git reset --hard &&
|
2018-03-24 08:44:31 +01:00
|
|
|
test-tool chmtime =123456789 file3 &&
|
2009-03-03 10:55:31 +01:00
|
|
|
git update-index --refresh &&
|
|
|
|
HEAD=$(git rev-parse HEAD) &&
|
|
|
|
git rebase -i HEAD~4 &&
|
|
|
|
test $HEAD = $(git rev-parse HEAD) &&
|
2018-04-25 06:29:00 +02:00
|
|
|
MTIME=$(test-tool chmtime --get file3) &&
|
2009-03-03 10:55:31 +01:00
|
|
|
test 123456789 = $MTIME
|
|
|
|
'
|
|
|
|
|
2009-10-07 08:13:23 +02:00
|
|
|
test_expect_success 'reword' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout -b reword-branch primary &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 2 3 reword 4" FAKE_COMMIT_MESSAGE="E changed" \
|
|
|
|
git rebase -i A &&
|
|
|
|
git show HEAD | grep "E changed" &&
|
2020-11-24 11:15:49 +01:00
|
|
|
test $(git rev-parse primary) != $(git rev-parse HEAD) &&
|
|
|
|
test_cmp_rev primary^ HEAD^ &&
|
2019-10-15 12:25:28 +02:00
|
|
|
FAKE_LINES="1 2 reword 3 4" FAKE_COMMIT_MESSAGE="D changed" \
|
|
|
|
git rebase -i A &&
|
|
|
|
git show HEAD^ | grep "D changed" &&
|
|
|
|
FAKE_LINES="reword 1 2 3 4" FAKE_COMMIT_MESSAGE="B changed" \
|
|
|
|
git rebase -i A &&
|
|
|
|
git show HEAD~3 | grep "B changed" &&
|
|
|
|
FAKE_LINES="1 r 2 pick 3 p 4" FAKE_COMMIT_MESSAGE="C changed" \
|
|
|
|
git rebase -i A
|
|
|
|
) &&
|
2009-10-07 08:13:23 +02:00
|
|
|
git show HEAD~2 | grep "C changed"
|
|
|
|
'
|
|
|
|
|
2021-08-20 17:40:36 +02:00
|
|
|
test_expect_success 'no uncommited changes when rewording the todo list is reloaded' '
|
|
|
|
git checkout E &&
|
|
|
|
test_when_finished "git checkout @{-1}" &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
GIT_SEQUENCE_EDITOR="\"$PWD/fake-editor.sh\"" &&
|
|
|
|
export GIT_SEQUENCE_EDITOR &&
|
|
|
|
set_reword_editor &&
|
|
|
|
FAKE_LINES="reword 1 reword 2" git rebase -i C
|
|
|
|
) &&
|
|
|
|
check_reworded_commits D E
|
|
|
|
'
|
|
|
|
|
2010-03-12 18:04:33 +01:00
|
|
|
test_expect_success 'rebase -i can copy notes' '
|
|
|
|
git config notes.rewrite.rebase true &&
|
|
|
|
git config notes.rewriteRef "refs/notes/*" &&
|
|
|
|
test_commit n1 &&
|
|
|
|
test_commit n2 &&
|
|
|
|
test_commit n3 &&
|
|
|
|
git notes add -m"a note" n3 &&
|
2013-05-28 14:54:31 +02:00
|
|
|
git rebase -i --onto n1 n2 &&
|
2010-03-12 18:04:33 +01:00
|
|
|
test "a note" = "$(git notes show HEAD)"
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i can copy notes over a fixup' '
|
2019-06-24 20:13:14 +02:00
|
|
|
cat >expect <<-\EOF &&
|
|
|
|
an earlier note
|
|
|
|
|
|
|
|
a note
|
|
|
|
EOF
|
2010-03-12 18:04:33 +01:00
|
|
|
git reset --hard n3 &&
|
|
|
|
git notes add -m"an earlier note" n2 &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
GIT_NOTES_REWRITE_MODE=concatenate FAKE_LINES="1 f 2" \
|
|
|
|
git rebase -i n1
|
|
|
|
) &&
|
2010-03-12 18:04:33 +01:00
|
|
|
git notes show > output &&
|
|
|
|
test_cmp expect output
|
|
|
|
'
|
|
|
|
|
2010-03-15 05:48:22 +01:00
|
|
|
test_expect_success 'rebase while detaching HEAD' '
|
|
|
|
git symbolic-ref HEAD &&
|
|
|
|
grandparent=$(git rev-parse HEAD~2) &&
|
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="2 1" git rebase -i HEAD~2 HEAD^0
|
|
|
|
) &&
|
2010-03-15 05:48:22 +01:00
|
|
|
test $grandparent = $(git rev-parse HEAD~2) &&
|
|
|
|
test_must_fail git symbolic-ref HEAD
|
|
|
|
'
|
|
|
|
|
2010-03-24 21:34:04 +01:00
|
|
|
test_tick # Ensure that the rebased commits get a different timestamp.
|
|
|
|
test_expect_success 'always cherry-pick with --no-ff' '
|
|
|
|
git checkout no-ff-branch &&
|
|
|
|
git tag original-no-ff-branch &&
|
|
|
|
git rebase -i --no-ff A &&
|
|
|
|
for p in 0 1 2
|
|
|
|
do
|
|
|
|
test ! $(git rev-parse HEAD~$p) = $(git rev-parse original-no-ff-branch~$p) &&
|
|
|
|
git diff HEAD~$p original-no-ff-branch~$p > out &&
|
tests: use 'test_must_be_empty' instead of 'test_cmp <empty> <out>'
Using 'test_must_be_empty' is shorter and more idiomatic than
>empty &&
test_cmp empty out
as it saves the creation of an empty file. Furthermore, sometimes the
expected empty file doesn't have such a descriptive name like 'empty',
and its creation is far away from the place where it's finally used
for comparison (e.g. in 't7600-merge.sh', where two expected empty
files are created in the 'setup' test, but are used only about 500
lines later).
These cases were found by instrumenting 'test_cmp' to error out the
test script when it's used to compare empty files, and then converted
manually.
Note that even after this patch there still remain a lot of cases
where we use 'test_cmp' to check empty files:
- Sometimes the expected output is not hard-coded in the test, but
'test_cmp' is used to ensure that two similar git commands produce
the same output, and that output happens to be empty, e.g. the
test 'submodule update --merge - ignores --merge for new
submodules' in 't7406-submodule-update.sh'.
- Repetitive common tasks, including preparing the expected results
and running 'test_cmp', are often extracted into a helper
function, and some of this helper's callsites expect no output.
- For the same reason as above, the whole 'test_expect_success'
block is within a helper function, e.g. in 't3070-wildmatch.sh'.
- Or 'test_cmp' is invoked in a loop, e.g. the test 'cvs update
(-p)' in 't9400-git-cvsserver-server.sh'.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-08-19 23:57:25 +02:00
|
|
|
test_must_be_empty out
|
2010-03-24 21:34:04 +01:00
|
|
|
done &&
|
2019-12-06 17:06:06 +01:00
|
|
|
test_cmp_rev HEAD~3 original-no-ff-branch~3 &&
|
2010-03-24 21:34:04 +01:00
|
|
|
git diff HEAD~3 original-no-ff-branch~3 > out &&
|
tests: use 'test_must_be_empty' instead of 'test_cmp <empty> <out>'
Using 'test_must_be_empty' is shorter and more idiomatic than
>empty &&
test_cmp empty out
as it saves the creation of an empty file. Furthermore, sometimes the
expected empty file doesn't have such a descriptive name like 'empty',
and its creation is far away from the place where it's finally used
for comparison (e.g. in 't7600-merge.sh', where two expected empty
files are created in the 'setup' test, but are used only about 500
lines later).
These cases were found by instrumenting 'test_cmp' to error out the
test script when it's used to compare empty files, and then converted
manually.
Note that even after this patch there still remain a lot of cases
where we use 'test_cmp' to check empty files:
- Sometimes the expected output is not hard-coded in the test, but
'test_cmp' is used to ensure that two similar git commands produce
the same output, and that output happens to be empty, e.g. the
test 'submodule update --merge - ignores --merge for new
submodules' in 't7406-submodule-update.sh'.
- Repetitive common tasks, including preparing the expected results
and running 'test_cmp', are often extracted into a helper
function, and some of this helper's callsites expect no output.
- For the same reason as above, the whole 'test_expect_success'
block is within a helper function, e.g. in 't3070-wildmatch.sh'.
- Or 'test_cmp' is invoked in a loop, e.g. the test 'cvs update
(-p)' in 't9400-git-cvsserver-server.sh'.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-08-19 23:57:25 +02:00
|
|
|
test_must_be_empty out
|
2010-03-24 21:34:04 +01:00
|
|
|
'
|
|
|
|
|
2010-07-06 08:08:36 +02:00
|
|
|
test_expect_success 'set up commits with funny messages' '
|
|
|
|
git checkout -b funny A &&
|
|
|
|
echo >>file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -a -m "end with slash\\" &&
|
|
|
|
echo >>file1 &&
|
|
|
|
test_tick &&
|
2010-07-22 21:15:11 +02:00
|
|
|
git commit -a -m "something (\000) that looks like octal" &&
|
|
|
|
echo >>file1 &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -a -m "something (\n) that looks like a newline" &&
|
|
|
|
echo >>file1 &&
|
|
|
|
test_tick &&
|
2010-07-06 08:08:36 +02:00
|
|
|
git commit -a -m "another commit"
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase-i history with funny messages' '
|
|
|
|
git rev-list A..funny >expect &&
|
|
|
|
test_tick &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 2 3 4" git rebase -i A
|
|
|
|
) &&
|
2010-07-06 08:08:36 +02:00
|
|
|
git rev-list A.. >actual &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
2012-06-12 10:05:12 +02:00
|
|
|
test_expect_success 'prepare for rebase -i --exec' '
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2012-06-12 10:05:12 +02:00
|
|
|
git checkout -b execute &&
|
|
|
|
test_commit one_exec main.txt one_exec &&
|
|
|
|
test_commit two_exec main.txt two_exec &&
|
|
|
|
test_commit three_exec main.txt three_exec
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'running "git rebase -i --exec git show HEAD"' '
|
|
|
|
(
|
2019-10-15 12:25:28 +02:00
|
|
|
set_fake_editor &&
|
|
|
|
git rebase -i --exec "git show HEAD" HEAD~2 >actual &&
|
2012-06-12 10:05:12 +02:00
|
|
|
FAKE_LINES="1 exec_git_show_HEAD 2 exec_git_show_HEAD" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
git rebase -i HEAD~2 >expect
|
|
|
|
) &&
|
|
|
|
sed -e "1,9d" expect >expected &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'running "git rebase --exec git show HEAD -i"' '
|
|
|
|
git reset --hard execute &&
|
|
|
|
(
|
2019-10-15 12:25:28 +02:00
|
|
|
set_fake_editor &&
|
|
|
|
git rebase --exec "git show HEAD" -i HEAD~2 >actual &&
|
2012-06-12 10:05:12 +02:00
|
|
|
FAKE_LINES="1 exec_git_show_HEAD 2 exec_git_show_HEAD" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
git rebase -i HEAD~2 >expect
|
|
|
|
) &&
|
|
|
|
sed -e "1,9d" expect >expected &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'running "git rebase -ix git show HEAD"' '
|
|
|
|
git reset --hard execute &&
|
|
|
|
(
|
2019-10-15 12:25:28 +02:00
|
|
|
set_fake_editor &&
|
|
|
|
git rebase -ix "git show HEAD" HEAD~2 >actual &&
|
2012-06-12 10:05:12 +02:00
|
|
|
FAKE_LINES="1 exec_git_show_HEAD 2 exec_git_show_HEAD" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
git rebase -i HEAD~2 >expect
|
|
|
|
) &&
|
|
|
|
sed -e "1,9d" expect >expected &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
|
|
|
|
|
|
|
test_expect_success 'rebase -ix with several <CMD>' '
|
|
|
|
git reset --hard execute &&
|
|
|
|
(
|
2019-10-15 12:25:28 +02:00
|
|
|
set_fake_editor &&
|
|
|
|
git rebase -ix "git show HEAD; pwd" HEAD~2 >actual &&
|
2012-06-12 10:05:12 +02:00
|
|
|
FAKE_LINES="1 exec_git_show_HEAD;_pwd 2 exec_git_show_HEAD;_pwd" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
git rebase -i HEAD~2 >expect
|
|
|
|
) &&
|
|
|
|
sed -e "1,9d" expect >expected &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -ix with several instances of --exec' '
|
|
|
|
git reset --hard execute &&
|
|
|
|
(
|
2019-10-15 12:25:28 +02:00
|
|
|
set_fake_editor &&
|
|
|
|
git rebase -i --exec "git show HEAD" --exec "pwd" HEAD~2 >actual &&
|
2012-06-12 10:05:12 +02:00
|
|
|
FAKE_LINES="1 exec_git_show_HEAD exec_pwd 2
|
|
|
|
exec_git_show_HEAD exec_pwd" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
git rebase -i HEAD~2 >expect
|
|
|
|
) &&
|
|
|
|
sed -e "1,11d" expect >expected &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
2021-02-11 02:53:51 +01:00
|
|
|
test_expect_success 'rebase -ix with --autosquash' '
|
2012-06-12 10:05:12 +02:00
|
|
|
git reset --hard execute &&
|
|
|
|
git checkout -b autosquash &&
|
|
|
|
echo second >second.txt &&
|
|
|
|
git add second.txt &&
|
|
|
|
git commit -m "fixup! two_exec" &&
|
|
|
|
echo bis >bis.txt &&
|
|
|
|
git add bis.txt &&
|
|
|
|
git commit -m "fixup! two_exec" &&
|
2019-10-15 12:25:27 +02:00
|
|
|
git checkout -b autosquash_actual &&
|
|
|
|
git rebase -i --exec "git show HEAD" --autosquash HEAD~4 >actual &&
|
2012-06-12 10:05:12 +02:00
|
|
|
git checkout autosquash &&
|
|
|
|
(
|
2019-10-15 12:25:28 +02:00
|
|
|
set_fake_editor &&
|
2012-06-12 10:05:12 +02:00
|
|
|
git checkout -b autosquash_expected &&
|
|
|
|
FAKE_LINES="1 fixup 3 fixup 4 exec_git_show_HEAD 2 exec_git_show_HEAD" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
git rebase -i HEAD~4 >expect
|
|
|
|
) &&
|
|
|
|
sed -e "1,13d" expect >expected &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
2016-03-18 22:26:17 +01:00
|
|
|
test_expect_success 'rebase --exec works without -i ' '
|
2012-06-12 10:05:12 +02:00
|
|
|
git reset --hard execute &&
|
2016-03-18 22:26:17 +01:00
|
|
|
rm -rf exec_output &&
|
|
|
|
EDITOR="echo >invoked_editor" git rebase --exec "echo a line >>exec_output" HEAD~2 2>actual &&
|
|
|
|
test_i18ngrep "Successfully rebased and updated" actual &&
|
|
|
|
test_line_count = 2 exec_output &&
|
|
|
|
test_path_is_missing invoked_editor
|
2012-06-12 10:05:12 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i --exec without <CMD>' '
|
|
|
|
git reset --hard execute &&
|
2018-03-22 19:43:51 +01:00
|
|
|
test_must_fail git rebase -i --exec 2>actual &&
|
|
|
|
test_i18ngrep "requires a value" actual &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary
|
2012-06-12 10:05:12 +02:00
|
|
|
'
|
|
|
|
|
2012-06-26 23:55:24 +02:00
|
|
|
test_expect_success 'rebase -i --root re-order and drop commits' '
|
|
|
|
git checkout E &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="3 1 2 5" git rebase -i --root
|
|
|
|
) &&
|
2012-06-26 23:55:24 +02:00
|
|
|
test E = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test B = $(git cat-file commit HEAD^ | sed -ne \$p) &&
|
|
|
|
test A = $(git cat-file commit HEAD^^ | sed -ne \$p) &&
|
|
|
|
test C = $(git cat-file commit HEAD^^^ | sed -ne \$p) &&
|
|
|
|
test 0 = $(git cat-file commit HEAD^^^ | grep -c ^parent\ )
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i --root retain root commit author and message' '
|
|
|
|
git checkout A &&
|
|
|
|
echo B >file7 &&
|
|
|
|
git add file7 &&
|
|
|
|
GIT_AUTHOR_NAME="Twerp Snog" git commit -m "different author" &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="2" git rebase -i --root
|
|
|
|
) &&
|
2012-06-26 23:55:24 +02:00
|
|
|
git cat-file commit HEAD | grep -q "^author Twerp Snog" &&
|
|
|
|
git cat-file commit HEAD | grep -q "^different author$"
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i --root temporary sentinel commit' '
|
|
|
|
git checkout B &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="2" git rebase -i --root
|
|
|
|
) &&
|
2019-08-18 21:16:38 +02:00
|
|
|
git cat-file commit HEAD | grep "^tree $EMPTY_TREE" &&
|
2012-06-26 23:55:24 +02:00
|
|
|
git rebase --abort
|
|
|
|
'
|
|
|
|
|
2012-07-24 14:17:03 +02:00
|
|
|
test_expect_success 'rebase -i --root fixup root commit' '
|
|
|
|
git checkout B &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 fixup 2" git rebase -i --root
|
|
|
|
) &&
|
2012-07-24 14:17:03 +02:00
|
|
|
test A = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test B = $(git show HEAD:file1) &&
|
|
|
|
test 0 = $(git cat-file commit HEAD | grep -c ^parent\ )
|
|
|
|
'
|
|
|
|
|
2019-08-19 11:18:21 +02:00
|
|
|
test_expect_success 'rebase -i --root reword original root commit' '
|
2018-06-15 06:31:11 +02:00
|
|
|
test_when_finished "test_might_fail git rebase --abort" &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout -b reword-original-root-branch primary &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="reword 1 2" FAKE_COMMIT_MESSAGE="A changed" \
|
|
|
|
git rebase -i --root
|
|
|
|
) &&
|
2018-06-19 00:19:42 +02:00
|
|
|
git show HEAD^ | grep "A changed" &&
|
|
|
|
test -z "$(git show -s --format=%p HEAD^)"
|
2018-06-15 06:31:11 +02:00
|
|
|
'
|
|
|
|
|
2019-08-19 11:18:21 +02:00
|
|
|
test_expect_success 'rebase -i --root reword new root commit' '
|
|
|
|
test_when_finished "test_might_fail git rebase --abort" &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout -b reword-now-root-branch primary &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="reword 3 1" FAKE_COMMIT_MESSAGE="C changed" \
|
|
|
|
git rebase -i --root
|
|
|
|
) &&
|
2019-08-19 11:18:21 +02:00
|
|
|
git show HEAD^ | grep "C changed" &&
|
|
|
|
test -z "$(git show -s --format=%p HEAD^)"
|
|
|
|
'
|
|
|
|
|
2019-06-14 14:16:08 +02:00
|
|
|
test_expect_success 'rebase -i --root when root has untracked file conflict' '
|
sequencer: do not squash 'reword' commits when we hit conflicts
Ever since commit 18633e1a22 ("rebase -i: use the rebase--helper builtin",
2017-02-09), when a commit marked as 'reword' in an interactive rebase
has conflicts and fails to apply, when the rebase is resumed that commit
will be squashed into its parent with its commit message taken.
The issue can be understood better by looking at commit 56dc3ab04b
("sequencer (rebase -i): implement the 'edit' command", 2017-01-02), which
introduced error_with_patch() for the edit command. For the edit command,
it needs to stop the rebase whether or not the patch applies cleanly. If
the patch does apply cleanly, then when it resumes it knows it needs to
amend all changes into the previous commit. If it does not apply cleanly,
then the changes should not be amended. Thus, it passes !res (success of
applying the 'edit' commit) to error_with_patch() for the to_amend flag.
The problematic line of code actually came from commit 04efc8b57c
("sequencer (rebase -i): implement the 'reword' command", 2017-01-02).
Note that to get to this point in the code:
* !!res (i.e. patch application failed)
* item->command < TODO_SQUASH
* item->command != TODO_EDIT
* !is_fixup(item->command) [i.e. not squash or fixup]
So that means this can only be a failed patch application that is either a
pick, revert, or reword. We only need to amend HEAD when rewording the
root commit or a commit that has been fast-forwarded, for any of the other
cases we want a new commit, so we should not set the to_amend flag.
Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Original-patch-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-06-19 14:46:51 +02:00
|
|
|
test_when_finished "reset_rebase" &&
|
|
|
|
git checkout -b failing-root-pick A &&
|
|
|
|
echo x >file2 &&
|
|
|
|
git rm file1 &&
|
|
|
|
git commit -m "remove file 1 add file 2" &&
|
|
|
|
echo z >file1 &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 2" git rebase -i --root
|
|
|
|
) &&
|
sequencer: do not squash 'reword' commits when we hit conflicts
Ever since commit 18633e1a22 ("rebase -i: use the rebase--helper builtin",
2017-02-09), when a commit marked as 'reword' in an interactive rebase
has conflicts and fails to apply, when the rebase is resumed that commit
will be squashed into its parent with its commit message taken.
The issue can be understood better by looking at commit 56dc3ab04b
("sequencer (rebase -i): implement the 'edit' command", 2017-01-02), which
introduced error_with_patch() for the edit command. For the edit command,
it needs to stop the rebase whether or not the patch applies cleanly. If
the patch does apply cleanly, then when it resumes it knows it needs to
amend all changes into the previous commit. If it does not apply cleanly,
then the changes should not be amended. Thus, it passes !res (success of
applying the 'edit' commit) to error_with_patch() for the to_amend flag.
The problematic line of code actually came from commit 04efc8b57c
("sequencer (rebase -i): implement the 'reword' command", 2017-01-02).
Note that to get to this point in the code:
* !!res (i.e. patch application failed)
* item->command < TODO_SQUASH
* item->command != TODO_EDIT
* !is_fixup(item->command) [i.e. not squash or fixup]
So that means this can only be a failed patch application that is either a
pick, revert, or reword. We only need to amend HEAD when rewording the
root commit or a commit that has been fast-forwarded, for any of the other
cases we want a new commit, so we should not set the to_amend flag.
Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Original-patch-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-06-19 14:46:51 +02:00
|
|
|
rm file1 &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test "$(git log -1 --format=%B)" = "remove file 1 add file 2" &&
|
|
|
|
test "$(git rev-list --count HEAD)" = 2
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i --root reword root when root has untracked file conflict' '
|
|
|
|
test_when_finished "reset_rebase" &&
|
|
|
|
echo z>file1 &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="reword 1 2" \
|
|
|
|
FAKE_COMMIT_MESSAGE="Modified A" git rebase -i --root &&
|
|
|
|
rm file1 &&
|
|
|
|
FAKE_COMMIT_MESSAGE="Reworded A" git rebase --continue
|
|
|
|
) &&
|
sequencer: do not squash 'reword' commits when we hit conflicts
Ever since commit 18633e1a22 ("rebase -i: use the rebase--helper builtin",
2017-02-09), when a commit marked as 'reword' in an interactive rebase
has conflicts and fails to apply, when the rebase is resumed that commit
will be squashed into its parent with its commit message taken.
The issue can be understood better by looking at commit 56dc3ab04b
("sequencer (rebase -i): implement the 'edit' command", 2017-01-02), which
introduced error_with_patch() for the edit command. For the edit command,
it needs to stop the rebase whether or not the patch applies cleanly. If
the patch does apply cleanly, then when it resumes it knows it needs to
amend all changes into the previous commit. If it does not apply cleanly,
then the changes should not be amended. Thus, it passes !res (success of
applying the 'edit' commit) to error_with_patch() for the to_amend flag.
The problematic line of code actually came from commit 04efc8b57c
("sequencer (rebase -i): implement the 'reword' command", 2017-01-02).
Note that to get to this point in the code:
* !!res (i.e. patch application failed)
* item->command < TODO_SQUASH
* item->command != TODO_EDIT
* !is_fixup(item->command) [i.e. not squash or fixup]
So that means this can only be a failed patch application that is either a
pick, revert, or reword. We only need to amend HEAD when rewording the
root commit or a commit that has been fast-forwarded, for any of the other
cases we want a new commit, so we should not set the to_amend flag.
Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Original-patch-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-06-19 14:46:51 +02:00
|
|
|
test "$(git log -1 --format=%B HEAD^)" = "Reworded A" &&
|
|
|
|
test "$(git rev-list --count HEAD)" = 2
|
|
|
|
'
|
|
|
|
|
2021-02-11 02:53:51 +01:00
|
|
|
test_expect_success 'rebase --edit-todo does not work on non-interactive rebase' '
|
2019-08-19 11:18:21 +02:00
|
|
|
git checkout reword-original-root-branch &&
|
2012-09-18 03:28:10 +02:00
|
|
|
git reset --hard &&
|
|
|
|
git checkout conflict-branch &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
2020-02-15 22:36:41 +01:00
|
|
|
test_must_fail git rebase -f --apply --onto HEAD~2 HEAD~ &&
|
2019-10-15 12:25:28 +02:00
|
|
|
test_must_fail git rebase --edit-todo
|
|
|
|
) &&
|
2012-09-18 03:28:10 +02:00
|
|
|
git rebase --abort
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase --edit-todo can be used to modify todo' '
|
|
|
|
git reset --hard &&
|
|
|
|
git checkout no-conflict-branch^0 &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1 2 3" git rebase -i HEAD~3 &&
|
|
|
|
FAKE_LINES="2 1" git rebase --edit-todo &&
|
|
|
|
git rebase --continue
|
|
|
|
) &&
|
2012-09-18 03:28:10 +02:00
|
|
|
test M = $(git cat-file commit HEAD^ | sed -ne \$p) &&
|
|
|
|
test L = $(git cat-file commit HEAD | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
2013-06-16 10:45:13 +02:00
|
|
|
test_expect_success 'rebase -i produces readable reflog' '
|
|
|
|
git reset --hard &&
|
|
|
|
git branch -f branch-reflog-test H &&
|
|
|
|
git rebase -i --onto I F branch-reflog-test &&
|
|
|
|
cat >expect <<-\EOF &&
|
2020-02-15 22:36:36 +01:00
|
|
|
rebase (finish): returning to refs/heads/branch-reflog-test
|
|
|
|
rebase (pick): H
|
|
|
|
rebase (pick): G
|
|
|
|
rebase (start): checkout I
|
2013-06-16 10:45:13 +02:00
|
|
|
EOF
|
2015-07-28 00:57:08 +02:00
|
|
|
git reflog -n4 HEAD |
|
|
|
|
sed "s/[^:]*: //" >actual &&
|
2013-06-16 10:45:13 +02:00
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
2013-02-12 00:08:04 +01:00
|
|
|
test_expect_success 'rebase -i respects core.commentchar' '
|
|
|
|
git reset --hard &&
|
|
|
|
git checkout E^0 &&
|
2013-03-24 22:06:04 +01:00
|
|
|
test_config core.commentchar "\\" &&
|
2013-02-12 00:08:04 +01:00
|
|
|
write_script remove-all-but-first.sh <<-\EOF &&
|
|
|
|
sed -e "2,\$s/^/\\\\/" "$1" >"$1.tmp" &&
|
|
|
|
mv "$1.tmp" "$1"
|
|
|
|
EOF
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
test_set_editor "$(pwd)/remove-all-but-first.sh" &&
|
|
|
|
git rebase -i B
|
|
|
|
) &&
|
2013-02-12 00:08:04 +01:00
|
|
|
test B = $(git cat-file commit HEAD^ | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
2016-11-21 15:18:29 +01:00
|
|
|
test_expect_success 'rebase -i respects core.commentchar=auto' '
|
2016-11-21 15:18:05 +01:00
|
|
|
test_config core.commentchar auto &&
|
|
|
|
write_script copy-edit-script.sh <<-\EOF &&
|
|
|
|
cp "$1" edit-script
|
|
|
|
EOF
|
|
|
|
test_when_finished "git rebase --abort || :" &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
test_set_editor "$(pwd)/copy-edit-script.sh" &&
|
|
|
|
git rebase -i HEAD^
|
|
|
|
) &&
|
2016-11-21 15:18:05 +01:00
|
|
|
test -z "$(grep -ve "^#" -e "^\$" -e "^pick" edit-script)"
|
|
|
|
'
|
|
|
|
|
2013-06-14 15:17:52 +02:00
|
|
|
test_expect_success 'rebase -i, with <onto> and <upstream> specified as :/quuxery' '
|
2013-06-14 15:17:50 +02:00
|
|
|
test_when_finished "git branch -D torebase" &&
|
|
|
|
git checkout -b torebase branch1 &&
|
|
|
|
upstream=$(git rev-parse ":/J") &&
|
|
|
|
onto=$(git rev-parse ":/A") &&
|
|
|
|
git rebase --onto $onto $upstream &&
|
|
|
|
git reset --hard branch1 &&
|
|
|
|
git rebase --onto ":/A" ":/J" &&
|
|
|
|
git checkout branch1
|
|
|
|
'
|
|
|
|
|
2013-07-02 10:05:48 +02:00
|
|
|
test_expect_success 'rebase -i with --strategy and -X' '
|
|
|
|
git checkout -b conflict-merge-use-theirs conflict-branch &&
|
|
|
|
git reset --hard HEAD^ &&
|
|
|
|
echo five >conflict &&
|
|
|
|
echo Z >file1 &&
|
|
|
|
git commit -a -m "one file conflict" &&
|
|
|
|
EDITOR=true git rebase -i --strategy=recursive -Xours conflict-branch &&
|
|
|
|
test $(git show conflict-branch:conflict) = $(cat conflict) &&
|
|
|
|
test $(cat file1) = Z
|
|
|
|
'
|
|
|
|
|
rebase -i: remember merge options beyond continue actions
If the user explicitly specified a merge strategy or strategy
options, continue to use that strategy/option after
"rebase --continue". Add a test of the corrected behavior.
If --merge is specified or implied by -s or -X, then "strategy and
"strategy_opts" are set to values from which "strategy_args" can be
derived; otherwise they are set to empty strings. Either way,
their values are propagated from one step of an interactive rebase
to the next via state files.
"do_merge", on the other hand, is *not* propagated to later steps of
an interactive rebase. Therefore, making the initialization of
"strategy_args" conditional on "do_merge" being set prevents later
steps of an interactive rebase from setting it correctly.
Luckily, we don't need the "do_merge" guard at all. If the rebase
was started without --merge, then "strategy" and "strategy_opts"
are both the empty string, which results in "strategy_args" also
being set to the empty string, which is just what we want in that
situation. So remove the "do_merge" guard and derive
"strategy_args" from "strategy" and "strategy_opts" every time.
Reported-by: Diogo de Campos <campos@esss.com.br>
Signed-off-by: Fabian Ruch <bafain@gmail.com>
Helped-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-12-11 21:30:36 +01:00
|
|
|
test_expect_success 'interrupted rebase -i with --strategy and -X' '
|
|
|
|
git checkout -b conflict-merge-use-theirs-interrupted conflict-branch &&
|
|
|
|
git reset --hard HEAD^ &&
|
|
|
|
>breakpoint &&
|
|
|
|
git add breakpoint &&
|
|
|
|
git commit -m "breakpoint for interactive mode" &&
|
|
|
|
echo five >conflict &&
|
|
|
|
echo Z >file1 &&
|
|
|
|
git commit -a -m "one file conflict" &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1 2" git rebase -i --strategy=recursive \
|
|
|
|
-Xours conflict-branch
|
|
|
|
) &&
|
rebase -i: remember merge options beyond continue actions
If the user explicitly specified a merge strategy or strategy
options, continue to use that strategy/option after
"rebase --continue". Add a test of the corrected behavior.
If --merge is specified or implied by -s or -X, then "strategy and
"strategy_opts" are set to values from which "strategy_args" can be
derived; otherwise they are set to empty strings. Either way,
their values are propagated from one step of an interactive rebase
to the next via state files.
"do_merge", on the other hand, is *not* propagated to later steps of
an interactive rebase. Therefore, making the initialization of
"strategy_args" conditional on "do_merge" being set prevents later
steps of an interactive rebase from setting it correctly.
Luckily, we don't need the "do_merge" guard at all. If the rebase
was started without --merge, then "strategy" and "strategy_opts"
are both the empty string, which results in "strategy_args" also
being set to the empty string, which is just what we want in that
situation. So remove the "do_merge" guard and derive
"strategy_args" from "strategy" and "strategy_opts" every time.
Reported-by: Diogo de Campos <campos@esss.com.br>
Signed-off-by: Fabian Ruch <bafain@gmail.com>
Helped-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-12-11 21:30:36 +01:00
|
|
|
git rebase --continue &&
|
|
|
|
test $(git show conflict-branch:conflict) = $(cat conflict) &&
|
|
|
|
test $(cat file1) = Z
|
|
|
|
'
|
|
|
|
|
2013-08-07 11:26:05 +02:00
|
|
|
test_expect_success 'rebase -i error on commits with \ in message' '
|
2015-03-20 11:07:15 +01:00
|
|
|
current_head=$(git rev-parse HEAD) &&
|
2013-08-07 11:26:05 +02:00
|
|
|
test_when_finished "git rebase --abort; git reset --hard $current_head; rm -f error" &&
|
|
|
|
test_commit TO-REMOVE will-conflict old-content &&
|
|
|
|
test_commit "\temp" will-conflict new-content dummy &&
|
2014-03-18 19:54:05 +01:00
|
|
|
test_must_fail env EDITOR=true git rebase -i HEAD^ --onto HEAD^^ 2>error &&
|
2013-08-07 11:26:05 +02:00
|
|
|
test_expect_code 1 grep " emp" error
|
|
|
|
'
|
|
|
|
|
2020-07-30 01:13:53 +02:00
|
|
|
test_expect_success 'short commit ID setup' '
|
2020-11-24 11:15:49 +01:00
|
|
|
test_when_finished "git checkout primary" &&
|
2013-08-24 02:10:41 +02:00
|
|
|
git checkout --orphan collide &&
|
|
|
|
git rm -rf . &&
|
|
|
|
(
|
|
|
|
unset test_tick &&
|
|
|
|
test_commit collide1 collide &&
|
|
|
|
test_commit --notick collide2 collide &&
|
|
|
|
test_commit --notick collide3 collide
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2020-07-30 01:13:53 +02:00
|
|
|
if test -n "$GIT_TEST_FIND_COLLIDER"
|
|
|
|
then
|
|
|
|
author="$(unset test_tick; test_tick; git var GIT_AUTHOR_IDENT)"
|
|
|
|
committer="$(unset test_tick; test_tick; git var GIT_COMMITTER_IDENT)"
|
|
|
|
blob="$(git rev-parse collide2:collide)"
|
|
|
|
from="$(git rev-parse collide1^0)"
|
|
|
|
repl="commit refs/heads/collider-&\\n"
|
|
|
|
repl="${repl}author $author\\ncommitter $committer\\n"
|
|
|
|
repl="${repl}data <<EOF\\ncollide2 &\\nEOF\\n"
|
|
|
|
repl="${repl}from $from\\nM 100644 $blob collide\\n"
|
|
|
|
test_seq 1 32768 | sed "s|.*|$repl|" >script &&
|
|
|
|
git fast-import <script &&
|
|
|
|
git pack-refs &&
|
|
|
|
git for-each-ref >refs &&
|
|
|
|
grep "^$(test_oid t3404_collision)" <refs >matches &&
|
|
|
|
cat matches &&
|
|
|
|
test_line_count -gt 2 matches || {
|
|
|
|
echo "Could not find a collider" >&2
|
|
|
|
exit 1
|
|
|
|
}
|
|
|
|
fi
|
|
|
|
|
|
|
|
test_expect_success 'short commit ID collide' '
|
|
|
|
test_oid_cache <<-EOF &&
|
|
|
|
# collision-related constants
|
|
|
|
t3404_collision sha1:6bcd
|
|
|
|
t3404_collision sha256:0161
|
|
|
|
t3404_collider sha1:ac4f2ee
|
|
|
|
t3404_collider sha256:16697
|
|
|
|
EOF
|
2020-11-24 11:15:49 +01:00
|
|
|
test_when_finished "reset_rebase && git checkout primary" &&
|
2013-08-24 02:10:41 +02:00
|
|
|
git checkout collide &&
|
2020-07-30 01:13:53 +02:00
|
|
|
colliding_id=$(test_oid t3404_collision) &&
|
|
|
|
hexsz=$(test_oid hexsz) &&
|
|
|
|
test $colliding_id = "$(git rev-parse HEAD | cut -c 1-4)" &&
|
|
|
|
test_config core.abbrev 4 &&
|
2013-08-24 02:10:41 +02:00
|
|
|
(
|
2019-12-07 23:22:44 +01:00
|
|
|
unset test_tick &&
|
|
|
|
test_tick &&
|
|
|
|
set_fake_editor &&
|
2020-07-30 01:13:53 +02:00
|
|
|
FAKE_COMMIT_MESSAGE="collide2 $(test_oid t3404_collider)" \
|
rebase -i: re-fix short SHA-1 collision
In 66ae9a57b88 (t3404: rebase -i: demonstrate short SHA-1 collision,
2013-08-23), we added a test case that demonstrated how it is possible
that a previously unambiguous short commit ID could become ambiguous
*during* a rebase.
In 75c69766554 (rebase -i: fix short SHA-1 collision, 2013-08-23), we
fixed that problem simply by writing out the todo list with expanded
commit IDs (except *right* before letting the user edit the todo list,
in which case we shorten them, but we expand them right after the file
was edited).
However, the bug resurfaced as a side effect of 393adf7a6f6 (sequencer:
directly call pick_commits() from complete_action(), 2019-11-24): as of
this commit, the sequencer no longer re-reads the todo list after
writing it out with expanded commit IDs.
The only redeeming factor is that the todo list is already parsed at
that stage, including all the commits corresponding to the commands,
therefore the sequencer can continue even if the internal todo list has
short commit IDs.
That does not prevent problems, though: the sequencer writes out the
`done` and `git-rebase-todo` files incrementally (i.e. overwriting the
todo list with a version that has _short_ commit IDs), and if a merge
conflict happens, or if an `edit` or a `break` command is encountered, a
subsequent `git rebase --continue` _will_ re-read the todo list, opening
an opportunity for the "short SHA-1 collision" bug again.
To avoid that, let's make sure that we do expand the commit IDs in the
todo list as soon as we have parsed it after letting the user edit it.
Additionally, we improve the 'short SHA-1 collide' test case in t3404 to
test specifically for the case where the rebase is resumed. We also
hard-code the expected colliding short SHA-1s, to document the
expectation (and to make it easier on future readers).
Note that we specifically test that the short commit ID is used in the
`git-rebase-todo.tmp` file: this file is created by the fake editor in
the test script and reflects the state that would have been presented to
the user to edit.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-23 13:28:18 +01:00
|
|
|
FAKE_LINES="reword 1 break 2" git rebase -i HEAD~2 &&
|
2020-07-30 01:13:53 +02:00
|
|
|
test $colliding_id = "$(git rev-parse HEAD | cut -c 1-4)" &&
|
|
|
|
grep "^pick $colliding_id " \
|
rebase -i: re-fix short SHA-1 collision
In 66ae9a57b88 (t3404: rebase -i: demonstrate short SHA-1 collision,
2013-08-23), we added a test case that demonstrated how it is possible
that a previously unambiguous short commit ID could become ambiguous
*during* a rebase.
In 75c69766554 (rebase -i: fix short SHA-1 collision, 2013-08-23), we
fixed that problem simply by writing out the todo list with expanded
commit IDs (except *right* before letting the user edit the todo list,
in which case we shorten them, but we expand them right after the file
was edited).
However, the bug resurfaced as a side effect of 393adf7a6f6 (sequencer:
directly call pick_commits() from complete_action(), 2019-11-24): as of
this commit, the sequencer no longer re-reads the todo list after
writing it out with expanded commit IDs.
The only redeeming factor is that the todo list is already parsed at
that stage, including all the commits corresponding to the commands,
therefore the sequencer can continue even if the internal todo list has
short commit IDs.
That does not prevent problems, though: the sequencer writes out the
`done` and `git-rebase-todo` files incrementally (i.e. overwriting the
todo list with a version that has _short_ commit IDs), and if a merge
conflict happens, or if an `edit` or a `break` command is encountered, a
subsequent `git rebase --continue` _will_ re-read the todo list, opening
an opportunity for the "short SHA-1 collision" bug again.
To avoid that, let's make sure that we do expand the commit IDs in the
todo list as soon as we have parsed it after letting the user edit it.
Additionally, we improve the 'short SHA-1 collide' test case in t3404 to
test specifically for the case where the rebase is resumed. We also
hard-code the expected colliding short SHA-1s, to document the
expectation (and to make it easier on future readers).
Note that we specifically test that the short commit ID is used in the
`git-rebase-todo.tmp` file: this file is created by the fake editor in
the test script and reflects the state that would have been presented to
the user to edit.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-23 13:28:18 +01:00
|
|
|
.git/rebase-merge/git-rebase-todo.tmp &&
|
2020-07-30 01:13:53 +02:00
|
|
|
grep "^pick [0-9a-f]\{$hexsz\}" \
|
rebase -i: re-fix short SHA-1 collision
In 66ae9a57b88 (t3404: rebase -i: demonstrate short SHA-1 collision,
2013-08-23), we added a test case that demonstrated how it is possible
that a previously unambiguous short commit ID could become ambiguous
*during* a rebase.
In 75c69766554 (rebase -i: fix short SHA-1 collision, 2013-08-23), we
fixed that problem simply by writing out the todo list with expanded
commit IDs (except *right* before letting the user edit the todo list,
in which case we shorten them, but we expand them right after the file
was edited).
However, the bug resurfaced as a side effect of 393adf7a6f6 (sequencer:
directly call pick_commits() from complete_action(), 2019-11-24): as of
this commit, the sequencer no longer re-reads the todo list after
writing it out with expanded commit IDs.
The only redeeming factor is that the todo list is already parsed at
that stage, including all the commits corresponding to the commands,
therefore the sequencer can continue even if the internal todo list has
short commit IDs.
That does not prevent problems, though: the sequencer writes out the
`done` and `git-rebase-todo` files incrementally (i.e. overwriting the
todo list with a version that has _short_ commit IDs), and if a merge
conflict happens, or if an `edit` or a `break` command is encountered, a
subsequent `git rebase --continue` _will_ re-read the todo list, opening
an opportunity for the "short SHA-1 collision" bug again.
To avoid that, let's make sure that we do expand the commit IDs in the
todo list as soon as we have parsed it after letting the user edit it.
Additionally, we improve the 'short SHA-1 collide' test case in t3404 to
test specifically for the case where the rebase is resumed. We also
hard-code the expected colliding short SHA-1s, to document the
expectation (and to make it easier on future readers).
Note that we specifically test that the short commit ID is used in the
`git-rebase-todo.tmp` file: this file is created by the fake editor in
the test script and reflects the state that would have been presented to
the user to edit.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-23 13:28:18 +01:00
|
|
|
.git/rebase-merge/git-rebase-todo &&
|
2020-07-30 01:13:53 +02:00
|
|
|
grep "^pick [0-9a-f]\{$hexsz\}" \
|
2020-01-23 13:28:19 +01:00
|
|
|
.git/rebase-merge/git-rebase-todo.backup &&
|
rebase -i: re-fix short SHA-1 collision
In 66ae9a57b88 (t3404: rebase -i: demonstrate short SHA-1 collision,
2013-08-23), we added a test case that demonstrated how it is possible
that a previously unambiguous short commit ID could become ambiguous
*during* a rebase.
In 75c69766554 (rebase -i: fix short SHA-1 collision, 2013-08-23), we
fixed that problem simply by writing out the todo list with expanded
commit IDs (except *right* before letting the user edit the todo list,
in which case we shorten them, but we expand them right after the file
was edited).
However, the bug resurfaced as a side effect of 393adf7a6f6 (sequencer:
directly call pick_commits() from complete_action(), 2019-11-24): as of
this commit, the sequencer no longer re-reads the todo list after
writing it out with expanded commit IDs.
The only redeeming factor is that the todo list is already parsed at
that stage, including all the commits corresponding to the commands,
therefore the sequencer can continue even if the internal todo list has
short commit IDs.
That does not prevent problems, though: the sequencer writes out the
`done` and `git-rebase-todo` files incrementally (i.e. overwriting the
todo list with a version that has _short_ commit IDs), and if a merge
conflict happens, or if an `edit` or a `break` command is encountered, a
subsequent `git rebase --continue` _will_ re-read the todo list, opening
an opportunity for the "short SHA-1 collision" bug again.
To avoid that, let's make sure that we do expand the commit IDs in the
todo list as soon as we have parsed it after letting the user edit it.
Additionally, we improve the 'short SHA-1 collide' test case in t3404 to
test specifically for the case where the rebase is resumed. We also
hard-code the expected colliding short SHA-1s, to document the
expectation (and to make it easier on future readers).
Note that we specifically test that the short commit ID is used in the
`git-rebase-todo.tmp` file: this file is created by the fake editor in
the test script and reflects the state that would have been presented to
the user to edit.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-23 13:28:18 +01:00
|
|
|
git rebase --continue
|
|
|
|
) &&
|
|
|
|
collide2="$(git rev-parse HEAD~1 | cut -c 1-4)" &&
|
|
|
|
collide3="$(git rev-parse collide3 | cut -c 1-4)" &&
|
|
|
|
test "$collide2" = "$collide3"
|
2013-08-24 02:10:41 +02:00
|
|
|
'
|
|
|
|
|
2015-01-22 12:50:15 +01:00
|
|
|
test_expect_success 'respect core.abbrev' '
|
|
|
|
git config core.abbrev 12 &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_cat_todo_editor &&
|
|
|
|
test_must_fail git rebase -i HEAD~4 >todo-list
|
|
|
|
) &&
|
2015-01-22 12:50:15 +01:00
|
|
|
test 4 = $(grep -c "pick [0-9a-f]\{12,\}" todo-list)
|
|
|
|
'
|
|
|
|
|
2015-03-04 08:53:04 +01:00
|
|
|
test_expect_success 'todo count' '
|
|
|
|
write_script dump-raw.sh <<-\EOF &&
|
|
|
|
cat "$1"
|
|
|
|
EOF
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
test_set_editor "$(pwd)/dump-raw.sh" &&
|
|
|
|
git rebase -i HEAD~4 >actual
|
|
|
|
) &&
|
2016-06-17 22:21:04 +02:00
|
|
|
test_i18ngrep "^# Rebase ..* onto ..* ([0-9]" actual
|
2015-03-04 08:53:04 +01:00
|
|
|
'
|
|
|
|
|
2015-04-29 00:55:20 +02:00
|
|
|
test_expect_success 'rebase -i commits that overwrite untracked files (pick)' '
|
|
|
|
git checkout --force branch2 &&
|
|
|
|
git clean -f &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1 2" git rebase -i A
|
|
|
|
) &&
|
2015-04-29 00:55:20 +02:00
|
|
|
test_cmp_rev HEAD F &&
|
|
|
|
test_path_is_missing file6 &&
|
|
|
|
>file6 &&
|
|
|
|
test_must_fail git rebase --continue &&
|
|
|
|
test_cmp_rev HEAD F &&
|
|
|
|
rm file6 &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test_cmp_rev HEAD I
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i commits that overwrite untracked files (squash)' '
|
|
|
|
git checkout --force branch2 &&
|
|
|
|
git clean -f &&
|
|
|
|
git tag original-branch2 &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1 squash 2" git rebase -i A
|
|
|
|
) &&
|
2015-04-29 00:55:20 +02:00
|
|
|
test_cmp_rev HEAD F &&
|
|
|
|
test_path_is_missing file6 &&
|
|
|
|
>file6 &&
|
|
|
|
test_must_fail git rebase --continue &&
|
|
|
|
test_cmp_rev HEAD F &&
|
|
|
|
rm file6 &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test $(git cat-file commit HEAD | sed -ne \$p) = I &&
|
|
|
|
git reset --hard original-branch2
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i commits that overwrite untracked files (no ff)' '
|
|
|
|
git checkout --force branch2 &&
|
|
|
|
git clean -f &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1 2" git rebase -i --no-ff A
|
|
|
|
) &&
|
2015-04-29 00:55:20 +02:00
|
|
|
test $(git cat-file commit HEAD | sed -ne \$p) = F &&
|
|
|
|
test_path_is_missing file6 &&
|
|
|
|
>file6 &&
|
|
|
|
test_must_fail git rebase --continue &&
|
|
|
|
test $(git cat-file commit HEAD | sed -ne \$p) = F &&
|
|
|
|
rm file6 &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test $(git cat-file commit HEAD | sed -ne \$p) = I
|
|
|
|
'
|
|
|
|
|
2015-06-18 18:38:53 +02:00
|
|
|
test_expect_success 'rebase --continue removes CHERRY_PICK_HEAD' '
|
2015-06-18 18:38:44 +02:00
|
|
|
git checkout -b commit-to-skip &&
|
|
|
|
for double in X 3 1
|
|
|
|
do
|
|
|
|
test_seq 5 | sed "s/$double/&&/" >seq &&
|
|
|
|
git add seq &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m seq-$double
|
|
|
|
done &&
|
|
|
|
git tag seq-onto &&
|
|
|
|
git reset --hard HEAD~2 &&
|
|
|
|
git cherry-pick seq-onto &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES= git rebase -i seq-onto
|
|
|
|
) &&
|
2015-06-18 18:38:44 +02:00
|
|
|
test -d .git/rebase-merge &&
|
|
|
|
git rebase --continue &&
|
|
|
|
git diff --exit-code seq-onto &&
|
|
|
|
test ! -d .git/rebase-merge &&
|
|
|
|
test ! -f .git/CHERRY_PICK_HEAD
|
|
|
|
'
|
|
|
|
|
2015-06-29 22:20:30 +02:00
|
|
|
rebase_setup_and_clean () {
|
|
|
|
test_when_finished "
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout primary &&
|
2015-06-29 22:20:30 +02:00
|
|
|
test_might_fail git branch -D $1 &&
|
|
|
|
test_might_fail git rebase --abort
|
|
|
|
" &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git checkout -b $1 ${2:-primary}
|
2015-06-29 22:20:30 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
test_expect_success 'drop' '
|
|
|
|
rebase_setup_and_clean drop-test &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 drop 2 3 d 4 5" git rebase -i --root
|
|
|
|
) &&
|
2015-06-29 22:20:30 +02:00
|
|
|
test E = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test C = $(git cat-file commit HEAD^ | sed -ne \$p) &&
|
|
|
|
test A = $(git cat-file commit HEAD^^ | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
2015-06-29 22:20:31 +02:00
|
|
|
test_expect_success 'rebase -i respects rebase.missingCommitsCheck = ignore' '
|
|
|
|
test_config rebase.missingCommitsCheck ignore &&
|
|
|
|
rebase_setup_and_clean missing-commit &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 2 3 4" git rebase -i --root 2>actual
|
|
|
|
) &&
|
2015-06-29 22:20:31 +02:00
|
|
|
test D = $(git cat-file commit HEAD | sed -ne \$p) &&
|
rebase -i --root: let the sequencer handle even the initial part
In this developer's earlier attempt to accelerate interactive rebases by
converting large parts from Unix shell script into portable, performant
C, the --root handling was specifically excluded (to simplify the task a
little bit; it still took over a year to get that reduced set of patches
into Git proper).
This patch ties up that loose end: now only --preserve-merges uses the
slow Unix shell script implementation to perform the interactive rebase.
As the rebase--helper reports progress to stderr (unlike the scripted
interactive rebase, which reports it to stdout, of all places), we have
to adjust a couple of tests that did not expect that for `git rebase -i
--root`.
This patch fixes -- at long last! -- the really old bug reported in
6a6bc5bdc4d (add tests for rebasing root, 2013-06-06) that rebasing with
--root *always* rewrote the root commit, even if there were no changes.
The bug still persists in --preserve-merges mode, of course, but that
mode will be deprecated as soon as the new --rebase-merges mode
stabilizes, anyway.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-05-04 01:01:18 +02:00
|
|
|
test_i18ngrep \
|
|
|
|
"Successfully rebased and updated refs/heads/missing-commit" \
|
|
|
|
actual
|
2015-06-29 22:20:31 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i respects rebase.missingCommitsCheck = warn' '
|
2019-06-24 20:13:14 +02:00
|
|
|
cat >expect <<-EOF &&
|
|
|
|
Warning: some commits may have been dropped accidentally.
|
|
|
|
Dropped commits (newer to older):
|
2020-11-24 11:15:49 +01:00
|
|
|
- $(git rev-list --pretty=oneline --abbrev-commit -1 primary)
|
2019-06-24 20:13:14 +02:00
|
|
|
To avoid this message, use "drop" to explicitly remove a commit.
|
|
|
|
EOF
|
2015-06-29 22:20:31 +02:00
|
|
|
test_config rebase.missingCommitsCheck warn &&
|
|
|
|
rebase_setup_and_clean missing-commit &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 2 3 4" git rebase -i --root 2>actual.2
|
|
|
|
) &&
|
2019-06-24 20:13:15 +02:00
|
|
|
head -n4 actual.2 >actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect actual &&
|
2015-06-29 22:20:31 +02:00
|
|
|
test D = $(git cat-file commit HEAD | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i respects rebase.missingCommitsCheck = error' '
|
2019-06-24 20:13:14 +02:00
|
|
|
cat >expect <<-EOF &&
|
|
|
|
Warning: some commits may have been dropped accidentally.
|
|
|
|
Dropped commits (newer to older):
|
2020-11-24 11:15:49 +01:00
|
|
|
- $(git rev-list --pretty=oneline --abbrev-commit -1 primary)
|
|
|
|
- $(git rev-list --pretty=oneline --abbrev-commit -1 primary~2)
|
2019-06-24 20:13:14 +02:00
|
|
|
To avoid this message, use "drop" to explicitly remove a commit.
|
|
|
|
|
|
|
|
Use '\''git config rebase.missingCommitsCheck'\'' to change the level of warnings.
|
|
|
|
The possible behaviours are: ignore, warn, error.
|
|
|
|
|
|
|
|
You can fix this with '\''git rebase --edit-todo'\'' and then run '\''git rebase --continue'\''.
|
|
|
|
Or you can abort the rebase with '\''git rebase --abort'\''.
|
|
|
|
EOF
|
2015-06-29 22:20:31 +02:00
|
|
|
test_config rebase.missingCommitsCheck error &&
|
|
|
|
rebase_setup_and_clean missing-commit &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 2 4" \
|
|
|
|
git rebase -i --root 2>actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect actual &&
|
2019-10-15 12:25:28 +02:00
|
|
|
cp .git/rebase-merge/git-rebase-todo.backup \
|
|
|
|
.git/rebase-merge/git-rebase-todo &&
|
|
|
|
FAKE_LINES="1 2 drop 3 4 drop 5" git rebase --edit-todo
|
|
|
|
) &&
|
2015-06-29 22:20:31 +02:00
|
|
|
git rebase --continue &&
|
|
|
|
test D = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test B = $(git cat-file commit HEAD^ | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
test_expect_success 'rebase --edit-todo respects rebase.missingCommitsCheck = ignore' '
|
|
|
|
test_config rebase.missingCommitsCheck ignore &&
|
|
|
|
rebase_setup_and_clean missing-commit &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="break 1 2 3 4 5" git rebase -i --root &&
|
|
|
|
FAKE_LINES="1 2 3 4" git rebase --edit-todo &&
|
|
|
|
git rebase --continue 2>actual
|
|
|
|
) &&
|
|
|
|
test D = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test_i18ngrep \
|
|
|
|
"Successfully rebased and updated refs/heads/missing-commit" \
|
|
|
|
actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase --edit-todo respects rebase.missingCommitsCheck = warn' '
|
|
|
|
cat >expect <<-EOF &&
|
2020-11-24 11:15:49 +01:00
|
|
|
error: invalid line 1: badcmd $(git rev-list --pretty=oneline --abbrev-commit -1 primary~4)
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
Warning: some commits may have been dropped accidentally.
|
|
|
|
Dropped commits (newer to older):
|
2020-11-24 11:15:49 +01:00
|
|
|
- $(git rev-list --pretty=oneline --abbrev-commit -1 primary)
|
|
|
|
- $(git rev-list --pretty=oneline --abbrev-commit -1 primary~4)
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
To avoid this message, use "drop" to explicitly remove a commit.
|
|
|
|
EOF
|
|
|
|
head -n4 expect >expect.2 &&
|
|
|
|
tail -n1 expect >>expect.2 &&
|
|
|
|
tail -n4 expect.2 >expect.3 &&
|
|
|
|
test_config rebase.missingCommitsCheck warn &&
|
|
|
|
rebase_setup_and_clean missing-commit &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="bad 1 2 3 4 5" \
|
|
|
|
git rebase -i --root &&
|
|
|
|
cp .git/rebase-merge/git-rebase-todo.backup orig &&
|
|
|
|
FAKE_LINES="2 3 4" git rebase --edit-todo 2>actual.2 &&
|
|
|
|
head -n6 actual.2 >actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect actual &&
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
cp orig .git/rebase-merge/git-rebase-todo &&
|
|
|
|
FAKE_LINES="1 2 3 4" git rebase --edit-todo 2>actual.2 &&
|
|
|
|
head -n4 actual.2 >actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect.3 actual &&
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
git rebase --continue 2>actual
|
|
|
|
) &&
|
|
|
|
test D = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test_i18ngrep \
|
|
|
|
"Successfully rebased and updated refs/heads/missing-commit" \
|
|
|
|
actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase --edit-todo respects rebase.missingCommitsCheck = error' '
|
|
|
|
cat >expect <<-EOF &&
|
2020-11-24 11:15:49 +01:00
|
|
|
error: invalid line 1: badcmd $(git rev-list --pretty=oneline --abbrev-commit -1 primary~4)
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
Warning: some commits may have been dropped accidentally.
|
|
|
|
Dropped commits (newer to older):
|
2020-11-24 11:15:49 +01:00
|
|
|
- $(git rev-list --pretty=oneline --abbrev-commit -1 primary)
|
|
|
|
- $(git rev-list --pretty=oneline --abbrev-commit -1 primary~4)
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
To avoid this message, use "drop" to explicitly remove a commit.
|
|
|
|
|
|
|
|
Use '\''git config rebase.missingCommitsCheck'\'' to change the level of warnings.
|
|
|
|
The possible behaviours are: ignore, warn, error.
|
|
|
|
|
|
|
|
You can fix this with '\''git rebase --edit-todo'\'' and then run '\''git rebase --continue'\''.
|
|
|
|
Or you can abort the rebase with '\''git rebase --abort'\''.
|
|
|
|
EOF
|
|
|
|
tail -n11 expect >expect.2 &&
|
|
|
|
head -n3 expect.2 >expect.3 &&
|
|
|
|
tail -n7 expect.2 >>expect.3 &&
|
|
|
|
test_config rebase.missingCommitsCheck error &&
|
|
|
|
rebase_setup_and_clean missing-commit &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="bad 1 2 3 4 5" \
|
|
|
|
git rebase -i --root &&
|
|
|
|
cp .git/rebase-merge/git-rebase-todo.backup orig &&
|
|
|
|
test_must_fail env FAKE_LINES="2 3 4" \
|
|
|
|
git rebase --edit-todo 2>actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect actual &&
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
test_must_fail git rebase --continue 2>actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect.2 actual &&
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
test_must_fail git rebase --edit-todo &&
|
|
|
|
cp orig .git/rebase-merge/git-rebase-todo &&
|
|
|
|
test_must_fail env FAKE_LINES="1 2 3 4" \
|
|
|
|
git rebase --edit-todo 2>actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect.3 actual &&
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
test_must_fail git rebase --continue 2>actual &&
|
2021-02-11 02:53:53 +01:00
|
|
|
test_cmp expect.3 actual &&
|
rebase-interactive: warn if commit is dropped with `rebase --edit-todo'
When set to "warn" or "error", `rebase.missingCommitsCheck' would make
`rebase -i' warn if the user removed commits from the todo list to
prevent mistakes. Unfortunately, `rebase --edit-todo' and `rebase
--continue' don't take it into account.
This adds the ability for `rebase --edit-todo' and `rebase --continue'
to check if commits were dropped by the user. As both edit_todo_list()
and complete_action() parse the todo list and check for dropped commits,
the code doing so in the latter is removed to reduce duplication.
`edit_todo_list_advice' is removed from sequencer.c as it is no longer
used there.
This changes when a backup of the todo list is made. Until now, it was
saved only once, before the initial edit. Now, it is also made if the
original todo list has no errors or no dropped commits. Thus, the
backup should be error-free. Without this, sequencer_continue()
(`rebase --continue') could only compare the current todo list against
the original, unedited list. Before this change, this file was only
used by edit_todo_list() and `rebase -p' to create the backup before
the initial edit, and check_todo_list_from_file(), only used by
`rebase -p' to check for dropped commits after its own initial edit.
If the edited list has an error, a file, `dropped', is created to
report the issue. Otherwise, it is deleted. Usually, the edited list
is compared against the list before editing, but if this file exists,
it will be compared to the backup. Also, if the file exists,
sequencer_continue() checks the list for dropped commits. If the
check was performed every time, it would fail when resuming a rebase
after resolving a conflict, as the backup will contain commits that
were picked, but they will not be in the new list. It's safe to
ignore this check if `dropped' does not exist, because that means that
no errors were found at the last edition, so any missing commits here
have already been picked.
Five tests are added to t3404. The tests for
`rebase.missingCommitsCheck = warn' and `rebase.missingCommitsCheck =
error' have a similar structure. First, we start a rebase with an
incorrect command on the first line. Then, we edit the todo list,
removing the first and the last lines. This demonstrates that
`--edit-todo' notices dropped commits, but not when the command is
incorrect. Then, we restore the original todo list, and edit it to
remove the last line. This demonstrates that if we add a commit after
the initial edit, then remove it, `--edit-todo' will notice that it
has been dropped. Then, the actual rebase takes place. In the third
test, it is also checked that `--continue' will refuse to resume the
rebase if commits were dropped. The fourth test checks that no errors
are raised when resuming a rebase after resolving a conflict, the fifth
checks that no errors are raised when editing the todo list after
pausing the rebase.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-28 22:12:46 +01:00
|
|
|
cp orig .git/rebase-merge/git-rebase-todo &&
|
|
|
|
FAKE_LINES="1 2 3 4 drop 5" git rebase --edit-todo &&
|
|
|
|
git rebase --continue 2>actual
|
|
|
|
) &&
|
|
|
|
test D = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test_i18ngrep \
|
|
|
|
"Successfully rebased and updated refs/heads/missing-commit" \
|
|
|
|
actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase.missingCommitsCheck = error after resolving conflicts' '
|
|
|
|
test_config rebase.missingCommitsCheck error &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="drop 1 break 2 3 4" git rebase -i A E
|
|
|
|
) &&
|
|
|
|
git rebase --edit-todo &&
|
|
|
|
test_must_fail git rebase --continue &&
|
|
|
|
echo x >file1 &&
|
|
|
|
git add file1 &&
|
|
|
|
git rebase --continue
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase.missingCommitsCheck = error when editing for a second time' '
|
|
|
|
test_config rebase.missingCommitsCheck error &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 break 2 3" git rebase -i A D &&
|
|
|
|
cp .git/rebase-merge/git-rebase-todo todo &&
|
|
|
|
test_must_fail env FAKE_LINES=2 git rebase --edit-todo &&
|
|
|
|
GIT_SEQUENCE_EDITOR="cp todo" git rebase --edit-todo &&
|
|
|
|
git rebase --continue
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2017-12-05 18:52:35 +01:00
|
|
|
test_expect_success 'respects rebase.abbreviateCommands with fixup, squash and exec' '
|
|
|
|
rebase_setup_and_clean abbrevcmd &&
|
|
|
|
test_commit "first" file1.txt "first line" first &&
|
|
|
|
test_commit "second" file1.txt "another line" second &&
|
|
|
|
test_commit "fixup! first" file2.txt "first line again" first_fixup &&
|
|
|
|
test_commit "squash! second" file1.txt "another line here" second_squash &&
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
p $(git rev-list --abbrev-commit -1 first) first
|
|
|
|
f $(git rev-list --abbrev-commit -1 first_fixup) fixup! first
|
|
|
|
x git show HEAD
|
|
|
|
p $(git rev-list --abbrev-commit -1 second) second
|
|
|
|
s $(git rev-list --abbrev-commit -1 second_squash) squash! second
|
|
|
|
x git show HEAD
|
|
|
|
EOF
|
|
|
|
git checkout abbrevcmd &&
|
|
|
|
test_config rebase.abbreviateCommands true &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_cat_todo_editor &&
|
|
|
|
test_must_fail git rebase -i --exec "git show HEAD" \
|
2020-11-24 11:15:49 +01:00
|
|
|
--autosquash primary >actual
|
2019-10-15 12:25:28 +02:00
|
|
|
) &&
|
2017-12-05 18:52:35 +01:00
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
2015-06-29 22:20:32 +02:00
|
|
|
test_expect_success 'static check of bad command' '
|
|
|
|
rebase_setup_and_clean bad-cmd &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 2 3 bad 4 5" \
|
2015-06-29 22:20:32 +02:00
|
|
|
git rebase -i --root 2>actual &&
|
2020-11-24 11:15:49 +01:00
|
|
|
test_i18ngrep "badcmd $(git rev-list --oneline -1 primary~1)" \
|
2019-10-15 12:25:28 +02:00
|
|
|
actual &&
|
|
|
|
test_i18ngrep "You can fix this with .git rebase --edit-todo.." \
|
|
|
|
actual &&
|
|
|
|
FAKE_LINES="1 2 3 drop 4 5" git rebase --edit-todo
|
|
|
|
) &&
|
2015-06-29 22:20:32 +02:00
|
|
|
git rebase --continue &&
|
|
|
|
test E = $(git cat-file commit HEAD | sed -ne \$p) &&
|
|
|
|
test C = $(git cat-file commit HEAD^ | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
2015-10-01 10:18:42 +02:00
|
|
|
test_expect_success 'tabs and spaces are accepted in the todolist' '
|
|
|
|
rebase_setup_and_clean indented-comment &&
|
|
|
|
write_script add-indent.sh <<-\EOF &&
|
|
|
|
(
|
|
|
|
# Turn single spaces into space/tab mix
|
|
|
|
sed "1s/ / /g; 2s/ / /g; 3s/ / /g" "$1"
|
|
|
|
printf "\n\t# comment\n #more\n\t # comment\n"
|
2015-12-02 21:50:07 +01:00
|
|
|
) >"$1.new"
|
2015-10-01 10:18:42 +02:00
|
|
|
mv "$1.new" "$1"
|
|
|
|
EOF
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
test_set_editor "$(pwd)/add-indent.sh" &&
|
|
|
|
git rebase -i HEAD^^^
|
|
|
|
) &&
|
2015-10-01 10:18:42 +02:00
|
|
|
test E = $(git cat-file commit HEAD | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
2015-06-29 22:20:32 +02:00
|
|
|
test_expect_success 'static check of bad SHA-1' '
|
|
|
|
rebase_setup_and_clean bad-sha &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
test_must_fail env FAKE_LINES="1 2 edit fakesha 3 4 5 #" \
|
|
|
|
git rebase -i --root 2>actual &&
|
|
|
|
test_i18ngrep "edit XXXXXXX False commit" actual &&
|
|
|
|
test_i18ngrep "You can fix this with .git rebase --edit-todo.." \
|
|
|
|
actual &&
|
|
|
|
FAKE_LINES="1 2 4 5 6" git rebase --edit-todo
|
|
|
|
) &&
|
2015-06-29 22:20:32 +02:00
|
|
|
git rebase --continue &&
|
|
|
|
test E = $(git cat-file commit HEAD | sed -ne \$p)
|
|
|
|
'
|
|
|
|
|
2015-10-28 15:54:48 +01:00
|
|
|
test_expect_success 'editor saves as CR/LF' '
|
2015-10-28 15:54:21 +01:00
|
|
|
git checkout -b with-crlf &&
|
|
|
|
write_script add-crs.sh <<-\EOF &&
|
|
|
|
sed -e "s/\$/Q/" <"$1" | tr Q "\\015" >"$1".new &&
|
|
|
|
mv -f "$1".new "$1"
|
|
|
|
EOF
|
|
|
|
(
|
|
|
|
test_set_editor "$(pwd)/add-crs.sh" &&
|
|
|
|
git rebase -i HEAD^
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2016-07-07 17:52:50 +02:00
|
|
|
test_expect_success 'rebase -i --gpg-sign=<key-id>' '
|
2017-12-22 12:50:50 +01:00
|
|
|
test_when_finished "test_might_fail git rebase --abort" &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1" git rebase -i --gpg-sign="\"S I Gner\"" \
|
|
|
|
HEAD^ >out 2>err
|
|
|
|
) &&
|
2017-12-22 12:50:50 +01:00
|
|
|
test_i18ngrep "$SQ-S\"S I Gner\"$SQ" err
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -i --gpg-sign=<key-id> overrides commit.gpgSign' '
|
|
|
|
test_when_finished "test_might_fail git rebase --abort" &&
|
|
|
|
test_config commit.gpgsign true &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 1" git rebase -i --gpg-sign="\"S I Gner\"" \
|
|
|
|
HEAD^ >out 2>err
|
|
|
|
) &&
|
2016-08-12 13:59:00 +02:00
|
|
|
test_i18ngrep "$SQ-S\"S I Gner\"$SQ" err
|
2016-07-07 17:52:50 +02:00
|
|
|
'
|
|
|
|
|
2018-07-31 09:33:28 +02:00
|
|
|
test_expect_success 'valid author header after --root swap' '
|
|
|
|
rebase_setup_and_clean author-header no-conflict-branch &&
|
2018-08-07 11:34:52 +02:00
|
|
|
git commit --amend --author="Au ${SQ}thor <author@example.com>" --no-edit &&
|
|
|
|
git cat-file commit HEAD | grep ^author >expected &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="5 1" git rebase -i --root
|
|
|
|
) &&
|
2018-08-07 11:34:52 +02:00
|
|
|
git cat-file commit HEAD^ | grep ^author >actual &&
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'valid author header when author contains single quote' '
|
|
|
|
rebase_setup_and_clean author-header no-conflict-branch &&
|
|
|
|
git commit --amend --author="Au ${SQ}thor <author@example.com>" --no-edit &&
|
|
|
|
git cat-file commit HEAD | grep ^author >expected &&
|
2019-10-15 12:25:28 +02:00
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="2" git rebase -i HEAD~2
|
|
|
|
) &&
|
2018-08-07 11:34:52 +02:00
|
|
|
git cat-file commit HEAD | grep ^author >actual &&
|
|
|
|
test_cmp expected actual
|
2018-07-31 09:33:28 +02:00
|
|
|
'
|
|
|
|
|
2019-10-15 12:25:32 +02:00
|
|
|
test_expect_success 'post-commit hook is called' '
|
|
|
|
test_when_finished "rm -f .git/hooks/post-commit" &&
|
|
|
|
>actual &&
|
|
|
|
mkdir -p .git/hooks &&
|
|
|
|
write_script .git/hooks/post-commit <<-\EOS &&
|
|
|
|
git rev-parse HEAD >>actual
|
|
|
|
EOS
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="edit 4 1 reword 2 fixup 3" git rebase -i A E &&
|
|
|
|
echo x>file3 &&
|
|
|
|
git add file3 &&
|
|
|
|
FAKE_COMMIT_MESSAGE=edited git rebase --continue
|
|
|
|
) &&
|
|
|
|
git rev-parse HEAD@{5} HEAD@{4} HEAD@{3} HEAD@{2} HEAD@{1} HEAD \
|
|
|
|
>expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
2019-12-06 17:06:12 +01:00
|
|
|
test_expect_success 'correct error message for partial commit after empty pick' '
|
|
|
|
test_when_finished "git rebase --abort" &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="2 1 1" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
test_must_fail git rebase -i A D
|
|
|
|
) &&
|
|
|
|
echo x >file1 &&
|
|
|
|
test_must_fail git commit file1 2>err &&
|
|
|
|
test_i18ngrep "cannot do a partial commit during a rebase." err
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'correct error message for commit --amend after empty pick' '
|
|
|
|
test_when_finished "git rebase --abort" &&
|
|
|
|
(
|
|
|
|
set_fake_editor &&
|
|
|
|
FAKE_LINES="1 1" &&
|
|
|
|
export FAKE_LINES &&
|
|
|
|
test_must_fail git rebase -i A D
|
|
|
|
) &&
|
|
|
|
echo x>file1 &&
|
|
|
|
test_must_fail git commit -a --amend 2>err &&
|
|
|
|
test_i18ngrep "middle of a rebase -- cannot amend." err
|
|
|
|
'
|
|
|
|
|
2020-08-13 19:42:57 +02:00
|
|
|
test_expect_success 'todo has correct onto hash' '
|
|
|
|
GIT_SEQUENCE_EDITOR=cat git rebase -i no-conflict-branch~4 no-conflict-branch >actual &&
|
|
|
|
onto=$(git rev-parse --short HEAD~4) &&
|
|
|
|
test_i18ngrep "^# Rebase ..* onto $onto" actual
|
|
|
|
'
|
|
|
|
|
2020-11-04 16:29:37 +01:00
|
|
|
test_expect_success 'ORIG_HEAD is updated correctly' '
|
2020-11-24 11:15:49 +01:00
|
|
|
test_when_finished "git checkout primary && git branch -D test-orig-head" &&
|
2020-11-04 16:29:37 +01:00
|
|
|
git checkout -b test-orig-head A &&
|
|
|
|
git commit --allow-empty -m A1 &&
|
|
|
|
git commit --allow-empty -m A2 &&
|
|
|
|
git commit --allow-empty -m A3 &&
|
|
|
|
git commit --allow-empty -m A4 &&
|
2020-11-24 11:15:49 +01:00
|
|
|
git rebase primary &&
|
2020-11-04 16:29:37 +01:00
|
|
|
test_cmp_rev ORIG_HEAD test-orig-head@{1}
|
|
|
|
'
|
|
|
|
|
2019-10-15 12:25:29 +02:00
|
|
|
# This must be the last test in this file
|
|
|
|
test_expect_success '$EDITOR and friends are unchanged' '
|
|
|
|
test_editor_unchanged
|
|
|
|
'
|
|
|
|
|
2007-06-25 02:11:14 +02:00
|
|
|
test_done
|