2009-10-09 12:22:00 +02:00
|
|
|
#!/bin/sh
|
|
|
|
#
|
|
|
|
# Copyright (c) 2007 Johannes E. Schindelin
|
|
|
|
#
|
|
|
|
|
|
|
|
test_description='Test commit notes index (expensive!)'
|
|
|
|
|
2020-11-19 00:44:23 +01:00
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
tests: mark tests relying on the current default for `init.defaultBranch`
In addition to the manual adjustment to let the `linux-gcc` CI job run
the test suite with `master` and then with `main`, this patch makes sure
that GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME is set in all test scripts
that currently rely on the initial branch name being `master by default.
To determine which test scripts to mark up, the first step was to
force-set the default branch name to `master` in
- all test scripts that contain the keyword `master`,
- t4211, which expects `t/t4211/history.export` with a hard-coded ref to
initialize the default branch,
- t5560 because it sources `t/t556x_common` which uses `master`,
- t8002 and t8012 because both source `t/annotate-tests.sh` which also
uses `master`)
This trick was performed by this command:
$ sed -i '/^ *\. \.\/\(test-lib\|lib-\(bash\|cvs\|git-svn\)\|gitweb-lib\)\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' $(git grep -l master t/t[0-9]*.sh) \
t/t4211*.sh t/t5560*.sh t/t8002*.sh t/t8012*.sh
After that, careful, manual inspection revealed that some of the test
scripts containing the needle `master` do not actually rely on a
specific default branch name: either they mention `master` only in a
comment, or they initialize that branch specificially, or they do not
actually refer to the current default branch. Therefore, the
aforementioned modification was undone in those test scripts thusly:
$ git checkout HEAD -- \
t/t0027-auto-crlf.sh t/t0060-path-utils.sh \
t/t1011-read-tree-sparse-checkout.sh \
t/t1305-config-include.sh t/t1309-early-config.sh \
t/t1402-check-ref-format.sh t/t1450-fsck.sh \
t/t2024-checkout-dwim.sh \
t/t2106-update-index-assume-unchanged.sh \
t/t3040-subprojects-basic.sh t/t3301-notes.sh \
t/t3308-notes-merge.sh t/t3423-rebase-reword.sh \
t/t3436-rebase-more-options.sh \
t/t4015-diff-whitespace.sh t/t4257-am-interactive.sh \
t/t5323-pack-redundant.sh t/t5401-update-hooks.sh \
t/t5511-refspec.sh t/t5526-fetch-submodules.sh \
t/t5529-push-errors.sh t/t5530-upload-pack-error.sh \
t/t5548-push-porcelain.sh \
t/t5552-skipping-fetch-negotiator.sh \
t/t5572-pull-submodule.sh t/t5608-clone-2gb.sh \
t/t5614-clone-submodules-shallow.sh \
t/t7508-status.sh t/t7606-merge-custom.sh \
t/t9302-fast-import-unpack-limit.sh
We excluded one set of test scripts in these commands, though: the range
of `git p4` tests. The reason? `git p4` stores the (foreign) remote
branch in the branch called `p4/master`, which is obviously not the
default branch. Manual analysis revealed that only five of these tests
actually require a specific default branch name to pass; They were
modified thusly:
$ sed -i '/^ *\. \.\/lib-git-p4\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' t/t980[0167]*.sh t/t9811*.sh
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-11-19 00:44:19 +01:00
|
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
|
revisions API: have release_revisions() release "mailmap"
Extend the the release_revisions() function so that it frees the
"mailmap" in the "struct rev_info".
The log family of functions now calls the clear_mailmap() function
added in fa8afd18e5a (revisions API: provide and use a
release_revisions(), 2021-09-19), allowing us to whitelist some tests
with "TEST_PASSES_SANITIZE_LEAK=true".
Unfortunately having a pointer to a mailmap in "struct rev_info"
instead of an embedded member that we "own" get a bit messy, as can be
seen in the change to builtin/commit.c.
When we free() this data we won't be able to tell apart a pointer to a
"mailmap" on the heap from one on the stack. As seen in
ea57bc0d41b (log: add --use-mailmap option, 2013-01-05) the "log"
family allocates it on the heap, but in the find_author_by_nickname()
code added in ea16794e430 (commit: search author pattern against
mailmap, 2013-08-23) we allocated it on the stack instead.
Ideally we'd simply change that member to a "struct string_list
mailmap" and never free() the "mailmap" itself, but that would be a
much larger change to the revisions API.
We have code that needs to hand an existing "mailmap" to a "struct
rev_info", while we could change all of that, let's not go there
now.
The complexity isn't in the ownership of the "mailmap" per-se, but
that various things assume a "rev_info.mailmap == NULL" means "doesn't
want mailmap", if we changed that to an init'd "struct string_list
we'd need to carefully refactor things to change those assumptions.
Let's instead always free() it, and simply declare that if you add
such a "mailmap" it must be allocated on the heap. Any modern libc
will correctly panic if we free() a stack variable, so this should be
safe going forward.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2022-04-13 22:01:46 +02:00
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
2009-10-09 12:22:00 +02:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
create_repo () {
|
|
|
|
number_of_commits=$1
|
|
|
|
nr=0
|
|
|
|
test -d .git || {
|
|
|
|
git init &&
|
2009-10-09 12:22:03 +02:00
|
|
|
(
|
2014-06-09 22:21:59 +02:00
|
|
|
while test $nr -lt $number_of_commits
|
|
|
|
do
|
2009-10-09 12:22:03 +02:00
|
|
|
nr=$(($nr+1))
|
|
|
|
mark=$(($nr+$nr))
|
|
|
|
notemark=$(($mark+1))
|
|
|
|
test_tick &&
|
2014-06-09 22:21:59 +02:00
|
|
|
cat <<-INPUT_END &&
|
2020-11-19 00:44:23 +01:00
|
|
|
commit refs/heads/main
|
2014-06-09 22:21:59 +02:00
|
|
|
mark :$mark
|
|
|
|
committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE
|
|
|
|
data <<COMMIT
|
|
|
|
commit #$nr
|
|
|
|
COMMIT
|
|
|
|
|
|
|
|
M 644 inline file
|
|
|
|
data <<EOF
|
|
|
|
file in commit #$nr
|
|
|
|
EOF
|
|
|
|
|
|
|
|
blob
|
|
|
|
mark :$notemark
|
|
|
|
data <<EOF
|
|
|
|
note for commit #$nr
|
|
|
|
EOF
|
|
|
|
|
|
|
|
INPUT_END
|
|
|
|
echo "N :$notemark :$mark" >>note_commit
|
2009-10-09 12:22:03 +02:00
|
|
|
done &&
|
2009-10-09 12:22:00 +02:00
|
|
|
test_tick &&
|
2014-06-09 22:21:59 +02:00
|
|
|
cat <<-INPUT_END &&
|
|
|
|
commit refs/notes/commits
|
|
|
|
committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE
|
|
|
|
data <<COMMIT
|
|
|
|
notes
|
|
|
|
COMMIT
|
2009-10-09 12:22:03 +02:00
|
|
|
|
2014-06-09 22:21:59 +02:00
|
|
|
INPUT_END
|
2009-10-09 12:22:03 +02:00
|
|
|
|
|
|
|
cat note_commit
|
|
|
|
) |
|
|
|
|
git fast-import --quiet &&
|
2009-10-09 12:22:00 +02:00
|
|
|
git config core.notesRef refs/notes/commits
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
test_notes () {
|
|
|
|
count=$1 &&
|
|
|
|
git config core.notesRef refs/notes/commits &&
|
2022-03-07 13:49:00 +01:00
|
|
|
git log >tmp &&
|
|
|
|
grep "^ " tmp >output &&
|
2009-10-09 12:22:03 +02:00
|
|
|
i=$count &&
|
2014-06-09 22:21:59 +02:00
|
|
|
while test $i -gt 0
|
|
|
|
do
|
2009-10-09 12:22:03 +02:00
|
|
|
echo " commit #$i" &&
|
|
|
|
echo " note for commit #$i" &&
|
2014-06-09 22:21:59 +02:00
|
|
|
i=$(($i-1))
|
|
|
|
done >expect &&
|
2009-10-09 12:22:03 +02:00
|
|
|
test_cmp expect output
|
2009-10-09 12:22:00 +02:00
|
|
|
}
|
|
|
|
|
2014-06-09 22:21:59 +02:00
|
|
|
write_script time_notes <<\EOF
|
2009-10-09 12:22:00 +02:00
|
|
|
mode=$1
|
|
|
|
i=1
|
2014-06-09 22:21:59 +02:00
|
|
|
while test $i -lt $2
|
|
|
|
do
|
2009-10-09 12:22:00 +02:00
|
|
|
case $1 in
|
|
|
|
no-notes)
|
2014-06-09 22:21:59 +02:00
|
|
|
GIT_NOTES_REF=non-existing
|
|
|
|
export GIT_NOTES_REF
|
|
|
|
;;
|
2009-10-09 12:22:00 +02:00
|
|
|
notes)
|
|
|
|
unset GIT_NOTES_REF
|
2014-06-09 22:21:59 +02:00
|
|
|
;;
|
2009-10-09 12:22:00 +02:00
|
|
|
esac
|
2022-03-07 13:49:00 +01:00
|
|
|
git log || exit $?
|
2009-10-09 12:22:00 +02:00
|
|
|
i=$(($i+1))
|
2014-06-09 22:21:59 +02:00
|
|
|
done >/dev/null
|
2009-10-09 12:22:00 +02:00
|
|
|
EOF
|
|
|
|
|
|
|
|
time_notes () {
|
|
|
|
for mode in no-notes notes
|
|
|
|
do
|
|
|
|
echo $mode
|
2014-06-09 22:21:59 +02:00
|
|
|
/usr/bin/time ../time_notes $mode $1
|
2009-10-09 12:22:00 +02:00
|
|
|
done
|
|
|
|
}
|
|
|
|
|
2010-08-11 01:37:48 +02:00
|
|
|
do_tests () {
|
2014-06-09 22:43:19 +02:00
|
|
|
count=$1 pr=${2-}
|
2010-08-11 01:37:48 +02:00
|
|
|
|
2014-06-09 22:36:54 +02:00
|
|
|
test_expect_success $pr "setup $count" '
|
|
|
|
mkdir "$count" &&
|
|
|
|
(
|
|
|
|
cd "$count" &&
|
|
|
|
create_repo "$count"
|
|
|
|
)
|
2010-08-11 01:37:48 +02:00
|
|
|
'
|
2009-10-09 12:22:00 +02:00
|
|
|
|
2014-06-09 22:36:54 +02:00
|
|
|
test_expect_success $pr 'notes work' '
|
|
|
|
(
|
|
|
|
cd "$count" &&
|
|
|
|
test_notes "$count"
|
|
|
|
)
|
|
|
|
'
|
2010-08-11 01:37:48 +02:00
|
|
|
|
2014-06-09 22:43:19 +02:00
|
|
|
test_expect_success "USR_BIN_TIME${pr:+,$pr}" 'notes timing with /usr/bin/time' '
|
2014-06-09 22:36:54 +02:00
|
|
|
(
|
|
|
|
cd "$count" &&
|
|
|
|
time_notes 100
|
|
|
|
)
|
|
|
|
'
|
2010-08-11 01:37:48 +02:00
|
|
|
}
|
2009-10-09 12:22:00 +02:00
|
|
|
|
2014-06-09 22:43:19 +02:00
|
|
|
do_tests 10
|
2014-06-09 22:21:59 +02:00
|
|
|
for count in 100 1000 10000
|
|
|
|
do
|
2014-06-09 22:43:19 +02:00
|
|
|
do_tests "$count" EXPENSIVE
|
2009-10-09 12:22:00 +02:00
|
|
|
done
|
|
|
|
|
|
|
|
test_done
|