2015-08-10 19:52:45 +02:00
|
|
|
#!/bin/sh
|
|
|
|
#
|
|
|
|
# Copyright (c) 2015 Twitter, Inc
|
|
|
|
#
|
|
|
|
|
|
|
|
test_description='Test merging of notes trees in multiple worktrees'
|
|
|
|
|
2020-11-19 00:44:23 +01:00
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
tests: mark tests relying on the current default for `init.defaultBranch`
In addition to the manual adjustment to let the `linux-gcc` CI job run
the test suite with `master` and then with `main`, this patch makes sure
that GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME is set in all test scripts
that currently rely on the initial branch name being `master by default.
To determine which test scripts to mark up, the first step was to
force-set the default branch name to `master` in
- all test scripts that contain the keyword `master`,
- t4211, which expects `t/t4211/history.export` with a hard-coded ref to
initialize the default branch,
- t5560 because it sources `t/t556x_common` which uses `master`,
- t8002 and t8012 because both source `t/annotate-tests.sh` which also
uses `master`)
This trick was performed by this command:
$ sed -i '/^ *\. \.\/\(test-lib\|lib-\(bash\|cvs\|git-svn\)\|gitweb-lib\)\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' $(git grep -l master t/t[0-9]*.sh) \
t/t4211*.sh t/t5560*.sh t/t8002*.sh t/t8012*.sh
After that, careful, manual inspection revealed that some of the test
scripts containing the needle `master` do not actually rely on a
specific default branch name: either they mention `master` only in a
comment, or they initialize that branch specificially, or they do not
actually refer to the current default branch. Therefore, the
aforementioned modification was undone in those test scripts thusly:
$ git checkout HEAD -- \
t/t0027-auto-crlf.sh t/t0060-path-utils.sh \
t/t1011-read-tree-sparse-checkout.sh \
t/t1305-config-include.sh t/t1309-early-config.sh \
t/t1402-check-ref-format.sh t/t1450-fsck.sh \
t/t2024-checkout-dwim.sh \
t/t2106-update-index-assume-unchanged.sh \
t/t3040-subprojects-basic.sh t/t3301-notes.sh \
t/t3308-notes-merge.sh t/t3423-rebase-reword.sh \
t/t3436-rebase-more-options.sh \
t/t4015-diff-whitespace.sh t/t4257-am-interactive.sh \
t/t5323-pack-redundant.sh t/t5401-update-hooks.sh \
t/t5511-refspec.sh t/t5526-fetch-submodules.sh \
t/t5529-push-errors.sh t/t5530-upload-pack-error.sh \
t/t5548-push-porcelain.sh \
t/t5552-skipping-fetch-negotiator.sh \
t/t5572-pull-submodule.sh t/t5608-clone-2gb.sh \
t/t5614-clone-submodules-shallow.sh \
t/t7508-status.sh t/t7606-merge-custom.sh \
t/t9302-fast-import-unpack-limit.sh
We excluded one set of test scripts in these commands, though: the range
of `git p4` tests. The reason? `git p4` stores the (foreign) remote
branch in the branch called `p4/master`, which is obviously not the
default branch. Manual analysis revealed that only five of these tests
actually require a specific default branch name to pass; They were
modified thusly:
$ sed -i '/^ *\. \.\/lib-git-p4\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' t/t980[0167]*.sh t/t9811*.sh
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-11-19 00:44:19 +01:00
|
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
|
2021-10-31 00:24:17 +02:00
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
2015-08-10 19:52:45 +02:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
test_expect_success 'setup commit' '
|
|
|
|
test_commit tantrum
|
|
|
|
'
|
|
|
|
|
|
|
|
commit_tantrum=$(git rev-parse tantrum^{commit})
|
|
|
|
|
|
|
|
test_expect_success 'setup notes ref (x)' '
|
|
|
|
git config core.notesRef refs/notes/x &&
|
|
|
|
git notes add -m "x notes on tantrum" tantrum
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'setup local branch (y)' '
|
|
|
|
git update-ref refs/notes/y refs/notes/x &&
|
|
|
|
git config core.notesRef refs/notes/y &&
|
|
|
|
git notes remove tantrum
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'setup remote branch (z)' '
|
|
|
|
git update-ref refs/notes/z refs/notes/x &&
|
|
|
|
git config core.notesRef refs/notes/z &&
|
|
|
|
git notes add -f -m "conflicting notes on tantrum" tantrum
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'modify notes ref ourselves (x)' '
|
|
|
|
git config core.notesRef refs/notes/x &&
|
|
|
|
git notes add -f -m "more conflicting notes on tantrum" tantrum
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'create some new worktrees' '
|
2020-11-19 00:44:23 +01:00
|
|
|
git worktree add -b newbranch worktree main &&
|
|
|
|
git worktree add -b newbranch2 worktree2 main
|
2015-08-10 19:52:45 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'merge z into y fails and sets NOTES_MERGE_REF' '
|
|
|
|
git config core.notesRef refs/notes/y &&
|
|
|
|
test_must_fail git notes merge z &&
|
2021-08-02 18:53:29 +02:00
|
|
|
echo "refs/notes/y" >expect &&
|
|
|
|
git symbolic-ref NOTES_MERGE_REF >actual &&
|
|
|
|
test_cmp expect actual
|
2015-08-10 19:52:45 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'merge z into y while mid-merge in another workdir fails' '
|
|
|
|
(
|
|
|
|
cd worktree &&
|
|
|
|
git config core.notesRef refs/notes/y &&
|
|
|
|
test_must_fail git notes merge z 2>err &&
|
2016-09-15 16:59:04 +02:00
|
|
|
test_i18ngrep "a notes merge into refs/notes/y is already in-progress at" err
|
2015-08-10 19:52:45 +02:00
|
|
|
) &&
|
2021-08-02 18:53:29 +02:00
|
|
|
test_must_fail git -C worktree symbolic-ref NOTES_MERGE_REF
|
2015-08-10 19:52:45 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'merge z into x while mid-merge on y succeeds' '
|
|
|
|
(
|
|
|
|
cd worktree2 &&
|
|
|
|
git config core.notesRef refs/notes/x &&
|
2017-11-14 17:17:52 +01:00
|
|
|
test_must_fail git notes merge z >out 2>&1 &&
|
2016-06-17 22:21:14 +02:00
|
|
|
test_i18ngrep "Automatic notes merge failed" out &&
|
2015-08-10 19:52:45 +02:00
|
|
|
grep -v "A notes merge into refs/notes/x is already in-progress in" out
|
|
|
|
) &&
|
2021-08-02 18:53:29 +02:00
|
|
|
echo "refs/notes/x" >expect &&
|
|
|
|
git -C worktree2 symbolic-ref NOTES_MERGE_REF >actual &&
|
|
|
|
test_cmp expect actual
|
2015-08-10 19:52:45 +02:00
|
|
|
'
|
|
|
|
|
|
|
|
test_done
|