2007-03-01 05:26:30 +01:00
|
|
|
#include "cache.h"
|
|
|
|
#include "builtin.h"
|
|
|
|
#include "object.h"
|
|
|
|
#include "commit.h"
|
|
|
|
#include "tag.h"
|
|
|
|
#include "run-command.h"
|
|
|
|
#include "exec_cmd.h"
|
|
|
|
#include "utf8.h"
|
2007-10-07 23:02:29 +02:00
|
|
|
#include "parse-options.h"
|
2008-01-11 07:49:35 +01:00
|
|
|
#include "cache-tree.h"
|
2008-03-03 07:30:56 +01:00
|
|
|
#include "diff.h"
|
|
|
|
#include "revision.h"
|
2008-08-10 13:48:55 +02:00
|
|
|
#include "rerere.h"
|
2008-09-02 23:11:15 +02:00
|
|
|
#include "merge-recursive.h"
|
2010-03-06 21:34:42 +01:00
|
|
|
#include "refs.h"
|
2011-08-04 12:39:08 +02:00
|
|
|
#include "dir.h"
|
2011-08-04 12:39:11 +02:00
|
|
|
#include "sequencer.h"
|
2007-03-01 05:26:30 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* This implements the builtins revert and cherry-pick.
|
|
|
|
*
|
|
|
|
* Copyright (c) 2007 Johannes E. Schindelin
|
|
|
|
*
|
|
|
|
* Based on git-revert.sh, which is
|
|
|
|
*
|
|
|
|
* Copyright (c) 2005 Linus Torvalds
|
|
|
|
* Copyright (c) 2005 Junio C Hamano
|
|
|
|
*/
|
|
|
|
|
2007-10-07 23:02:29 +02:00
|
|
|
static const char * const revert_usage[] = {
|
2008-07-13 15:36:15 +02:00
|
|
|
"git revert [options] <commit-ish>",
|
2011-08-04 12:39:11 +02:00
|
|
|
"git revert <subcommand>",
|
2007-10-07 23:02:29 +02:00
|
|
|
NULL
|
|
|
|
};
|
2007-03-01 05:26:30 +01:00
|
|
|
|
2007-10-07 23:02:29 +02:00
|
|
|
static const char * const cherry_pick_usage[] = {
|
2008-07-13 15:36:15 +02:00
|
|
|
"git cherry-pick [options] <commit-ish>",
|
2011-08-04 12:39:11 +02:00
|
|
|
"git cherry-pick <subcommand>",
|
2007-10-07 23:02:29 +02:00
|
|
|
NULL
|
|
|
|
};
|
2007-03-01 05:26:30 +01:00
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
enum replay_action { REVERT, CHERRY_PICK };
|
2011-11-23 02:27:21 +01:00
|
|
|
enum replay_subcommand {
|
|
|
|
REPLAY_NONE,
|
|
|
|
REPLAY_REMOVE_STATE,
|
|
|
|
REPLAY_CONTINUE,
|
|
|
|
REPLAY_ROLLBACK
|
|
|
|
};
|
2011-08-04 12:39:05 +02:00
|
|
|
|
|
|
|
struct replay_opts {
|
|
|
|
enum replay_action action;
|
2011-08-04 12:39:11 +02:00
|
|
|
enum replay_subcommand subcommand;
|
2011-08-04 12:39:05 +02:00
|
|
|
|
|
|
|
/* Boolean options */
|
|
|
|
int edit;
|
|
|
|
int record_origin;
|
|
|
|
int no_commit;
|
|
|
|
int signoff;
|
|
|
|
int allow_ff;
|
|
|
|
int allow_rerere_auto;
|
|
|
|
|
|
|
|
int mainline;
|
|
|
|
|
|
|
|
/* Merge strategy */
|
|
|
|
const char *strategy;
|
|
|
|
const char **xopts;
|
|
|
|
size_t xopts_nr, xopts_alloc;
|
2011-08-13 19:06:23 +02:00
|
|
|
|
|
|
|
/* Only used by REPLAY_NONE */
|
|
|
|
struct rev_info *revs;
|
2011-08-04 12:39:05 +02:00
|
|
|
};
|
2007-03-01 05:26:30 +01:00
|
|
|
|
|
|
|
#define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION"
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
static const char *action_name(const struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
return opts->action == REVERT ? "revert" : "cherry-pick";
|
|
|
|
}
|
|
|
|
|
2010-03-21 01:45:21 +01:00
|
|
|
static char *get_encoding(const char *message);
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
static const char * const *revert_or_cherry_pick_usage(struct replay_opts *opts)
|
2010-06-14 07:32:09 +02:00
|
|
|
{
|
2011-08-04 12:39:05 +02:00
|
|
|
return opts->action == REVERT ? revert_usage : cherry_pick_usage;
|
2010-06-14 07:32:09 +02:00
|
|
|
}
|
|
|
|
|
2010-12-11 01:51:44 +01:00
|
|
|
static int option_parse_x(const struct option *opt,
|
|
|
|
const char *arg, int unset)
|
|
|
|
{
|
2011-08-04 12:39:05 +02:00
|
|
|
struct replay_opts **opts_ptr = opt->value;
|
|
|
|
struct replay_opts *opts = *opts_ptr;
|
|
|
|
|
2010-12-11 01:51:44 +01:00
|
|
|
if (unset)
|
|
|
|
return 0;
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
ALLOC_GROW(opts->xopts, opts->xopts_nr + 1, opts->xopts_alloc);
|
|
|
|
opts->xopts[opts->xopts_nr++] = xstrdup(arg);
|
2010-12-11 01:51:44 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:07 +02:00
|
|
|
static void verify_opt_compatible(const char *me, const char *base_opt, ...)
|
|
|
|
{
|
|
|
|
const char *this_opt;
|
|
|
|
va_list ap;
|
|
|
|
|
|
|
|
va_start(ap, base_opt);
|
|
|
|
while ((this_opt = va_arg(ap, const char *))) {
|
|
|
|
if (va_arg(ap, int))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
va_end(ap);
|
|
|
|
|
|
|
|
if (this_opt)
|
|
|
|
die(_("%s: %s cannot be used with %s"), me, this_opt, base_opt);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:15 +02:00
|
|
|
static void verify_opt_mutually_compatible(const char *me, ...)
|
|
|
|
{
|
2011-09-11 21:39:32 +02:00
|
|
|
const char *opt1, *opt2 = NULL;
|
2011-08-04 12:39:15 +02:00
|
|
|
va_list ap;
|
|
|
|
|
|
|
|
va_start(ap, me);
|
|
|
|
while ((opt1 = va_arg(ap, const char *))) {
|
|
|
|
if (va_arg(ap, int))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (opt1) {
|
|
|
|
while ((opt2 = va_arg(ap, const char *))) {
|
|
|
|
if (va_arg(ap, int))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (opt1 && opt2)
|
|
|
|
die(_("%s: %s cannot be used with %s"), me, opt1, opt2);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
static void parse_args(int argc, const char **argv, struct replay_opts *opts)
|
2007-03-01 05:26:30 +01:00
|
|
|
{
|
2011-08-04 12:39:05 +02:00
|
|
|
const char * const * usage_str = revert_or_cherry_pick_usage(opts);
|
2011-08-04 12:39:07 +02:00
|
|
|
const char *me = action_name(opts);
|
2011-11-22 12:14:29 +01:00
|
|
|
int remove_state = 0;
|
2011-08-04 12:39:15 +02:00
|
|
|
int contin = 0;
|
2011-11-23 02:27:21 +01:00
|
|
|
int rollback = 0;
|
2007-10-07 23:02:29 +02:00
|
|
|
struct option options[] = {
|
2011-11-22 12:14:29 +01:00
|
|
|
OPT_BOOLEAN(0, "quit", &remove_state, "end revert or cherry-pick sequence"),
|
|
|
|
OPT_BOOLEAN(0, "continue", &contin, "resume revert or cherry-pick sequence"),
|
2011-11-23 02:27:21 +01:00
|
|
|
OPT_BOOLEAN(0, "abort", &rollback, "cancel revert or cherry-pick sequence"),
|
2011-08-04 12:39:05 +02:00
|
|
|
OPT_BOOLEAN('n', "no-commit", &opts->no_commit, "don't automatically commit"),
|
|
|
|
OPT_BOOLEAN('e', "edit", &opts->edit, "edit the commit message"),
|
2011-09-28 19:47:50 +02:00
|
|
|
OPT_NOOP_NOARG('r', NULL),
|
2011-08-04 12:39:05 +02:00
|
|
|
OPT_BOOLEAN('s', "signoff", &opts->signoff, "add Signed-off-by:"),
|
|
|
|
OPT_INTEGER('m', "mainline", &opts->mainline, "parent number"),
|
|
|
|
OPT_RERERE_AUTOUPDATE(&opts->allow_rerere_auto),
|
|
|
|
OPT_STRING(0, "strategy", &opts->strategy, "strategy", "merge strategy"),
|
|
|
|
OPT_CALLBACK('X', "strategy-option", &opts, "option",
|
2010-12-11 01:51:44 +01:00
|
|
|
"option for merge strategy", option_parse_x),
|
2007-10-07 23:02:29 +02:00
|
|
|
OPT_END(),
|
2010-03-06 21:34:42 +01:00
|
|
|
OPT_END(),
|
|
|
|
OPT_END(),
|
2007-10-07 23:02:29 +02:00
|
|
|
};
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
if (opts->action == CHERRY_PICK) {
|
2010-03-06 21:34:42 +01:00
|
|
|
struct option cp_extra[] = {
|
2011-08-04 12:39:05 +02:00
|
|
|
OPT_BOOLEAN('x', NULL, &opts->record_origin, "append commit name"),
|
|
|
|
OPT_BOOLEAN(0, "ff", &opts->allow_ff, "allow fast-forward"),
|
2010-03-06 21:34:42 +01:00
|
|
|
OPT_END(),
|
|
|
|
};
|
|
|
|
if (parse_options_concat(options, ARRAY_SIZE(options), cp_extra))
|
2011-02-23 00:42:28 +01:00
|
|
|
die(_("program error"));
|
2010-03-06 21:34:42 +01:00
|
|
|
}
|
|
|
|
|
2011-08-13 19:06:23 +02:00
|
|
|
argc = parse_options(argc, argv, NULL, options, usage_str,
|
|
|
|
PARSE_OPT_KEEP_ARGV0 |
|
|
|
|
PARSE_OPT_KEEP_UNKNOWN);
|
2011-08-04 12:39:11 +02:00
|
|
|
|
2011-08-04 12:39:15 +02:00
|
|
|
/* Check for incompatible subcommands */
|
|
|
|
verify_opt_mutually_compatible(me,
|
2011-11-22 12:14:29 +01:00
|
|
|
"--quit", remove_state,
|
2011-08-04 12:39:15 +02:00
|
|
|
"--continue", contin,
|
2011-11-23 02:27:21 +01:00
|
|
|
"--abort", rollback,
|
2011-08-04 12:39:15 +02:00
|
|
|
NULL);
|
|
|
|
|
2011-08-04 12:39:11 +02:00
|
|
|
/* Set the subcommand */
|
2011-11-22 12:14:29 +01:00
|
|
|
if (remove_state)
|
|
|
|
opts->subcommand = REPLAY_REMOVE_STATE;
|
2011-08-04 12:39:15 +02:00
|
|
|
else if (contin)
|
|
|
|
opts->subcommand = REPLAY_CONTINUE;
|
2011-11-23 02:27:21 +01:00
|
|
|
else if (rollback)
|
|
|
|
opts->subcommand = REPLAY_ROLLBACK;
|
2011-08-04 12:39:11 +02:00
|
|
|
else
|
|
|
|
opts->subcommand = REPLAY_NONE;
|
|
|
|
|
|
|
|
/* Check for incompatible command line arguments */
|
2011-08-04 12:39:15 +02:00
|
|
|
if (opts->subcommand != REPLAY_NONE) {
|
|
|
|
char *this_operation;
|
2011-11-22 12:14:29 +01:00
|
|
|
if (opts->subcommand == REPLAY_REMOVE_STATE)
|
|
|
|
this_operation = "--quit";
|
2011-11-23 02:27:21 +01:00
|
|
|
else if (opts->subcommand == REPLAY_CONTINUE)
|
2011-08-04 12:39:15 +02:00
|
|
|
this_operation = "--continue";
|
2011-11-23 02:27:21 +01:00
|
|
|
else {
|
|
|
|
assert(opts->subcommand == REPLAY_ROLLBACK);
|
|
|
|
this_operation = "--abort";
|
|
|
|
}
|
2011-08-04 12:39:15 +02:00
|
|
|
|
|
|
|
verify_opt_compatible(me, this_operation,
|
2011-08-04 12:39:11 +02:00
|
|
|
"--no-commit", opts->no_commit,
|
|
|
|
"--signoff", opts->signoff,
|
|
|
|
"--mainline", opts->mainline,
|
|
|
|
"--strategy", opts->strategy ? 1 : 0,
|
|
|
|
"--strategy-option", opts->xopts ? 1 : 0,
|
|
|
|
"-x", opts->record_origin,
|
|
|
|
"--ff", opts->allow_ff,
|
|
|
|
NULL);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:07 +02:00
|
|
|
if (opts->allow_ff)
|
|
|
|
verify_opt_compatible(me, "--ff",
|
|
|
|
"--signoff", opts->signoff,
|
|
|
|
"--no-commit", opts->no_commit,
|
|
|
|
"-x", opts->record_origin,
|
|
|
|
"--edit", opts->edit,
|
|
|
|
NULL);
|
2011-08-13 19:06:23 +02:00
|
|
|
|
|
|
|
if (opts->subcommand != REPLAY_NONE) {
|
|
|
|
opts->revs = NULL;
|
|
|
|
} else {
|
|
|
|
opts->revs = xmalloc(sizeof(*opts->revs));
|
|
|
|
init_revisions(opts->revs, NULL);
|
|
|
|
opts->revs->no_walk = 1;
|
|
|
|
if (argc < 2)
|
|
|
|
usage_with_options(usage_str, options);
|
|
|
|
argc = setup_revisions(argc, argv, opts->revs, NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (argc > 1)
|
|
|
|
usage_with_options(usage_str, options);
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
|
|
|
|
2010-03-21 01:45:21 +01:00
|
|
|
struct commit_message {
|
|
|
|
char *parent_label;
|
|
|
|
const char *label;
|
|
|
|
const char *subject;
|
|
|
|
char *reencoded_message;
|
|
|
|
const char *message;
|
|
|
|
};
|
|
|
|
|
2011-08-04 12:39:04 +02:00
|
|
|
static int get_message(struct commit *commit, struct commit_message *out)
|
2007-03-01 05:26:30 +01:00
|
|
|
{
|
2010-03-21 01:45:21 +01:00
|
|
|
const char *encoding;
|
2010-07-22 15:18:31 +02:00
|
|
|
const char *abbrev, *subject;
|
|
|
|
int abbrev_len, subject_len;
|
2010-03-21 01:45:21 +01:00
|
|
|
char *q;
|
2007-03-01 05:26:30 +01:00
|
|
|
|
2011-08-04 12:39:04 +02:00
|
|
|
if (!commit->buffer)
|
2010-03-21 01:45:21 +01:00
|
|
|
return -1;
|
2011-08-04 12:39:04 +02:00
|
|
|
encoding = get_encoding(commit->buffer);
|
2010-03-21 01:45:21 +01:00
|
|
|
if (!encoding)
|
|
|
|
encoding = "UTF-8";
|
|
|
|
if (!git_commit_encoding)
|
|
|
|
git_commit_encoding = "UTF-8";
|
2010-05-09 01:17:29 +02:00
|
|
|
|
|
|
|
out->reencoded_message = NULL;
|
2011-08-04 12:39:04 +02:00
|
|
|
out->message = commit->buffer;
|
2010-05-09 01:17:29 +02:00
|
|
|
if (strcmp(encoding, git_commit_encoding))
|
2011-08-04 12:39:04 +02:00
|
|
|
out->reencoded_message = reencode_string(commit->buffer,
|
2010-05-09 01:17:29 +02:00
|
|
|
git_commit_encoding, encoding);
|
|
|
|
if (out->reencoded_message)
|
2010-03-21 01:45:21 +01:00
|
|
|
out->message = out->reencoded_message;
|
|
|
|
|
|
|
|
abbrev = find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV);
|
|
|
|
abbrev_len = strlen(abbrev);
|
|
|
|
|
2010-07-22 15:18:31 +02:00
|
|
|
subject_len = find_commit_subject(out->message, &subject);
|
2010-03-21 01:45:21 +01:00
|
|
|
|
|
|
|
out->parent_label = xmalloc(strlen("parent of ") + abbrev_len +
|
2010-07-22 15:18:31 +02:00
|
|
|
strlen("... ") + subject_len + 1);
|
2010-03-21 01:45:21 +01:00
|
|
|
q = out->parent_label;
|
|
|
|
q = mempcpy(q, "parent of ", strlen("parent of "));
|
|
|
|
out->label = q;
|
|
|
|
q = mempcpy(q, abbrev, abbrev_len);
|
|
|
|
q = mempcpy(q, "... ", strlen("... "));
|
|
|
|
out->subject = q;
|
2010-07-22 15:18:31 +02:00
|
|
|
q = mempcpy(q, subject, subject_len);
|
2010-03-21 01:45:21 +01:00
|
|
|
*q = '\0';
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void free_message(struct commit_message *msg)
|
|
|
|
{
|
|
|
|
free(msg->parent_label);
|
|
|
|
free(msg->reencoded_message);
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
|
|
|
|
2007-06-07 22:45:00 +02:00
|
|
|
static char *get_encoding(const char *message)
|
2007-03-01 05:26:30 +01:00
|
|
|
{
|
|
|
|
const char *p = message, *eol;
|
|
|
|
|
|
|
|
while (*p && *p != '\n') {
|
|
|
|
for (eol = p + 1; *eol && *eol != '\n'; eol++)
|
|
|
|
; /* do nothing */
|
|
|
|
if (!prefixcmp(p, "encoding ")) {
|
|
|
|
char *result = xmalloc(eol - 8 - p);
|
|
|
|
strlcpy(result, p + 9, eol - 8 - p);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
p = eol;
|
|
|
|
if (*p == '\n')
|
|
|
|
p++;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2011-11-22 12:17:36 +01:00
|
|
|
static void write_cherry_pick_head(struct commit *commit, const char *pseudoref)
|
2007-03-01 05:26:30 +01:00
|
|
|
{
|
2011-11-16 09:03:36 +01:00
|
|
|
const char *filename;
|
2011-02-20 05:12:27 +01:00
|
|
|
int fd;
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
|
|
strbuf_addf(&buf, "%s\n", sha1_to_hex(commit->object.sha1));
|
|
|
|
|
2011-11-23 13:45:36 +01:00
|
|
|
filename = git_path("%s", pseudoref);
|
2011-11-16 09:03:36 +01:00
|
|
|
fd = open(filename, O_WRONLY | O_CREAT, 0666);
|
2011-02-20 05:12:27 +01:00
|
|
|
if (fd < 0)
|
2011-11-16 09:03:36 +01:00
|
|
|
die_errno(_("Could not open '%s' for writing"), filename);
|
2011-02-20 05:12:27 +01:00
|
|
|
if (write_in_full(fd, buf.buf, buf.len) != buf.len || close(fd))
|
2011-11-16 09:03:36 +01:00
|
|
|
die_errno(_("Could not write to '%s'"), filename);
|
2011-02-20 05:12:27 +01:00
|
|
|
strbuf_release(&buf);
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
|
|
|
|
2011-10-06 19:58:01 +02:00
|
|
|
static void print_advice(int show_hint)
|
2007-11-28 09:06:36 +01:00
|
|
|
{
|
|
|
|
char *msg = getenv("GIT_CHERRY_PICK_HELP");
|
|
|
|
|
2010-08-11 10:37:51 +02:00
|
|
|
if (msg) {
|
|
|
|
fprintf(stderr, "%s\n", msg);
|
2011-02-20 05:12:27 +01:00
|
|
|
/*
|
|
|
|
* A conflict has occured but the porcelain
|
|
|
|
* (typically rebase --interactive) wants to take care
|
|
|
|
* of the commit itself so remove CHERRY_PICK_HEAD
|
|
|
|
*/
|
|
|
|
unlink(git_path("CHERRY_PICK_HEAD"));
|
2010-08-11 10:37:51 +02:00
|
|
|
return;
|
2007-11-28 09:06:36 +01:00
|
|
|
}
|
|
|
|
|
i18n of multi-line advice messages
Advice messages are by definition meant for human end-users, and prime
candidates for i18n/l10n. They tend to also be more verbose to be helpful,
and need to be longer than just one line.
Although we do not have parameterized multi-line advice messages yet, once
we do, we cannot emit such a message like this:
advise(_("Please rename %s to something else"), gostak);
advise(_("so that we can avoid distimming %s unnecessarily."), doshes);
because some translations may need to have the replacement of 'gostak' on
the second line (or 'doshes' on the first line). Some languages may even
need to use three lines in order to fit the same message within a
reasonable width.
Instead, it has to be a single advise() construct, like this:
advise(_("Please rename %s to something else\n"
"so that we can avoid distimming %s unnecessarily."),
gostak, doshes);
Update the advise() function and its existing callers to
- take a format string that can be multi-line and translatable as a
whole;
- use the string and the parameters to form a localized message; and
- show each line in the result with the localization of the "hint: ".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-12-22 20:21:26 +01:00
|
|
|
if (show_hint)
|
|
|
|
advise(_("after resolving the conflicts, mark the corrected paths\n"
|
|
|
|
"with 'git add <paths>' or 'git rm <paths>'\n"
|
|
|
|
"and commit the result with 'git commit'"));
|
2007-11-28 09:06:36 +01:00
|
|
|
}
|
|
|
|
|
2010-03-31 21:22:04 +02:00
|
|
|
static void write_message(struct strbuf *msgbuf, const char *filename)
|
|
|
|
{
|
|
|
|
static struct lock_file msg_file;
|
|
|
|
|
|
|
|
int msg_fd = hold_lock_file_for_update(&msg_file, filename,
|
|
|
|
LOCK_DIE_ON_ERROR);
|
|
|
|
if (write_in_full(msg_fd, msgbuf->buf, msgbuf->len) < 0)
|
2011-11-15 10:31:32 +01:00
|
|
|
die_errno(_("Could not write to %s"), filename);
|
2010-03-31 21:22:04 +02:00
|
|
|
strbuf_release(msgbuf);
|
|
|
|
if (commit_lock_file(&msg_file) < 0)
|
2011-02-23 00:42:28 +01:00
|
|
|
die(_("Error wrapping up %s"), filename);
|
2010-03-31 21:22:04 +02:00
|
|
|
}
|
|
|
|
|
2008-09-02 23:11:15 +02:00
|
|
|
static struct tree *empty_tree(void)
|
|
|
|
{
|
2011-08-14 17:22:04 +02:00
|
|
|
return lookup_tree((const unsigned char *)EMPTY_TREE_SHA1_BIN);
|
2008-09-02 23:11:15 +02:00
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:16 +02:00
|
|
|
static int error_dirty_index(struct replay_opts *opts)
|
Be more user-friendly when refusing to do something because of conflict.
Various commands refuse to run in the presence of conflicts (commit,
merge, pull, cherry-pick/revert). They all used to provide rough, and
inconsistant error messages.
A new variable advice.resolveconflict is introduced, and allows more
verbose messages, pointing the user to the appropriate solution.
For commit, the error message used to look like this:
$ git commit
foo.txt: needs merge
foo.txt: unmerged (c34a92682e0394bc0d6f4d4a67a8e2d32395c169)
foo.txt: unmerged (3afcd75de8de0bb5076942fcb17446be50451030)
foo.txt: unmerged (c9785d77b76dfe4fb038bf927ee518f6ae45ede4)
error: Error building trees
The "need merge" line is given by refresh_cache. We add the IN_PORCELAIN
option to make the output more consistant with the other porcelain
commands, and catch the error in return, to stop with a clean error
message. The next lines were displayed by a call to cache_tree_update(),
which is not reached anymore if we noticed the conflict.
The new output looks like:
U foo.txt
fatal: 'commit' is not possible because you have unmerged files.
Please, fix them up in the work tree, and then use 'git add/rm <file>' as
appropriate to mark resolution and make a commit, or use 'git commit -a'.
Pull is slightly modified to abort immediately if $GIT_DIR/MERGE_HEAD
exists instead of waiting for merge to complain.
The behavior of merge and the test-case are slightly modified to reflect
the usual flow: start with conflicts, fix them, and afterwards get rid of
MERGE_HEAD, with different error messages at each stage.
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-01-12 10:54:44 +01:00
|
|
|
{
|
2011-08-04 12:39:16 +02:00
|
|
|
if (read_cache_unmerged())
|
|
|
|
return error_resolve_conflict(action_name(opts));
|
|
|
|
|
|
|
|
/* Different translation strings for cherry-pick and revert */
|
|
|
|
if (opts->action == CHERRY_PICK)
|
|
|
|
error(_("Your local changes would be overwritten by cherry-pick."));
|
|
|
|
else
|
|
|
|
error(_("Your local changes would be overwritten by revert."));
|
|
|
|
|
|
|
|
if (advice_commit_before_merge)
|
|
|
|
advise(_("Commit your changes or stash them to proceed."));
|
|
|
|
return -1;
|
Be more user-friendly when refusing to do something because of conflict.
Various commands refuse to run in the presence of conflicts (commit,
merge, pull, cherry-pick/revert). They all used to provide rough, and
inconsistant error messages.
A new variable advice.resolveconflict is introduced, and allows more
verbose messages, pointing the user to the appropriate solution.
For commit, the error message used to look like this:
$ git commit
foo.txt: needs merge
foo.txt: unmerged (c34a92682e0394bc0d6f4d4a67a8e2d32395c169)
foo.txt: unmerged (3afcd75de8de0bb5076942fcb17446be50451030)
foo.txt: unmerged (c9785d77b76dfe4fb038bf927ee518f6ae45ede4)
error: Error building trees
The "need merge" line is given by refresh_cache. We add the IN_PORCELAIN
option to make the output more consistant with the other porcelain
commands, and catch the error in return, to stop with a clean error
message. The next lines were displayed by a call to cache_tree_update(),
which is not reached anymore if we noticed the conflict.
The new output looks like:
U foo.txt
fatal: 'commit' is not possible because you have unmerged files.
Please, fix them up in the work tree, and then use 'git add/rm <file>' as
appropriate to mark resolution and make a commit, or use 'git commit -a'.
Pull is slightly modified to abort immediately if $GIT_DIR/MERGE_HEAD
exists instead of waiting for merge to complain.
The behavior of merge and the test-case are slightly modified to reflect
the usual flow: start with conflicts, fix them, and afterwards get rid of
MERGE_HEAD, with different error messages at each stage.
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-01-12 10:54:44 +01:00
|
|
|
}
|
|
|
|
|
2010-03-06 21:34:42 +01:00
|
|
|
static int fast_forward_to(const unsigned char *to, const unsigned char *from)
|
|
|
|
{
|
|
|
|
struct ref_lock *ref_lock;
|
|
|
|
|
|
|
|
read_cache();
|
|
|
|
if (checkout_fast_forward(from, to))
|
|
|
|
exit(1); /* the callee should have complained already */
|
|
|
|
ref_lock = lock_any_ref_for_update("HEAD", from, 0);
|
|
|
|
return write_ref_sha1(ref_lock, to, "cherry-pick");
|
|
|
|
}
|
|
|
|
|
2010-07-14 01:28:12 +02:00
|
|
|
static int do_recursive_merge(struct commit *base, struct commit *next,
|
|
|
|
const char *base_label, const char *next_label,
|
2011-08-04 12:39:05 +02:00
|
|
|
unsigned char *head, struct strbuf *msgbuf,
|
|
|
|
struct replay_opts *opts)
|
2010-03-31 21:22:05 +02:00
|
|
|
{
|
|
|
|
struct merge_options o;
|
|
|
|
struct tree *result, *next_tree, *base_tree, *head_tree;
|
|
|
|
int clean, index_fd;
|
2010-12-11 01:51:44 +01:00
|
|
|
const char **xopt;
|
2010-03-31 21:22:05 +02:00
|
|
|
static struct lock_file index_lock;
|
|
|
|
|
|
|
|
index_fd = hold_locked_index(&index_lock, 1);
|
|
|
|
|
|
|
|
read_cache();
|
2010-08-05 13:32:41 +02:00
|
|
|
|
2010-03-31 21:22:05 +02:00
|
|
|
init_merge_options(&o);
|
|
|
|
o.ancestor = base ? base_label : "(empty tree)";
|
|
|
|
o.branch1 = "HEAD";
|
|
|
|
o.branch2 = next ? next_label : "(empty tree)";
|
|
|
|
|
|
|
|
head_tree = parse_tree_indirect(head);
|
|
|
|
next_tree = next ? next->tree : empty_tree();
|
|
|
|
base_tree = base ? base->tree : empty_tree();
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
for (xopt = opts->xopts; xopt != opts->xopts + opts->xopts_nr; xopt++)
|
2010-12-11 01:51:44 +01:00
|
|
|
parse_merge_opt(&o, *xopt);
|
|
|
|
|
2010-03-31 21:22:05 +02:00
|
|
|
clean = merge_trees(&o,
|
|
|
|
head_tree,
|
|
|
|
next_tree, base_tree, &result);
|
|
|
|
|
|
|
|
if (active_cache_changed &&
|
|
|
|
(write_cache(index_fd, active_cache, active_nr) ||
|
|
|
|
commit_locked_index(&index_lock)))
|
2011-02-23 00:42:30 +01:00
|
|
|
/* TRANSLATORS: %s will be "revert" or "cherry-pick" */
|
2011-08-04 12:39:05 +02:00
|
|
|
die(_("%s: Unable to write new index file"), action_name(opts));
|
2010-03-31 21:22:05 +02:00
|
|
|
rollback_lock_file(&index_lock);
|
|
|
|
|
|
|
|
if (!clean) {
|
|
|
|
int i;
|
|
|
|
strbuf_addstr(msgbuf, "\nConflicts:\n\n");
|
|
|
|
for (i = 0; i < active_nr;) {
|
|
|
|
struct cache_entry *ce = active_cache[i++];
|
|
|
|
if (ce_stage(ce)) {
|
|
|
|
strbuf_addch(msgbuf, '\t');
|
|
|
|
strbuf_addstr(msgbuf, ce->name);
|
|
|
|
strbuf_addch(msgbuf, '\n');
|
|
|
|
while (i < active_nr && !strcmp(ce->name,
|
|
|
|
active_cache[i]->name))
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-07-14 01:28:12 +02:00
|
|
|
|
|
|
|
return !clean;
|
2010-03-31 21:22:05 +02:00
|
|
|
}
|
|
|
|
|
2010-07-14 01:28:13 +02:00
|
|
|
/*
|
|
|
|
* If we are cherry-pick, and if the merge did not result in
|
|
|
|
* hand-editing, we will hit this commit and inherit the original
|
|
|
|
* author date and name.
|
|
|
|
* If we are revert, or if our cherry-pick results in a hand merge,
|
|
|
|
* we had better say that the current user is responsible for that.
|
|
|
|
*/
|
2011-08-04 12:39:05 +02:00
|
|
|
static int run_git_commit(const char *defmsg, struct replay_opts *opts)
|
2010-07-14 01:28:13 +02:00
|
|
|
{
|
|
|
|
/* 6 is max possible length of our args array including NULL */
|
|
|
|
const char *args[6];
|
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
args[i++] = "commit";
|
|
|
|
args[i++] = "-n";
|
2011-08-04 12:39:05 +02:00
|
|
|
if (opts->signoff)
|
2010-07-14 01:28:13 +02:00
|
|
|
args[i++] = "-s";
|
2011-08-04 12:39:05 +02:00
|
|
|
if (!opts->edit) {
|
2010-07-14 01:28:13 +02:00
|
|
|
args[i++] = "-F";
|
|
|
|
args[i++] = defmsg;
|
|
|
|
}
|
|
|
|
args[i] = NULL;
|
|
|
|
|
|
|
|
return run_command_v_opt(args, RUN_GIT_CMD);
|
2010-03-31 21:22:05 +02:00
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
|
2007-03-01 05:26:30 +01:00
|
|
|
{
|
|
|
|
unsigned char head[20];
|
2007-10-23 22:33:26 +02:00
|
|
|
struct commit *base, *next, *parent;
|
2010-03-21 01:46:07 +01:00
|
|
|
const char *base_label, *next_label;
|
2010-03-21 01:45:21 +01:00
|
|
|
struct commit_message msg = { NULL, NULL, NULL, NULL, NULL };
|
2010-03-21 03:01:20 +01:00
|
|
|
char *defmsg = NULL;
|
2010-03-31 21:22:04 +02:00
|
|
|
struct strbuf msgbuf = STRBUF_INIT;
|
2010-07-14 01:28:12 +02:00
|
|
|
int res;
|
2007-03-01 05:26:30 +01:00
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
if (opts->no_commit) {
|
2007-03-01 05:26:30 +01:00
|
|
|
/*
|
|
|
|
* We do not intend to commit immediately. We just want to
|
2007-11-13 22:45:11 +01:00
|
|
|
* merge the differences in, so let's compute the tree
|
|
|
|
* that represents the "current" state for merge-recursive
|
|
|
|
* to work on.
|
2007-03-01 05:26:30 +01:00
|
|
|
*/
|
2008-01-11 07:49:35 +01:00
|
|
|
if (write_cache_as_tree(head, 0, NULL))
|
2011-02-23 00:42:28 +01:00
|
|
|
die (_("Your index file is unmerged."));
|
2007-03-01 05:26:30 +01:00
|
|
|
} else {
|
|
|
|
if (get_sha1("HEAD", head))
|
2011-08-04 12:39:16 +02:00
|
|
|
return error(_("You do not have a valid HEAD"));
|
2009-02-10 15:30:35 +01:00
|
|
|
if (index_differs_from("HEAD", 0))
|
2011-08-04 12:39:16 +02:00
|
|
|
return error_dirty_index(opts);
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
2008-09-02 23:11:15 +02:00
|
|
|
discard_cache();
|
|
|
|
|
2008-07-04 17:19:52 +02:00
|
|
|
if (!commit->parents) {
|
|
|
|
parent = NULL;
|
|
|
|
}
|
|
|
|
else if (commit->parents->next) {
|
2007-10-23 22:33:26 +02:00
|
|
|
/* Reverting or cherry-picking a merge commit */
|
|
|
|
int cnt;
|
|
|
|
struct commit_list *p;
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
if (!opts->mainline)
|
2011-08-04 12:39:16 +02:00
|
|
|
return error(_("Commit %s is a merge but no -m option was given."),
|
|
|
|
sha1_to_hex(commit->object.sha1));
|
2007-10-23 22:33:26 +02:00
|
|
|
|
|
|
|
for (cnt = 1, p = commit->parents;
|
2011-08-04 12:39:05 +02:00
|
|
|
cnt != opts->mainline && p;
|
2007-10-23 22:33:26 +02:00
|
|
|
cnt++)
|
|
|
|
p = p->next;
|
2011-08-04 12:39:05 +02:00
|
|
|
if (cnt != opts->mainline || !p)
|
2011-08-04 12:39:16 +02:00
|
|
|
return error(_("Commit %s does not have parent %d"),
|
|
|
|
sha1_to_hex(commit->object.sha1), opts->mainline);
|
2007-10-23 22:33:26 +02:00
|
|
|
parent = p->item;
|
2011-08-04 12:39:05 +02:00
|
|
|
} else if (0 < opts->mainline)
|
2011-08-04 12:39:16 +02:00
|
|
|
return error(_("Mainline was specified but commit %s is not a merge."),
|
|
|
|
sha1_to_hex(commit->object.sha1));
|
2007-10-23 22:33:26 +02:00
|
|
|
else
|
|
|
|
parent = commit->parents->item;
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
if (opts->allow_ff && parent && !hashcmp(parent->object.sha1, head))
|
2010-03-06 21:34:42 +01:00
|
|
|
return fast_forward_to(commit->object.sha1, head);
|
|
|
|
|
2008-09-02 23:11:15 +02:00
|
|
|
if (parent && parse_commit(parent) < 0)
|
2011-02-23 00:42:30 +01:00
|
|
|
/* TRANSLATORS: The first %s will be "revert" or
|
|
|
|
"cherry-pick", the second %s a SHA1 */
|
2011-08-04 12:39:16 +02:00
|
|
|
return error(_("%s: cannot parse parent commit %s"),
|
|
|
|
action_name(opts), sha1_to_hex(parent->object.sha1));
|
2008-09-02 23:11:15 +02:00
|
|
|
|
2011-08-04 12:39:04 +02:00
|
|
|
if (get_message(commit, &msg) != 0)
|
2011-08-04 12:39:16 +02:00
|
|
|
return error(_("Cannot get commit message for %s"),
|
|
|
|
sha1_to_hex(commit->object.sha1));
|
2010-03-21 01:45:21 +01:00
|
|
|
|
2007-03-01 05:26:30 +01:00
|
|
|
/*
|
|
|
|
* "commit" is an existing commit. We would want to apply
|
|
|
|
* the difference it introduces since its first parent "prev"
|
|
|
|
* on top of the current HEAD if we are cherry-pick. Or the
|
|
|
|
* reverse of it if we are revert.
|
|
|
|
*/
|
|
|
|
|
2010-03-21 03:01:20 +01:00
|
|
|
defmsg = git_pathdup("MERGE_MSG");
|
2010-03-06 21:34:42 +01:00
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
if (opts->action == REVERT) {
|
2007-03-01 05:26:30 +01:00
|
|
|
base = commit;
|
2010-03-21 01:46:07 +01:00
|
|
|
base_label = msg.label;
|
2007-10-23 22:33:26 +02:00
|
|
|
next = parent;
|
2010-03-21 01:45:21 +01:00
|
|
|
next_label = msg.parent_label;
|
2010-03-31 21:22:04 +02:00
|
|
|
strbuf_addstr(&msgbuf, "Revert \"");
|
|
|
|
strbuf_addstr(&msgbuf, msg.subject);
|
|
|
|
strbuf_addstr(&msgbuf, "\"\n\nThis reverts commit ");
|
|
|
|
strbuf_addstr(&msgbuf, sha1_to_hex(commit->object.sha1));
|
2008-12-21 23:17:12 +01:00
|
|
|
|
2011-05-12 13:09:55 +02:00
|
|
|
if (commit->parents && commit->parents->next) {
|
2010-03-31 21:22:04 +02:00
|
|
|
strbuf_addstr(&msgbuf, ", reversing\nchanges made to ");
|
|
|
|
strbuf_addstr(&msgbuf, sha1_to_hex(parent->object.sha1));
|
2008-12-21 23:17:12 +01:00
|
|
|
}
|
2010-03-31 21:22:04 +02:00
|
|
|
strbuf_addstr(&msgbuf, ".\n");
|
2007-03-01 05:26:30 +01:00
|
|
|
} else {
|
2011-08-04 12:39:01 +02:00
|
|
|
const char *p;
|
|
|
|
|
2007-10-23 22:33:26 +02:00
|
|
|
base = parent;
|
2010-03-21 01:46:07 +01:00
|
|
|
base_label = msg.parent_label;
|
2007-03-01 05:26:30 +01:00
|
|
|
next = commit;
|
2010-03-21 01:45:21 +01:00
|
|
|
next_label = msg.label;
|
2011-08-04 12:39:01 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Append the commit log message to msgbuf; it starts
|
|
|
|
* after the tree, parent, author, committer
|
|
|
|
* information followed by "\n\n".
|
|
|
|
*/
|
|
|
|
p = strstr(msg.message, "\n\n");
|
|
|
|
if (p) {
|
|
|
|
p += 2;
|
|
|
|
strbuf_addstr(&msgbuf, p);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
if (opts->record_origin) {
|
2010-03-31 21:22:04 +02:00
|
|
|
strbuf_addstr(&msgbuf, "(cherry picked from commit ");
|
|
|
|
strbuf_addstr(&msgbuf, sha1_to_hex(commit->object.sha1));
|
|
|
|
strbuf_addstr(&msgbuf, ")\n");
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
if (!opts->strategy || !strcmp(opts->strategy, "recursive") || opts->action == REVERT) {
|
2010-07-14 01:28:12 +02:00
|
|
|
res = do_recursive_merge(base, next, base_label, next_label,
|
2011-08-04 12:39:05 +02:00
|
|
|
head, &msgbuf, opts);
|
2010-07-14 01:28:12 +02:00
|
|
|
write_message(&msgbuf, defmsg);
|
|
|
|
} else {
|
2010-03-31 21:22:08 +02:00
|
|
|
struct commit_list *common = NULL;
|
|
|
|
struct commit_list *remotes = NULL;
|
2010-07-14 01:28:12 +02:00
|
|
|
|
2010-03-31 21:22:08 +02:00
|
|
|
write_message(&msgbuf, defmsg);
|
2010-07-14 01:28:12 +02:00
|
|
|
|
2010-03-31 21:22:08 +02:00
|
|
|
commit_list_insert(base, &common);
|
|
|
|
commit_list_insert(next, &remotes);
|
2011-08-04 12:39:05 +02:00
|
|
|
res = try_merge_command(opts->strategy, opts->xopts_nr, opts->xopts,
|
|
|
|
common, sha1_to_hex(head), remotes);
|
2010-03-31 21:22:08 +02:00
|
|
|
free_commit_list(common);
|
|
|
|
free_commit_list(remotes);
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
|
|
|
|
2011-10-06 19:48:35 +02:00
|
|
|
/*
|
|
|
|
* If the merge was clean or if it failed due to conflict, we write
|
|
|
|
* CHERRY_PICK_HEAD for the subsequent invocation of commit to use.
|
|
|
|
* However, if the merge did not even start, then we don't want to
|
|
|
|
* write it at all.
|
|
|
|
*/
|
2011-10-07 02:02:11 +02:00
|
|
|
if (opts->action == CHERRY_PICK && !opts->no_commit && (res == 0 || res == 1))
|
2011-11-22 12:17:36 +01:00
|
|
|
write_cherry_pick_head(commit, "CHERRY_PICK_HEAD");
|
|
|
|
if (opts->action == REVERT && ((opts->no_commit && res == 0) || res == 1))
|
|
|
|
write_cherry_pick_head(commit, "REVERT_HEAD");
|
2011-10-06 19:48:35 +02:00
|
|
|
|
2010-07-14 01:28:12 +02:00
|
|
|
if (res) {
|
2011-08-04 12:39:05 +02:00
|
|
|
error(opts->action == REVERT
|
2011-02-23 00:42:31 +01:00
|
|
|
? _("could not revert %s... %s")
|
|
|
|
: _("could not apply %s... %s"),
|
2010-08-11 10:37:24 +02:00
|
|
|
find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
|
|
|
|
msg.subject);
|
2011-10-06 19:58:01 +02:00
|
|
|
print_advice(res == 1);
|
2011-08-04 12:39:05 +02:00
|
|
|
rerere(opts->allow_rerere_auto);
|
2010-07-14 01:28:12 +02:00
|
|
|
} else {
|
2011-08-04 12:39:05 +02:00
|
|
|
if (!opts->no_commit)
|
|
|
|
res = run_git_commit(defmsg, opts);
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
2010-06-02 07:58:35 +02:00
|
|
|
|
|
|
|
free_message(&msg);
|
2008-10-28 18:27:33 +01:00
|
|
|
free(defmsg);
|
2007-03-01 05:26:30 +01:00
|
|
|
|
2010-07-14 01:28:14 +02:00
|
|
|
return res;
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
|
|
|
|
2011-08-13 19:06:23 +02:00
|
|
|
static void prepare_revs(struct replay_opts *opts)
|
2010-06-02 07:58:38 +02:00
|
|
|
{
|
2011-08-04 12:39:05 +02:00
|
|
|
if (opts->action != REVERT)
|
2011-08-13 19:06:23 +02:00
|
|
|
opts->revs->reverse ^= 1;
|
2010-06-14 07:32:09 +02:00
|
|
|
|
2011-08-13 19:06:23 +02:00
|
|
|
if (prepare_revision_walk(opts->revs))
|
2011-02-23 00:42:28 +01:00
|
|
|
die(_("revision walk setup failed"));
|
2010-06-02 07:58:38 +02:00
|
|
|
|
2011-08-13 19:06:23 +02:00
|
|
|
if (!opts->revs->commits)
|
2011-02-23 00:42:28 +01:00
|
|
|
die(_("empty commit set passed"));
|
2010-06-02 07:58:38 +02:00
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
static void read_and_refresh_cache(struct replay_opts *opts)
|
2010-10-31 20:59:33 +01:00
|
|
|
{
|
|
|
|
static struct lock_file index_lock;
|
|
|
|
int index_fd = hold_locked_index(&index_lock, 0);
|
|
|
|
if (read_index_preload(&the_index, NULL) < 0)
|
2011-08-04 12:39:05 +02:00
|
|
|
die(_("git %s: failed to read the index"), action_name(opts));
|
2010-10-31 20:59:33 +01:00
|
|
|
refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, NULL, NULL, NULL);
|
|
|
|
if (the_index.cache_changed) {
|
|
|
|
if (write_index(&the_index, index_fd) ||
|
|
|
|
commit_locked_index(&index_lock))
|
2011-08-04 12:39:05 +02:00
|
|
|
die(_("git %s: failed to refresh the index"), action_name(opts));
|
2010-10-31 20:59:33 +01:00
|
|
|
}
|
|
|
|
rollback_lock_file(&index_lock);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:08 +02:00
|
|
|
/*
|
|
|
|
* Append a commit to the end of the commit_list.
|
|
|
|
*
|
|
|
|
* next starts by pointing to the variable that holds the head of an
|
|
|
|
* empty commit_list, and is updated to point to the "next" field of
|
|
|
|
* the last item on the list as new commits are appended.
|
|
|
|
*
|
|
|
|
* Usage example:
|
|
|
|
*
|
|
|
|
* struct commit_list *list;
|
|
|
|
* struct commit_list **next = &list;
|
|
|
|
*
|
|
|
|
* next = commit_list_append(c1, next);
|
|
|
|
* next = commit_list_append(c2, next);
|
|
|
|
* assert(commit_list_count(list) == 2);
|
|
|
|
* return list;
|
|
|
|
*/
|
2011-09-12 00:29:21 +02:00
|
|
|
static struct commit_list **commit_list_append(struct commit *commit,
|
|
|
|
struct commit_list **next)
|
2011-08-04 12:39:08 +02:00
|
|
|
{
|
|
|
|
struct commit_list *new = xmalloc(sizeof(struct commit_list));
|
|
|
|
new->item = commit;
|
|
|
|
*next = new;
|
|
|
|
new->next = NULL;
|
|
|
|
return &new->next;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int format_todo(struct strbuf *buf, struct commit_list *todo_list,
|
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list *cur = NULL;
|
|
|
|
const char *sha1_abbrev = NULL;
|
|
|
|
const char *action_str = opts->action == REVERT ? "revert" : "pick";
|
2011-12-14 17:54:31 +01:00
|
|
|
const char *subject;
|
|
|
|
int subject_len;
|
2011-08-04 12:39:08 +02:00
|
|
|
|
|
|
|
for (cur = todo_list; cur; cur = cur->next) {
|
|
|
|
sha1_abbrev = find_unique_abbrev(cur->item->object.sha1, DEFAULT_ABBREV);
|
2011-12-14 17:54:31 +01:00
|
|
|
subject_len = find_commit_subject(cur->item->buffer, &subject);
|
|
|
|
strbuf_addf(buf, "%s %s %.*s\n", action_str, sha1_abbrev,
|
|
|
|
subject_len, subject);
|
2011-08-04 12:39:08 +02:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-12-14 17:54:29 +01:00
|
|
|
static struct commit *parse_insn_line(char *bol, char *eol, struct replay_opts *opts)
|
2011-08-04 12:39:15 +02:00
|
|
|
{
|
|
|
|
unsigned char commit_sha1[20];
|
|
|
|
enum replay_action action;
|
2011-12-14 17:54:29 +01:00
|
|
|
char *end_of_object_name;
|
2011-12-14 17:54:30 +01:00
|
|
|
int saved, status, padding;
|
2011-08-04 12:39:15 +02:00
|
|
|
|
2011-12-14 17:54:30 +01:00
|
|
|
if (!prefixcmp(bol, "pick")) {
|
2011-08-04 12:39:15 +02:00
|
|
|
action = CHERRY_PICK;
|
2011-12-14 17:54:30 +01:00
|
|
|
bol += strlen("pick");
|
|
|
|
} else if (!prefixcmp(bol, "revert")) {
|
2011-08-04 12:39:15 +02:00
|
|
|
action = REVERT;
|
2011-12-14 17:54:30 +01:00
|
|
|
bol += strlen("revert");
|
2011-08-04 12:39:15 +02:00
|
|
|
} else
|
|
|
|
return NULL;
|
|
|
|
|
2011-12-14 17:54:30 +01:00
|
|
|
/* Eat up extra spaces/ tabs before object name */
|
|
|
|
padding = strspn(bol, " \t");
|
|
|
|
if (!padding)
|
2011-08-04 12:39:15 +02:00
|
|
|
return NULL;
|
2011-12-14 17:54:30 +01:00
|
|
|
bol += padding;
|
2011-08-04 12:39:15 +02:00
|
|
|
|
2011-12-14 17:54:30 +01:00
|
|
|
end_of_object_name = bol + strcspn(bol, " \t\n");
|
2011-12-14 17:54:29 +01:00
|
|
|
saved = *end_of_object_name;
|
|
|
|
*end_of_object_name = '\0';
|
|
|
|
status = get_sha1(bol, commit_sha1);
|
|
|
|
*end_of_object_name = saved;
|
2011-08-04 12:39:15 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Verify that the action matches up with the one in
|
|
|
|
* opts; we don't support arbitrary instructions
|
|
|
|
*/
|
|
|
|
if (action != opts->action) {
|
|
|
|
const char *action_str;
|
|
|
|
action_str = action == REVERT ? "revert" : "cherry-pick";
|
|
|
|
error(_("Cannot %s during a %s"), action_str, action_name(opts));
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2011-12-14 17:54:29 +01:00
|
|
|
if (status < 0)
|
2011-08-04 12:39:15 +02:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
return lookup_commit_reference(commit_sha1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_insn_buffer(char *buf, struct commit_list **todo_list,
|
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list **next = todo_list;
|
|
|
|
struct commit *commit;
|
|
|
|
char *p = buf;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 1; *p; i++) {
|
2011-12-14 17:54:29 +01:00
|
|
|
char *eol = strchrnul(p, '\n');
|
|
|
|
commit = parse_insn_line(p, eol, opts);
|
2011-08-04 12:39:15 +02:00
|
|
|
if (!commit)
|
|
|
|
return error(_("Could not parse line %d."), i);
|
|
|
|
next = commit_list_append(commit, next);
|
2011-12-14 17:54:29 +01:00
|
|
|
p = *eol ? eol + 1 : eol;
|
2011-08-04 12:39:15 +02:00
|
|
|
}
|
|
|
|
if (!*todo_list)
|
|
|
|
return error(_("No commits parsed."));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void read_populate_todo(struct commit_list **todo_list,
|
|
|
|
struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
const char *todo_file = git_path(SEQ_TODO_FILE);
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int fd, res;
|
|
|
|
|
|
|
|
fd = open(todo_file, O_RDONLY);
|
|
|
|
if (fd < 0)
|
2011-11-15 10:31:32 +01:00
|
|
|
die_errno(_("Could not open %s"), todo_file);
|
2011-08-04 12:39:15 +02:00
|
|
|
if (strbuf_read(&buf, fd, 0) < 0) {
|
|
|
|
close(fd);
|
|
|
|
strbuf_release(&buf);
|
|
|
|
die(_("Could not read %s."), todo_file);
|
|
|
|
}
|
|
|
|
close(fd);
|
|
|
|
|
|
|
|
res = parse_insn_buffer(buf.buf, todo_list, opts);
|
|
|
|
strbuf_release(&buf);
|
|
|
|
if (res)
|
|
|
|
die(_("Unusable instruction sheet: %s"), todo_file);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int populate_opts_cb(const char *key, const char *value, void *data)
|
|
|
|
{
|
|
|
|
struct replay_opts *opts = data;
|
|
|
|
int error_flag = 1;
|
|
|
|
|
|
|
|
if (!value)
|
|
|
|
error_flag = 0;
|
|
|
|
else if (!strcmp(key, "options.no-commit"))
|
|
|
|
opts->no_commit = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.edit"))
|
|
|
|
opts->edit = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.signoff"))
|
|
|
|
opts->signoff = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.record-origin"))
|
|
|
|
opts->record_origin = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.allow-ff"))
|
|
|
|
opts->allow_ff = git_config_bool_or_int(key, value, &error_flag);
|
|
|
|
else if (!strcmp(key, "options.mainline"))
|
|
|
|
opts->mainline = git_config_int(key, value);
|
|
|
|
else if (!strcmp(key, "options.strategy"))
|
|
|
|
git_config_string(&opts->strategy, key, value);
|
|
|
|
else if (!strcmp(key, "options.strategy-option")) {
|
|
|
|
ALLOC_GROW(opts->xopts, opts->xopts_nr + 1, opts->xopts_alloc);
|
|
|
|
opts->xopts[opts->xopts_nr++] = xstrdup(value);
|
|
|
|
} else
|
|
|
|
return error(_("Invalid key: %s"), key);
|
|
|
|
|
|
|
|
if (!error_flag)
|
|
|
|
return error(_("Invalid value for %s: %s"), key, value);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void read_populate_opts(struct replay_opts **opts_ptr)
|
|
|
|
{
|
|
|
|
const char *opts_file = git_path(SEQ_OPTS_FILE);
|
|
|
|
|
|
|
|
if (!file_exists(opts_file))
|
|
|
|
return;
|
|
|
|
if (git_config_from_file(populate_opts_cb, opts_file, *opts_ptr) < 0)
|
|
|
|
die(_("Malformed options sheet: %s"), opts_file);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:08 +02:00
|
|
|
static void walk_revs_populate_todo(struct commit_list **todo_list,
|
|
|
|
struct replay_opts *opts)
|
2010-06-02 07:58:36 +02:00
|
|
|
{
|
2011-08-04 12:39:04 +02:00
|
|
|
struct commit *commit;
|
2011-08-04 12:39:08 +02:00
|
|
|
struct commit_list **next;
|
2010-06-02 07:58:38 +02:00
|
|
|
|
2011-08-13 19:06:23 +02:00
|
|
|
prepare_revs(opts);
|
2011-08-04 12:39:08 +02:00
|
|
|
|
|
|
|
next = todo_list;
|
2011-08-13 19:06:23 +02:00
|
|
|
while ((commit = get_revision(opts->revs)))
|
2011-08-04 12:39:08 +02:00
|
|
|
next = commit_list_append(commit, next);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:14 +02:00
|
|
|
static int create_seq_dir(void)
|
2011-08-04 12:39:08 +02:00
|
|
|
{
|
|
|
|
const char *seq_dir = git_path(SEQ_DIR);
|
|
|
|
|
2011-11-22 12:15:47 +01:00
|
|
|
if (file_exists(seq_dir)) {
|
|
|
|
error(_("a cherry-pick or revert is already in progress"));
|
2011-11-23 02:27:21 +01:00
|
|
|
advise(_("try \"git cherry-pick (--continue | --quit | --abort)\""));
|
2011-11-22 12:15:47 +01:00
|
|
|
return -1;
|
|
|
|
}
|
2011-08-04 12:39:14 +02:00
|
|
|
else if (mkdir(seq_dir, 0777) < 0)
|
2011-11-15 10:31:32 +01:00
|
|
|
die_errno(_("Could not create sequencer directory %s"), seq_dir);
|
2011-08-04 12:39:14 +02:00
|
|
|
return 0;
|
2011-08-04 12:39:08 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void save_head(const char *head)
|
|
|
|
{
|
|
|
|
const char *head_file = git_path(SEQ_HEAD_FILE);
|
|
|
|
static struct lock_file head_lock;
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
fd = hold_lock_file_for_update(&head_lock, head_file, LOCK_DIE_ON_ERROR);
|
|
|
|
strbuf_addf(&buf, "%s\n", head);
|
|
|
|
if (write_in_full(fd, buf.buf, buf.len) < 0)
|
2011-11-15 10:31:32 +01:00
|
|
|
die_errno(_("Could not write to %s"), head_file);
|
2011-08-04 12:39:08 +02:00
|
|
|
if (commit_lock_file(&head_lock) < 0)
|
|
|
|
die(_("Error wrapping up %s."), head_file);
|
|
|
|
}
|
|
|
|
|
2011-11-23 02:27:21 +01:00
|
|
|
static int reset_for_rollback(const unsigned char *sha1)
|
|
|
|
{
|
|
|
|
const char *argv[4]; /* reset --merge <arg> + NULL */
|
|
|
|
argv[0] = "reset";
|
|
|
|
argv[1] = "--merge";
|
|
|
|
argv[2] = sha1_to_hex(sha1);
|
|
|
|
argv[3] = NULL;
|
|
|
|
return run_command_v_opt(argv, RUN_GIT_CMD);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int rollback_single_pick(void)
|
|
|
|
{
|
|
|
|
unsigned char head_sha1[20];
|
|
|
|
|
|
|
|
if (!file_exists(git_path("CHERRY_PICK_HEAD")) &&
|
|
|
|
!file_exists(git_path("REVERT_HEAD")))
|
|
|
|
return error(_("no cherry-pick or revert in progress"));
|
2011-12-12 12:20:29 +01:00
|
|
|
if (read_ref_full("HEAD", head_sha1, 0, NULL))
|
2011-11-23 02:27:21 +01:00
|
|
|
return error(_("cannot resolve HEAD"));
|
|
|
|
if (is_null_sha1(head_sha1))
|
|
|
|
return error(_("cannot abort from a branch yet to be born"));
|
|
|
|
return reset_for_rollback(head_sha1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sequencer_rollback(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
const char *filename;
|
|
|
|
FILE *f;
|
|
|
|
unsigned char sha1[20];
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
|
|
filename = git_path(SEQ_HEAD_FILE);
|
|
|
|
f = fopen(filename, "r");
|
|
|
|
if (!f && errno == ENOENT) {
|
|
|
|
/*
|
|
|
|
* There is no multiple-cherry-pick in progress.
|
|
|
|
* If CHERRY_PICK_HEAD or REVERT_HEAD indicates
|
|
|
|
* a single-cherry-pick in progress, abort that.
|
|
|
|
*/
|
|
|
|
return rollback_single_pick();
|
|
|
|
}
|
|
|
|
if (!f)
|
|
|
|
return error(_("cannot open %s: %s"), filename,
|
|
|
|
strerror(errno));
|
|
|
|
if (strbuf_getline(&buf, f, '\n')) {
|
|
|
|
error(_("cannot read %s: %s"), filename, ferror(f) ?
|
|
|
|
strerror(errno) : _("unexpected end of file"));
|
2011-11-23 09:49:38 +01:00
|
|
|
fclose(f);
|
2011-11-23 02:27:21 +01:00
|
|
|
goto fail;
|
|
|
|
}
|
2011-11-23 09:49:38 +01:00
|
|
|
fclose(f);
|
2011-11-23 02:27:21 +01:00
|
|
|
if (get_sha1_hex(buf.buf, sha1) || buf.buf[40] != '\0') {
|
|
|
|
error(_("stored pre-cherry-pick HEAD file '%s' is corrupt"),
|
|
|
|
filename);
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
if (reset_for_rollback(sha1))
|
|
|
|
goto fail;
|
2011-12-10 14:06:12 +01:00
|
|
|
remove_sequencer_state();
|
2011-11-23 02:27:21 +01:00
|
|
|
strbuf_release(&buf);
|
|
|
|
return 0;
|
|
|
|
fail:
|
|
|
|
strbuf_release(&buf);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:08 +02:00
|
|
|
static void save_todo(struct commit_list *todo_list, struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
const char *todo_file = git_path(SEQ_TODO_FILE);
|
|
|
|
static struct lock_file todo_lock;
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
fd = hold_lock_file_for_update(&todo_lock, todo_file, LOCK_DIE_ON_ERROR);
|
|
|
|
if (format_todo(&buf, todo_list, opts) < 0)
|
|
|
|
die(_("Could not format %s."), todo_file);
|
|
|
|
if (write_in_full(fd, buf.buf, buf.len) < 0) {
|
|
|
|
strbuf_release(&buf);
|
2011-11-15 10:31:32 +01:00
|
|
|
die_errno(_("Could not write to %s"), todo_file);
|
2011-08-04 12:39:08 +02:00
|
|
|
}
|
|
|
|
if (commit_lock_file(&todo_lock) < 0) {
|
|
|
|
strbuf_release(&buf);
|
|
|
|
die(_("Error wrapping up %s."), todo_file);
|
2010-06-02 07:58:36 +02:00
|
|
|
}
|
2011-08-04 12:39:08 +02:00
|
|
|
strbuf_release(&buf);
|
|
|
|
}
|
2010-06-02 07:58:36 +02:00
|
|
|
|
2011-08-04 12:39:09 +02:00
|
|
|
static void save_opts(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
const char *opts_file = git_path(SEQ_OPTS_FILE);
|
|
|
|
|
|
|
|
if (opts->no_commit)
|
|
|
|
git_config_set_in_file(opts_file, "options.no-commit", "true");
|
|
|
|
if (opts->edit)
|
|
|
|
git_config_set_in_file(opts_file, "options.edit", "true");
|
|
|
|
if (opts->signoff)
|
|
|
|
git_config_set_in_file(opts_file, "options.signoff", "true");
|
|
|
|
if (opts->record_origin)
|
|
|
|
git_config_set_in_file(opts_file, "options.record-origin", "true");
|
|
|
|
if (opts->allow_ff)
|
|
|
|
git_config_set_in_file(opts_file, "options.allow-ff", "true");
|
|
|
|
if (opts->mainline) {
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
strbuf_addf(&buf, "%d", opts->mainline);
|
|
|
|
git_config_set_in_file(opts_file, "options.mainline", buf.buf);
|
|
|
|
strbuf_release(&buf);
|
|
|
|
}
|
|
|
|
if (opts->strategy)
|
|
|
|
git_config_set_in_file(opts_file, "options.strategy", opts->strategy);
|
|
|
|
if (opts->xopts) {
|
|
|
|
int i;
|
|
|
|
for (i = 0; i < opts->xopts_nr; i++)
|
|
|
|
git_config_set_multivar_in_file(opts_file,
|
|
|
|
"options.strategy-option",
|
|
|
|
opts->xopts[i], "^$", 0);
|
|
|
|
}
|
|
|
|
}
|
2010-06-02 07:58:36 +02:00
|
|
|
|
2011-08-04 12:39:10 +02:00
|
|
|
static int pick_commits(struct commit_list *todo_list, struct replay_opts *opts)
|
2011-08-04 12:39:08 +02:00
|
|
|
{
|
|
|
|
struct commit_list *cur;
|
|
|
|
int res;
|
2010-06-02 07:58:38 +02:00
|
|
|
|
2011-08-04 12:39:05 +02:00
|
|
|
setenv(GIT_REFLOG_ACTION, action_name(opts), 0);
|
2011-08-04 12:39:07 +02:00
|
|
|
if (opts->allow_ff)
|
|
|
|
assert(!(opts->signoff || opts->no_commit ||
|
|
|
|
opts->record_origin || opts->edit));
|
2011-08-04 12:39:05 +02:00
|
|
|
read_and_refresh_cache(opts);
|
2010-06-02 07:58:36 +02:00
|
|
|
|
2011-08-04 12:39:08 +02:00
|
|
|
for (cur = todo_list; cur; cur = cur->next) {
|
|
|
|
save_todo(cur, opts);
|
|
|
|
res = do_pick_commit(cur->item, opts);
|
2011-12-10 14:02:12 +01:00
|
|
|
if (res)
|
2010-06-02 07:58:38 +02:00
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:08 +02:00
|
|
|
/*
|
|
|
|
* Sequence of picks finished successfully; cleanup by
|
|
|
|
* removing the .git/sequencer directory
|
|
|
|
*/
|
2011-12-10 14:06:12 +01:00
|
|
|
remove_sequencer_state();
|
2010-06-02 07:58:38 +02:00
|
|
|
return 0;
|
2010-06-02 07:58:36 +02:00
|
|
|
}
|
|
|
|
|
2011-12-10 13:49:25 +01:00
|
|
|
static int continue_single_pick(void)
|
|
|
|
{
|
|
|
|
const char *argv[] = { "commit", NULL };
|
|
|
|
|
|
|
|
if (!file_exists(git_path("CHERRY_PICK_HEAD")) &&
|
|
|
|
!file_exists(git_path("REVERT_HEAD")))
|
|
|
|
return error(_("no cherry-pick or revert in progress"));
|
|
|
|
return run_command_v_opt(argv, RUN_GIT_CMD);
|
|
|
|
}
|
|
|
|
|
2011-12-10 13:47:36 +01:00
|
|
|
static int sequencer_continue(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list *todo_list = NULL;
|
|
|
|
|
|
|
|
if (!file_exists(git_path(SEQ_TODO_FILE)))
|
2011-12-10 13:49:25 +01:00
|
|
|
return continue_single_pick();
|
2011-12-10 13:47:36 +01:00
|
|
|
read_populate_opts(&opts);
|
|
|
|
read_populate_todo(&todo_list, opts);
|
|
|
|
|
|
|
|
/* Verify that the conflict has been resolved */
|
2011-12-10 13:49:25 +01:00
|
|
|
if (file_exists(git_path("CHERRY_PICK_HEAD")) ||
|
|
|
|
file_exists(git_path("REVERT_HEAD"))) {
|
|
|
|
int ret = continue_single_pick();
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
if (index_differs_from("HEAD", 0))
|
|
|
|
return error_dirty_index(opts);
|
|
|
|
todo_list = todo_list->next;
|
2011-12-10 13:47:36 +01:00
|
|
|
return pick_commits(todo_list, opts);
|
|
|
|
}
|
|
|
|
|
2011-12-10 13:59:48 +01:00
|
|
|
static int single_pick(struct commit *cmit, struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
setenv(GIT_REFLOG_ACTION, action_name(opts), 0);
|
|
|
|
return do_pick_commit(cmit, opts);
|
|
|
|
}
|
|
|
|
|
2011-08-04 12:39:10 +02:00
|
|
|
static int pick_revisions(struct replay_opts *opts)
|
|
|
|
{
|
|
|
|
struct commit_list *todo_list = NULL;
|
|
|
|
unsigned char sha1[20];
|
|
|
|
|
2011-08-13 19:06:23 +02:00
|
|
|
if (opts->subcommand == REPLAY_NONE)
|
|
|
|
assert(opts->revs);
|
|
|
|
|
2011-08-04 12:39:10 +02:00
|
|
|
read_and_refresh_cache(opts);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Decide what to do depending on the arguments; a fresh
|
|
|
|
* cherry-pick should be handled differently from an existing
|
|
|
|
* one that is being continued
|
|
|
|
*/
|
2011-11-22 12:14:29 +01:00
|
|
|
if (opts->subcommand == REPLAY_REMOVE_STATE) {
|
2011-12-10 14:06:12 +01:00
|
|
|
remove_sequencer_state();
|
2011-08-04 12:39:11 +02:00
|
|
|
return 0;
|
2011-11-22 12:15:10 +01:00
|
|
|
}
|
2011-11-23 02:27:21 +01:00
|
|
|
if (opts->subcommand == REPLAY_ROLLBACK)
|
|
|
|
return sequencer_rollback(opts);
|
2011-12-10 13:47:36 +01:00
|
|
|
if (opts->subcommand == REPLAY_CONTINUE)
|
|
|
|
return sequencer_continue(opts);
|
2011-08-04 12:39:14 +02:00
|
|
|
|
2011-12-10 13:59:48 +01:00
|
|
|
/*
|
|
|
|
* If we were called as "git cherry-pick <commit>", just
|
|
|
|
* cherry-pick/revert it, set CHERRY_PICK_HEAD /
|
|
|
|
* REVERT_HEAD, and don't touch the sequencer state.
|
|
|
|
* This means it is possible to cherry-pick in the middle
|
|
|
|
* of a cherry-pick sequence.
|
|
|
|
*/
|
|
|
|
if (opts->revs->cmdline.nr == 1 &&
|
|
|
|
opts->revs->cmdline.rev->whence == REV_CMD_REV &&
|
|
|
|
opts->revs->no_walk &&
|
|
|
|
!opts->revs->cmdline.rev->flags) {
|
|
|
|
struct commit *cmit;
|
|
|
|
if (prepare_revision_walk(opts->revs))
|
|
|
|
die(_("revision walk setup failed"));
|
|
|
|
cmit = get_revision(opts->revs);
|
|
|
|
if (!cmit || get_revision(opts->revs))
|
|
|
|
die("BUG: expected exactly one commit from walk");
|
|
|
|
return single_pick(cmit, opts);
|
|
|
|
}
|
|
|
|
|
2011-11-22 12:15:10 +01:00
|
|
|
/*
|
|
|
|
* Start a new cherry-pick/ revert sequence; but
|
|
|
|
* first, make sure that an existing one isn't in
|
|
|
|
* progress
|
|
|
|
*/
|
|
|
|
|
|
|
|
walk_revs_populate_todo(&todo_list, opts);
|
2011-11-22 12:15:47 +01:00
|
|
|
if (create_seq_dir() < 0)
|
2011-11-22 12:15:10 +01:00
|
|
|
return -1;
|
|
|
|
if (get_sha1("HEAD", sha1)) {
|
|
|
|
if (opts->action == REVERT)
|
|
|
|
return error(_("Can't revert as initial commit"));
|
|
|
|
return error(_("Can't cherry-pick into empty head"));
|
2011-08-04 12:39:10 +02:00
|
|
|
}
|
2011-11-22 12:15:10 +01:00
|
|
|
save_head(sha1_to_hex(sha1));
|
|
|
|
save_opts(opts);
|
2011-08-04 12:39:10 +02:00
|
|
|
return pick_commits(todo_list, opts);
|
|
|
|
}
|
|
|
|
|
2007-03-01 05:26:30 +01:00
|
|
|
int cmd_revert(int argc, const char **argv, const char *prefix)
|
|
|
|
{
|
2011-08-04 12:39:05 +02:00
|
|
|
struct replay_opts opts;
|
2011-08-04 12:39:16 +02:00
|
|
|
int res;
|
2011-08-04 12:39:05 +02:00
|
|
|
|
|
|
|
memset(&opts, 0, sizeof(opts));
|
2007-03-01 05:26:30 +01:00
|
|
|
if (isatty(0))
|
2011-08-04 12:39:05 +02:00
|
|
|
opts.edit = 1;
|
|
|
|
opts.action = REVERT;
|
revert: Separate cmdline parsing from functional code
Currently, revert_or_cherry_pick sets up a default git config, parses
command-line arguments, before preparing to pick commits. This makes
for a bad API as the central worry of callers is to assert whether or
not a conflict occured while cherry picking. The current API is like:
if (revert_or_cherry_pick(argc, argv, opts) < 0)
print "Something failed, we're not sure what"
Simplify and rename revert_or_cherry_pick to pick_commits so that it
only has the responsibility of setting up the revision walker and
picking commits in a loop. Transfer the remaining work to its
callers. Now, the API is simplified as:
if (parse_args(argc, argv, opts) < 0)
print "Can't parse arguments"
if (pick_commits(opts) < 0)
print "Error encountered in picking machinery"
Later in the series, pick_commits will also serve as the starting
point for continuing a cherry-pick or revert.
Inspired-by: Christian Couder <chriscool@tuxfamily.org>
Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-04 12:39:06 +02:00
|
|
|
git_config(git_default_config, NULL);
|
|
|
|
parse_args(argc, argv, &opts);
|
2011-08-04 12:39:16 +02:00
|
|
|
res = pick_revisions(&opts);
|
|
|
|
if (res < 0)
|
|
|
|
die(_("revert failed"));
|
|
|
|
return res;
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
int cmd_cherry_pick(int argc, const char **argv, const char *prefix)
|
|
|
|
{
|
2011-08-04 12:39:05 +02:00
|
|
|
struct replay_opts opts;
|
2011-08-04 12:39:16 +02:00
|
|
|
int res;
|
2011-08-04 12:39:05 +02:00
|
|
|
|
|
|
|
memset(&opts, 0, sizeof(opts));
|
|
|
|
opts.action = CHERRY_PICK;
|
revert: Separate cmdline parsing from functional code
Currently, revert_or_cherry_pick sets up a default git config, parses
command-line arguments, before preparing to pick commits. This makes
for a bad API as the central worry of callers is to assert whether or
not a conflict occured while cherry picking. The current API is like:
if (revert_or_cherry_pick(argc, argv, opts) < 0)
print "Something failed, we're not sure what"
Simplify and rename revert_or_cherry_pick to pick_commits so that it
only has the responsibility of setting up the revision walker and
picking commits in a loop. Transfer the remaining work to its
callers. Now, the API is simplified as:
if (parse_args(argc, argv, opts) < 0)
print "Can't parse arguments"
if (pick_commits(opts) < 0)
print "Error encountered in picking machinery"
Later in the series, pick_commits will also serve as the starting
point for continuing a cherry-pick or revert.
Inspired-by: Christian Couder <chriscool@tuxfamily.org>
Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-04 12:39:06 +02:00
|
|
|
git_config(git_default_config, NULL);
|
|
|
|
parse_args(argc, argv, &opts);
|
2011-08-04 12:39:16 +02:00
|
|
|
res = pick_revisions(&opts);
|
|
|
|
if (res < 0)
|
|
|
|
die(_("cherry-pick failed"));
|
|
|
|
return res;
|
2007-03-01 05:26:30 +01:00
|
|
|
}
|