2019-08-17 20:41:24 +02:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
test_description='recursive merge diff3 style conflict markers'
|
|
|
|
|
2020-11-19 00:44:38 +01:00
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
tests: mark tests relying on the current default for `init.defaultBranch`
In addition to the manual adjustment to let the `linux-gcc` CI job run
the test suite with `master` and then with `main`, this patch makes sure
that GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME is set in all test scripts
that currently rely on the initial branch name being `master by default.
To determine which test scripts to mark up, the first step was to
force-set the default branch name to `master` in
- all test scripts that contain the keyword `master`,
- t4211, which expects `t/t4211/history.export` with a hard-coded ref to
initialize the default branch,
- t5560 because it sources `t/t556x_common` which uses `master`,
- t8002 and t8012 because both source `t/annotate-tests.sh` which also
uses `master`)
This trick was performed by this command:
$ sed -i '/^ *\. \.\/\(test-lib\|lib-\(bash\|cvs\|git-svn\)\|gitweb-lib\)\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' $(git grep -l master t/t[0-9]*.sh) \
t/t4211*.sh t/t5560*.sh t/t8002*.sh t/t8012*.sh
After that, careful, manual inspection revealed that some of the test
scripts containing the needle `master` do not actually rely on a
specific default branch name: either they mention `master` only in a
comment, or they initialize that branch specificially, or they do not
actually refer to the current default branch. Therefore, the
aforementioned modification was undone in those test scripts thusly:
$ git checkout HEAD -- \
t/t0027-auto-crlf.sh t/t0060-path-utils.sh \
t/t1011-read-tree-sparse-checkout.sh \
t/t1305-config-include.sh t/t1309-early-config.sh \
t/t1402-check-ref-format.sh t/t1450-fsck.sh \
t/t2024-checkout-dwim.sh \
t/t2106-update-index-assume-unchanged.sh \
t/t3040-subprojects-basic.sh t/t3301-notes.sh \
t/t3308-notes-merge.sh t/t3423-rebase-reword.sh \
t/t3436-rebase-more-options.sh \
t/t4015-diff-whitespace.sh t/t4257-am-interactive.sh \
t/t5323-pack-redundant.sh t/t5401-update-hooks.sh \
t/t5511-refspec.sh t/t5526-fetch-submodules.sh \
t/t5529-push-errors.sh t/t5530-upload-pack-error.sh \
t/t5548-push-porcelain.sh \
t/t5552-skipping-fetch-negotiator.sh \
t/t5572-pull-submodule.sh t/t5608-clone-2gb.sh \
t/t5614-clone-submodules-shallow.sh \
t/t7508-status.sh t/t7606-merge-custom.sh \
t/t9302-fast-import-unpack-limit.sh
We excluded one set of test scripts in these commands, though: the range
of `git p4` tests. The reason? `git p4` stores the (foreign) remote
branch in the branch called `p4/master`, which is obviously not the
default branch. Manual analysis revealed that only five of these tests
actually require a specific default branch name to pass; They were
modified thusly:
$ sed -i '/^ *\. \.\/lib-git-p4\.sh$/i\
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\
' t/t980[0167]*.sh t/t9811*.sh
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-11-19 00:44:19 +01:00
|
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
|
2019-08-17 20:41:24 +02:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
# Setup:
|
|
|
|
# L1
|
|
|
|
# \
|
|
|
|
# ?
|
|
|
|
# /
|
|
|
|
# R1
|
|
|
|
#
|
|
|
|
# Where:
|
|
|
|
# L1 and R1 both have a file named 'content' but have no common history
|
|
|
|
#
|
|
|
|
|
|
|
|
test_expect_success 'setup no merge base' '
|
2022-08-26 05:49:19 +02:00
|
|
|
git init no_merge_base &&
|
2019-08-17 20:41:24 +02:00
|
|
|
(
|
|
|
|
cd no_merge_base &&
|
|
|
|
|
|
|
|
git checkout -b L &&
|
|
|
|
test_commit A content A &&
|
|
|
|
|
|
|
|
git checkout --orphan R &&
|
|
|
|
test_commit B content B
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'check no merge base' '
|
|
|
|
(
|
|
|
|
cd no_merge_base &&
|
|
|
|
|
|
|
|
git checkout L^0 &&
|
|
|
|
|
|
|
|
test_must_fail git -c merge.conflictstyle=diff3 merge --allow-unrelated-histories -s recursive R^0 &&
|
|
|
|
|
|
|
|
grep "|||||| empty tree" content
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
|
|
|
# Setup:
|
|
|
|
# L1
|
|
|
|
# / \
|
2020-11-19 00:44:38 +01:00
|
|
|
# main ?
|
2019-08-17 20:41:24 +02:00
|
|
|
# \ /
|
|
|
|
# R1
|
|
|
|
#
|
|
|
|
# Where:
|
|
|
|
# L1 and R1 have modified the same file ('content') in conflicting ways
|
|
|
|
#
|
|
|
|
|
|
|
|
test_expect_success 'setup unique merge base' '
|
2022-08-26 05:49:19 +02:00
|
|
|
git init unique_merge_base &&
|
2019-08-17 20:41:24 +02:00
|
|
|
(
|
|
|
|
cd unique_merge_base &&
|
|
|
|
|
|
|
|
test_commit base content "1
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5
|
|
|
|
" &&
|
|
|
|
|
|
|
|
git branch L &&
|
|
|
|
git branch R &&
|
|
|
|
|
|
|
|
git checkout L &&
|
|
|
|
test_commit L content "1
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5
|
|
|
|
7" &&
|
|
|
|
|
|
|
|
git checkout R &&
|
|
|
|
git rm content &&
|
|
|
|
test_commit R renamed "1
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5
|
|
|
|
six"
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'check unique merge base' '
|
|
|
|
(
|
|
|
|
cd unique_merge_base &&
|
|
|
|
|
|
|
|
git checkout L^0 &&
|
2020-11-19 00:44:38 +01:00
|
|
|
MAIN=$(git rev-parse --short main) &&
|
2019-08-17 20:41:24 +02:00
|
|
|
|
|
|
|
test_must_fail git -c merge.conflictstyle=diff3 merge -s recursive R^0 &&
|
|
|
|
|
2020-11-19 00:44:38 +01:00
|
|
|
grep "|||||| $MAIN:content" renamed
|
2019-08-17 20:41:24 +02:00
|
|
|
)
|
|
|
|
'
|
|
|
|
|
|
|
|
# Setup:
|
|
|
|
# L1---L2--L3
|
|
|
|
# / \ / \
|
2020-11-19 00:44:38 +01:00
|
|
|
# main X1 ?
|
2019-08-17 20:41:24 +02:00
|
|
|
# \ / \ /
|
|
|
|
# R1---R2--R3
|
|
|
|
#
|
|
|
|
# Where:
|
|
|
|
# commits L1 and R1 have modified the same file in non-conflicting ways
|
|
|
|
# X1 is an auto-generated merge-base used when merging L1 and R1
|
|
|
|
# commits L2 and R2 are merges of R1 and L1 into L1 and R1, respectively
|
|
|
|
# commits L3 and R3 both modify 'content' in conflicting ways
|
|
|
|
#
|
|
|
|
|
|
|
|
test_expect_success 'setup multiple merge bases' '
|
2022-08-26 05:49:19 +02:00
|
|
|
git init multiple_merge_bases &&
|
2019-08-17 20:41:24 +02:00
|
|
|
(
|
|
|
|
cd multiple_merge_bases &&
|
|
|
|
|
|
|
|
test_commit initial content "1
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5" &&
|
|
|
|
|
|
|
|
git branch L &&
|
|
|
|
git branch R &&
|
|
|
|
|
|
|
|
# Create L1
|
|
|
|
git checkout L &&
|
|
|
|
test_commit L1 content "0
|
|
|
|
1
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5" &&
|
|
|
|
|
|
|
|
# Create R1
|
|
|
|
git checkout R &&
|
|
|
|
test_commit R1 content "1
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5
|
|
|
|
6" &&
|
|
|
|
|
|
|
|
# Create L2
|
|
|
|
git checkout L &&
|
|
|
|
git merge R1 &&
|
|
|
|
|
|
|
|
# Create R2
|
|
|
|
git checkout R &&
|
|
|
|
git merge L1 &&
|
|
|
|
|
|
|
|
# Create L3
|
|
|
|
git checkout L &&
|
|
|
|
test_commit L3 content "0
|
|
|
|
1
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5
|
|
|
|
A" &&
|
|
|
|
|
|
|
|
# Create R3
|
|
|
|
git checkout R &&
|
|
|
|
git rm content &&
|
|
|
|
test_commit R3 renamed "0
|
|
|
|
2
|
|
|
|
3
|
|
|
|
4
|
|
|
|
5
|
|
|
|
six"
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'check multiple merge bases' '
|
|
|
|
(
|
|
|
|
cd multiple_merge_bases &&
|
|
|
|
|
|
|
|
git checkout L^0 &&
|
|
|
|
|
|
|
|
test_must_fail git -c merge.conflictstyle=diff3 merge -s recursive R^0 &&
|
|
|
|
|
|
|
|
grep "|||||| merged common ancestors:content" renamed
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2020-02-15 22:36:38 +01:00
|
|
|
test_expect_success 'rebase --merge describes parent of commit being picked' '
|
2022-08-26 05:49:19 +02:00
|
|
|
git init rebase &&
|
merge-recursive: fix the diff3 common ancestor label for virtual commits
In commit 743474cbfa8b ("merge-recursive: provide a better label for
diff3 common ancestor", 2019-08-17), the label for the common ancestor
was changed from always being
"merged common ancestors"
to instead be based on the number of merge bases:
>=2: "merged common ancestors"
1: <abbreviated commit hash>
0: "<empty tree>"
Unfortunately, this did not take into account that when we have a single
merge base, that merge base could be fake or constructed. In such
cases, this resulted in a label of "00000000". Of course, the previous
label of "merged common ancestors" was also misleading for this case.
Since we have an API that is explicitly about creating fake merge base
commits in merge_recursive_generic(), we should provide a better label
when using that API with one merge base. So, when
merge_recursive_generic() is called with one merge base, set the label
to:
"constructed merge base"
Note that callers of merge_recursive_generic() include the builtin
commands git-am (in combination with git apply --build-fake-ancestor),
git-merge-recursive, and git-stash.
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-10-01 20:17:27 +02:00
|
|
|
(
|
|
|
|
cd rebase &&
|
|
|
|
test_commit base file &&
|
2020-11-19 00:44:38 +01:00
|
|
|
test_commit main file &&
|
merge-recursive: fix the diff3 common ancestor label for virtual commits
In commit 743474cbfa8b ("merge-recursive: provide a better label for
diff3 common ancestor", 2019-08-17), the label for the common ancestor
was changed from always being
"merged common ancestors"
to instead be based on the number of merge bases:
>=2: "merged common ancestors"
1: <abbreviated commit hash>
0: "<empty tree>"
Unfortunately, this did not take into account that when we have a single
merge base, that merge base could be fake or constructed. In such
cases, this resulted in a label of "00000000". Of course, the previous
label of "merged common ancestors" was also misleading for this case.
Since we have an API that is explicitly about creating fake merge base
commits in merge_recursive_generic(), we should provide a better label
when using that API with one merge base. So, when
merge_recursive_generic() is called with one merge base, set the label
to:
"constructed merge base"
Note that callers of merge_recursive_generic() include the builtin
commands git-am (in combination with git apply --build-fake-ancestor),
git-merge-recursive, and git-stash.
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-10-01 20:17:27 +02:00
|
|
|
git checkout -b side HEAD^ &&
|
|
|
|
test_commit side file &&
|
2020-11-19 00:44:38 +01:00
|
|
|
test_must_fail git -c merge.conflictstyle=diff3 rebase --merge main &&
|
2020-02-15 22:36:38 +01:00
|
|
|
grep "||||||| parent of" file
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2020-02-15 22:36:41 +01:00
|
|
|
test_expect_success 'rebase --apply describes fake ancestor base' '
|
2020-02-15 22:36:38 +01:00
|
|
|
(
|
|
|
|
cd rebase &&
|
|
|
|
git rebase --abort &&
|
2020-11-19 00:44:38 +01:00
|
|
|
test_must_fail git -c merge.conflictstyle=diff3 rebase --apply main &&
|
merge-recursive: fix the diff3 common ancestor label for virtual commits
In commit 743474cbfa8b ("merge-recursive: provide a better label for
diff3 common ancestor", 2019-08-17), the label for the common ancestor
was changed from always being
"merged common ancestors"
to instead be based on the number of merge bases:
>=2: "merged common ancestors"
1: <abbreviated commit hash>
0: "<empty tree>"
Unfortunately, this did not take into account that when we have a single
merge base, that merge base could be fake or constructed. In such
cases, this resulted in a label of "00000000". Of course, the previous
label of "merged common ancestors" was also misleading for this case.
Since we have an API that is explicitly about creating fake merge base
commits in merge_recursive_generic(), we should provide a better label
when using that API with one merge base. So, when
merge_recursive_generic() is called with one merge base, set the label
to:
"constructed merge base"
Note that callers of merge_recursive_generic() include the builtin
commands git-am (in combination with git apply --build-fake-ancestor),
git-merge-recursive, and git-stash.
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-10-01 20:17:27 +02:00
|
|
|
grep "||||||| constructed merge base" file
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
xdiff: implement a zealous diff3, or "zdiff3"
"zdiff3" is identical to ordinary diff3 except that it allows compaction
of common lines on the two sides of history at the beginning or end of
the conflict hunk. For example, the following diff3 conflict:
1
2
3
4
<<<<<<
A
B
C
D
E
||||||
5
6
======
A
X
C
Y
E
>>>>>>
7
8
9
has common lines 'A', 'C', and 'E' on the two sides. With zdiff3, one
would instead get the following conflict:
1
2
3
4
A
<<<<<<
B
C
D
||||||
5
6
======
X
C
Y
>>>>>>
E
7
8
9
Note that the common lines, 'A', and 'E' were moved outside the
conflict. Unlike with the two-way conflicts from the 'merge'
conflictStyle, the zdiff3 conflict is NOT split into multiple conflict
regions to allow the common 'C' lines to be shown outside a conflict,
because zdiff3 shows the base version too and the base version cannot be
reasonably split.
Note also that the removing of lines common to the two sides might make
the remaining text inside the conflict region match the base text inside
the conflict region (for example, if the diff3 conflict had '5 6 E' on
the right side of the conflict, then the common line 'E' would be moved
outside and both the base and right side's remaining conflict text would
be the lines '5' and '6'). This has the potential to surprise users and
make them think there should not have been a conflict, but there
definitely was a conflict and it should remain.
Based-on-patch-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Co-authored-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Phillip Wood <phillip.wood123@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-12-01 01:05:06 +01:00
|
|
|
test_setup_zdiff3 () {
|
2022-08-26 05:49:19 +02:00
|
|
|
git init zdiff3 &&
|
xdiff: implement a zealous diff3, or "zdiff3"
"zdiff3" is identical to ordinary diff3 except that it allows compaction
of common lines on the two sides of history at the beginning or end of
the conflict hunk. For example, the following diff3 conflict:
1
2
3
4
<<<<<<
A
B
C
D
E
||||||
5
6
======
A
X
C
Y
E
>>>>>>
7
8
9
has common lines 'A', 'C', and 'E' on the two sides. With zdiff3, one
would instead get the following conflict:
1
2
3
4
A
<<<<<<
B
C
D
||||||
5
6
======
X
C
Y
>>>>>>
E
7
8
9
Note that the common lines, 'A', and 'E' were moved outside the
conflict. Unlike with the two-way conflicts from the 'merge'
conflictStyle, the zdiff3 conflict is NOT split into multiple conflict
regions to allow the common 'C' lines to be shown outside a conflict,
because zdiff3 shows the base version too and the base version cannot be
reasonably split.
Note also that the removing of lines common to the two sides might make
the remaining text inside the conflict region match the base text inside
the conflict region (for example, if the diff3 conflict had '5 6 E' on
the right side of the conflict, then the common line 'E' would be moved
outside and both the base and right side's remaining conflict text would
be the lines '5' and '6'). This has the potential to surprise users and
make them think there should not have been a conflict, but there
definitely was a conflict and it should remain.
Based-on-patch-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Co-authored-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Phillip Wood <phillip.wood123@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-12-01 01:05:06 +01:00
|
|
|
(
|
|
|
|
cd zdiff3 &&
|
|
|
|
|
|
|
|
test_write_lines 1 2 3 4 5 6 7 8 9 >basic &&
|
|
|
|
test_write_lines 1 2 3 AA 4 5 BB 6 7 8 >middle-common &&
|
|
|
|
test_write_lines 1 2 3 4 5 6 7 8 9 >interesting &&
|
|
|
|
test_write_lines 1 2 3 4 5 6 7 8 9 >evil &&
|
|
|
|
|
|
|
|
git add basic middle-common interesting evil &&
|
|
|
|
git commit -m base &&
|
|
|
|
|
|
|
|
git branch left &&
|
|
|
|
git branch right &&
|
|
|
|
|
|
|
|
git checkout left &&
|
|
|
|
test_write_lines 1 2 3 4 A B C D E 7 8 9 >basic &&
|
|
|
|
test_write_lines 1 2 3 CC 4 5 DD 6 7 8 >middle-common &&
|
|
|
|
test_write_lines 1 2 3 4 A B C D E F G H I J 7 8 9 >interesting &&
|
|
|
|
test_write_lines 1 2 3 4 X A B C 7 8 9 >evil &&
|
|
|
|
git add -u &&
|
|
|
|
git commit -m letters &&
|
|
|
|
|
|
|
|
git checkout right &&
|
|
|
|
test_write_lines 1 2 3 4 A X C Y E 7 8 9 >basic &&
|
|
|
|
test_write_lines 1 2 3 EE 4 5 FF 6 7 8 >middle-common &&
|
|
|
|
test_write_lines 1 2 3 4 A B C 5 6 G H I J 7 8 9 >interesting &&
|
|
|
|
test_write_lines 1 2 3 4 Y A B C B C 7 8 9 >evil &&
|
|
|
|
git add -u &&
|
|
|
|
git commit -m permuted
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
|
|
|
test_expect_success 'check zdiff3 markers' '
|
|
|
|
test_setup_zdiff3 &&
|
|
|
|
(
|
|
|
|
cd zdiff3 &&
|
|
|
|
|
|
|
|
git checkout left^0 &&
|
|
|
|
|
|
|
|
base=$(git rev-parse --short HEAD^1) &&
|
|
|
|
test_must_fail git -c merge.conflictstyle=zdiff3 merge -s recursive right^0 &&
|
|
|
|
|
|
|
|
test_write_lines 1 2 3 4 A \
|
|
|
|
"<<<<<<< HEAD" B C D \
|
|
|
|
"||||||| $base" 5 6 \
|
|
|
|
======= X C Y \
|
|
|
|
">>>>>>> right^0" \
|
|
|
|
E 7 8 9 \
|
|
|
|
>expect &&
|
|
|
|
test_cmp expect basic &&
|
|
|
|
|
|
|
|
test_write_lines 1 2 3 \
|
|
|
|
"<<<<<<< HEAD" CC \
|
|
|
|
"||||||| $base" AA \
|
|
|
|
======= EE \
|
|
|
|
">>>>>>> right^0" \
|
|
|
|
4 5 \
|
|
|
|
"<<<<<<< HEAD" DD \
|
|
|
|
"||||||| $base" BB \
|
|
|
|
======= FF \
|
|
|
|
">>>>>>> right^0" \
|
|
|
|
6 7 8 \
|
|
|
|
>expect &&
|
|
|
|
test_cmp expect middle-common &&
|
|
|
|
|
|
|
|
test_write_lines 1 2 3 4 A B C \
|
|
|
|
"<<<<<<< HEAD" D E F \
|
|
|
|
"||||||| $base" 5 6 \
|
|
|
|
======= 5 6 \
|
|
|
|
">>>>>>> right^0" \
|
|
|
|
G H I J 7 8 9 \
|
|
|
|
>expect &&
|
|
|
|
test_cmp expect interesting &&
|
|
|
|
|
|
|
|
# Not passing this one yet; the common "B C" lines is still
|
|
|
|
# being left in the conflict blocks on the left and right
|
|
|
|
# sides.
|
|
|
|
test_write_lines 1 2 3 4 \
|
|
|
|
"<<<<<<< HEAD" X A \
|
|
|
|
"||||||| $base" 5 6 \
|
|
|
|
======= Y A B C \
|
|
|
|
">>>>>>> right^0" \
|
|
|
|
B C 7 8 9 \
|
|
|
|
>expect &&
|
|
|
|
test_cmp expect evil
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2019-08-17 20:41:24 +02:00
|
|
|
test_done
|