2008-07-09 14:58:57 +02:00
|
|
|
#include "cache.h"
|
2014-10-01 12:28:42 +02:00
|
|
|
#include "lockfile.h"
|
2008-07-21 20:03:49 +02:00
|
|
|
#include "string-list.h"
|
2008-07-09 14:58:57 +02:00
|
|
|
#include "rerere.h"
|
|
|
|
#include "xdiff-interface.h"
|
2009-12-26 00:51:32 +01:00
|
|
|
#include "dir.h"
|
|
|
|
#include "resolve-undo.h"
|
|
|
|
#include "ll-merge.h"
|
2010-01-17 08:28:46 +01:00
|
|
|
#include "attr.h"
|
2013-07-14 10:35:40 +02:00
|
|
|
#include "pathspec.h"
|
2008-07-09 14:58:57 +02:00
|
|
|
|
2011-02-16 11:47:44 +01:00
|
|
|
#define RESOLVED 0
|
|
|
|
#define PUNTED 1
|
|
|
|
#define THREE_STAGED 2
|
|
|
|
void *RERERE_RESOLVED = &RERERE_RESOLVED;
|
|
|
|
|
2008-07-09 14:58:57 +02:00
|
|
|
/* if rerere_enabled == -1, fall back to detection of .git/rr-cache */
|
|
|
|
static int rerere_enabled = -1;
|
|
|
|
|
|
|
|
/* automatically update cleanly resolved paths to the index */
|
|
|
|
static int rerere_autoupdate;
|
|
|
|
|
2009-02-14 23:21:04 +01:00
|
|
|
const char *rerere_path(const char *hex, const char *file)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
2009-02-14 23:21:04 +01:00
|
|
|
return git_path("rr-cache/%s/%s", hex, file);
|
2008-07-09 14:58:57 +02:00
|
|
|
}
|
|
|
|
|
2012-09-15 23:06:00 +02:00
|
|
|
static int has_rerere_resolution(const char *hex)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
|
|
|
struct stat st;
|
2009-02-14 23:21:04 +01:00
|
|
|
return !stat(rerere_path(hex, "postimage"), &st);
|
2008-07-09 14:58:57 +02:00
|
|
|
}
|
|
|
|
|
2008-07-21 20:03:49 +02:00
|
|
|
static void read_rr(struct string_list *rr)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
|
|
|
unsigned char sha1[20];
|
|
|
|
char buf[PATH_MAX];
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 11:38:57 +02:00
|
|
|
FILE *in = fopen(git_path_merge_rr(), "r");
|
2008-07-09 14:58:57 +02:00
|
|
|
if (!in)
|
|
|
|
return;
|
|
|
|
while (fread(buf, 40, 1, in) == 1) {
|
|
|
|
int i;
|
|
|
|
char *name;
|
|
|
|
if (get_sha1_hex(buf, sha1))
|
|
|
|
die("corrupt MERGE_RR");
|
|
|
|
buf[40] = '\0';
|
|
|
|
name = xstrdup(buf);
|
|
|
|
if (fgetc(in) != '\t')
|
|
|
|
die("corrupt MERGE_RR");
|
2011-05-26 15:54:18 +02:00
|
|
|
for (i = 0; i < sizeof(buf); i++) {
|
|
|
|
int c = fgetc(in);
|
|
|
|
if (c < 0)
|
|
|
|
die("corrupt MERGE_RR");
|
|
|
|
buf[i] = c;
|
|
|
|
if (c == 0)
|
|
|
|
break;
|
|
|
|
}
|
2008-07-09 14:58:57 +02:00
|
|
|
if (i == sizeof(buf))
|
|
|
|
die("filename too long");
|
2010-06-26 01:41:35 +02:00
|
|
|
string_list_insert(rr, buf)->util = name;
|
2008-07-09 14:58:57 +02:00
|
|
|
}
|
|
|
|
fclose(in);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct lock_file write_lock;
|
|
|
|
|
2008-07-21 20:03:49 +02:00
|
|
|
static int write_rr(struct string_list *rr, int out_fd)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
for (i = 0; i < rr->nr; i++) {
|
|
|
|
const char *path;
|
|
|
|
int length;
|
|
|
|
if (!rr->items[i].util)
|
|
|
|
continue;
|
2008-07-21 20:03:49 +02:00
|
|
|
path = rr->items[i].string;
|
2008-07-09 14:58:57 +02:00
|
|
|
length = strlen(path) + 1;
|
|
|
|
if (write_in_full(out_fd, rr->items[i].util, 40) != 40 ||
|
use write_str_in_full helper to avoid literal string lengths
In 2d14d65 (Use a clearer style to issue commands to remote helpers,
2009-09-03) I happened to notice two changes like this:
- write_in_full(helper->in, "list\n", 5);
+
+ strbuf_addstr(&buf, "list\n");
+ write_in_full(helper->in, buf.buf, buf.len);
+ strbuf_reset(&buf);
IMHO, it would be better to define a new function,
static inline ssize_t write_str_in_full(int fd, const char *str)
{
return write_in_full(fd, str, strlen(str));
}
and then use it like this:
- strbuf_addstr(&buf, "list\n");
- write_in_full(helper->in, buf.buf, buf.len);
- strbuf_reset(&buf);
+ write_str_in_full(helper->in, "list\n");
Thus not requiring the added allocation, and still avoiding
the maintenance risk of literal string lengths.
These days, compilers are good enough that strlen("literal")
imposes no run-time cost.
Transformed via this:
perl -pi -e \
's/write_in_full\((.*?), (".*?"), \d+\)/write_str_in_full($1, $2)/'\
$(git grep -l 'write_in_full.*"')
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-09-12 10:54:32 +02:00
|
|
|
write_str_in_full(out_fd, "\t") != 1 ||
|
2008-07-09 14:58:57 +02:00
|
|
|
write_in_full(out_fd, path, length) != length)
|
|
|
|
die("unable to write rerere record");
|
|
|
|
}
|
|
|
|
if (commit_lock_file(&write_lock) != 0)
|
|
|
|
die("unable to write rerere record");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-12-05 01:35:48 +01:00
|
|
|
static void ferr_write(const void *p, size_t count, FILE *fp, int *err)
|
|
|
|
{
|
|
|
|
if (!count || *err)
|
|
|
|
return;
|
|
|
|
if (fwrite(p, count, 1, fp) != 1)
|
|
|
|
*err = errno;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void ferr_puts(const char *s, FILE *fp, int *err)
|
|
|
|
{
|
|
|
|
ferr_write(s, strlen(s), fp, err);
|
|
|
|
}
|
|
|
|
|
2009-12-25 23:34:53 +01:00
|
|
|
struct rerere_io {
|
|
|
|
int (*getline)(struct strbuf *, struct rerere_io *);
|
|
|
|
FILE *output;
|
|
|
|
int wrerror;
|
|
|
|
/* some more stuff */
|
|
|
|
};
|
|
|
|
|
|
|
|
static void rerere_io_putstr(const char *str, struct rerere_io *io)
|
|
|
|
{
|
|
|
|
if (io->output)
|
|
|
|
ferr_puts(str, io->output, &io->wrerror);
|
|
|
|
}
|
|
|
|
|
2010-01-17 08:06:45 +01:00
|
|
|
static void rerere_io_putconflict(int ch, int size, struct rerere_io *io)
|
|
|
|
{
|
|
|
|
char buf[64];
|
|
|
|
|
|
|
|
while (size) {
|
|
|
|
if (size < sizeof(buf) - 2) {
|
|
|
|
memset(buf, ch, size);
|
|
|
|
buf[size] = '\n';
|
|
|
|
buf[size + 1] = '\0';
|
|
|
|
size = 0;
|
|
|
|
} else {
|
|
|
|
int sz = sizeof(buf) - 1;
|
|
|
|
if (size <= sz)
|
|
|
|
sz -= (sz - size) + 1;
|
|
|
|
memset(buf, ch, sz);
|
|
|
|
buf[sz] = '\0';
|
|
|
|
size -= sz;
|
|
|
|
}
|
|
|
|
rerere_io_putstr(buf, io);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-12-25 23:34:53 +01:00
|
|
|
static void rerere_io_putmem(const char *mem, size_t sz, struct rerere_io *io)
|
|
|
|
{
|
|
|
|
if (io->output)
|
|
|
|
ferr_write(mem, sz, io->output, &io->wrerror);
|
|
|
|
}
|
|
|
|
|
|
|
|
struct rerere_io_file {
|
|
|
|
struct rerere_io io;
|
|
|
|
FILE *input;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int rerere_file_getline(struct strbuf *sb, struct rerere_io *io_)
|
|
|
|
{
|
|
|
|
struct rerere_io_file *io = (struct rerere_io_file *)io_;
|
|
|
|
return strbuf_getwholeline(sb, io->input, '\n');
|
|
|
|
}
|
|
|
|
|
2010-01-17 08:06:45 +01:00
|
|
|
static int is_cmarker(char *buf, int marker_char, int marker_size, int want_sp)
|
|
|
|
{
|
|
|
|
while (marker_size--)
|
|
|
|
if (*buf++ != marker_char)
|
|
|
|
return 0;
|
|
|
|
if (want_sp && *buf != ' ')
|
|
|
|
return 0;
|
|
|
|
return isspace(*buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int handle_path(unsigned char *sha1, struct rerere_io *io, int marker_size)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
2008-10-01 20:05:20 +02:00
|
|
|
git_SHA_CTX ctx;
|
2008-08-29 19:12:23 +02:00
|
|
|
int hunk_no = 0;
|
|
|
|
enum {
|
2010-05-14 11:31:35 +02:00
|
|
|
RR_CONTEXT = 0, RR_SIDE_1, RR_SIDE_2, RR_ORIGINAL
|
2008-08-29 19:12:23 +02:00
|
|
|
} hunk = RR_CONTEXT;
|
2008-10-09 21:12:12 +02:00
|
|
|
struct strbuf one = STRBUF_INIT, two = STRBUF_INIT;
|
2009-12-25 22:55:29 +01:00
|
|
|
struct strbuf buf = STRBUF_INIT;
|
2008-07-09 14:58:57 +02:00
|
|
|
|
|
|
|
if (sha1)
|
2008-10-01 20:05:20 +02:00
|
|
|
git_SHA1_Init(&ctx);
|
2008-07-09 14:58:57 +02:00
|
|
|
|
2009-12-25 23:34:53 +01:00
|
|
|
while (!io->getline(&buf, io)) {
|
2010-01-17 08:06:45 +01:00
|
|
|
if (is_cmarker(buf.buf, '<', marker_size, 1)) {
|
2008-08-29 19:12:23 +02:00
|
|
|
if (hunk != RR_CONTEXT)
|
2008-07-09 14:58:57 +02:00
|
|
|
goto bad;
|
2008-08-29 19:12:23 +02:00
|
|
|
hunk = RR_SIDE_1;
|
2010-01-17 08:06:45 +01:00
|
|
|
} else if (is_cmarker(buf.buf, '|', marker_size, 0)) {
|
2008-08-29 19:12:23 +02:00
|
|
|
if (hunk != RR_SIDE_1)
|
2008-07-09 14:58:57 +02:00
|
|
|
goto bad;
|
2008-08-29 19:24:45 +02:00
|
|
|
hunk = RR_ORIGINAL;
|
2010-01-17 08:06:45 +01:00
|
|
|
} else if (is_cmarker(buf.buf, '=', marker_size, 0)) {
|
2008-08-29 19:24:45 +02:00
|
|
|
if (hunk != RR_SIDE_1 && hunk != RR_ORIGINAL)
|
2008-07-09 14:58:57 +02:00
|
|
|
goto bad;
|
2008-08-29 19:12:23 +02:00
|
|
|
hunk = RR_SIDE_2;
|
2010-01-17 08:06:45 +01:00
|
|
|
} else if (is_cmarker(buf.buf, '>', marker_size, 1)) {
|
2008-08-29 19:12:23 +02:00
|
|
|
if (hunk != RR_SIDE_2)
|
2008-07-09 14:58:57 +02:00
|
|
|
goto bad;
|
|
|
|
if (strbuf_cmp(&one, &two) > 0)
|
|
|
|
strbuf_swap(&one, &two);
|
|
|
|
hunk_no++;
|
2008-08-29 19:12:23 +02:00
|
|
|
hunk = RR_CONTEXT;
|
2010-01-17 08:06:45 +01:00
|
|
|
rerere_io_putconflict('<', marker_size, io);
|
2009-12-25 23:34:53 +01:00
|
|
|
rerere_io_putmem(one.buf, one.len, io);
|
2010-01-17 08:06:45 +01:00
|
|
|
rerere_io_putconflict('=', marker_size, io);
|
2009-12-25 23:34:53 +01:00
|
|
|
rerere_io_putmem(two.buf, two.len, io);
|
2010-01-17 08:06:45 +01:00
|
|
|
rerere_io_putconflict('>', marker_size, io);
|
2008-07-09 14:58:57 +02:00
|
|
|
if (sha1) {
|
2008-10-01 20:05:20 +02:00
|
|
|
git_SHA1_Update(&ctx, one.buf ? one.buf : "",
|
2008-07-09 14:58:57 +02:00
|
|
|
one.len + 1);
|
2008-10-01 20:05:20 +02:00
|
|
|
git_SHA1_Update(&ctx, two.buf ? two.buf : "",
|
2008-07-09 14:58:57 +02:00
|
|
|
two.len + 1);
|
|
|
|
}
|
|
|
|
strbuf_reset(&one);
|
|
|
|
strbuf_reset(&two);
|
2008-08-29 19:12:23 +02:00
|
|
|
} else if (hunk == RR_SIDE_1)
|
2014-07-10 10:52:21 +02:00
|
|
|
strbuf_addbuf(&one, &buf);
|
2008-08-29 19:24:45 +02:00
|
|
|
else if (hunk == RR_ORIGINAL)
|
|
|
|
; /* discard */
|
2008-08-29 19:12:23 +02:00
|
|
|
else if (hunk == RR_SIDE_2)
|
2014-07-10 10:52:21 +02:00
|
|
|
strbuf_addbuf(&two, &buf);
|
2009-12-25 23:34:53 +01:00
|
|
|
else
|
|
|
|
rerere_io_putstr(buf.buf, io);
|
2008-07-09 14:58:57 +02:00
|
|
|
continue;
|
|
|
|
bad:
|
|
|
|
hunk = 99; /* force error exit */
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
strbuf_release(&one);
|
|
|
|
strbuf_release(&two);
|
2009-12-25 22:55:29 +01:00
|
|
|
strbuf_release(&buf);
|
2008-07-09 14:58:57 +02:00
|
|
|
|
|
|
|
if (sha1)
|
2008-10-01 20:05:20 +02:00
|
|
|
git_SHA1_Final(sha1, &ctx);
|
2009-12-25 23:34:53 +01:00
|
|
|
if (hunk != RR_CONTEXT)
|
|
|
|
return -1;
|
|
|
|
return hunk_no;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int handle_file(const char *path, unsigned char *sha1, const char *output)
|
|
|
|
{
|
|
|
|
int hunk_no = 0;
|
|
|
|
struct rerere_io_file io;
|
2010-01-17 08:28:46 +01:00
|
|
|
int marker_size = ll_merge_marker_size(path);
|
2009-12-25 23:34:53 +01:00
|
|
|
|
|
|
|
memset(&io, 0, sizeof(io));
|
|
|
|
io.io.getline = rerere_file_getline;
|
|
|
|
io.input = fopen(path, "r");
|
|
|
|
io.io.wrerror = 0;
|
|
|
|
if (!io.input)
|
|
|
|
return error("Could not open %s", path);
|
|
|
|
|
|
|
|
if (output) {
|
|
|
|
io.io.output = fopen(output, "w");
|
|
|
|
if (!io.io.output) {
|
|
|
|
fclose(io.input);
|
|
|
|
return error("Could not write %s", output);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-01-17 08:06:45 +01:00
|
|
|
hunk_no = handle_path(sha1, (struct rerere_io *)&io, marker_size);
|
2009-12-25 23:34:53 +01:00
|
|
|
|
|
|
|
fclose(io.input);
|
|
|
|
if (io.io.wrerror)
|
|
|
|
error("There were errors while writing %s (%s)",
|
|
|
|
path, strerror(io.io.wrerror));
|
|
|
|
if (io.io.output && fclose(io.io.output))
|
|
|
|
io.io.wrerror = error("Failed to flush %s: %s",
|
|
|
|
path, strerror(errno));
|
|
|
|
|
|
|
|
if (hunk_no < 0) {
|
2008-07-09 14:58:57 +02:00
|
|
|
if (output)
|
2009-04-29 23:22:56 +02:00
|
|
|
unlink_or_warn(output);
|
2008-07-09 14:58:57 +02:00
|
|
|
return error("Could not parse conflict hunks in %s", path);
|
|
|
|
}
|
2009-12-25 23:34:53 +01:00
|
|
|
if (io.io.wrerror)
|
2008-12-05 01:35:48 +01:00
|
|
|
return -1;
|
2008-07-09 14:58:57 +02:00
|
|
|
return hunk_no;
|
|
|
|
}
|
|
|
|
|
2009-12-26 00:51:32 +01:00
|
|
|
struct rerere_io_mem {
|
|
|
|
struct rerere_io io;
|
|
|
|
struct strbuf input;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int rerere_mem_getline(struct strbuf *sb, struct rerere_io *io_)
|
|
|
|
{
|
|
|
|
struct rerere_io_mem *io = (struct rerere_io_mem *)io_;
|
|
|
|
char *ep;
|
|
|
|
size_t len;
|
|
|
|
|
|
|
|
strbuf_release(sb);
|
|
|
|
if (!io->input.len)
|
|
|
|
return -1;
|
2013-04-01 23:36:36 +02:00
|
|
|
ep = memchr(io->input.buf, '\n', io->input.len);
|
|
|
|
if (!ep)
|
|
|
|
ep = io->input.buf + io->input.len;
|
|
|
|
else if (*ep == '\n')
|
2009-12-26 00:51:32 +01:00
|
|
|
ep++;
|
|
|
|
len = ep - io->input.buf;
|
|
|
|
strbuf_add(sb, io->input.buf, len);
|
|
|
|
strbuf_remove(&io->input, 0, len);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int handle_cache(const char *path, unsigned char *sha1, const char *output)
|
|
|
|
{
|
2013-04-04 20:41:43 +02:00
|
|
|
mmfile_t mmfile[3] = {{NULL}};
|
2009-12-26 00:51:32 +01:00
|
|
|
mmbuffer_t result = {NULL, 0};
|
Convert "struct cache_entry *" to "const ..." wherever possible
I attempted to make index_state->cache[] a "const struct cache_entry **"
to find out how existing entries in index are modified and where. The
question I have is what do we do if we really need to keep track of on-disk
changes in the index. The result is
- diff-lib.c: setting CE_UPTODATE
- name-hash.c: setting CE_HASHED
- preload-index.c, read-cache.c, unpack-trees.c and
builtin/update-index: obvious
- entry.c: write_entry() may refresh the checked out entry via
fill_stat_cache_info(). This causes "non-const struct cache_entry
*" in builtin/apply.c, builtin/checkout-index.c and
builtin/checkout.c
- builtin/ls-files.c: --with-tree changes stagemask and may set
CE_UPDATE
Of these, write_entry() and its call sites are probably most
interesting because it modifies on-disk info. But this is stat info
and can be retrieved via refresh, at least for porcelain
commands. Other just uses ce_flags for local purposes.
So, keeping track of "dirty" entries is just a matter of setting a
flag in index modification functions exposed by read-cache.c. Except
unpack-trees, the rest of the code base does not do anything funny
behind read-cache's back.
The actual patch is less valueable than the summary above. But if
anyone wants to re-identify the above sites. Applying this patch, then
this:
diff --git a/cache.h b/cache.h
index 430d021..1692891 100644
--- a/cache.h
+++ b/cache.h
@@ -267,7 +267,7 @@ static inline unsigned int canon_mode(unsigned int mode)
#define cache_entry_size(len) (offsetof(struct cache_entry,name) + (len) + 1)
struct index_state {
- struct cache_entry **cache;
+ const struct cache_entry **cache;
unsigned int version;
unsigned int cache_nr, cache_alloc, cache_changed;
struct string_list *resolve_undo;
will help quickly identify them without bogus warnings.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-07-09 17:29:00 +02:00
|
|
|
const struct cache_entry *ce;
|
2009-12-26 00:51:32 +01:00
|
|
|
int pos, len, i, hunk_no;
|
|
|
|
struct rerere_io_mem io;
|
2010-01-17 08:28:46 +01:00
|
|
|
int marker_size = ll_merge_marker_size(path);
|
2009-12-26 00:51:32 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Reproduce the conflicted merge in-core
|
|
|
|
*/
|
|
|
|
len = strlen(path);
|
|
|
|
pos = cache_name_pos(path, len);
|
|
|
|
if (0 <= pos)
|
2008-12-05 01:35:48 +01:00
|
|
|
return -1;
|
2009-12-26 00:51:32 +01:00
|
|
|
pos = -pos - 1;
|
|
|
|
|
|
|
|
for (i = 0; i < 3; i++) {
|
|
|
|
enum object_type type;
|
|
|
|
unsigned long size;
|
2013-04-04 20:41:43 +02:00
|
|
|
int j;
|
2009-12-26 00:51:32 +01:00
|
|
|
|
|
|
|
if (active_nr <= pos)
|
|
|
|
break;
|
|
|
|
ce = active_cache[pos++];
|
2013-04-04 20:41:43 +02:00
|
|
|
if (ce_namelen(ce) != len || memcmp(ce->name, path, len))
|
|
|
|
continue;
|
|
|
|
j = ce_stage(ce) - 1;
|
|
|
|
mmfile[j].ptr = read_sha1_file(ce->sha1, &type, &size);
|
|
|
|
mmfile[j].size = size;
|
2009-12-26 00:51:32 +01:00
|
|
|
}
|
|
|
|
for (i = 0; i < 3; i++) {
|
|
|
|
if (!mmfile[i].ptr && !mmfile[i].size)
|
|
|
|
mmfile[i].ptr = xstrdup("");
|
|
|
|
}
|
2010-08-05 13:24:58 +02:00
|
|
|
/*
|
|
|
|
* NEEDSWORK: handle conflicts from merges with
|
|
|
|
* merge.renormalize set, too
|
|
|
|
*/
|
2010-03-21 01:38:58 +01:00
|
|
|
ll_merge(&result, path, &mmfile[0], NULL,
|
2009-12-26 00:51:32 +01:00
|
|
|
&mmfile[1], "ours",
|
2010-08-26 07:49:53 +02:00
|
|
|
&mmfile[2], "theirs", NULL);
|
2009-12-26 00:51:32 +01:00
|
|
|
for (i = 0; i < 3; i++)
|
|
|
|
free(mmfile[i].ptr);
|
|
|
|
|
2010-01-28 15:52:16 +01:00
|
|
|
memset(&io, 0, sizeof(io));
|
2009-12-26 00:51:32 +01:00
|
|
|
io.io.getline = rerere_mem_getline;
|
|
|
|
if (output)
|
|
|
|
io.io.output = fopen(output, "w");
|
|
|
|
else
|
|
|
|
io.io.output = NULL;
|
|
|
|
strbuf_init(&io.input, 0);
|
|
|
|
strbuf_attach(&io.input, result.ptr, result.size, result.size);
|
|
|
|
|
2010-01-17 08:06:45 +01:00
|
|
|
hunk_no = handle_path(sha1, (struct rerere_io *)&io, marker_size);
|
2009-12-26 00:51:32 +01:00
|
|
|
strbuf_release(&io.input);
|
|
|
|
if (io.io.output)
|
|
|
|
fclose(io.io.output);
|
2008-07-09 14:58:57 +02:00
|
|
|
return hunk_no;
|
|
|
|
}
|
|
|
|
|
2011-02-16 11:47:44 +01:00
|
|
|
static int check_one_conflict(int i, int *type)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
Convert "struct cache_entry *" to "const ..." wherever possible
I attempted to make index_state->cache[] a "const struct cache_entry **"
to find out how existing entries in index are modified and where. The
question I have is what do we do if we really need to keep track of on-disk
changes in the index. The result is
- diff-lib.c: setting CE_UPTODATE
- name-hash.c: setting CE_HASHED
- preload-index.c, read-cache.c, unpack-trees.c and
builtin/update-index: obvious
- entry.c: write_entry() may refresh the checked out entry via
fill_stat_cache_info(). This causes "non-const struct cache_entry
*" in builtin/apply.c, builtin/checkout-index.c and
builtin/checkout.c
- builtin/ls-files.c: --with-tree changes stagemask and may set
CE_UPDATE
Of these, write_entry() and its call sites are probably most
interesting because it modifies on-disk info. But this is stat info
and can be retrieved via refresh, at least for porcelain
commands. Other just uses ce_flags for local purposes.
So, keeping track of "dirty" entries is just a matter of setting a
flag in index modification functions exposed by read-cache.c. Except
unpack-trees, the rest of the code base does not do anything funny
behind read-cache's back.
The actual patch is less valueable than the summary above. But if
anyone wants to re-identify the above sites. Applying this patch, then
this:
diff --git a/cache.h b/cache.h
index 430d021..1692891 100644
--- a/cache.h
+++ b/cache.h
@@ -267,7 +267,7 @@ static inline unsigned int canon_mode(unsigned int mode)
#define cache_entry_size(len) (offsetof(struct cache_entry,name) + (len) + 1)
struct index_state {
- struct cache_entry **cache;
+ const struct cache_entry **cache;
unsigned int version;
unsigned int cache_nr, cache_alloc, cache_changed;
struct string_list *resolve_undo;
will help quickly identify them without bogus warnings.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-07-09 17:29:00 +02:00
|
|
|
const struct cache_entry *e = active_cache[i];
|
2011-02-16 11:47:44 +01:00
|
|
|
|
|
|
|
if (!ce_stage(e)) {
|
|
|
|
*type = RESOLVED;
|
|
|
|
return i + 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
*type = PUNTED;
|
|
|
|
if (ce_stage(e) == 1) {
|
|
|
|
if (active_nr <= ++i)
|
|
|
|
return i + 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Only handle regular files with both stages #2 and #3 */
|
|
|
|
if (i + 1 < active_nr) {
|
Convert "struct cache_entry *" to "const ..." wherever possible
I attempted to make index_state->cache[] a "const struct cache_entry **"
to find out how existing entries in index are modified and where. The
question I have is what do we do if we really need to keep track of on-disk
changes in the index. The result is
- diff-lib.c: setting CE_UPTODATE
- name-hash.c: setting CE_HASHED
- preload-index.c, read-cache.c, unpack-trees.c and
builtin/update-index: obvious
- entry.c: write_entry() may refresh the checked out entry via
fill_stat_cache_info(). This causes "non-const struct cache_entry
*" in builtin/apply.c, builtin/checkout-index.c and
builtin/checkout.c
- builtin/ls-files.c: --with-tree changes stagemask and may set
CE_UPDATE
Of these, write_entry() and its call sites are probably most
interesting because it modifies on-disk info. But this is stat info
and can be retrieved via refresh, at least for porcelain
commands. Other just uses ce_flags for local purposes.
So, keeping track of "dirty" entries is just a matter of setting a
flag in index modification functions exposed by read-cache.c. Except
unpack-trees, the rest of the code base does not do anything funny
behind read-cache's back.
The actual patch is less valueable than the summary above. But if
anyone wants to re-identify the above sites. Applying this patch, then
this:
diff --git a/cache.h b/cache.h
index 430d021..1692891 100644
--- a/cache.h
+++ b/cache.h
@@ -267,7 +267,7 @@ static inline unsigned int canon_mode(unsigned int mode)
#define cache_entry_size(len) (offsetof(struct cache_entry,name) + (len) + 1)
struct index_state {
- struct cache_entry **cache;
+ const struct cache_entry **cache;
unsigned int version;
unsigned int cache_nr, cache_alloc, cache_changed;
struct string_list *resolve_undo;
will help quickly identify them without bogus warnings.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-07-09 17:29:00 +02:00
|
|
|
const struct cache_entry *e2 = active_cache[i];
|
|
|
|
const struct cache_entry *e3 = active_cache[i + 1];
|
2008-07-09 14:58:57 +02:00
|
|
|
if (ce_stage(e2) == 2 &&
|
|
|
|
ce_stage(e3) == 3 &&
|
2011-02-16 11:47:44 +01:00
|
|
|
ce_same_name(e, e3) &&
|
2008-07-09 14:58:57 +02:00
|
|
|
S_ISREG(e2->ce_mode) &&
|
2011-02-16 11:47:44 +01:00
|
|
|
S_ISREG(e3->ce_mode))
|
|
|
|
*type = THREE_STAGED;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Skip the entries with the same name */
|
|
|
|
while (i < active_nr && ce_same_name(e, active_cache[i]))
|
|
|
|
i++;
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int find_conflict(struct string_list *conflict)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
if (read_cache() < 0)
|
|
|
|
return error("Could not read index");
|
|
|
|
|
|
|
|
for (i = 0; i < active_nr;) {
|
|
|
|
int conflict_type;
|
Convert "struct cache_entry *" to "const ..." wherever possible
I attempted to make index_state->cache[] a "const struct cache_entry **"
to find out how existing entries in index are modified and where. The
question I have is what do we do if we really need to keep track of on-disk
changes in the index. The result is
- diff-lib.c: setting CE_UPTODATE
- name-hash.c: setting CE_HASHED
- preload-index.c, read-cache.c, unpack-trees.c and
builtin/update-index: obvious
- entry.c: write_entry() may refresh the checked out entry via
fill_stat_cache_info(). This causes "non-const struct cache_entry
*" in builtin/apply.c, builtin/checkout-index.c and
builtin/checkout.c
- builtin/ls-files.c: --with-tree changes stagemask and may set
CE_UPDATE
Of these, write_entry() and its call sites are probably most
interesting because it modifies on-disk info. But this is stat info
and can be retrieved via refresh, at least for porcelain
commands. Other just uses ce_flags for local purposes.
So, keeping track of "dirty" entries is just a matter of setting a
flag in index modification functions exposed by read-cache.c. Except
unpack-trees, the rest of the code base does not do anything funny
behind read-cache's back.
The actual patch is less valueable than the summary above. But if
anyone wants to re-identify the above sites. Applying this patch, then
this:
diff --git a/cache.h b/cache.h
index 430d021..1692891 100644
--- a/cache.h
+++ b/cache.h
@@ -267,7 +267,7 @@ static inline unsigned int canon_mode(unsigned int mode)
#define cache_entry_size(len) (offsetof(struct cache_entry,name) + (len) + 1)
struct index_state {
- struct cache_entry **cache;
+ const struct cache_entry **cache;
unsigned int version;
unsigned int cache_nr, cache_alloc, cache_changed;
struct string_list *resolve_undo;
will help quickly identify them without bogus warnings.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-07-09 17:29:00 +02:00
|
|
|
const struct cache_entry *e = active_cache[i];
|
2011-02-16 11:47:44 +01:00
|
|
|
i = check_one_conflict(i, &conflict_type);
|
|
|
|
if (conflict_type == THREE_STAGED)
|
|
|
|
string_list_insert(conflict, (const char *)e->name);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int rerere_remaining(struct string_list *merge_rr)
|
|
|
|
{
|
|
|
|
int i;
|
rerere: release lockfile in non-writing functions
There's a bug in builtin/am.c in which we take a lock on
MERGE_RR recursively. But rather than fix am.c, this patch
fixes the confusing interface from rerere.c that caused the
bug. Read on for the gory details.
The setup_rerere() function both reads the existing MERGE_RR
file, and takes MERGE_RR.lock. In the rerere() and
rerere_forget() functions, we end up in write_rr(), which
will then commit the lock file.
But for functions like rerere_clear() that do not write to
MERGE_RR, we expect the caller to have handled
setup_rerere(). That caller would then need to release the
lockfile, but it can't; the lock struct is local to
rerere.c.
For builtin/rerere.c, this is OK. We run a single rerere
operation and then exit immediately, which has the side
effect of rolling back the lockfile.
But in builtin/am.c, this is actively wrong. If we run "git
am -3 --skip", we call setup-rerere twice without releasing
the lock:
1. The "--skip" causes us to call am_rerere_clear(), which
calls setup_rerere(), but never drops the lock.
2. We then proceed to the next patch.
3. The "--3way" may cause us to call rerere() to handle
conflicts in that patch, but we are already holding the
lock. The lockfile code dies with:
BUG: prepare_tempfile_object called for active object
We could fix this by having rerere_clear() call
rollback_lock_file(). But it feels a bit odd for it to roll
back a lockfile that it did not itself take. So let's
simplify the interface further, and handle setup_rerere in
the function itself, taking away the question from the
caller over whether they need to do so.
We can give rerere_gc() the same treatment, as well (even
though it doesn't have any callers besides builtin/rerere.c
at this point). Note that these functions don't take flags
from their callers to pass along to setup_rerere; that's OK,
because the flags would not be meaningful for what they are
doing.
Both of those functions need to hold the lock because even
though they do not write to MERGE_RR, they are still writing
and should be protected from a simultaneous "rerere" run.
But rerere_remaining(), "rerere diff", and "rerere status"
are all read-only operations. They want to setup_rerere(),
but do not care about taking the lock in the first place.
Since our update of MERGE_RR is the usual atomic rename done
by commit_lock_file, they can just do a lockless read. For
that, we teach setup_rerere a READONLY flag to avoid the
lock.
As a bonus, this pushes builtin/rerere.c's setup_rerere call
closer to the functions that use it. Which means that "git
rerere totally-bogus-command" will no longer silently
exit(0) in a repository without rerere enabled.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-09-02 00:14:09 +02:00
|
|
|
if (setup_rerere(merge_rr, RERERE_READONLY))
|
|
|
|
return 0;
|
2011-02-16 11:47:44 +01:00
|
|
|
if (read_cache() < 0)
|
|
|
|
return error("Could not read index");
|
|
|
|
|
|
|
|
for (i = 0; i < active_nr;) {
|
|
|
|
int conflict_type;
|
Convert "struct cache_entry *" to "const ..." wherever possible
I attempted to make index_state->cache[] a "const struct cache_entry **"
to find out how existing entries in index are modified and where. The
question I have is what do we do if we really need to keep track of on-disk
changes in the index. The result is
- diff-lib.c: setting CE_UPTODATE
- name-hash.c: setting CE_HASHED
- preload-index.c, read-cache.c, unpack-trees.c and
builtin/update-index: obvious
- entry.c: write_entry() may refresh the checked out entry via
fill_stat_cache_info(). This causes "non-const struct cache_entry
*" in builtin/apply.c, builtin/checkout-index.c and
builtin/checkout.c
- builtin/ls-files.c: --with-tree changes stagemask and may set
CE_UPDATE
Of these, write_entry() and its call sites are probably most
interesting because it modifies on-disk info. But this is stat info
and can be retrieved via refresh, at least for porcelain
commands. Other just uses ce_flags for local purposes.
So, keeping track of "dirty" entries is just a matter of setting a
flag in index modification functions exposed by read-cache.c. Except
unpack-trees, the rest of the code base does not do anything funny
behind read-cache's back.
The actual patch is less valueable than the summary above. But if
anyone wants to re-identify the above sites. Applying this patch, then
this:
diff --git a/cache.h b/cache.h
index 430d021..1692891 100644
--- a/cache.h
+++ b/cache.h
@@ -267,7 +267,7 @@ static inline unsigned int canon_mode(unsigned int mode)
#define cache_entry_size(len) (offsetof(struct cache_entry,name) + (len) + 1)
struct index_state {
- struct cache_entry **cache;
+ const struct cache_entry **cache;
unsigned int version;
unsigned int cache_nr, cache_alloc, cache_changed;
struct string_list *resolve_undo;
will help quickly identify them without bogus warnings.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-07-09 17:29:00 +02:00
|
|
|
const struct cache_entry *e = active_cache[i];
|
2011-02-16 11:47:44 +01:00
|
|
|
i = check_one_conflict(i, &conflict_type);
|
|
|
|
if (conflict_type == PUNTED)
|
|
|
|
string_list_insert(merge_rr, (const char *)e->name);
|
|
|
|
else if (conflict_type == RESOLVED) {
|
|
|
|
struct string_list_item *it;
|
|
|
|
it = string_list_lookup(merge_rr, (const char *)e->name);
|
|
|
|
if (it != NULL) {
|
|
|
|
free(it->util);
|
|
|
|
it->util = RERERE_RESOLVED;
|
|
|
|
}
|
2008-07-09 14:58:57 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int merge(const char *name, const char *path)
|
|
|
|
{
|
|
|
|
int ret;
|
2010-02-23 21:11:53 +01:00
|
|
|
mmfile_t cur = {NULL, 0}, base = {NULL, 0}, other = {NULL, 0};
|
2008-07-09 14:58:57 +02:00
|
|
|
mmbuffer_t result = {NULL, 0};
|
|
|
|
|
2009-02-14 23:21:04 +01:00
|
|
|
if (handle_file(path, NULL, rerere_path(name, "thisimage")) < 0)
|
2008-07-09 14:58:57 +02:00
|
|
|
return 1;
|
|
|
|
|
2009-02-14 23:21:04 +01:00
|
|
|
if (read_mmfile(&cur, rerere_path(name, "thisimage")) ||
|
|
|
|
read_mmfile(&base, rerere_path(name, "preimage")) ||
|
2010-02-23 21:11:53 +01:00
|
|
|
read_mmfile(&other, rerere_path(name, "postimage"))) {
|
|
|
|
ret = 1;
|
|
|
|
goto out;
|
|
|
|
}
|
2011-04-03 09:06:54 +02:00
|
|
|
ret = ll_merge(&result, path, &base, NULL, &cur, "", &other, "", NULL);
|
2008-07-09 14:58:57 +02:00
|
|
|
if (!ret) {
|
2010-07-13 01:42:04 +02:00
|
|
|
FILE *f;
|
|
|
|
|
|
|
|
if (utime(rerere_path(name, "postimage"), NULL) < 0)
|
|
|
|
warning("failed utime() on %s: %s",
|
|
|
|
rerere_path(name, "postimage"),
|
|
|
|
strerror(errno));
|
|
|
|
f = fopen(path, "w");
|
2008-07-09 14:58:57 +02:00
|
|
|
if (!f)
|
2008-12-05 01:35:48 +01:00
|
|
|
return error("Could not open %s: %s", path,
|
|
|
|
strerror(errno));
|
|
|
|
if (fwrite(result.ptr, result.size, 1, f) != 1)
|
|
|
|
error("Could not write %s: %s", path, strerror(errno));
|
|
|
|
if (fclose(f))
|
|
|
|
return error("Writing %s failed: %s", path,
|
|
|
|
strerror(errno));
|
2008-07-09 14:58:57 +02:00
|
|
|
}
|
|
|
|
|
2010-02-23 21:11:53 +01:00
|
|
|
out:
|
2008-07-09 14:58:57 +02:00
|
|
|
free(cur.ptr);
|
|
|
|
free(base.ptr);
|
|
|
|
free(other.ptr);
|
|
|
|
free(result.ptr);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct lock_file index_lock;
|
|
|
|
|
2014-12-03 05:20:49 +01:00
|
|
|
static void update_paths(struct string_list *update)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2014-12-03 05:20:49 +01:00
|
|
|
hold_locked_index(&index_lock, 1);
|
2008-07-09 14:58:57 +02:00
|
|
|
|
|
|
|
for (i = 0; i < update->nr; i++) {
|
2008-07-21 20:03:49 +02:00
|
|
|
struct string_list_item *item = &update->items[i];
|
2014-12-03 05:20:49 +01:00
|
|
|
if (add_file_to_cache(item->string, 0))
|
|
|
|
exit(128);
|
2008-07-09 14:58:57 +02:00
|
|
|
}
|
|
|
|
|
2014-12-03 05:20:49 +01:00
|
|
|
if (active_cache_changed) {
|
2014-06-13 14:19:23 +02:00
|
|
|
if (write_locked_index(&the_index, &index_lock, COMMIT_LOCK))
|
2008-07-09 14:58:57 +02:00
|
|
|
die("Unable to write new index file");
|
2014-12-03 05:20:49 +01:00
|
|
|
} else
|
2008-07-09 14:58:57 +02:00
|
|
|
rollback_lock_file(&index_lock);
|
|
|
|
}
|
|
|
|
|
2008-07-21 20:03:49 +02:00
|
|
|
static int do_plain_rerere(struct string_list *rr, int fd)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
2010-07-04 21:46:19 +02:00
|
|
|
struct string_list conflict = STRING_LIST_INIT_DUP;
|
|
|
|
struct string_list update = STRING_LIST_INIT_DUP;
|
2008-07-09 14:58:57 +02:00
|
|
|
int i;
|
|
|
|
|
|
|
|
find_conflict(&conflict);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* MERGE_RR records paths with conflicts immediately after merge
|
|
|
|
* failed. Some of the conflicted paths might have been hand resolved
|
|
|
|
* in the working tree since then, but the initial run would catch all
|
|
|
|
* and register their preimages.
|
|
|
|
*/
|
|
|
|
|
|
|
|
for (i = 0; i < conflict.nr; i++) {
|
2008-07-21 20:03:49 +02:00
|
|
|
const char *path = conflict.items[i].string;
|
|
|
|
if (!string_list_has_string(rr, path)) {
|
2008-07-09 14:58:57 +02:00
|
|
|
unsigned char sha1[20];
|
|
|
|
char *hex;
|
|
|
|
int ret;
|
|
|
|
ret = handle_file(path, sha1, NULL);
|
|
|
|
if (ret < 1)
|
|
|
|
continue;
|
|
|
|
hex = xstrdup(sha1_to_hex(sha1));
|
2010-06-26 01:41:35 +02:00
|
|
|
string_list_insert(rr, path)->util = hex;
|
2012-07-10 01:27:49 +02:00
|
|
|
if (mkdir_in_gitdir(git_path("rr-cache/%s", hex)))
|
2009-02-11 02:42:04 +01:00
|
|
|
continue;
|
2009-02-14 23:21:04 +01:00
|
|
|
handle_file(path, NULL, rerere_path(hex, "preimage"));
|
2008-07-09 14:58:57 +02:00
|
|
|
fprintf(stderr, "Recorded preimage for '%s'\n", path);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now some of the paths that had conflicts earlier might have been
|
|
|
|
* hand resolved. Others may be similar to a conflict already that
|
|
|
|
* was resolved before.
|
|
|
|
*/
|
|
|
|
|
|
|
|
for (i = 0; i < rr->nr; i++) {
|
|
|
|
int ret;
|
2008-07-21 20:03:49 +02:00
|
|
|
const char *path = rr->items[i].string;
|
2008-07-09 14:58:57 +02:00
|
|
|
const char *name = (const char *)rr->items[i].util;
|
|
|
|
|
2009-02-14 23:21:04 +01:00
|
|
|
if (has_rerere_resolution(name)) {
|
2008-07-09 14:58:57 +02:00
|
|
|
if (!merge(name, path)) {
|
2012-06-07 14:05:14 +02:00
|
|
|
const char *msg;
|
|
|
|
if (rerere_autoupdate) {
|
2010-06-26 01:41:35 +02:00
|
|
|
string_list_insert(&update, path);
|
2012-06-07 14:05:14 +02:00
|
|
|
msg = "Staged '%s' using previous resolution.\n";
|
|
|
|
} else
|
|
|
|
msg = "Resolved '%s' using previous resolution.\n";
|
|
|
|
fprintf(stderr, msg, path);
|
2008-07-09 14:58:57 +02:00
|
|
|
goto mark_resolved;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Let's see if we have resolved it. */
|
|
|
|
ret = handle_file(path, NULL, NULL);
|
|
|
|
if (ret)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
fprintf(stderr, "Recorded resolution for '%s'.\n", path);
|
2009-02-14 23:21:04 +01:00
|
|
|
copy_file(rerere_path(name, "postimage"), path, 0666);
|
2008-07-09 14:58:57 +02:00
|
|
|
mark_resolved:
|
|
|
|
rr->items[i].util = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (update.nr)
|
|
|
|
update_paths(&update);
|
|
|
|
|
|
|
|
return write_rr(rr, fd);
|
|
|
|
}
|
|
|
|
|
2014-08-07 18:21:21 +02:00
|
|
|
static void git_rerere_config(void)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
2014-08-07 18:21:21 +02:00
|
|
|
git_config_get_bool("rerere.enabled", &rerere_enabled);
|
|
|
|
git_config_get_bool("rerere.autoupdate", &rerere_autoupdate);
|
|
|
|
git_config(git_default_config, NULL);
|
2008-07-09 14:58:57 +02:00
|
|
|
}
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 11:38:57 +02:00
|
|
|
static GIT_PATH_FUNC(git_path_rr_cache, "rr-cache")
|
|
|
|
|
2008-07-09 14:58:57 +02:00
|
|
|
static int is_rerere_enabled(void)
|
|
|
|
{
|
|
|
|
int rr_cache_exists;
|
|
|
|
|
|
|
|
if (!rerere_enabled)
|
|
|
|
return 0;
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 11:38:57 +02:00
|
|
|
rr_cache_exists = is_directory(git_path_rr_cache());
|
2008-07-09 14:58:57 +02:00
|
|
|
if (rerere_enabled < 0)
|
|
|
|
return rr_cache_exists;
|
|
|
|
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 11:38:57 +02:00
|
|
|
if (!rr_cache_exists && mkdir_in_gitdir(git_path_rr_cache()))
|
|
|
|
die("Could not create directory %s", git_path_rr_cache());
|
2008-07-09 14:58:57 +02:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2009-12-04 09:20:48 +01:00
|
|
|
int setup_rerere(struct string_list *merge_rr, int flags)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
|
|
|
int fd;
|
|
|
|
|
2014-08-07 18:21:21 +02:00
|
|
|
git_rerere_config();
|
2008-07-09 14:58:57 +02:00
|
|
|
if (!is_rerere_enabled())
|
|
|
|
return -1;
|
|
|
|
|
2009-12-04 09:20:48 +01:00
|
|
|
if (flags & (RERERE_AUTOUPDATE|RERERE_NOAUTOUPDATE))
|
|
|
|
rerere_autoupdate = !!(flags & RERERE_AUTOUPDATE);
|
rerere: release lockfile in non-writing functions
There's a bug in builtin/am.c in which we take a lock on
MERGE_RR recursively. But rather than fix am.c, this patch
fixes the confusing interface from rerere.c that caused the
bug. Read on for the gory details.
The setup_rerere() function both reads the existing MERGE_RR
file, and takes MERGE_RR.lock. In the rerere() and
rerere_forget() functions, we end up in write_rr(), which
will then commit the lock file.
But for functions like rerere_clear() that do not write to
MERGE_RR, we expect the caller to have handled
setup_rerere(). That caller would then need to release the
lockfile, but it can't; the lock struct is local to
rerere.c.
For builtin/rerere.c, this is OK. We run a single rerere
operation and then exit immediately, which has the side
effect of rolling back the lockfile.
But in builtin/am.c, this is actively wrong. If we run "git
am -3 --skip", we call setup-rerere twice without releasing
the lock:
1. The "--skip" causes us to call am_rerere_clear(), which
calls setup_rerere(), but never drops the lock.
2. We then proceed to the next patch.
3. The "--3way" may cause us to call rerere() to handle
conflicts in that patch, but we are already holding the
lock. The lockfile code dies with:
BUG: prepare_tempfile_object called for active object
We could fix this by having rerere_clear() call
rollback_lock_file(). But it feels a bit odd for it to roll
back a lockfile that it did not itself take. So let's
simplify the interface further, and handle setup_rerere in
the function itself, taking away the question from the
caller over whether they need to do so.
We can give rerere_gc() the same treatment, as well (even
though it doesn't have any callers besides builtin/rerere.c
at this point). Note that these functions don't take flags
from their callers to pass along to setup_rerere; that's OK,
because the flags would not be meaningful for what they are
doing.
Both of those functions need to hold the lock because even
though they do not write to MERGE_RR, they are still writing
and should be protected from a simultaneous "rerere" run.
But rerere_remaining(), "rerere diff", and "rerere status"
are all read-only operations. They want to setup_rerere(),
but do not care about taking the lock in the first place.
Since our update of MERGE_RR is the usual atomic rename done
by commit_lock_file, they can just do a lockless read. For
that, we teach setup_rerere a READONLY flag to avoid the
lock.
As a bonus, this pushes builtin/rerere.c's setup_rerere call
closer to the functions that use it. Which means that "git
rerere totally-bogus-command" will no longer silently
exit(0) in a repository without rerere enabled.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-09-02 00:14:09 +02:00
|
|
|
if (flags & RERERE_READONLY)
|
|
|
|
fd = 0;
|
|
|
|
else
|
|
|
|
fd = hold_lock_file_for_update(&write_lock, git_path_merge_rr(),
|
|
|
|
LOCK_DIE_ON_ERROR);
|
2008-07-09 14:58:57 +02:00
|
|
|
read_rr(merge_rr);
|
|
|
|
return fd;
|
|
|
|
}
|
|
|
|
|
2009-12-04 09:20:48 +01:00
|
|
|
int rerere(int flags)
|
2008-07-09 14:58:57 +02:00
|
|
|
{
|
2010-07-04 21:46:19 +02:00
|
|
|
struct string_list merge_rr = STRING_LIST_INIT_DUP;
|
2008-07-09 14:58:57 +02:00
|
|
|
int fd;
|
|
|
|
|
2009-12-04 09:20:48 +01:00
|
|
|
fd = setup_rerere(&merge_rr, flags);
|
2008-07-09 14:58:57 +02:00
|
|
|
if (fd < 0)
|
|
|
|
return 0;
|
|
|
|
return do_plain_rerere(&merge_rr, fd);
|
|
|
|
}
|
2009-12-26 00:51:32 +01:00
|
|
|
|
|
|
|
static int rerere_forget_one_path(const char *path, struct string_list *rr)
|
|
|
|
{
|
|
|
|
const char *filename;
|
|
|
|
char *hex;
|
|
|
|
unsigned char sha1[20];
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = handle_cache(path, sha1, NULL);
|
|
|
|
if (ret < 1)
|
|
|
|
return error("Could not parse conflict hunks in '%s'", path);
|
|
|
|
hex = xstrdup(sha1_to_hex(sha1));
|
|
|
|
filename = rerere_path(hex, "postimage");
|
|
|
|
if (unlink(filename))
|
|
|
|
return (errno == ENOENT
|
|
|
|
? error("no remembered resolution for %s", path)
|
|
|
|
: error("cannot unlink %s: %s", filename, strerror(errno)));
|
|
|
|
|
|
|
|
handle_cache(path, sha1, rerere_path(hex, "preimage"));
|
|
|
|
fprintf(stderr, "Updated preimage for '%s'\n", path);
|
|
|
|
|
|
|
|
|
2010-06-26 01:41:35 +02:00
|
|
|
string_list_insert(rr, path)->util = hex;
|
2009-12-26 00:51:32 +01:00
|
|
|
fprintf(stderr, "Forgot resolution for %s\n", path);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-07-14 10:35:40 +02:00
|
|
|
int rerere_forget(struct pathspec *pathspec)
|
2009-12-26 00:51:32 +01:00
|
|
|
{
|
|
|
|
int i, fd;
|
2010-07-04 21:46:19 +02:00
|
|
|
struct string_list conflict = STRING_LIST_INIT_DUP;
|
|
|
|
struct string_list merge_rr = STRING_LIST_INIT_DUP;
|
2009-12-26 00:51:32 +01:00
|
|
|
|
|
|
|
if (read_cache() < 0)
|
|
|
|
return error("Could not read index");
|
|
|
|
|
2010-01-20 23:44:31 +01:00
|
|
|
fd = setup_rerere(&merge_rr, RERERE_NOAUTOUPDATE);
|
2015-05-14 21:20:52 +02:00
|
|
|
if (fd < 0)
|
|
|
|
return 0;
|
2009-12-26 00:51:32 +01:00
|
|
|
|
|
|
|
unmerge_cache(pathspec);
|
|
|
|
find_conflict(&conflict);
|
|
|
|
for (i = 0; i < conflict.nr; i++) {
|
|
|
|
struct string_list_item *it = &conflict.items[i];
|
2014-01-24 14:40:30 +01:00
|
|
|
if (!match_pathspec(pathspec, it->string,
|
2014-01-24 14:40:33 +01:00
|
|
|
strlen(it->string), 0, NULL, 0))
|
2009-12-26 00:51:32 +01:00
|
|
|
continue;
|
|
|
|
rerere_forget_one_path(it->string, &merge_rr);
|
|
|
|
}
|
|
|
|
return write_rr(&merge_rr, fd);
|
|
|
|
}
|
2011-05-08 21:55:34 +02:00
|
|
|
|
|
|
|
static time_t rerere_created_at(const char *name)
|
|
|
|
{
|
|
|
|
struct stat st;
|
|
|
|
return stat(rerere_path(name, "preimage"), &st) ? (time_t) 0 : st.st_mtime;
|
|
|
|
}
|
|
|
|
|
|
|
|
static time_t rerere_last_used_at(const char *name)
|
|
|
|
{
|
|
|
|
struct stat st;
|
|
|
|
return stat(rerere_path(name, "postimage"), &st) ? (time_t) 0 : st.st_mtime;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void unlink_rr_item(const char *name)
|
|
|
|
{
|
|
|
|
unlink(rerere_path(name, "thisimage"));
|
|
|
|
unlink(rerere_path(name, "preimage"));
|
|
|
|
unlink(rerere_path(name, "postimage"));
|
|
|
|
rmdir(git_path("rr-cache/%s", name));
|
|
|
|
}
|
|
|
|
|
|
|
|
void rerere_gc(struct string_list *rr)
|
|
|
|
{
|
|
|
|
struct string_list to_remove = STRING_LIST_INIT_DUP;
|
|
|
|
DIR *dir;
|
|
|
|
struct dirent *e;
|
|
|
|
int i, cutoff;
|
|
|
|
time_t now = time(NULL), then;
|
2014-08-07 18:21:21 +02:00
|
|
|
int cutoff_noresolve = 15;
|
|
|
|
int cutoff_resolve = 60;
|
2011-05-08 21:55:34 +02:00
|
|
|
|
rerere: release lockfile in non-writing functions
There's a bug in builtin/am.c in which we take a lock on
MERGE_RR recursively. But rather than fix am.c, this patch
fixes the confusing interface from rerere.c that caused the
bug. Read on for the gory details.
The setup_rerere() function both reads the existing MERGE_RR
file, and takes MERGE_RR.lock. In the rerere() and
rerere_forget() functions, we end up in write_rr(), which
will then commit the lock file.
But for functions like rerere_clear() that do not write to
MERGE_RR, we expect the caller to have handled
setup_rerere(). That caller would then need to release the
lockfile, but it can't; the lock struct is local to
rerere.c.
For builtin/rerere.c, this is OK. We run a single rerere
operation and then exit immediately, which has the side
effect of rolling back the lockfile.
But in builtin/am.c, this is actively wrong. If we run "git
am -3 --skip", we call setup-rerere twice without releasing
the lock:
1. The "--skip" causes us to call am_rerere_clear(), which
calls setup_rerere(), but never drops the lock.
2. We then proceed to the next patch.
3. The "--3way" may cause us to call rerere() to handle
conflicts in that patch, but we are already holding the
lock. The lockfile code dies with:
BUG: prepare_tempfile_object called for active object
We could fix this by having rerere_clear() call
rollback_lock_file(). But it feels a bit odd for it to roll
back a lockfile that it did not itself take. So let's
simplify the interface further, and handle setup_rerere in
the function itself, taking away the question from the
caller over whether they need to do so.
We can give rerere_gc() the same treatment, as well (even
though it doesn't have any callers besides builtin/rerere.c
at this point). Note that these functions don't take flags
from their callers to pass along to setup_rerere; that's OK,
because the flags would not be meaningful for what they are
doing.
Both of those functions need to hold the lock because even
though they do not write to MERGE_RR, they are still writing
and should be protected from a simultaneous "rerere" run.
But rerere_remaining(), "rerere diff", and "rerere status"
are all read-only operations. They want to setup_rerere(),
but do not care about taking the lock in the first place.
Since our update of MERGE_RR is the usual atomic rename done
by commit_lock_file, they can just do a lockless read. For
that, we teach setup_rerere a READONLY flag to avoid the
lock.
As a bonus, this pushes builtin/rerere.c's setup_rerere call
closer to the functions that use it. Which means that "git
rerere totally-bogus-command" will no longer silently
exit(0) in a repository without rerere enabled.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-09-02 00:14:09 +02:00
|
|
|
if (setup_rerere(rr, 0) < 0)
|
|
|
|
return;
|
|
|
|
|
2014-08-07 18:21:21 +02:00
|
|
|
git_config_get_int("gc.rerereresolved", &cutoff_resolve);
|
|
|
|
git_config_get_int("gc.rerereunresolved", &cutoff_noresolve);
|
|
|
|
git_config(git_default_config, NULL);
|
2011-05-08 21:55:34 +02:00
|
|
|
dir = opendir(git_path("rr-cache"));
|
|
|
|
if (!dir)
|
|
|
|
die_errno("unable to open rr-cache directory");
|
|
|
|
while ((e = readdir(dir))) {
|
|
|
|
if (is_dot_or_dotdot(e->d_name))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
then = rerere_last_used_at(e->d_name);
|
|
|
|
if (then) {
|
2014-08-07 18:21:21 +02:00
|
|
|
cutoff = cutoff_resolve;
|
2011-05-08 21:55:34 +02:00
|
|
|
} else {
|
|
|
|
then = rerere_created_at(e->d_name);
|
|
|
|
if (!then)
|
|
|
|
continue;
|
2014-08-07 18:21:21 +02:00
|
|
|
cutoff = cutoff_noresolve;
|
2011-05-08 21:55:34 +02:00
|
|
|
}
|
|
|
|
if (then < now - cutoff * 86400)
|
|
|
|
string_list_append(&to_remove, e->d_name);
|
|
|
|
}
|
2011-05-26 15:55:50 +02:00
|
|
|
closedir(dir);
|
2011-05-08 21:55:34 +02:00
|
|
|
for (i = 0; i < to_remove.nr; i++)
|
|
|
|
unlink_rr_item(to_remove.items[i].string);
|
|
|
|
string_list_clear(&to_remove, 0);
|
rerere: release lockfile in non-writing functions
There's a bug in builtin/am.c in which we take a lock on
MERGE_RR recursively. But rather than fix am.c, this patch
fixes the confusing interface from rerere.c that caused the
bug. Read on for the gory details.
The setup_rerere() function both reads the existing MERGE_RR
file, and takes MERGE_RR.lock. In the rerere() and
rerere_forget() functions, we end up in write_rr(), which
will then commit the lock file.
But for functions like rerere_clear() that do not write to
MERGE_RR, we expect the caller to have handled
setup_rerere(). That caller would then need to release the
lockfile, but it can't; the lock struct is local to
rerere.c.
For builtin/rerere.c, this is OK. We run a single rerere
operation and then exit immediately, which has the side
effect of rolling back the lockfile.
But in builtin/am.c, this is actively wrong. If we run "git
am -3 --skip", we call setup-rerere twice without releasing
the lock:
1. The "--skip" causes us to call am_rerere_clear(), which
calls setup_rerere(), but never drops the lock.
2. We then proceed to the next patch.
3. The "--3way" may cause us to call rerere() to handle
conflicts in that patch, but we are already holding the
lock. The lockfile code dies with:
BUG: prepare_tempfile_object called for active object
We could fix this by having rerere_clear() call
rollback_lock_file(). But it feels a bit odd for it to roll
back a lockfile that it did not itself take. So let's
simplify the interface further, and handle setup_rerere in
the function itself, taking away the question from the
caller over whether they need to do so.
We can give rerere_gc() the same treatment, as well (even
though it doesn't have any callers besides builtin/rerere.c
at this point). Note that these functions don't take flags
from their callers to pass along to setup_rerere; that's OK,
because the flags would not be meaningful for what they are
doing.
Both of those functions need to hold the lock because even
though they do not write to MERGE_RR, they are still writing
and should be protected from a simultaneous "rerere" run.
But rerere_remaining(), "rerere diff", and "rerere status"
are all read-only operations. They want to setup_rerere(),
but do not care about taking the lock in the first place.
Since our update of MERGE_RR is the usual atomic rename done
by commit_lock_file, they can just do a lockless read. For
that, we teach setup_rerere a READONLY flag to avoid the
lock.
As a bonus, this pushes builtin/rerere.c's setup_rerere call
closer to the functions that use it. Which means that "git
rerere totally-bogus-command" will no longer silently
exit(0) in a repository without rerere enabled.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-09-02 00:14:09 +02:00
|
|
|
rollback_lock_file(&write_lock);
|
2011-05-08 21:55:34 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void rerere_clear(struct string_list *merge_rr)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
rerere: release lockfile in non-writing functions
There's a bug in builtin/am.c in which we take a lock on
MERGE_RR recursively. But rather than fix am.c, this patch
fixes the confusing interface from rerere.c that caused the
bug. Read on for the gory details.
The setup_rerere() function both reads the existing MERGE_RR
file, and takes MERGE_RR.lock. In the rerere() and
rerere_forget() functions, we end up in write_rr(), which
will then commit the lock file.
But for functions like rerere_clear() that do not write to
MERGE_RR, we expect the caller to have handled
setup_rerere(). That caller would then need to release the
lockfile, but it can't; the lock struct is local to
rerere.c.
For builtin/rerere.c, this is OK. We run a single rerere
operation and then exit immediately, which has the side
effect of rolling back the lockfile.
But in builtin/am.c, this is actively wrong. If we run "git
am -3 --skip", we call setup-rerere twice without releasing
the lock:
1. The "--skip" causes us to call am_rerere_clear(), which
calls setup_rerere(), but never drops the lock.
2. We then proceed to the next patch.
3. The "--3way" may cause us to call rerere() to handle
conflicts in that patch, but we are already holding the
lock. The lockfile code dies with:
BUG: prepare_tempfile_object called for active object
We could fix this by having rerere_clear() call
rollback_lock_file(). But it feels a bit odd for it to roll
back a lockfile that it did not itself take. So let's
simplify the interface further, and handle setup_rerere in
the function itself, taking away the question from the
caller over whether they need to do so.
We can give rerere_gc() the same treatment, as well (even
though it doesn't have any callers besides builtin/rerere.c
at this point). Note that these functions don't take flags
from their callers to pass along to setup_rerere; that's OK,
because the flags would not be meaningful for what they are
doing.
Both of those functions need to hold the lock because even
though they do not write to MERGE_RR, they are still writing
and should be protected from a simultaneous "rerere" run.
But rerere_remaining(), "rerere diff", and "rerere status"
are all read-only operations. They want to setup_rerere(),
but do not care about taking the lock in the first place.
Since our update of MERGE_RR is the usual atomic rename done
by commit_lock_file, they can just do a lockless read. For
that, we teach setup_rerere a READONLY flag to avoid the
lock.
As a bonus, this pushes builtin/rerere.c's setup_rerere call
closer to the functions that use it. Which means that "git
rerere totally-bogus-command" will no longer silently
exit(0) in a repository without rerere enabled.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-09-02 00:14:09 +02:00
|
|
|
if (setup_rerere(merge_rr, 0) < 0)
|
|
|
|
return;
|
|
|
|
|
2011-05-08 21:55:34 +02:00
|
|
|
for (i = 0; i < merge_rr->nr; i++) {
|
|
|
|
const char *name = (const char *)merge_rr->items[i].util;
|
|
|
|
if (!has_rerere_resolution(name))
|
|
|
|
unlink_rr_item(name);
|
|
|
|
}
|
memoize common git-path "constant" files
One of the most common uses of git_path() is to pass a
constant, like git_path("MERGE_MSG"). This has two
drawbacks:
1. The return value is a static buffer, and the lifetime
is dependent on other calls to git_path, etc.
2. There's no compile-time checking of the pathname. This
is OK for a one-off (after all, we have to spell it
correctly at least once), but many of these constant
strings appear throughout the code.
This patch introduces a series of functions to "memoize"
these strings, which are essentially globals for the
lifetime of the program. We compute the value once, take
ownership of the buffer, and return the cached value for
subsequent calls. cache.h provides a helper macro for
defining these functions as one-liners, and defines a few
common ones for global use.
Using a macro is a little bit gross, but it does nicely
document the purpose of the functions. If we need to touch
them all later (e.g., because we learned how to change the
git_dir variable at runtime, and need to invalidate all of
the stored values), it will be much easier to have the
complete list.
Note that the shared-global functions have separate, manual
declarations. We could do something clever with the macros
(e.g., expand it to a declaration in some places, and a
declaration _and_ a definition in path.c). But there aren't
that many, and it's probably better to stay away from
too-magical macros.
Likewise, if we abandon the C preprocessor in favor of
generating these with a script, we could get much fancier.
E.g., normalizing "FOO/BAR-BAZ" into "git_path_foo_bar_baz".
But the small amount of saved typing is probably not worth
the resulting confusion to readers who want to grep for the
function's definition.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-08-10 11:38:57 +02:00
|
|
|
unlink_or_warn(git_path_merge_rr());
|
rerere: release lockfile in non-writing functions
There's a bug in builtin/am.c in which we take a lock on
MERGE_RR recursively. But rather than fix am.c, this patch
fixes the confusing interface from rerere.c that caused the
bug. Read on for the gory details.
The setup_rerere() function both reads the existing MERGE_RR
file, and takes MERGE_RR.lock. In the rerere() and
rerere_forget() functions, we end up in write_rr(), which
will then commit the lock file.
But for functions like rerere_clear() that do not write to
MERGE_RR, we expect the caller to have handled
setup_rerere(). That caller would then need to release the
lockfile, but it can't; the lock struct is local to
rerere.c.
For builtin/rerere.c, this is OK. We run a single rerere
operation and then exit immediately, which has the side
effect of rolling back the lockfile.
But in builtin/am.c, this is actively wrong. If we run "git
am -3 --skip", we call setup-rerere twice without releasing
the lock:
1. The "--skip" causes us to call am_rerere_clear(), which
calls setup_rerere(), but never drops the lock.
2. We then proceed to the next patch.
3. The "--3way" may cause us to call rerere() to handle
conflicts in that patch, but we are already holding the
lock. The lockfile code dies with:
BUG: prepare_tempfile_object called for active object
We could fix this by having rerere_clear() call
rollback_lock_file(). But it feels a bit odd for it to roll
back a lockfile that it did not itself take. So let's
simplify the interface further, and handle setup_rerere in
the function itself, taking away the question from the
caller over whether they need to do so.
We can give rerere_gc() the same treatment, as well (even
though it doesn't have any callers besides builtin/rerere.c
at this point). Note that these functions don't take flags
from their callers to pass along to setup_rerere; that's OK,
because the flags would not be meaningful for what they are
doing.
Both of those functions need to hold the lock because even
though they do not write to MERGE_RR, they are still writing
and should be protected from a simultaneous "rerere" run.
But rerere_remaining(), "rerere diff", and "rerere status"
are all read-only operations. They want to setup_rerere(),
but do not care about taking the lock in the first place.
Since our update of MERGE_RR is the usual atomic rename done
by commit_lock_file, they can just do a lockless read. For
that, we teach setup_rerere a READONLY flag to avoid the
lock.
As a bonus, this pushes builtin/rerere.c's setup_rerere call
closer to the functions that use it. Which means that "git
rerere totally-bogus-command" will no longer silently
exit(0) in a repository without rerere enabled.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2015-09-02 00:14:09 +02:00
|
|
|
rollback_lock_file(&write_lock);
|
2011-05-08 21:55:34 +02:00
|
|
|
}
|