undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

promisor-remote: remove a return value

Browse Source 
No caller of promisor_remote_get_direct() is checking its return value,
so remove it.

Not checking the return value means that the user would not know
whether the failure of reading an object is due to the promisor remote
not supplying the object or because of local repository corruption, but
this will be fixed in a subsequent patch.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jonathan Tan 2022-10-04 14:13:40 -07:00 committed by Junio C Hamano
parent a0feb8611d
commit 00057bf14c
2 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
promisor-remote.c
View File

@ -230,18 +230,17 @@ static int remove_fetched_oids(struct repository *repo,
return remaining_nr;
}
int promisor_remote_get_direct(struct repository *repo,
const struct object_id *oids,
int oid_nr)
void promisor_remote_get_direct(struct repository *repo,
const struct object_id *oids,
int oid_nr)
{
struct promisor_remote *r;
struct object_id *remaining_oids = (struct object_id *)oids;
int remaining_nr = oid_nr;
int to_free = 0;
int res = -1;
if (oid_nr == 0)
return 0;
return;
promisor_remote_init(repo);
@ -256,12 +255,9 @@ int promisor_remote_get_direct(struct repository *repo,
continue;
}
}
res = 0;
break;
}
if (to_free)
free(remaining_oids);
return res;
}

11
promisor-remote.h
View File

@ -39,13 +39,12 @@ static inline int has_promisor_remote(void)
/*
* Fetches all requested objects from all promisor remotes, trying them one at
* a time until all objects are fetched. Returns 0 upon success, and non-zero
* otherwise.
* a time until all objects are fetched.
*
* If oid_nr is 0, this function returns 0 (success) immediately.
* If oid_nr is 0, this function returns immediately.
*/
int promisor_remote_get_direct(struct repository *repo,
const struct object_id *oids,
int oid_nr);
void promisor_remote_get_direct(struct repository *repo,
const struct object_id *oids,
int oid_nr);
#endif /* PROMISOR_REMOTE_H */