undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix potentially dangerous uses of mkpath and git_path

Browse Source 
Replace them with mksnpath/git_snpath and a local buffer
for the resulting string.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Alex Riesen 2008-10-26 23:08:52 +01:00 committed by Junio C Hamano
parent 356af64d84
commit 058412d097
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin-for-each-ref.c
View File

@ -620,14 +620,16 @@ static char *get_short_ref(struct refinfo *ref)
for (j = 0; j < i; j++) { for (j = 0; j < i; j++) {
const char *rule = ref_rev_parse_rules[j]; const char *rule = ref_rev_parse_rules[j];
unsigned char short_objectname[20]; unsigned char short_objectname[20];
char refname[PATH_MAX];
/* /*
* the short name is ambiguous, if it resolves * the short name is ambiguous, if it resolves
* (with this previous rule) to a valid ref * (with this previous rule) to a valid ref
* read_ref() returns 0 on success * read_ref() returns 0 on success
*/ */
if (!read_ref(mkpath(rule, short_name_len, short_name), mksnpath(refname, sizeof(refname),
short_objectname)) rule, short_name_len, short_name);
if (!read_ref(refname, short_objectname))
break; break;
} }