undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'wd/rebase-conflict-guide'

Browse Source 
The advice message given when "git rebase" stops for conflicting
changes has been improved.

* wd/rebase-conflict-guide:
  rebase: make resolve message clearer for inexperienced users
This commit is contained in:
Junio C Hamano 2017-08-11 13:26:58 -07:00
commit 076eeec8be
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
git-rebase.sh
View File

@ -55,9 +55,10 @@ LF='
' '
ok_to_skip_pre_rebase= ok_to_skip_pre_rebase=
resolvemsg=" resolvemsg="
$(gettext 'When you have resolved this problem, run "git rebase --continue". $(gettext 'Resolve all conflicts manually, mark them as resolved with
If you prefer to skip this patch, run "git rebase --skip" instead. "git add/rm <conflicted_files>", then run "git rebase --continue".
To check out the original branch and stop rebasing, run "git rebase --abort".') You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".')
" "
unset onto unset onto
unset restrict_revision unset restrict_revision

4
t/t5520-pull.sh
View File

@ -305,7 +305,7 @@ test_expect_success '--rebase with conflicts shows advice' '
test_tick && test_tick &&
git commit -m "Create conflict" seq.txt && git commit -m "Create conflict" seq.txt &&
test_must_fail git pull --rebase . seq 2>err >out && test_must_fail git pull --rebase . seq 2>err >out &&
test_i18ngrep "When you have resolved this problem" out test_i18ngrep "Resolve all conflicts manually" out
' '
test_expect_success 'failed --rebase shows advice' ' test_expect_success 'failed --rebase shows advice' '
@ -319,7 +319,7 @@ test_expect_success 'failed --rebase shows advice' '
git checkout -f -b fails-to-rebase HEAD^ && git checkout -f -b fails-to-rebase HEAD^ &&
test_commit v2-without-cr file "2" file2-lf && test_commit v2-without-cr file "2" file2-lf &&
test_must_fail git pull --rebase . diverging 2>err >out && test_must_fail git pull --rebase . diverging 2>err >out &&
test_i18ngrep "When you have resolved this problem" out test_i18ngrep "Resolve all conflicts manually" out
' '
test_expect_success '--rebase fails with multiple branches' ' test_expect_success '--rebase fails with multiple branches' '