undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

copy_fd: close ifd on error

Browse Source 
In copy_fd when write fails we ought to close input file descriptor.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Sam Ravnborg 2005-12-27 09:19:05 +01:00 committed by Junio C Hamano
parent 975b31dc6e
commit 08337a97a2
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
copy.c
View File

@ -22,11 +22,14 @@ int copy_fd(int ifd, int ofd)
buf += written; buf += written;
len -= written; len -= written;
} }
else if (!written) else if (!written) {
close(ifd);
return error("copy-fd: write returned 0"); return error("copy-fd: write returned 0");
else } else {
close(ifd);
return error("copy-fd: write returned %s", return error("copy-fd: write returned %s",
strerror(errno)); strerror(errno));
}
} }
} }
close(ifd); close(ifd);