undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

config: add test cases for empty value and no value config variables.

Browse Source 
The tests in 't1300-repo-config.sh' did not check what happens when
an empty value like the following is used in the config file:

[emptyvalue]
	variable =

Also it was not checked that a variable with no value like the
following:

[novalue]
	variable

gives a boolean "true" value, while an ampty value gives a boolean
"false" value.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Christian Couder 2008-02-07 06:23:46 +01:00 committed by Junio C Hamano
parent e75201963f
commit 09bc098c2d
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
t/t1300-repo-config.sh
View File

@ -283,17 +283,40 @@ test_expect_success '--add' \
cat > .git/config << EOF cat > .git/config << EOF
[novalue] [novalue]
variable variable
[emptyvalue]
variable =
EOF EOF
test_expect_success 'get variable with no value' \ test_expect_success 'get variable with no value' \
'git config --get novalue.variable ^$' 'git config --get novalue.variable ^$'
test_expect_success 'get variable with empty value' \
'git config --get emptyvalue.variable ^$'
echo novalue.variable > expect echo novalue.variable > expect
test_expect_success 'get-regexp variable with no value' \ test_expect_success 'get-regexp variable with no value' \
'git config --get-regexp novalue > output && 'git config --get-regexp novalue > output &&
cmp output expect' cmp output expect'
echo 'emptyvalue.variable ' > expect
test_expect_success 'get-regexp variable with empty value' \
'git config --get-regexp emptyvalue > output &&
cmp output expect'
echo true > expect
test_expect_success 'get bool variable with no value' \
'git config --bool novalue.variable > output &&
cmp output expect'
echo false > expect
test_expect_success 'get bool variable with empty value' \
'git config --bool emptyvalue.variable > output &&
cmp output expect'
git config > output 2>&1 git config > output 2>&1
test_expect_success 'no arguments, but no crash' \ test_expect_success 'no arguments, but no crash' \