undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t7502: factor out autoident prerequisite

Browse Source 
t7502 checks the behavior of commit when we can and cannot
determine a valid committer ident. Let's move that into
test-lib as a lazy prerequisite so other scripts can use it.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2012-11-14 16:33:40 -08:00 committed by Junio C Hamano
parent bdccd3c1fb
commit 09feffb633
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
t/t7502-commit.sh
View File

@ -243,16 +243,6 @@ test_expect_success 'message shows author when it is not equal to committer' '
.git/COMMIT_EDITMSG .git/COMMIT_EDITMSG
' '
test_expect_success 'setup auto-ident prerequisite' '
if (sane_unset GIT_COMMITTER_EMAIL &&
sane_unset GIT_COMMITTER_NAME &&
git var GIT_COMMITTER_IDENT); then
test_set_prereq AUTOIDENT
else
test_set_prereq NOAUTOIDENT
fi
'
test_expect_success AUTOIDENT 'message shows committer when it is automatic' ' test_expect_success AUTOIDENT 'message shows committer when it is automatic' '
echo >>negative && echo >>negative &&
@ -271,7 +261,7 @@ echo editor started > "$(pwd)/.git/result"
exit 0 exit 0
EOF EOF
test_expect_success NOAUTOIDENT 'do not fire editor when committer is bogus' ' test_expect_success !AUTOIDENT 'do not fire editor when committer is bogus' '
>.git/result >.git/result
>expect && >expect &&

6
t/test-lib.sh
View File

@ -738,6 +738,12 @@ test_lazy_prereq UTF8_NFD_TO_NFC '
esac esac
' '
test_lazy_prereq AUTOIDENT '
sane_unset GIT_AUTHOR_NAME &&
sane_unset GIT_AUTHOR_EMAIL &&
git var GIT_AUTHOR_IDENT
'
# When the tests are run as root, permission tests will report that # When the tests are run as root, permission tests will report that
# things are writable when they shouldn't be. # things are writable when they shouldn't be.
test -w / || test_set_prereq SANITY test -w / || test_set_prereq SANITY