t2200, t7004: Avoid glob pattern that also matches files

On Windows, there is an unfortunate interaction between the MSYS bash and
git's command line processing:

- Since Windows's CMD does not do the wildcard expansion, but passes
  arguments like path* through to the programs, the programs must do the
  expansion themselves. This happens in the startup code before main() is
  entered.

- bash, however, passes the argument "path*" to git, assuming that git will
  see the unquoted word unchanged as a single argument.

But actually git expands the unquoted word before main() is entered.

In t2200, not all names that the test case is interested in exist as files
at the time when 'git ls-files' is invoked. git expands "path?" to only
the subset of files the exist, and only that subset was listed, so that the
test failed.  We now list all interesting paths explicitly.

In t7004, git exanded the pattern "*a*" to "actual" (the file that stdout
was redirected to), which is not what the was tested for. We fix it by
renaming the output file (and removing any existing files matching *a*).
This was originally fixed by Johannes Schindelin.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
This commit is contained in:
Johannes Sixt 2009-02-09 10:24:51 +01:00
parent e2c2407683
commit 0aaaef7b0f
2 changed files with 4 additions and 3 deletions

View File

@ -150,7 +150,7 @@ test_expect_success 'add -u resolves unmerged paths' '
echo 2 >path3 && echo 2 >path3 &&
echo 2 >path5 && echo 2 >path5 &&
git add -u && git add -u &&
git ls-files -s "path?" >actual && git ls-files -s path1 path2 path3 path4 path5 path6 >actual &&
{ {
echo "100644 $three 0 path1" echo "100644 $three 0 path1"
echo "100644 $one 1 path3" echo "100644 $one 1 path3"

View File

@ -185,8 +185,9 @@ cba
EOF EOF
test_expect_success \ test_expect_success \
'listing tags with substring as pattern must print those matching' ' 'listing tags with substring as pattern must print those matching' '
git tag -l "*a*" > actual && rm *a* &&
test_cmp expect actual git tag -l "*a*" > current &&
test_cmp expect current
' '
cat >expect <<EOF cat >expect <<EOF