undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

commit: reword --author error message

Browse Source 
If an --author argument is specified but does not contain a '>' then git tries
to find the argument within the existing authors; and gives the error
message "No existing author found with '%s'" if there is no match.

This is confusing for users who try to specify a valid complete author
name.

Rename the error message to make it clearer that the failure has two
reasons in this case.

(This codepath is touched only when we know already that the argument
cannot be a completely wellformed author ident.)

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael J Gruber 2015-01-26 16:48:33 +01:00 committed by Junio C Hamano
parent 282616c72d
commit 1044b1f6a1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/commit.c
View File

@ -999,7 +999,7 @@ static const char *find_author_by_nickname(const char *name)
clear_mailmap(&mailmap); clear_mailmap(&mailmap);
return strbuf_detach(&buf, NULL); return strbuf_detach(&buf, NULL);
} }
die(_("No existing author found with '%s'"), name); die(_("--author '%s' is not 'Name <email>' and matches no existing author"), name);
} }