undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

alias.c: replace git_config() with git_config_get_string()

Browse Source 
Use `git_config_get_string()` instead of `git_config()` to take advantage of
the config-set API which provides a cleaner control flow.

Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Tanay Abhra 2014-08-07 09:21:25 -07:00 committed by Junio C Hamano
parent ef7e1d0cda
commit 111791559e
1 changed files with 6 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
alias.c
View File

@ -1,26 +1,13 @@
#include "cache.h" #include "cache.h"
static const char *alias_key;
static char *alias_val;
static int alias_lookup_cb(const char *k, const char *v, void *cb)
{
const char *name;
if (skip_prefix(k, "alias.", &name) && !strcmp(name, alias_key)) {
if (!v)
return config_error_nonbool(k);
alias_val = xstrdup(v);
return 0;
}
return 0;
}
char *alias_lookup(const char *alias) char *alias_lookup(const char *alias)
{ {
alias_key = alias; char *v = NULL;
alias_val = NULL; struct strbuf key = STRBUF_INIT;
git_config(alias_lookup_cb, NULL); strbuf_addf(&key, "alias.%s", alias);
return alias_val; git_config_get_string(key.buf, &v);
strbuf_release(&key);
return v;
} }
#define SPLIT_CMDLINE_BAD_ENDING 1 #define SPLIT_CMDLINE_BAD_ENDING 1