undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: Use underscore instead of hyphen to separate words in HTTP headers names

Browse Source 
Use underscore (which will be turned into hyphen) to separate words in
HTTP header names, in keys to CGI header() method, consistently.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Jakub Narebski 2006-08-22 16:55:34 +02:00 committed by Junio C Hamano
parent 952c65fc02
commit 134a6941ec
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gitweb/gitweb.perl
View File

@ -2198,7 +2198,8 @@ sub git_blob_plain {
$save_as .= '.txt';
}
print $cgi->header(-type => "$type", '-content-disposition' => "inline; filename=\"$save_as\"");
print $cgi->header(-type => "$type",
-content_disposition => "inline; filename=\"$save_as\"");
undef $/;
binmode STDOUT, ':raw';
print <$fd>;
@ -2382,8 +2383,8 @@ sub git_snapshot {
my $filename = basename($project) . "-$hash.tar.$suffix";
print $cgi->header(-type => 'application/x-tar',
-content-encoding => $ctype,
'-content-disposition' => "inline; filename=\"$filename\"",
-content_encoding => $ctype,
-content_disposition => "inline; filename=\"$filename\"",
-status => '200 OK');
open my $fd, "-|", "$GIT tar-tree $hash \'$project\' | $command" or
@ -2701,7 +2702,7 @@ sub git_commitdiff_plain {
print $cgi->header(-type => "text/plain",
-charset => 'utf-8',
'-content-disposition' => "inline; filename=\"git-$hash.patch\"");
-content_disposition => "inline; filename=\"git-$hash.patch\"");
my %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});
my $comment = $co{'comment'};
print "From: $co{'author'}\n" .