undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t/t3210-pack-refs.sh: use the $( ... ) construct for command substitution

Browse Source 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2015-12-22 16:27:45 +01:00 committed by Junio C Hamano
parent 8db3294142
commit 13f11b9585
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/t3210-pack-refs.sh
View File

@ -27,7 +27,7 @@ SHA1=
test_expect_success \ test_expect_success \
'see if git show-ref works as expected' \ 'see if git show-ref works as expected' \
'git branch a && 'git branch a &&
SHA1=`cat .git/refs/heads/a` && SHA1=$(cat .git/refs/heads/a) &&
echo "$SHA1 refs/heads/a" >expect && echo "$SHA1 refs/heads/a" >expect &&
git show-ref a >result && git show-ref a >result &&
test_cmp expect result' test_cmp expect result'