undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

win32: plug memory leak on realloc() failure in syslog()

Browse Source 
If realloc() fails then the original buffer is still valid.  Free it
before exiting the function.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2017-08-10 12:23:45 +02:00 committed by Junio C Hamano
parent 7234152e66
commit 149d8cbb2e
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compat/win32/syslog.c
View File

@ -43,8 +43,10 @@ void syslog(int priority, const char *fmt, ...)
va_end(ap); va_end(ap);
while ((pos = strstr(str, "%1")) != NULL) { while ((pos = strstr(str, "%1")) != NULL) {
char *oldstr = str;
str = realloc(str, st_add(++str_len, 1)); str = realloc(str, st_add(++str_len, 1));
if (!str) { if (!str) {
free(oldstr);
warning_errno("realloc failed"); warning_errno("realloc failed");
return; return;
} }