undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use column indexes in git-cvsserver where necessary.

Browse Source 
Tonight I found a git-cvsserver instance spending a lot of time in
disk IO while trying to process operations against a Git repository
with >30,000 objects contained in it.

Blowing away my SQLLite database and rebuilding all tables with
indexes on the attributes that git-cvsserver frequently runs queries
against seems to have resolved the issue quite nicely.

Since the indexes shouldn't hurt performance on small repositories
and always helps on larger repositories we should just always create
them when creating the revision storage tables.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Shawn Pearce 2006-10-23 01:09:35 -04:00 committed by Junio C Hamano
parent b6b7fc7283
commit 178e015c05
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
git-cvsserver.perl
View File

@ -2118,9 +2118,17 @@ sub new
mode TEXT NOT NULL mode TEXT NOT NULL
) )
"); ");
$self->{dbh}->do("
CREATE INDEX revision_ix1
ON revision (name,revision)
");
$self->{dbh}->do("
CREATE INDEX revision_ix2
ON revision (name,commithash)
");
} }
# Construct the revision table if required # Construct the head table if required
unless ( $self->{tables}{head} ) unless ( $self->{tables}{head} )
{ {
$self->{dbh}->do(" $self->{dbh}->do("
@ -2134,6 +2142,10 @@ sub new
mode TEXT NOT NULL mode TEXT NOT NULL
) )
"); ");
$self->{dbh}->do("
CREATE INDEX head_ix1
ON head (name)
");
} }
# Construct the properties table if required # Construct the properties table if required