undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cvsserver: Remove trailing "\n" from commithash in checkin function

Browse Source 
The commithash for updating the ref is obtained from a call to
git-commit-tree.  However, it was returned (and stored) with the
trailing newline.  This meant that the later call to git-update-ref that
was trying to update to $commithash was including the newline in the
parameter - obviously that hash would never exist, and so git-update-ref
would always fail.

The solution is to chomp() the commithash as soon as it is returned by
git-commit-tree.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Andy Parkins 2007-02-27 12:49:09 +00:00 committed by Junio C Hamano
parent ada5ef3b48
commit 1872adabcc
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
git-cvsserver.perl
View File

@ -1152,6 +1152,7 @@ sub req_ci
close $msg_fh; close $msg_fh;
my $commithash = `git-commit-tree $treehash -p $parenthash < $msg_filename`; my $commithash = `git-commit-tree $treehash -p $parenthash < $msg_filename`;
chomp($commithash);
$log->info("Commit hash : $commithash"); $log->info("Commit hash : $commithash");
unless ( $commithash =~ /[a-zA-Z0-9]{40}/ ) unless ( $commithash =~ /[a-zA-Z0-9]{40}/ )