undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mingw: avoid memory leak when splitting PATH

Browse Source 
In the (admittedly, concocted) case that PATH consists only of path
delimiters, we would leak the duplicated string.

Reported by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2017-05-04 15:55:24 +02:00 committed by Junio C Hamano
parent d2bbb7c2bc
commit 1a845a2c88
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compat/mingw.c
View File

@ -961,8 +961,10 @@ static char **get_path_split(void)
++n; ++n;
} }
} }
if (!n) if (!n) {
free(envpath);
return NULL; return NULL;
}
ALLOC_ARRAY(path, n + 1); ALLOC_ARRAY(path, n + 1);
p = envpath; p = envpath;