undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-send-email: abort/usage on bad option

Browse Source 
Instead of proceeding, abort and give usage message when a bad option
is seen.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Michael Coleman 2007-02-27 22:47:54 -06:00 committed by Junio C Hamano
parent 437b1b20df
commit 1b0baf1401
1 changed files with 53 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

97
git-send-email.perl
View File

@ -34,6 +34,53 @@ sub readline {
} }
package main; package main;
sub usage {
print <<EOT;
git-send-email [options] <file | directory>...
Options:
--from Specify the "From:" line of the email to be sent.
--to Specify the primary "To:" line of the email.
--cc Specify an initial "Cc:" list for the entire series
of emails.
--bcc Specify a list of email addresses that should be Bcc:
on all the emails.
--compose Use \$EDITOR to edit an introductory message for the
patch series.
--subject Specify the initial "Subject:" line.
Only necessary if --compose is also set. If --compose
is not set, this will be prompted for.
--in-reply-to Specify the first "In-Reply-To:" header line.
Only used if --compose is also set. If --compose is not
set, this will be prompted for.
--chain-reply-to If set, the replies will all be to the previous
email sent, rather than to the first email sent.
Defaults to on.
--no-signed-off-cc Suppress the automatic addition of email addresses
that appear in a Signed-off-by: line, to the cc: list.
Note: Using this option is not recommended.
--smtp-server If set, specifies the outgoing SMTP server to use.
Defaults to localhost.
--suppress-from Suppress sending emails to yourself if your address
appears in a From: line.
--quiet Make git-send-email less verbose. One line per email
should be all that is output.
EOT
exit(1);
}
# most mail servers generate the Date: header, but not all... # most mail servers generate the Date: header, but not all...
sub format_2822_time { sub format_2822_time {
my ($time) = @_; my ($time) = @_;
@ -120,6 +167,10 @@ my $rc = GetOptions("from=s" => \$from,
"dry-run" => \$dry_run, "dry-run" => \$dry_run,
); );
unless ($rc) {
usage();
}
# Verify the user input # Verify the user input
foreach my $entry (@to) { foreach my $entry (@to) {
@ -311,50 +362,8 @@ if (@files) {
print $_,"\n" for (@files); print $_,"\n" for (@files);
} }
} else { } else {
print <<EOT; print STDERR "\nNo patch files specified!\n\n";
git-send-email [options] <file | directory> [... file | directory ] usage();
Options:
--from Specify the "From:" line of the email to be sent.
--to Specify the primary "To:" line of the email.
--cc Specify an initial "Cc:" list for the entire series
of emails.
--bcc Specify a list of email addresses that should be Bcc:
on all the emails.
--compose Use \$EDITOR to edit an introductory message for the
patch series.
--subject Specify the initial "Subject:" line.
Only necessary if --compose is also set. If --compose
is not set, this will be prompted for.
--in-reply-to Specify the first "In-Reply-To:" header line.
Only used if --compose is also set. If --compose is not
set, this will be prompted for.
--chain-reply-to If set, the replies will all be to the previous
email sent, rather than to the first email sent.
Defaults to on.
--no-signed-off-cc Suppress the automatic addition of email addresses
that appear in a Signed-off-by: line, to the cc: list.
Note: Using this option is not recommended.
--smtp-server If set, specifies the outgoing SMTP server to use.
Defaults to localhost.
--suppress-from Suppress sending emails to yourself if your address
appears in a From: line.
--quiet Make git-send-email less verbose. One line per email should be
all that is output.
Error: Please specify a file or a directory on the command line.
EOT
exit(1);
} }
# Variables we set as part of the loop over files # Variables we set as part of the loop over files