undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

am: ignore return value of write_file()

Browse Source 
write_file() either returns 0 or dies, so there is no point in checking
its return value.  The callers of the wrappers write_state_text(),
write_state_count() and write_state_bool() consequently already ignore
their return values.  Stop pretending we care and make them void.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2016-07-08 05:08:05 -04:00 committed by Junio C Hamano
parent aabbd3f3c9
commit 1dad879a7b
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
builtin/am.c
View File

@ -183,22 +183,22 @@ static inline const char *am_path(const struct am_state *state, const char *path
/** /**
* For convenience to call write_file() * For convenience to call write_file()
*/ */
static int write_state_text(const struct am_state *state, static void write_state_text(const struct am_state *state,
const char *name, const char *string) const char *name, const char *string)
{ {
return write_file(am_path(state, name), "%s", string); write_file(am_path(state, name), "%s", string);
} }
static int write_state_count(const struct am_state *state, static void write_state_count(const struct am_state *state,
const char *name, int value)
{
write_file(am_path(state, name), "%d", value);
}
static void write_state_bool(const struct am_state *state,
const char *name, int value) const char *name, int value)
{ {
return write_file(am_path(state, name), "%d", value); write_state_text(state, name, value ? "t" : "f");
}
static int write_state_bool(const struct am_state *state,
const char *name, int value)
{
return write_state_text(state, name, value ? "t" : "f");
} }
/** /**