undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

builtin/add: add detail to a 'cannot chmod' error message

Browse Source 
In addition to adding the missing newline, add the x-ecutable bit
'mode change' character to the error message. This message now has
the same form as similar messages output by 'update-index'.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ramsay Jones 2017-08-09 01:51:23 +01:00 committed by Junio C Hamano
parent 610d55af0f
commit 1e22a9917b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/add.c
View File

@ -30,7 +30,7 @@ struct update_callback_data {
int add_errors;
};
static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
static void chmod_pathspec(struct pathspec *pathspec, char flip)
{
int i;
@ -40,8 +40,8 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
if (pathspec && !ce_path_match(ce, pathspec, NULL))
continue;
if (chmod_cache_entry(ce, force_mode) < 0)
fprintf(stderr, "cannot chmod '%s'", ce->name);
if (chmod_cache_entry(ce, flip) < 0)
fprintf(stderr, "cannot chmod %cx '%s'\n", flip, ce->name);
}
}