undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

http: mark unused parameter in fill_active_slot() callbacks

Browse Source 
We have a generic "fill" function that is used by both the dumb http
push and fetch code paths. It takes a void parameter in case the caller
wants to pass along extra data, but (since the previous commit) neither
does so.

So we could simply drop the extra parameter. But since it's good
practice to provide a void pointer for in callback functions, we'll
leave it here for the future, and just annotate it as unused (to appease
-Wunused-parameter).

While we're marking it, let's also fix the type in http-walker's
function to have the correct "void" type. The original had to cast the
function pointer and was technically undefined behavior (though
generally OK in practice).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2023-03-17 15:17:08 -04:00 committed by Junio C Hamano
parent 647edf79d6
commit 1e5e097496
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
http-push.c
View File

@ -602,7 +602,7 @@ static void finish_request(struct transfer_request *request)
}
static int is_running_queue;
static int fill_active_slot(void *unused)
static int fill_active_slot(void *data UNUSED)
{
struct transfer_request *request;

4
http-walker.c
View File

@ -127,7 +127,7 @@ static void release_object_request(struct object_request *obj_req)
free(obj_req);
}
static int fill_active_slot(struct walker *walker)
static int fill_active_slot(void *data UNUSED)
{
struct object_request *obj_req;
struct list_head *pos, *tmp, *head = &object_queue_head;
@ -613,7 +613,7 @@ struct walker *get_http_walker(const char *url)
walker->cleanup = cleanup;
walker->data = data;
add_fill_function(walker, (int (*)(void *)) fill_active_slot);
add_fill_function(NULL, fill_active_slot);
return walker;
}