undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Build-in "git-shell""

Browse Source 
This reverts commit daa0cc9a92.
It was a stupid idea to do this; when run as a log-in shell,
it is spawned with argv[0] set to "-git-shell", so the usual
name-based dispatch would not work to begin with.
This commit is contained in:
Junio C Hamano 2008-08-25 22:39:17 -07:00
parent daa0cc9a92
commit 1e7abc593d
4 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -546,7 +546,6 @@ BUILTIN_OBJS += builtin-rev-parse.o
BUILTIN_OBJS += builtin-revert.o BUILTIN_OBJS += builtin-revert.o
BUILTIN_OBJS += builtin-rm.o BUILTIN_OBJS += builtin-rm.o
BUILTIN_OBJS += builtin-send-pack.o BUILTIN_OBJS += builtin-send-pack.o
BUILTIN_OBJS += builtin-shell.o
BUILTIN_OBJS += builtin-shortlog.o BUILTIN_OBJS += builtin-shortlog.o
BUILTIN_OBJS += builtin-show-branch.o BUILTIN_OBJS += builtin-show-branch.o
BUILTIN_OBJS += builtin-show-ref.o BUILTIN_OBJS += builtin-show-ref.o
@ -822,6 +821,7 @@ EXTLIBS += -lz
ifndef NO_POSIX_ONLY_PROGRAMS ifndef NO_POSIX_ONLY_PROGRAMS
PROGRAMS += git-daemon$X PROGRAMS += git-daemon$X
PROGRAMS += git-imap-send$X PROGRAMS += git-imap-send$X
PROGRAMS += git-shell$X
endif endif
ifndef NO_OPENSSL ifndef NO_OPENSSL
OPENSSL_LIBSSL = -lssl OPENSSL_LIBSSL = -lssl

1
builtin.h
View File

@ -88,7 +88,6 @@ extern int cmd_rev_parse(int argc, const char **argv, const char *prefix);
extern int cmd_revert(int argc, const char **argv, const char *prefix); extern int cmd_revert(int argc, const char **argv, const char *prefix);
extern int cmd_rm(int argc, const char **argv, const char *prefix); extern int cmd_rm(int argc, const char **argv, const char *prefix);
extern int cmd_send_pack(int argc, const char **argv, const char *prefix); extern int cmd_send_pack(int argc, const char **argv, const char *prefix);
extern int cmd_shell(int argc, const char **argv, const char *prefix);
extern int cmd_shortlog(int argc, const char **argv, const char *prefix); extern int cmd_shortlog(int argc, const char **argv, const char *prefix);
extern int cmd_show(int argc, const char **argv, const char *prefix); extern int cmd_show(int argc, const char **argv, const char *prefix);
extern int cmd_show_branch(int argc, const char **argv, const char *prefix); extern int cmd_show_branch(int argc, const char **argv, const char *prefix);

1
git.c
View File

@ -338,7 +338,6 @@ static void handle_internal_command(int argc, const char **argv)
{ "revert", cmd_revert, RUN_SETUP | NEED_WORK_TREE }, { "revert", cmd_revert, RUN_SETUP | NEED_WORK_TREE },
{ "rm", cmd_rm, RUN_SETUP }, { "rm", cmd_rm, RUN_SETUP },
{ "send-pack", cmd_send_pack, RUN_SETUP }, { "send-pack", cmd_send_pack, RUN_SETUP },
{ "shell", cmd_shell },
{ "shortlog", cmd_shortlog, USE_PAGER }, { "shortlog", cmd_shortlog, USE_PAGER },
{ "show-branch", cmd_show_branch, RUN_SETUP }, { "show-branch", cmd_show_branch, RUN_SETUP },
{ "show", cmd_show, RUN_SETUP | USE_PAGER }, { "show", cmd_show, RUN_SETUP | USE_PAGER },

5
builtin-shell.c → shell.c
View File

@ -2,7 +2,6 @@
#include "quote.h" #include "quote.h"
#include "exec_cmd.h" #include "exec_cmd.h"
#include "strbuf.h" #include "strbuf.h"
#include "builtin.h"
static int do_generic_cmd(const char *me, char *arg) static int do_generic_cmd(const char *me, char *arg)
{ {
@ -45,7 +44,7 @@ static struct commands {
{ NULL }, { NULL },
}; };
int cmd_shell(int argc, const char **argv, const char *prefix) int main(int argc, char **argv)
{ {
char *prog; char *prog;
struct commands *cmd; struct commands *cmd;
@ -63,7 +62,7 @@ int cmd_shell(int argc, const char **argv, const char *prefix)
else if (argc != 3 || strcmp(argv[1], "-c")) else if (argc != 3 || strcmp(argv[1], "-c"))
die("What do you think I am? A shell?"); die("What do you think I am? A shell?");
prog = xstrdup(argv[2]); prog = argv[2];
if (!strncmp(prog, "git", 3) && isspace(prog[3])) if (!strncmp(prog, "git", 3) && isspace(prog[3]))
/* Accept "git foo" as if the caller said "git-foo". */ /* Accept "git foo" as if the caller said "git-foo". */
prog[3] = '-'; prog[3] = '-';