undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

imap-send.c: remove some unused fields from struct store

Browse Source 
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2013-01-15 09:06:24 +01:00 committed by Junio C Hamano
parent e6de375139
commit 1efee7ffce
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
imap-send.c
View File

@ -36,12 +36,7 @@ typedef void *SSL;
struct store { struct store {
/* currently open mailbox */ /* currently open mailbox */
const char *name; /* foreign! maybe preset? */ const char *name; /* foreign! maybe preset? */
char *path; /* own */
int uidvalidity; int uidvalidity;
unsigned char opts; /* maybe preset? */
/* note that the following do _not_ reflect stats from msgs, but mailbox totals */
int count; /* # of messages */
int recent; /* # of recent messages - don't trust this beyond the initial read */
}; };
static const char imap_send_usage[] = "git imap-send < <mbox>"; static const char imap_send_usage[] = "git imap-send < <mbox>";
@ -772,13 +767,20 @@ static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd)
!strcmp("NO", arg) || !strcmp("BYE", arg)) { !strcmp("NO", arg) || !strcmp("BYE", arg)) {
if ((resp = parse_response_code(ctx, NULL, cmd)) != RESP_OK) if ((resp = parse_response_code(ctx, NULL, cmd)) != RESP_OK)
return resp; return resp;
} else if (!strcmp("CAPABILITY", arg)) } else if (!strcmp("CAPABILITY", arg)) {
parse_capability(imap, cmd); parse_capability(imap, cmd);
else if ((arg1 = next_arg(&cmd))) { } else if ((arg1 = next_arg(&cmd))) {
if (!strcmp("EXISTS", arg1)) ; /*
ctx->gen.count = atoi(arg); * Unhandled response-data with at least two words.
else if (!strcmp("RECENT", arg1)) * Ignore it.
ctx->gen.recent = atoi(arg); *
* NEEDSWORK: Previously this case handled '<num> EXISTS'
* and '<num> RECENT' but as a probably-unintended side
* effect it ignores other unrecognized two-word
* responses. imap-send doesn't ever try to read
* messages or mailboxes these days, so consider
* eliminating this case.
*/
} else { } else {
fprintf(stderr, "IMAP error: unable to parse untagged response\n"); fprintf(stderr, "IMAP error: unable to parse untagged response\n");
return RESP_BAD; return RESP_BAD;
@ -1254,7 +1256,6 @@ static int imap_store_msg(struct store *gctx, struct strbuf *msg)
imap->caps = imap->rcaps; imap->caps = imap->rcaps;
if (ret != DRV_OK) if (ret != DRV_OK)
return ret; return ret;
gctx->count++;
return DRV_OK; return DRV_OK;
} }