undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-cvsserver: fix error for invalid password formats

Browse Source 
Change the error message to report the erroneous password
character. $1 was never set in the previos version, it was a leftover
from older code that used a regex for the test.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2010-06-19 16:06:58 +00:00 committed by Junio C Hamano
parent fce338a543
commit 1f0eb51391
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
git-cvsserver.perl
View File

@ -2658,7 +2658,10 @@ sub descramble
# This should never happen, the same password format (A) has been # This should never happen, the same password format (A) has been
# used by CVS since the beginning of time # used by CVS since the beginning of time
die "invalid password format $1" unless substr($str, 0, 1) eq 'A'; {
my $fmt = substr($str, 0, 1);
die "invalid password format `$fmt'" unless $fmt eq 'A';
}
my @str = unpack "C*", substr($str, 1); my @str = unpack "C*", substr($str, 1);
my $ret = join '', map { chr $SHIFTS[$_] } @str; my $ret = join '', map { chr $SHIFTS[$_] } @str;