undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

describe: make own copy of refname

Browse Source 
Do not retain a reference to the refname passed to the each_ref_fn
callback get_name(), because there is no guarantee of the lifetimes of
these names.  Instead, make a local copy when needed.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2013-05-25 11:08:00 +02:00 committed by Junio C Hamano
parent 5e49f30c85
commit 219a0f33ca
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/describe.c
View File

@ -42,7 +42,7 @@ struct commit_name {
unsigned prio:2; /* annotated tag = 2, tag = 1, head = 0 */ unsigned prio:2; /* annotated tag = 2, tag = 1, head = 0 */
unsigned name_checked:1; unsigned name_checked:1;
unsigned char sha1[20]; unsigned char sha1[20];
const char *path; char *path;
}; };
static const char *prio_names[] = { static const char *prio_names[] = {
"head", "lightweight", "annotated", "head", "lightweight", "annotated",
@ -126,12 +126,14 @@ static void add_to_known_names(const char *path,
} else { } else {
e->next = NULL; e->next = NULL;
} }
e->path = NULL;
} }
e->tag = tag; e->tag = tag;
e->prio = prio; e->prio = prio;
e->name_checked = 0; e->name_checked = 0;
hashcpy(e->sha1, sha1); hashcpy(e->sha1, sha1);
e->path = path; free(e->path);
e->path = xstrdup(path);
} }
} }