undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: Test if $from_id and $to_id are defined before comparison

Browse Source 
Get rid of "Use of uninitialized value in string eq at
gitweb/gitweb.perl line 2320" warning caused by the fact that "empty"
patches, consisting only of extended git diff header and with patch
body empty, such as patch for pure rename, does not have "index" line
in extended diff header.  For such patches $from_id and $to_id, filled
from parsing extended diff header, are undefined.  But such patches
cannot be continuation patches.

Test if $from_id and $to_id are defined before comparing them with
$diffinfo.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Jakub Narebski 2007-05-12 12:42:32 +02:00 committed by Junio C Hamano
parent 93c44d493b
commit 2206537c07
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gitweb/gitweb.perl
View File

@ -2660,9 +2660,10 @@ sub git_patchset_body {
# check if current patch belong to current raw line # check if current patch belong to current raw line
# and parse raw git-diff line if needed # and parse raw git-diff line if needed
if (defined $diffinfo && if (defined $diffinfo &&
defined $from_id && defined $to_id &&
from_ids_eq($diffinfo->{'from_id'}, $from_id) && from_ids_eq($diffinfo->{'from_id'}, $from_id) &&
$diffinfo->{'to_id'} eq $to_id) { $diffinfo->{'to_id'} eq $to_id) {
# this is split patch # this is continuation of a split patch
print "<div class=\"patch cont\">\n"; print "<div class=\"patch cont\">\n";
} else { } else {
# advance raw git-diff output if needed # advance raw git-diff output if needed