undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t3600: clean up permissions test properly

Browse Source 
The test of failing `git rm -f` removes the write permissions on the
test directory, but fails to restore them if the test fails. This
means that the test temporary directory cannot be cleaned up, which
means that subsequent attempts to run the test fail mysteriously.

Instead, do the cleanup in a `test_when_finished` block so that it
can't be skipped.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2017-05-22 16:17:31 +02:00 committed by Junio C Hamano
parent ca7b2ab07d
commit 23739aa2b3
1 changed files with 2 additions and 2 deletions

4
t/t3600-rm.sh
View File

@ -97,9 +97,9 @@ test_expect_success FUNNYNAMES \
embedded'"
test_expect_success SANITY 'Test that "git rm -f" fails if its rm fails' '
test_when_finished "chmod 775 ." &&
chmod a-w . &&
test_must_fail git rm -f baz &&
chmod 775 .
test_must_fail git rm -f baz
'
test_expect_success \