undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

push tests: fix logic error in "push" test assertion

Browse Source 
Fix a logic error that's been here since this test was added in
dbfeddb12e ("push: require force for refs under refs/tags/",
2012-11-29).

The intent of this test is to force-create a new tag pointing to
HEAD~, and then assert that pushing it doesn't work without --force.

Instead, the code was not creating a new tag at all, and then failing
to push the previous tag for the unrelated reason of providing a
refspec that doesn't make any sense.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2018-07-31 13:07:11 +00:00 committed by Junio C Hamano
parent 76bcde5956
commit 25f74f5234
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/t5516-fetch-push.sh
View File

@ -979,8 +979,8 @@ test_expect_success 'push requires --force to update lightweight tag' '
git tag -f testTag &&
test_must_fail git push ../child2 testTag &&
git push --force ../child2 testTag &&
git tag -f testTag &&
test_must_fail git push ../child2 testTag HEAD~ &&
git tag -f testTag HEAD~ &&
test_must_fail git push ../child2 testTag &&
git push --force ../child2 testTag
)
'