undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'bw/clone-recursive-quiet' into maint

Browse Source 
"git clone --recurse-submodules --quiet" did not pass the quiet
option down to submodules.

* bw/clone-recursive-quiet:
  clone: teach recursive clones to respect -q
This commit is contained in:
Junio C Hamano 2017-09-10 17:02:49 +09:00
commit 277194a280
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
builtin/clone.c
View File

@ -768,6 +768,9 @@ static int checkout(int submodule_progress)
if (submodule_progress) if (submodule_progress)
argv_array_push(&args, "--progress"); argv_array_push(&args, "--progress");
if (option_verbosity < 0)
argv_array_push(&args, "--quiet");
err = run_command_v_opt(args.argv, RUN_GIT_CMD); err = run_command_v_opt(args.argv, RUN_GIT_CMD);
argv_array_clear(&args); argv_array_clear(&args);
} }

6
t/t7400-submodule-basic.sh
View File

@ -1289,4 +1289,10 @@ test_expect_success 'init properly sets the config' '
test_must_fail git -C multisuper_clone config --get submodule.sub1.active test_must_fail git -C multisuper_clone config --get submodule.sub1.active
' '
test_expect_success 'recursive clone respects -q' '
test_when_finished "rm -rf multisuper_clone" &&
git clone -q --recurse-submodules multisuper multisuper_clone >actual &&
test_must_be_empty actual
'
test_done test_done