undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

reftable: fix resource leak blocksource.c

Browse Source 
This would be triggered in the unlikely event of fstat() failing on an
opened file.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Han-Wen Nienhuys 2022-01-20 15:12:02 +00:00 committed by Junio C Hamano
parent 24d4d38c0b
commit 27e27ee224
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
reftable/blocksource.c
View File

@ -134,8 +134,10 @@ int reftable_block_source_from_file(struct reftable_block_source *bs,
} }
err = fstat(fd, &st); err = fstat(fd, &st);
if (err < 0) if (err < 0) {
return -1; close(fd);
return REFTABLE_IO_ERROR;
}
p = reftable_calloc(sizeof(struct file_block_source)); p = reftable_calloc(sizeof(struct file_block_source));
p->size = st.st_size; p->size = st.st_size;