From ace5e97ecdf6a6ad8fd4ba443486fbe0058eb37a Mon Sep 17 00:00:00 2001 From: Michael Palimaka Date: Wed, 8 Feb 2012 21:59:04 +1100 Subject: [PATCH] Explicitly set X to avoid potential build breakage $X is appended to binary names for Windows builds (ie. git.exe). Pollution from the environment can inadvertently trigger this behaviour, resulting in 'git' turning into 'gitwhatever' without warning. Signed-off-by: Michael Palimaka Signed-off-by: Junio C Hamano --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index b21d2f1417..6e70a6d44c 100644 --- a/Makefile +++ b/Makefile @@ -428,6 +428,9 @@ PROGRAM_OBJS += upload-pack.o PROGRAM_OBJS += http-backend.o PROGRAM_OBJS += sh-i18n--envsubst.o +# Binary suffix, set to .exe for Windows builds +X = + PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS)) TEST_PROGRAMS_NEED_X += test-chmtime