git p4: avoid shell when invoking git config --get-all

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Pete Wyckoff 2013-01-26 22:11:22 -05:00 committed by Junio C Hamano
parent c7d34884ae
commit 2abba3014e

View File

@ -571,7 +571,8 @@ def gitConfig(key, args = None): # set args to "--bool", for instance
def gitConfigList(key): def gitConfigList(key):
if not _gitConfig.has_key(key): if not _gitConfig.has_key(key):
_gitConfig[key] = read_pipe("git config --get-all %s" % key, ignore_error=True).strip().split(os.linesep) s = read_pipe(["git", "config", "--get-all", key], ignore_error=True)
_gitConfig[key] = s.strip().split(os.linesep)
return _gitConfig[key] return _gitConfig[key]
def p4BranchesInGit(branchesAreInRemotes=True): def p4BranchesInGit(branchesAreInRemotes=True):