undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mmap: set FD_CLOEXEC for file descriptors we keep open for mmap()

Browse Source 
I do not have any proof that this matters to any existing
problems I am seeing, but I do not think of any reason not to do
this.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2006-12-29 00:30:01 -08:00
parent 9c18df1907
commit 2c039da804
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sha1_file.c
View File

@ -540,6 +540,7 @@ static void open_packed_git(struct packed_git *p)
struct pack_header hdr; struct pack_header hdr;
unsigned char sha1[20]; unsigned char sha1[20];
unsigned char *idx_sha1; unsigned char *idx_sha1;
long fd_flag;
p->pack_fd = open(p->pack_name, O_RDONLY); p->pack_fd = open(p->pack_name, O_RDONLY);
if (p->pack_fd < 0 || fstat(p->pack_fd, &st)) if (p->pack_fd < 0 || fstat(p->pack_fd, &st))
@ -553,6 +554,16 @@ static void open_packed_git(struct packed_git *p)
} else if (p->pack_size != st.st_size) } else if (p->pack_size != st.st_size)
die("packfile %s size changed", p->pack_name); die("packfile %s size changed", p->pack_name);
/* We leave these file descriptors open with sliding mmap;
* there is no point keeping them open across exec(), though.
*/
fd_flag = fcntl(p->pack_fd, F_GETFD, 0);
if (fd_flag < 0)
die("cannot determine file descriptor flags");
fd_flag |= FD_CLOEXEC;
if (fcntl(p->pack_fd, F_SETFD, fd_flag) == -1)
die("cannot set FD_CLOEXEC");
/* Verify we recognize this pack file format. */ /* Verify we recognize this pack file format. */
read_or_die(p->pack_fd, &hdr, sizeof(hdr)); read_or_die(p->pack_fd, &hdr, sizeof(hdr));
if (hdr.hdr_signature != htonl(PACK_SIGNATURE)) if (hdr.hdr_signature != htonl(PACK_SIGNATURE))