undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bisect: check for mandatory argument of 'bisect replay'

Browse Source 
'git bisect replay' has a mandatory logfile argument, but the current
implementation doesn't check whether the user has specified one.  When
the user omits the logfile argument, this leads to the following
unhelpful error message:

  cannot read  for replaying

So, check for the mandatory argument first, and provide a more
meaningful error message when it is omitted.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
SZEDER Gábor 2010-10-10 23:48:58 +02:00 committed by Junio C Hamano
parent 3bb8cf8824
commit 2c7c3877de
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
git-bisect.sh
View File

@ -343,6 +343,7 @@ bisect_clean_state() {
} }
bisect_replay () { bisect_replay () {
test "$#" -eq 1 || die "No logfile given"
test -r "$1" || die "cannot read $1 for replaying" test -r "$1" || die "cannot read $1 for replaying"
bisect_reset bisect_reset
while read git bisect command rev while read git bisect command rev