undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] Fix buffer overflow in ce_flush().

Browse Source 
Add a check before appending SHA1 signature to write_buffer,
flush it first if necessary.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Qingning Huo 2005-09-11 14:27:47 +01:00 committed by Junio C Hamano
parent 720d150c48
commit 2c865d9aa7
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
read-cache.c
View File

@ -462,6 +462,13 @@ static int ce_flush(SHA_CTX *context, int fd)
SHA1_Update(context, write_buffer, left); SHA1_Update(context, write_buffer, left);
} }
/* Flush first if not enough space for SHA1 signature */
if (left + 20 > WRITE_BUFFER_SIZE) {
if (write(fd, write_buffer, left) != left)
return -1;
left = 0;
}
/* Append the SHA1 signature at the end */ /* Append the SHA1 signature at the end */
SHA1_Final(write_buffer + left, context); SHA1_Final(write_buffer + left, context);
left += 20; left += 20;