undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make test-path-utils more robust against incorrect use

Browse Source 
Previously, this test utility happily returned with exit code 0 if garbage
was thrown at it. Now it reports failure if an unknown function name was
given on the command line.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Sixt 2009-02-07 16:08:27 +01:00 committed by Junio C Hamano
parent ab2fdb3b62
commit 2cd85c40a9
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test-path-utils.c
View File

@ -7,6 +7,7 @@ int main(int argc, char **argv)
int rv = normalize_absolute_path(buf, argv[2]); int rv = normalize_absolute_path(buf, argv[2]);
assert(strlen(buf) == rv); assert(strlen(buf) == rv);
puts(buf); puts(buf);
return 0;
} }
if (argc >= 2 && !strcmp(argv[1], "make_absolute_path")) { if (argc >= 2 && !strcmp(argv[1], "make_absolute_path")) {
@ -15,12 +16,16 @@ int main(int argc, char **argv)
argc--; argc--;
argv++; argv++;
} }
return 0;
} }
if (argc == 4 && !strcmp(argv[1], "longest_ancestor_length")) { if (argc == 4 && !strcmp(argv[1], "longest_ancestor_length")) {
int len = longest_ancestor_length(argv[2], argv[3]); int len = longest_ancestor_length(argv[2], argv[3]);
printf("%d\n", len); printf("%d\n", len);
return 0;
} }
return 0; fprintf(stderr, "%s: unknown function name: %s\n", argv[0],
argv[1] ? argv[1] : "(there was none)");
return 1;
} }