undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qsort(): ptrdiff_t may be larger than int

Browse Source 
This is a companion patch to e23eff8be9
commit.  The same logic, the same rationale that a comparison
function that returns an int should not just compute a ptrdiff_t
and return it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2005-12-08 17:29:11 -08:00
parent c82365dc6f
commit 2dee581667
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
server-info.c
View File

@ -140,7 +140,12 @@ static int compare_info(const void *a_, const void *b_)
return 1; return 1;
/* then it does not matter but at least keep the comparison stable */ /* then it does not matter but at least keep the comparison stable */
return (*a)->p - (*b)->p; if ((*a)->p == (*b)->p)
return 0;
else if ((*a)->p < (*b)->p)
return -1;
else
return 1;
} }
static void init_pack_info(const char *infofile, int force) static void init_pack_info(const char *infofile, int force)