undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] fix git-checkout-cache segfault on parisc

Browse Source 
The index cleanup code is executed via atexit() which is *after* main
has completed, so the stack allocated cache_file has gone out of scope.
Parisc seems to use stack in the destructor functions, so cache_file
gets partially overwritten leading to the predictable disastrous
consequences.

[jc: Just to make sure, I audited other users of the function
 hold_index_file_for_update() to make sure they do not have this
 problem; everybody else uses non-stack cache_file structure and
 is fine.  Thanks, James.]

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
James Bottomley 2005-08-13 10:29:32 -05:00 committed by Junio C Hamano
parent 3c3852e33b
commit 31f584c242
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
checkout-cache.c
View File

@ -78,10 +78,11 @@ static int checkout_all(void)
static const char checkout_cache_usage[] = static const char checkout_cache_usage[] =
"git-checkout-cache [-u] [-q] [-a] [-f] [-n] [--prefix=<string>] [--] <file>..."; "git-checkout-cache [-u] [-q] [-a] [-f] [-n] [--prefix=<string>] [--] <file>...";
static struct cache_file cache_file;
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
int i, force_filename = 0; int i, force_filename = 0;
struct cache_file cache_file;
int newfd = -1; int newfd = -1;
if (read_cache() < 0) { if (read_cache() < 0) {