undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

oidset: make oidset_size() an inline function

Browse Source 
oidset_size() just reads a single word from memory and returns it.
Avoid the function call overhead for this trivial operation by turning
it into an inline function.

While we're at it, declare its parameter const to allow it to be used
on read-only oidsets.

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2021-09-11 22:36:40 +02:00 committed by Junio C Hamano
parent 8b7c11b866
commit 325006f2db
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
oidset.c
View File

@ -36,11 +36,6 @@ void oidset_clear(struct oidset *set)
oidset_init(set, 0); oidset_init(set, 0);
} }
int oidset_size(struct oidset *set)
{
return kh_size(&set->set);
}
void oidset_parse_file(struct oidset *set, const char *path) void oidset_parse_file(struct oidset *set, const char *path)
{ {
oidset_parse_file_carefully(set, path, NULL, NULL); oidset_parse_file_carefully(set, path, NULL, NULL);

5
oidset.h
View File

@ -57,7 +57,10 @@ int oidset_remove(struct oidset *set, const struct object_id *oid);
/** /**
* Returns the number of oids in the set. * Returns the number of oids in the set.
*/ */
int oidset_size(struct oidset *set); static inline int oidset_size(const struct oidset *set)
{
return kh_size(&set->set);
}
/** /**
* Remove all entries from the oidset, freeing any resources associated with * Remove all entries from the oidset, freeing any resources associated with